Re: [PATCH] staging:lustre: remove irq.h from socklnd.h

On Thu, Jun 25, 2015 at 10:59 PM, James Simmons wrote: > The header socklnd.h includes irq.h which is not need > and doesn't exist in the OpenSFS lustre branch. Having > irq.h in socklnd.h does break the build on the m68k > platform. So we can safely remove it. > > Signed-off-by: James Simmons T

Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more lines

Heh. No. That's not useful. :P Checkpatch.pl warnings are only good if they make the code better for humans. Otherwise ignore them. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/ma

Re: [PATCH] staging: gdm72xx: Split Kconfig descriptions into more lines

On Thu, Jun 25, 2015 at 03:36:46PM -0700, Daniel Grimshaw wrote: > I am a high school student trying to become familiar with linux kernel > development. This is my first patch. > > checkpatch.pl throws a warning that config WIMAX_GDM72XX_QOS, config > WIMAX_GDM72XX_K_MODE, and config WIMAX_GDM72XX

Re: [PATCH] staging: wilc1000: host_interface: add spaces around '='

On Mon, Jun 22, 2015 at 07:23:01PM +0530, Sunil Shahu wrote: > Fix coding style error by placing spaces around '=' as suggested by > checkpatch.pl script. > > Signed-off-by: Sunil Shahu > --- > drivers/staging/wilc1000/host_interface.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

Hi Dan, On Mon, 2015-06-22 at 20:34 +0300, Dan Carpenter wrote: > > + u32 c = 0x1234; > ^^ > In another follow on patch you can get rid of this. It is nonsense > and > it isn't used. By "follow on patch", did you mean that I should send v3 revision of my patch or

rename_rev.pl: review script for whitespace changes

I've sent my review script out a few times before but we have some new reviewers in staging who maybe haven't tried them. rename_rev.pl strips out whitespace changes. We recently had someone send a re-indent patch that deleted a line of code by mistake. The diff looked like: 18 files changed, 9

Re: [PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

On Fri, Jun 26, 2015 at 06:35:11PM +0530, Sunil Shahu wrote: > Hi Dan, > > On Mon, 2015-06-22 at 20:34 +0300, Dan Carpenter wrote: > > > + u32 c = 0x1234; > > ^^ > > In another follow on patch you can get rid of this. It is nonsense > > and > > it isn't used. > >

[PATCH v6 1/3] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

Hyper-V module needs to disable cpu hotplug (offlining) as there is no support from hypervisor side to reassing already opened event channels to a different CPU. Currently it is been done by altering smp_ops.cpu_disable but it is hackish. Signed-off-by: Vitaly Kuznetsov --- kernel/cpu.c | 3 ++-

[PATCH v6 3/3] cpu-hotplug: convert cpu_hotplug_disabled to a counter

As cpu_hotplug_enable/cpu_hotplug_disable functions are now available to modules we need to convert cpu_hotplug_disabled to a counter to properly support disable -> disable -> enable call sequences. E.g. after Hyper-V vmbus module did cpu_hotplug_disable() hibernate path calls disable_nonboot_cpus(

[PATCH v6 2/3] Drivers: hv: vmbus: use cpu_hotplug_enable/disable

Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining. We can bo better by using cpu_hotplug_enable/disable functions instead of such hard-coding. Reported-by: Radim Krčmář Signed-off-by: Vitaly Kuznetsov

[PATCH v6 0/3] Drivers: hv: vmbus: use cpu_hotplug_enable/disable for CPU offlining prevention

Changes since v5: - Split PATCH 1 into two (PATCH 1/3 and 3/3), rewrite changelogs. [Thomas Gleixner] Changes since v4: - In disable_nonboot_cpus() do cpu_hotplug_disabled++ unconditionally as its users are doing enable_nonboot_cpus() on their failure paths. Changes since v3: - add WARN_ON wh

[PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization

Variable "u32 c" always re-initialize in for loop. Initialized value of "u32 c" is not used in function and is redundant, hence removed. Suggested-by: Dan Carpenter Signed-off-by: Sunil Shahu --- drivers/staging/rtl8712/rtl871x_security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 0/4] staging: wilc1000: cover letter

Patches to be applied on top of https://patchwork.kernel.org/patch/6655831/ Thanks! Luis ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/4] staging: wilc1000: remove unnecessary braces

Removing all checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 276 ++ 1 file changed, 92 insertions(+), 184 deletions(-) diff --git a/drivers/st

[PATCH 2/4] staging: wilc1000: add blank lines after declarations

Fix all checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wil

[PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines

Fix all checkpatch.pl warnings: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 84 +++ 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/staging/wilc1000/

[PATCH 4/4] staging: wilc1000: fix typos in PRINT_ERR()

Fix typo "packe" to "packet". Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 79b7c2a..1915fc6 100

[PATCH 4/4] staging: wilc1000: fix typos in PRINT_ERR()

Fix typo "packe" to "packet". Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 79b7c2a..1915fc6 100

Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines

On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote: > On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote: > > Fix all checkpatch.pl warnings: > > WARNING: unnecessary whitespace before a quoted newline > > Unassociated but: > > > diff --git a/drivers/staging/wilc1000/host_inter

Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines

On Fri, 2015-06-26 at 17:11 +0200, Luis de Bethencourt wrote: > On Fri, Jun 26, 2015 at 07:49:32AM -0700, Joe Perches wrote: > > On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote: > > > Fix all checkpatch.pl warnings: > > > WARNING: unnecessary whitespace before a quoted newline > > > >

[PATCH 5/4] staging: wilc1000: switch printks to vsprintf IPv4 extension

Switch printks with IP addresses to use vsprintf extension %pI4. Suggested-by: Joe Perches Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/driv

Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization

On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote: > Variable "u32 c" always re-initialize in for loop. > Initialized value of "u32 c" is not used in function > and is redundant, hence removed. > > Suggested-by: Dan Carpenter > Signed-off-by: Sunil Shahu > --- > drivers/staging/rtl871

Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization

On Fri, Jun 26, 2015 at 05:50:27PM +0200, Luis de Bethencourt wrote: > On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote: > > Variable "u32 c" always re-initialize in for loop. > > Initialized value of "u32 c" is not used in function > > and is redundant, hence removed. > > > > Suggested

Re: [PATCH] staging: rtl8712: rtl871x_security.c: remove unnecessary variable initialization

On Fri, Jun 26, 2015 at 06:51:33PM +0300, Dan Carpenter wrote: > On Fri, Jun 26, 2015 at 05:50:27PM +0200, Luis de Bethencourt wrote: > > On Fri, Jun 26, 2015 at 07:42:24PM +0530, Sunil Shahu wrote: > > > Variable "u32 c" always re-initialize in for loop. > > > Initialized value of "u32 c" is not u

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

On Thu, Jun 25, 2015 at 02:06:44PM +0200, Arnd Bergmann wrote: > On Wednesday 24 June 2015 13:34:58 Gaston Gonzalez wrote: > > On Tue, Jun 23, 2015 at 12:13:47PM +0200, Arnd Bergmann wrote: > > > On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > > > > /* WMM spec P.11: The mi

Re: rename_rev.pl: review script for whitespace changes

On Fri, Jun 26, 2015 at 04:15:24PM +0300, Dan Carpenter wrote: > I've sent my review script out a few times before but we have some new > reviewers in staging who maybe haven't tried them. > > rename_rev.pl strips out whitespace changes. We recently had someone > send a re-indent patch that delet

[PATCH net-next] hv_netvsc: Add support to set MTU reservation from guest side

When packet encapsulation is in use, the MTU needs to be reduced for headroom reservation. The existing code takes the updated MTU value only from the host side. But vSwitch extensions, such as Open vSwitch, require the flexibility to change the MTU to different values from within a guest during th

[PATCH] staging: xgifb: Delete an unnecessary check before the function call "XGIfb_search_crt2type"

From: Markus Elfring Date: Fri, 26 Jun 2015 21:50:41 +0200 The XGIfb_search_crt2type() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH] staging:slicoss:slicoss.h remove volatile variables

I am a high school student trying to become familiar with the opensource process and linux kernel. This is my first submission to the mailing list. I fixed the slicoss sub-system. The TODO file asks to remove volatile variables - also, checkpatch.pl warnings included volatile variables. I rem

Re: [PATCH] staging:slicoss:slicoss.h remove volatile variables

On Fri, Jun 26, 2015 at 12:57:32PM -0700, Vikul Gupta wrote: > I am a high school student trying to become familiar with the opensource > process and linux kernel. This is my first submission to the mailing list. Great, but this paragraph doesn't belong in here, as this whole thing will end up in

[PATCHv3 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ef876a4..947a38e 100644 --- a/drivers/staging/vme/devices/vm

[PATCHv3 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme/devic

[PATCHv3 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. v2 fixes ("vme_user: return -EFAULT on __copy_*_user errors") that had EINVAL instead

[PATCHv3 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 7ca943c..b3e3c2d 100644 --- a/drivers/staging/vm

[PATCHv3 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644 --- a/dr

[PATCHv3 5/9] staging: vme_user: allow large read()/write()

This changes large master transfers to do shorter read/write rather than return -EINVAL. User space will now be able to optimistically request a large transfer and get at least some data. This also removes comments suggesting on how to implement large transfers. Current vme_master_* read and write

[PATCHv3 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 947a38e..7ca943c 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/st

[PATCHv3 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices/vme_user.c

[PATCHv3 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices/vme_use

[PATCHv3 6/9] staging: vme_user: switch to returning -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index a2345db..ef876a4 100644 --- a/d

Re: [PATCH 3/4] staging: wilc1000: remove whitespaces before quoted newlines

On Fri, 2015-06-26 at 16:45 +0200, Luis de Bethencourt wrote: > Fix all checkpatch.pl warnings: > WARNING: unnecessary whitespace before a quoted newline Unassociated but: > diff --git a/drivers/staging/wilc1000/host_interface.c > b/drivers/staging/wilc1000/host_interface.c [] > @@ -740,7 +740,7

[PATCH] staging: lustre: Deletion of unnecessary checks before three function calls

From: Markus Elfring Date: Fri, 26 Jun 2015 23:10:42 +0200 The following functions test whether their argument is NULL and then return immediately. * kfree * ll_file_data_put * ptlrpc_connection_put Thus the test around such calls is not needed. This issue was detected by using the Coccinelle s

Re: [PATCH] staging:slicoss:slicoss.h remove volatile variables

Hi Vikul, welcome! See my comment below... On Fri, Jun 26, 2015 at 12:57 PM, Vikul Gupta wrote: > I am a high school student trying to become familiar with the opensource > process and linux kernel. This is my first submission to the mailing list. > > I fixed the slicoss sub-system. The TODO file

Re: [v3.16.y-ckt][v3.18.y][v3.19.y-ckt][v4.0.y][PATCH 1/1]Drivers: hv: vmbus: Add support for VMBus panic notifier handler

On Tue, Jun 16, 2015 at 04:22:12PM -0400, Joseph Salisbury wrote: > From: Nick Meier > > BugLink: http://bugs.launchpad.net/bugs/1463584 > > Hyper-V allows a guest to notify the Hyper-V host that a panic > condition occured. This notification can include up to five 64 > bit values. These 64 bi

[PATCH] staging: board: Add dependency on CLKDEV_LOOKUP

The code depends on CLKDEV_LOOKUP since commit 225d68d852f1 ("staging: board: Add support for devices with complex dependencies"). Related build error (powerpc:allmodconfig): drivers/built-in.o: In function `.board_staging_register_clock': (.init.text+0x1d8e0): undefined reference to `.clk_add_al

Re: [PATCH] staging:lustre: remove irq.h from socklnd.h

On Thu, Jun 25, 2015 at 04:59:46PM -0400, James Simmons wrote: > The header socklnd.h includes irq.h which is not need > and doesn't exist in the OpenSFS lustre branch. Having > irq.h in socklnd.h does break the build on the m68k > platform. So we can safely remove it. > > Signed-off-by: James Sim

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) Signed-off-by: Vasiliy Korchagin --- drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 05:44 +0100, Vasiliy Korchagin wrote: > This patch fixes the checkpatch.pl error: > > ERROR: Macros with complex values should be enclosed in parentheses > +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > > Signed-off-by: Vasiliy Korchagin > --- > drivers/s

Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code

>From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001 From: santhosh pai Date: Mon, 22 Jun 2015 23:26:33 +0530 Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error code try_module_get fails when the reference count of the module is not allowed to be

[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

This patch fixes the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) by expanding it as this macro is used only once. Signed-off-by: Vasiliy Korchagin --- Notes: Here is another version

Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote: > This patch fixes the checkpatch.pl error: > > ERROR: Macros with complex values should be enclosed in parentheses > +#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr)) > > by expanding it as this macro is used only once. []