Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

On Mon, Jun 22, 2015 at 06:25:11AM -0500, Greg Donald wrote: > Umm.. you have to fix more than one error if there's more than one > error on or very near the same line you are already fixing, else > checkpatch.pl complains that your patch has errors. Not to mention > Greg KH has never complained:

Re: staging patch not in staging tree (was: Re: [PATCH 1/2] staging: ft1000-usb: fixed table alignment)

On Tue, Jun 23, 2015 at 11:03:34AM +0530, Sudip Mukherjee wrote: > On Mon, Jun 22, 2015 at 07:06:49PM +0530, Sudip Mukherjee wrote: > > On Mon, Jun 22, 2015 at 03:02:37PM +0200, Peter Karlsson wrote: > > > On 2015-06-22 06:29, Sudip Mukherjee wrote: > > > > which tree have you been using? > > > > G

Re: staging patch not in staging tree (was: Re: [PATCH 1/2] staging: ft1000-usb: fixed table alignment)

On Tue, Jun 23, 2015 at 11:05:47AM +0300, Dan Carpenter wrote: > On Tue, Jun 23, 2015 at 11:03:34AM +0530, Sudip Mukherjee wrote: > > On Mon, Jun 22, 2015 at 07:06:49PM +0530, Sudip Mukherjee wrote: > > > On Mon, Jun 22, 2015 at 03:02:37PM +0200, Peter Karlsson wrote: > > > > On 2015-06-22 06:29, S

Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler

On Thu, Jun 04, K. Y. Srinivasan wrote: > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -18,6 +18,9 @@ > #include > #include > #include > +#ifdef CONFIG_KEXEC > +#include > +#endif Is this #ifdef required? Olaf ___ devel mailing list de...@linuxdriv

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On 2015/06/20, 10:58 AM, "Julia Lawall" wrote: >!x is more normal for kzalloc failure in the kernel. While "!x" might be more normal for kzalloc(), I don't see that as an improvement over explicitly checking against NULL, which is what kzalloc() and other memory-allocating functions return on er

Re: lustre: LIBCFS_ALLOC

On Jun 23, 2015, at 2:23 AM, Julia Lawall wrote: > It seems that libcfs_kvzalloc doesn't use any particular threshold or > switchingbetween kzalloc and vmalloc, so can be replaced by ths function > too? If you mean to replace all instances of LIBCFS_ALLOC with libcfs_kvzalloc (and all frees w

Re: [PATCH 2/2] staging: sm750fb: fix typo in debug statement

On Mon, Jun 22, 2015 at 04:48:01AM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch fixes a typo in the debug statement > > Signed-off-by: Hari Prasath Gujulan Elango > --- Fold these together. It's a one line change to the same line... rega

Re: [PATCH] staging: sm750fb: remove unused variables

On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.) wrote: > @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency) > * Sometime, the chip cannot set up the exact clock required by > User. > * Return value from calcPllValue() gives the ac

Re: [PATCH v2 07/10] staging: wilc1000: remove ununsed variable

On Mon, Jun 22, 2015 at 01:13:58PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch removes ununsed variable 'len' > > Signed-off-by: Hari Prasath Gujulan Elango This doesn't work because it's not in the same thread as the original email. You

Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > Place braces on previous lines in ddk750_sii164.c to > > rectify the following checkpatch errors: > > ERROR: that open brace { should be on the previous line > > >

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On Tue, Jun 23, 2015 at 08:25:05AM +, Dilger, Andreas wrote: > I've found in the past that developers can introduce bugs when they treat > return values as boolean when they really aren't. I can imagine a bug like that where a function can return 0-2 and people do: if (ret) instead o

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On Tue, 23 Jun 2015, Dan Carpenter wrote: > On Tue, Jun 23, 2015 at 08:25:05AM +, Dilger, Andreas wrote: > > I've found in the past that developers can introduce bugs when they treat > > return values as boolean when they really aren't. > > I can imagine a bug like that where a function can re

Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

On Tue, Jun 23, 2015 at 11:55:48AM +0300, Dan Carpenter wrote: > On Sat, Jun 20, 2015 at 12:54:02PM +0530, Sudip Mukherjee wrote: > > On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote: > > I never get Isaac's emails. I think gmail is still sending them to the > Spam folder? I searche

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

Yes. I know Al's thoughts and kernel style. But Alan Cox and Andreas have both said they think (x == NULL) can help you avoid some kind of boolean vs pointer bugs. I've had co-workers who did massive seds changing !foo to foo == NULL on our code base. But I've never seen a real life example of

Re: [PATCH] staging: sm750fb: remove unused variables

On Tue, Jun 23, 2015 at 11:46:13AM +0300, Dan Carpenter wrote: > On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency) > > * Sometime, the chip cannot set up the exact clock required by >

Re: [PATCH] staging: rtl8192u: ieee80211_rx: Fix incorrect type in assignments

On Sunday 21 June 2015 19:12:09 Gaston Gonzalez wrote: > /* WMM spec P.11: The minimum value for AIFSN shall be 2 */ > qos_param->aifs[aci] = (qos_param->aifs[aci] < 2) ? > 2:qos_param->aifs[aci]; > > - qos_param->cw_min[aci] = ac_params->ecw_min_max

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On Tue, 23 Jun 2015, Dan Carpenter wrote: > Yes. I know Al's thoughts and kernel style. > > But Alan Cox and Andreas have both said they think (x == NULL) can help > you avoid some kind of boolean vs pointer bugs. I've had co-workers who > did massive seds changing !foo to foo == NULL on our c

Re: [PATCH 1/4] staging: wilc1000: wilc_wfi_netdevice.c: remove commented codes

On Tue, Jun 23, 2015 at 09:17:44AM +0900, Chaehyun Lim wrote: > Remove commented codes. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_netdevice.c | 21 - > 1 file changed, 21 deletions(-) > > diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevic

Re: [PATCH] staging: sm750fb: convert pr_err to pr_info

On Monday 22 June 2015 08:46 PM, Dan Carpenter wrote: > On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.) > wrote: >> From: Hari Prasath Gujulan Elango >> >> This patch modifies few debug prints from pr_err() to pr_info() as they >> fall under that category. >> > > Th

Re: [PATCH] staging: dgnc: free memory allocated

On Monday 22 June 2015 10:45 PM, Dan Carpenter wrote: > You should have CC'd Mark on these. Use ./scripts/get_maintainer.pl > > regards, > dan carpenter > Thanks Dan.I did use the get_maintainer.pl as I do always. I missed Marks email ID. It was my mistake.Thanks for adding him.Greg has alrea

[PATCH 5/9] staging: vme_user: allow large read()/write()

This changes large master transfers to do shorter read/write rather than return -EINVAL. User space will now be able to optimistically request a large transfer and get at least some data. This also removes comments suggesting on how to implement large transfers. Current vme_master_* read and write

[PATCH 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index b6d81e5..db5f890 100644 --- a/drivers/staging/vme/devices/vme_user.c

[PATCH 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 5ff44fb..285e00e 100644 --- a/dr

[PATCH 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. Dmitry Kalinkin (9): staging: vme_user: fix code alignment staging: vme_user: fix b

[PATCH 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 6f5bbc4..14f9554 100644 --- a/drivers/staging/vm

[PATCH 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 285e00e..1f00ad7 100644 --- a/drivers/staging/vme/devices/vme_use

[PATCH 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 1f00ad7..b6d81e5 100644 --- a/drivers/staging/vme/devic

[PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 52cd638..85eb6ee 100644 --- a/d

[PATCH 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 28a70f4..6f5bbc4 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/st

[PATCH 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 85eb6ee..28a70f4 100644 --- a/drivers/staging/vme/devices/vm

[PATCH] staging: rtl8192u: bool tests don't need comparisons

Remove explicit true/false comparations to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/r8192U_core.c | 7 --- drivers/staging/rtl8192u/r8192U_dm.c | 21 +++-- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/stagi

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt wrote: > Remove explicit true/false comparations to bool variables. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/rtl8192u/r8192U_core.c | 7 --- > drivers/staging/rtl8192u/r8192U_dm.c | 21 +++-- > 2 fi

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 02:56:38PM +0200, Frans Klaver wrote: > On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt > wrote: > > Remove explicit true/false comparations to bool variables. > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/staging/rtl8192u/r8192U_core.c | 7 ---

Re: [PATCH 2/2] staging: sm750fb: fix typo in debug statement

On Tuesday 23 June 2015 02:07 PM, Dan Carpenter wrote: > On Mon, Jun 22, 2015 at 04:48:01AM +, Gujulan Elango, Hari Prasath (H.) > wrote: >> From: Hari Prasath Gujulan Elango >> >> This patch fixes a typo in the debug statement >> >> Signed-off-by: Hari Prasath Gujulan Elango >> --- > > F

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt wrote: > Remove explicit true/false comparations to bool variables. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/rtl8192u/r8192U_core.c | 7 --- > drivers/staging/rtl8192u/r8192U_dm.c | 21 +++-- > 2 fi

[PATCH v2] staging: rtl8192u: bool tests don't need comparisons

Remove explicit true/false comparations to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/r8192U_core.c | 13 - drivers/staging/rtl8192u/r8192U_dm.c | 21 +++-- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers

Re: [PATCH] staging: sm750fb: remove unused variables

On Tuesday 23 June 2015 02:16 PM, Dan Carpenter wrote: > On Mon, Jun 22, 2015 at 07:26:25AM +, Gujulan Elango, Hari Prasath (H.) > wrote: >> @@ -122,7 +121,7 @@ void setChipClock(unsigned int frequency) >> * Sometime, the chip cannot set up the exact clock required by >> User.

[PATCH v2] staging: rtl8192u: bool tests don't need comparisons

Remove explicit true/false comparations to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/r8192U_core.c | 13 - drivers/staging/rtl8192u/r8192U_dm.c | 21 +++-- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 03:04:32PM +0200, Frans Klaver wrote: > On Tue, Jun 23, 2015 at 2:52 PM, Luis de Bethencourt > wrote: > > Remove explicit true/false comparations to bool variables. > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/staging/rtl8192u/r8192U_core.c | 7 ---

Re: [PATCH 1/9] staging: vme_user: fix code alignment

On Tue, Jun 23, 2015 at 2:42 PM, Dmitry Kalinkin wrote: > Signed-off-by: Dmitry Kalinkin You left one in the function declarations (vme_user_write). > --- > drivers/staging/vme/devices/vme_user.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > di

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt wrote: >> > if (dm_digtable.dig_algorithm_switch) { >> > @@ -3062,7 +3062,8 @@ static void dm_dynamic_txpower(struct net_device >> > *dev) >> > priv->bDynamicTxLowPower = false; >> > } else { >>

Re: [PATCH 1/9] staging: vme_user: fix code alignment

> On 23 Jun 2015, at 16:21, Frans Klaver wrote: > > You left one in the function declarations (vme_user_write). If you mean forward declarations, they are already gone in Greg’s tree: https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/vme/devices/vme_user.c?h

Re: [PATCH 1/9] staging: vme_user: fix code alignment

On Tue, Jun 23, 2015 at 3:44 PM, Dmitry Kalinkin wrote: > >> On 23 Jun 2015, at 16:21, Frans Klaver wrote: >> >> You left one in the function declarations (vme_user_write). > > If you mean forward declarations, they are already gone in Greg’s tree: > https://git.kernel.org/cgit/linux/kernel/git/g

[PATCH v3] staging: rtl8192u: bool tests don't need comparisons

Remove explicit true/false comparations to bool variables. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 4 ++-- .../staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 4 ++-- drivers/sta

Re: [PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

On Tue, Jun 23, 2015 at 03:42:30PM +0300, Dmitry Kalinkin wrote: > @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char > __user *buf, > size_t count, loff_t *ppos) > { > void *image_ptr; > - ssize_t retval; > > image_ptr = ima

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote: > On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt > wrote: > > >> > if (dm_digtable.dig_algorithm_switch) { > >> > @@ -3062,7 +3062,8 @@ static void dm_dynamic_txpower(struct net_device > >> > *dev) > >> >

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 3:59 PM, Luis de Bethencourt wrote: > On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote: >> On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt >> wrote: >> >> >> > if (dm_digtable.dig_algorithm_switch) { >> >> > @@ -3062,7 +3062,8 @@ static void dm_dyn

Re: [PATCH 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

> On 23 Jun 2015, at 16:51, Dan Carpenter wrote: > > On Tue, Jun 23, 2015 at 03:42:30PM +0300, Dmitry Kalinkin wrote: >> @@ -178,38 +167,24 @@ static ssize_t buffer_to_user(unsigned int minor, char >> __user *buf, >>size_t count, loff_t *ppos) >> { >> void *imag

Re: [PATCH] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 03:59:41PM +0200, Frans Klaver wrote: > On Tue, Jun 23, 2015 at 3:59 PM, Luis de Bethencourt > wrote: > > On Tue, Jun 23, 2015 at 03:37:20PM +0200, Frans Klaver wrote: > >> On Tue, Jun 23, 2015 at 3:21 PM, Luis de Bethencourt > >> wrote: > >> > >> >> > if (dm_digta

[PATCH] staging: lustre: mgc: no need to compare bool value

Inverting the value of eof is a more direct way of passing to the debugging function if eof is false or not. Signed-off-by: Luis de Bethencourt --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/mg

[PATCH 0/6] Remove redundant spi driver bus initialization

This cleanup was already completed between end 2011 and early 2012 with a patch series from Lars-Peter Clausen: https://lkml.org/lkml/2011/11/24/190 Later on new redundant initialization re-appeared here and there. Time to cleanup again. And, yes, I'm lazy! I copy-paste the exact same commit mess

[PATCH 3/6] staging: mt29f_spinand: Remove redundant spi driver bus initialization

In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Greg Kroah-Hartman To: de...@driverdev.osuosl.org Cc: linux-ker...@vg

[PATCHv2 1/9] staging: vme_user: fix code alignment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 9cca97a..ccf9602 100644 --- a/dr

[PATCHv2 2/9] staging: vme_user: fix blank lines

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index ccf9602..494655a 100644 --- a/drivers/staging/vme/devices/vme_use

[PATCHv2 0/9] vme_user checkpatch fixes and read()/write() rework

First four patches are fixes for various checpatch warnings. Next there is a change to drop large read()/write() stub followed by a change to rework user copy error codes. Last three changes are refactorings. v2 fixes ("vme_user: return -EFAULT on __copy_*_user errors") that had EINVAL instead

[PATCHv2 3/9] staging: vme_user: fix NULL comparison style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 494655a..2ff15f0 100644 --- a/drivers/staging/vme/devic

[PATCHv2 8/9] staging: vme_user: remove distracting comment

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index cf47649..de9eda5 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/st

[PATCHv2 5/9] staging: vme_user: allow large read()/write()

This changes large master transfers to do shorter read/write rather than return -EINVAL. User space will now be able to optimistically request a large transfer and get at least some data. This also removes comments suggesting on how to implement large transfers. Current vme_master_* read and write

[PATCHv2 4/9] staging: vme_user: fix kmalloc style

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 2ff15f0..3467cde 100644 --- a/drivers/staging/vme/devices/vme_user.c

[PATCHv2 7/9] staging: vme_user: remove unused variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 070e63f..cf47649 100644 --- a/drivers/staging/vme/devices/vm

[PATCHv2 6/9] staging: vme_user: return -EFAULT on __copy_*_user errors

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 47 -- 1 file changed, 11 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index 101f7b9..070e63f 100644 --- a/d

[PATCHv2 9/9] staging: vme_user: remove okcount variable

Signed-off-by: Dmitry Kalinkin --- drivers/staging/vme/devices/vme_user.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index de9eda5..efed9c7 100644 --- a/drivers/staging/vm

Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler

Olaf Hering writes: > On Thu, Jun 04, K. Y. Srinivasan wrote: > >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -18,6 +18,9 @@ >> #include >> #include >> #include >> +#ifdef CONFIG_KEXEC >> +#include >> +#endif > > Is this #ifdef required? > No, it's not, but other parts of the same patch d

RE: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

> -Original Message- > From: K. Y. Srinivasan [mailto:k...@microsoft.com] > Sent: Sunday, June 21, 2015 7:56 PM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; mi...@kernel.org; pet...@infradead.org; > rafael.j.wyso...@intel.com; t...@linutr

Contact Him Immediately.

Dear Sir, The Central Bank of Nigeria (CBN) , Fact Finding & Special Duties office on foreign contract (FFSDO), has been given order to effect your contract and inheritance payment with reference number (LM-07-4918) amounting to the tune of (US$12,800.000.00) (Twelve Million Eight hundred thou

Re: [PATCH 1/1] cpu-hotplug: export cpu_hotplug_enable/cpu_hotplug_disable

On Tue, Jun 23, 2015 at 04:57:05PM +, KY Srinivasan wrote: > > diff --git a/kernel/cpu.c b/kernel/cpu.c > > index 94bbe46..8f35ee6 100644 > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -190,17 +190,19 @@ void cpu_hotplug_done(void) > > void cpu_hotplug_disable(void) > > { > > cpu_m

, [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error, code, try_module_get fails when the reference count of the module is not, allowed to be incremented ,and hence -ENXIO is returne

___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

Use the newer and nicer kstrtoint(), because simple_strtoul() is now obsolete. Signed-off-by: Luis de Bethencourt --- drivers/staging/speakup/varhandlers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhand

[PATCH] defines modified to match the 80-char rule

Defines have been written in more than one line to match the 80-character rule. This error has been fixed 6 times in this file. The file is fully compliant with respect to the coding rules now. Signed-off-by: Mario Bambagini --- .../lustre/include/linux/libcfs/libcfs_debug.h | 20 +

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On Tue, 2015-06-23 at 12:57 +0300, Dan Carpenter wrote: > I've never seen a real life proof that (!foo) code is less > buggy. Nor have I. > I should look through the kbuild mailbox... Hm... But my other > idea of setting up code style readability testing website is also a good > one. > > Linux

Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

On Tue, 2015-06-23 at 12:23 +0300, Dan Carpenter wrote: > people decided that > Yoda code was a good idea based on their gut instead of using statistics > and measurements and science. I think that style exists because compilers disallow CONST = val assignment typos.

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

On Tue, Jun 23, 2015 at 3:01 AM, Dan Carpenter wrote: > Actually, Greg complains about these all the time. All I know is he's yet to turn away a single one of my patches. > And here is a useless URL that you can look at: http://slashdot.org > I'm sure it supports my argument. > > But seriously,

Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

Nope. Your patch is totally wrong (buggy). Please be more careful in the future. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote: > Nope. Your patch is totally wrong (buggy). Please be more careful in > the future. > > regards, > dan carpenter > I saw other commits replace the obsolete simple_strtoul() this way and the documentation makes it look like it is a

Re: , [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return error, code, try_module_get fails when the reference count of the module is not, allowed to be incremented ,and hence -ENXIO is ret

On Tue, Jun 23, 2015 at 11:48:31PM +0530, Santosh wrote: > > ___ > devel mailing list > de...@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Your email did not get through properly :( __

Re: [PATCH V2 04/10] Drivers: hv: vmbus: add special kexec handler

On Tue, Jun 23, 2015 at 06:28:36PM +0200, Vitaly Kuznetsov wrote: > Olaf Hering writes: > > > On Thu, Jun 04, K. Y. Srinivasan wrote: > > > >> +++ b/arch/x86/kernel/cpu/mshyperv.c > >> @@ -18,6 +18,9 @@ > >> #include > >> #include > >> #include > >> +#ifdef CONFIG_KEXEC > >> +#include > >>

Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote: > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote: > > Nope. Your patch is totally wrong (buggy). Please be more careful in > > the future. > > > > regards, > > dan carpenter > > > > I saw other commits replace

[PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

linux/ieee80211.h already defines constants for information element IDs. Include it where needed, resolve discrepancies in naming, and remove the duplicated definitions. While at it, wrap a line that was too long and remove extra parentheses in an expression that mixes only equality and logical op

Re: [PATCH v2] staging: rtl8192u: bool tests don't need comparisons

On Tue, Jun 23, 2015 at 03:10:56PM +0200, Luis de Bethencourt wrote: > Remove explicit true/false comparations to bool variables. > > Signed-off-by: Luis de Bethencourt > --- > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c > b/drivers/staging/rtl8192u/r8192U_dm.c > index 12dd19e..9946615 10

[RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb

dev_kfree_skb checks for NULL pointer itself. Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- drivers/staging/vt6655/device_main.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_mai