Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blocks

2015-06-06 Thread Dan Carpenter
The patch is mangled. Read Documentation/email-clients.txt regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-ker...@vger.kernel.org,

2015-06-06 Thread Aparna Karuthodi
On Sat, Jun 06, 2015 at 02:26:28PM +0530, Aparna wrote: > From 59e894efbd2fc3e85edab2e142f7193b6a238789 Mon Sep 17 00:00:00 2001 > From: Aparna Karuthodi > Date: Sat, 6 Jun 2015 11:01:16 +0530 > Subject: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary > for single statement

[PATCH] staging: rtl8188eu: core/rtw_led.c: fix coding style issue

2015-06-06 Thread Markus Böhme
Convert spaces at the start of a line to a tab. Signed-off-by: Markus Böhme --- drivers/staging/rtl8188eu/core/rtw_led.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c index 94405dc..1446

Re: [PATCH 3/3] [PATCH] staging: dgnc: Fixed braces {} are not necessary for single statement blockslinux-ker...@vger.kernel.org,

2015-06-06 Thread Dan Carpenter
Send the patch to yourself. Apply it with git am. Review the git log and then send it to the list. But actually this change is not correct at all. The prefered style in staging is that multi-line indent blocks get curly braces for readability even when they are not required by the compiler. Th

Re: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style issue

2015-06-06 Thread Dan Carpenter
On Fri, Jun 05, 2015 at 04:27:48PM -0700, Dennis Chen wrote: > >From 843d038eec5ac2c59d3138f19ae52828098c7d50 Mon Sep 17 00:00:00 2001 > From: Dennis Chen > Date: Fri, 5 Jun 2015 15:42:37 -0700 > Subject: [PATCH] Staging: comedi: daqboard2000: fixed whitespace coding style > issue Sudip is right

[GIT PULL] Staging driver fixes for 4.1-rc7

2015-06-06 Thread Greg KH
The following changes since commit e26081808edadfd257c6c9d81014e3b25e9a6118: Linux 4.1-rc4 (2015-05-18 10:13:47 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.1-rc7 for you to fetch changes up to 39a6e7376af08

[PATCH v2 1/2] staging: rtl8723au: core: avoid bitwise arithmetic with forced endianness

2015-06-06 Thread David Decotigny
This fixes bitwise arithmetic performed on the host on a variable previously converted to little-endian, and subsequently converted again to little-endian: - issue_action_BA23a() called with "status" crafted in host byte order - "status" converted to LE - bitwise arithmetic on the (LE) "statu

[PATCH v2 0/2] staging: rtl8723au: core: endianness issues

2015-06-06 Thread David Decotigny
The code shows a couple inconsistencies (described in commit descriptions) which would not be an issue on little-endian cpus, but could cause breakage on non-LE cpus. Note: I could not test on real hardware, these patches created based on sparse reports. ###

[PATCH v2 2/2] staging: rtl8723au: core: remove redundant endianness conversion

2015-06-06 Thread David Decotigny
Source and destination have the same little-endian annotation: this patch removes forced conversion from host byte order to little-endian. This addresses the following sparse warning: drivers/staging/rtl8723au/core/rtw_mlme_ext.c:3911:56: warning: incorrect type in argument 1 (different base type