On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
> On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > From: Gujulan Elango Hari Prasath
> >
> > Remove the unwanted else block
> i think you need to refresh your tree. This was already removed b
On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Gujulan Elango Hari Prasath
> > >
> > > Re
On Mon, Jun 01, 2015 at 04:07:22PM +0200, Konrad Zapalowicz wrote:
> On 06/01, Gujulan Elango, Hari Prasath (H.) wrote:
> > From: Hari Prasath Gujulan Elango
> >
> > Remove braces around else clause with single line
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> > ---
> > drivers/staging
On Tue, Jun 02, 2015 at 12:18:06PM +0530, Sudip Mukherjee wrote:
> On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> > Insert Spaces after commas to rectify the following checkpatch
> > errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
> > ERROR: space required after that ','
size_t should print using %zu, but here it was using %d and hence we
were getting warning while printing.
Signed-off-by: Sudip Mukherjee
---
I think it will be easy to remove the other warnings if all the typedefs
are removed first.
drivers/staging/wilc1000/wilc_spi.c | 2 +-
dri
On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote:
> On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote:
> > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
> > > > Remove two lines at ieee80211_wep_null which checkpatch.
On Tue, Jun 02, 2015 at 12:55:22AM -0700, Isaac Assegai wrote:
> On Tue, Jun 02, 2015 at 12:18:06PM +0530, Sudip Mukherjee wrote:
> > On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> > > + FIELD_SET(0, CRT_DISPLAY_CTRL,
> > > TIMING, ENABLE)|
> >
On Tue, Jun 02, 2015 at 10:08:19AM +0200, pmarzo wrote:
> On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote:
> > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote:
> > > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> > > > On Thu, May 21, 2015 at 02:25:18AM +0200, Pedro Marzo Perez wrote:
On 06/02, Sudip Mukherjee wrote:
> size_t should print using %zu, but here it was using %d and hence we
> were getting warning while printing.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> I think it will be easy to remove the other warnings if all the typedefs
> are removed first.
>
> drivers/
On Tue, Jun 02, 2015 at 01:55:56PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 12:55:22AM -0700, Isaac Assegai wrote:
> > On Tue, Jun 02, 2015 at 12:18:06PM +0530, Sudip Mukherjee wrote:
> > > On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
>
> > > > +
On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
> On 06/02, Sudip Mukherjee wrote:
> > size_t should print using %zu, but here it was using %d and hence we
> > were getting warning while printing.
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
> >
> > I think it will be easy t
Aligned enum members to follow a common style per enum.
Signed-off-by: Stanislav Kholmanskikh
---
drivers/staging/wilc1000/coreconfigurator.c | 29 +++---
drivers/staging/wilc1000/coreconfigurator.h | 62 ++---
2 files changed, 46 insertions(+), 45 deletions(-)
d
Fixed several syntax/style issues found with checkpatch.pl.
Signed-off-by: Stanislav Kholmanskikh
---
Changes since V2:
* The first 2 patches were removed, because what they fix is already fixed now.
drivers/staging/wilc1000/coreconfigurator.c | 24
1 file changed, 12
On 06/02, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
> > On 06/02, Sudip Mukherjee wrote:
> > > size_t should print using %zu, but here it was using %d and hence we
> > > were getting warning while printing.
> > >
> > > Signed-off-by: Sudip Mukherje
size_t should print using %zu and unsigned long int should use %lu
but here it was using %d and hence we were getting warning while
printing.
Signed-off-by: Sudip Mukherjee
---
v2: missed mentioning unsigned long int in commit message.
drivers/staging/wilc1000/wilc_spi.c | 2 +-
On Tue, Jun 02, 2015 at 10:58:40AM +0200, Konrad Zapalowicz wrote:
> On 06/02, Sudip Mukherjee wrote:
> > On Tue, Jun 02, 2015 at 10:29:17AM +0200, Konrad Zapalowicz wrote:
> > > On 06/02, Sudip Mukherjee wrote:
> > > > size_t should print using %zu, but here it was using %d and hence we
> > > > we
On Tue, Jun 02, 2015 at 01:55:20PM +0900, Greg KH wrote:
> On Mon, Jun 01, 2015 at 09:56:18PM +0300, Stanislav Kholmanskikh wrote:
> > Signed-off-by: Stanislav Kholmanskikh
> > ---
> > Changes since V1:
> >
> > Split the V1 series into more logically unrelated patches
> > and updated patch descri
On Tue, Jun 02, 2015 at 12:38:26PM +0530, Sudip Mukherjee wrote:
> On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
> > > On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath
From: Chaitanya Dhere
In this patch, ARRAY_SIZE() macro is used to determine the
size. This change was detected with the help of coccinelle
tool.
Signed-off-by: Chaitanya Dhere
---
drivers/staging/wilc1000/linux_wlan.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
From: Hari Prasath Gujulan Elango
Remove ununecessary typecast for kzalloc.This patch was generated by
coccinelle tool.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_wlan_spi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s
From: Hari Prasath Gujulan Elango
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28 +---
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git a/drivers/staging/wilc1000/linux_wlan_spi
From: Hari Prasath Gujulan Elango
use the time_after_eq macro for the comparison operation
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgo
From: Prasanna Karthik
Preferred use of '*' is adjacent to the data name or function name
Signed-off-by: Prasanna Karthik
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_
>From : Hari Prasath Gujulan Elango
remove unwanted assignment to ih->check here as it will be
overwritten.Its not used in the ip_fast_csum() function as well.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 2 +-
1 file changed, 1 insertion(+), 1
On Tue, Jun 2, 2015 at 3:35 AM, Greg Kroah-Hartman
wrote:
> I don't know, but I'm a bit loath to delete the driver from the tree as
> then people will just continue to use the version with all of the bugs.
Yea, I understand that. Though, I'm pretty sure that most users of
ozwpan use old forks tie
>From : Hari Prasath Gujulan Elango
remove unwanted assignment to ih->check here as it will be
overwritten.Its not used in the ip_fast_csum() function as well.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: From name & signed off by were not matching
---
drivers/staging/wilc1000/wi
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> >From : Hari Prasath Gujulan Elango
>
> remove unwanted assignment to ih->check here as it will be
> overwritten.Its not used in the ip_fast_csum() function as well.
This code is hard for me to follow. How do
On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote:
> On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > >From : Hari Prasath Gujulan Elango
> >
> > remove unwanted assignment to ih->check here as it will be
> > overwritten.Its not used in the ip_
Loaded Hyper-V module will use these functions to disable CPU hotplug
under certain circumstances. Convert cpu_hotplug_disabled to a counter
(protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
enable call sequences.
Signed-off-by: Vitaly Kuznetsov
---
Documentation/power/sus
Changes since v2:
- Rebase on top of current Greg's char-misc-next tree [K. Y. Srinivasan]
Changes since v1:
- Make cpu_hotplug_disabled a counter [Radim Krčmář]
Export cpu_hotplug_enable/cpu_hotplug_disable functions from cpu.c and use
them instead of altering smp_ops.cpu_disable in Hyper-V vmbu
Commit e513229b4c38 ("Drivers: hv: vmbus: prevent cpu offlining on newer
hypervisors") was altering smp_ops.cpu_disable to prevent CPU offlining.
We can bo better by using cpu_hotplug_enable/disable functions instead of
such hard-coding.
Reported-by: Radim Krčmář
Signed-off-by: Vitaly Kuznetsov
On Tue, Jun 02, 2015 at 12:01:14PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote:
> > On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > >From : Hari Prasath Gujulan Elango
> > >
> > > re
On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> >From : Hari Prasath Gujulan Elango
You need to write this as "From: " not "From :", otherwise git will not
work properly.
Also, you sent me 5 patches for the same driver, yet no hint as to what
order to apply
Dan Carpenter writes:
> We don't catch this allocation failure because there is a typo and we
> check the wrong variable.
>
> Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
> abstraction')
> Signed-off-by: Dan Carpenter
Reviewed-by: Vitaly Kuznetsov
Thanks, Dan!
>
> d
On Tue, Jun 02, 2015 at 09:11:20PM +0900, gre...@linuxfoundation.org wrote:
> On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > >From : Hari Prasath Gujulan Elango
>
> You need to write this as "From: " not "From :", otherwise git will not
> work properly.
The underflow in OZ_DATA_F_ISOC_FIXED seems not harmful, but this patch
is a clean up and makes my static checker a bit happier.
The underflow in OZ_VENDOR_CLASS_RSP seems like it could result in
memory corruption.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/ozwpan/ozusbsvc1.c
b/
On Tue, Jun 02, 2015 at 03:06:04PM +0300, Dan Carpenter wrote:
> On Tue, Jun 02, 2015 at 12:01:14PM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > On Tue, Jun 02, 2015 at 02:47:24PM +0300, Dan Carpenter wrote:
> > > On Tue, Jun 02, 2015 at 11:37:11AM +, Gujulan Elango, Hari Prasath
> >
From: Hari Prasath Gujulan Elango
Remove ununecessary typecast for kzalloc.This patch was generated by
coccinelle tool
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/wilc1000/linux_wlan_spi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/st
From: Hari Prasath Gujulan Elango
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Sending it as part of a patchset.Previously sent it as
individual patch.
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28 +---
1 file chang
From: Hari Prasath Gujulan Elango
Remove dead code or commented code
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Sending it as part of a patchset.Previously sent it as
individual patch.
---
drivers/staging/wilc1000/linux_wlan_spi.c | 28 +---
1 file chang
From: Hari Prasath Gujulan yyElango
use the time_after_eq macro for the comparison operation
Signed-off-by: Hari Prasath Gujulan yyElango
---
v2:sending it as part of a patchset.previusly sent it as a
individual patch.
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 fil
struct hv_start_fcopy is too big to be on stack on i386, the following
warning is reported:
>> drivers/hv/hv_fcopy.c:159:1: warning: the frame size of 1088 bytes is larger
>> than 1024 bytes [-Wframe-larger-than=]
Reported-by: kbuild test robot
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/h
kzalloc() return value check was accidentally lost in 11bc3a5fa91f:
"Drivers: hv: kvp: convert to hv_utils_transport" commit.
We don't need to reset kvp_transaction.state here as we have the
kvp_timeout_func() timeout function and in case we're in OOM situation
it is preferable to wait.
Reported-
Fix two issues reported by Dan Carpenter and kbuild test robot.
Vitaly Kuznetsov (2):
Drivers: hv: kvp: check kzalloc return value
Drivers: hv: fcopy: dynamically allocate smsg_out in fcopy_send_data()
drivers/hv/hv_fcopy.c | 21 +
drivers/hv/hv_kvp.c | 3 +++
2 files
On mar, 2015-06-02 at 17:25 +0900, Greg KH wrote:
> On Tue, Jun 02, 2015 at 10:08:19AM +0200, pmarzo wrote:
> > On mar, 2015-06-02 at 14:21 +0900, Greg KH wrote:
> > > On Tue, Jun 02, 2015 at 12:19:12AM +0200, pmarzo wrote:
> > > > On Sun, 2015-05-31 at 10:39 +0900, Greg KH wrote:
> > > > > On Thu,
On Tue, Jun 02, 2015 at 03:35:05PM +0200, pmarzo wrote:
> Ok, I will download your staging tree and regenerate patches 1/3 and 2/3
> with that git tree. That would be v5 1/2 and 2/2 new patches.
> Just one (probably very stupid) question, why do you need me to resend
> the patches? I mean, both of
On Tue, Jun 02, 2015 at 11:09:41AM +0530, Sudip Mukherjee wrote:
> On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote:
> > Fix the following sparse warnings:
> >
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
From: Hari Prasath Gujulan Elango
Replace the obsolte simple_strtoul function with kstrtoul.This is a
checkpatch warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/speakup/kobjects.c| 4 ++--
drivers/staging/speakup/main.c| 2 +-
drivers/staging/speakup/varhand
On 06/01/2015 06:17 PM, Drew Fustini wrote:
On Mon, Jun 01, 2015 at 02:34:16PM -0400, Ben Romer wrote:
Would you mind if I sent a second version of this patch with it
rebased against my last set of patches, so it will apply?
Please go ahead.
thanks,
drew
Sorry, never mind, it looks like Gr
You didn't try to compile this.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jun 02, 2015 at 05:45:14PM +0300, Dan Carpenter wrote:
> You didn't try to compile this.
>
> regards,
> dan carpenter
>
>
sorry Dan,I overlooked the build warnings.I will fix and send a
v2.Thanks for the comment.
Regards,
Hari Prasath
___
dev
Signed-off-by: Chris Hanna
Minor changes to remove excessive whitespace and improve
readability of functions.
---
Sending again due to tree mismatch.
drivers/staging/lustre/lustre/osc/lproc_osc.c | 18 +-
drivers/staging/lustre/lustre/osc/osc_cache.c | 196 +++---
drivers
From: Gnanachandran Dhanapal
Casting correct Endianness for __le16 variable used in assignment and
condition check
Signed-off-by: Gnanachandran Dhanapal
---
v3: Greg review comments addressed
---
drivers/staging/rtl8192e/rtllib_softmac.c | 14 ++
1 file changed, 10 insertions(+)
auth_parse() return result is in incorrect le16 byte order. Currently
this still works since the user code merely checks if error code is
equal to 0. However debug statement in ieee80211_check_auth_response()
prints the error code in the incorrect le16 byte order. This fix
corrects the byte order a
>>On Mon, Jun 01, 2015 at 12:21:30PM -0700, David Decotigny wrote:
>> Thanks for reviewing.
>>
>> The 2 struct members were not marked as __user, which this patch does
>> here. This was causing warnings with copy from/to user (see commit
>> description). This patch also propagates the annotation
Fix the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:expected
restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8192
In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
warning due its inability to detect the noreturn attribute in
lbug_with_lock() function inside LBUG macro. Adding a never reached
return statement suppresses this warning.
Signed-off-by: Tolga Ceylan
---
drivers/staging/lu
Delete unused code. Removed some macros, enums, unions and several
structures (tx_fwinfo, wmm_tspec, qos_tstream, sta_qos, bss_qos).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 40 -
.../staging/rtl8192e/rtl8192e/r8192E_firmware.h| 5 -
d
This series of patches removes some dead code residing in rtl8192e driver.
It should apply cleanly to both staging-next (63d03e47) and
staging-testing (084861124).
Only driver code was modified (i.e. this series doesn't touch rtllib
embedded in the driver).
Series was target tested (802.11N/2.4G/
dig_t::dbg_mode is initialized to one value and checked only once in code.
This patch throws it away, and deletes always-true condition.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 5 +
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 24 --
Remove unused fields from rt_stats structure.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 40
1 file changed, 40 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
b/drivers/staging/rtl8192e/rtl8192e/rtl_
- Removed unused macros/enums/structures
- Remove unused fields in r8192_priv
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 154 ---
1 file changed, 154 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
b/drive
- Remove unused fields in dig_t structures. Some of them were only
initialized and never accessed.
- Remove unused enums/macros/defines in rtl_dm.h
- Remove duplicated function declarations
- Remove unused dm_change_dynamic_initgain_thresh() function
- Remove unused dm_shadow_init() function
Sig
Remove unused members of rtl8192_priv structure.
Some of them are never used, other are just initialized and
never accessed.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 11 --
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 32
drivers/staging/r
Remove cmpk_message_handle_rx() and static functions used by it.
This function was never called.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 272 --
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 134 ---
2 files chan
Both functions are never used.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 12
drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 4
2 files changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c
b/drivers/staging
mp_adapter structure was used in past, but now is only initialized and
never read.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 --
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 4 +---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.h | 17 ---
Remove cmpk_handle_query_config_rx function. It is called
once, does some calculation, but generates no output -
it has neither return value, nor modify its parameters.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 18 --
1 file changed
Remove undefined and unused PHY array forward-declarations.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h
b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy
The checkpatch.pl script reports several errors at file ieee80211_crypt_wep.c,
this patch fixes them.
Pedro Marzo Perez (2):
Simplify error check code at prism2_wep_init
Remove two useless lines at ieee80211_wep_null
.../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 34 ++--
Simplify prism2_wep_init error check code employing goto when a failure is
detected.
Removed pr_debug which was given a checkpatch.pl error because of literal string
splitted across two lines of code, it was seldom going to be printed anyway.
Signed-off-by: Pedro Marzo Perez
---
.../rtl8192u/i
Remove two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
The first one because it has a C99 comment style and the second one because it
is a void
return which is useless.
The function ieee80211_wep_null cannot be completely removed because it is
exported and
used to autoloa
Hi,
Here are a couple more comments. Hopefully not much duplication from
other reviews.
On 05/31/15 19:43, Petros Koutoupis wrote:
>
> diff -uNpr linux-next.orig/drivers/staging/rapiddisk/Kconfig
> linux-next/drivers/staging/rapiddisk/Kconfig
> --- linux-next.orig/drivers/staging/rapiddisk/Kc
Added a new line
Signed-off-by: aparnak
---
drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c
b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/stagin
On Wed, Jun 03, 2015 at 10:22:33AM +0530, aparnak wrote:
> Added a new line
>
> Signed-off-by: aparnak
Please use your full name in From header and Signed-off-by.
and subject should have been:
[PATCH] staging: lustre: llite: Fix No space after the declaration
regards
sudip
__
On Tue, Jun 02, 2015 at 11:32:19AM -0400, Chris Hanna wrote:
> Signed-off-by: Chris Hanna
>
> Minor changes to remove excessive whitespace and improve
> readability of functions.
this description should come above your Signed-off-by line.
regards
sudip
__
On Tue, Jun 02, 2015 at 12:57:20PM -0700, Tolga Ceylan wrote:
> In llog_cat_new_log(), sparse emits a context imbalance (unexpected lock)
> warning due its inability to detect the noreturn attribute in
> lbug_with_lock() function inside LBUG macro. Adding a never reached
> return statement suppress
On Tue, Jun 02, 2015 at 05:45:14PM +0300, Dan Carpenter wrote:
> You didn't try to compile this.
>
> regards,
> dan carpenter
>
>
I checked the build warnings. This is a false positive warning from
checkpatch.pl.Please discard this and sorry for the inconvenience
caused.Next time I would take e
78 matches
Mail list logo
