On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote:
> On 05/24/2015 02:03 PM, Haggai Eran wrote:
> >On 24 May 2015 at 00:16, Larry Finger wrote:
> >>The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
> >>del_timer_sync() while in interrupt mode. Such warnings ar
On Mon, May 25, 2015 at 02:14:32AM +0300, Vladimirs Ambrosovs wrote:
> From: Vladimirs Ambrosovs
>
No need for this, we get it from your email address.
> This patch fixes the leak, which was present in fwserial driver in the
> init function. in case the tty driver allocation failed the function
On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
> toobig = 1;
> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> -
On Mon, May 25, 2015 at 03:07:08PM +0530, Vaishali Thakkar wrote:
> I am sorry for those patches. It was me who introduced those bugs. Yes, it
> was sent during Outreachy process. But it was my mistake as a newbie. May
> be I should have taken care of interrupt mode thing.
>
> I would like to fix
Modified the if-else statements to remove unnecessary comparisons.
This change was detected with the help of coccinelle tool
Signed-off-by: Harisangam Sharvari S
---
drivers/staging/vt6655/rxtx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt665
On Thu, May 21, 2015 at 05:53:15PM +0200, Mateusz Kulikowski wrote:
> Add __aligned(2) into ethernet addresses allocated on stack or in non-packed
> structures. Use ETH_ALEN as array length in places where it was hardcoded to
> 6.
To be honest, this patch makes me hate the stupid ether_addr_copy(
On Thu, May 21, 2015 at 05:53:17PM +0200, Mateusz Kulikowski wrote:
> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
> checkpatch.pl warning.
> It will prevent accidential "Fix" to ether_addr_copy().
>
Hopefully someone is going to fix those properly soon so we won't need
the comm
On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
> Use dedicated macro to compare ethernet addresses in probe_rq_parse().
>
> Signed-off-by: Mateusz Kulikowski
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff
On Sun, May 24, 2015 at 01:11:08PM -0700, Greg KH wrote:
> That's multiple things in one patch :(
>
> Also, this is an attachment, which I can't apply, please resend it as a
> proper email.
Thanks for your reply. I split it into two patches, as you suggested.
Here are them.
---
Changes in v3:
Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
Signed-off-by: Geliang Tang
Reviewed-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
Signed-off-by: Geliang Tang
Reviewed-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_commo
Silence the following sparse warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning:
incorrect type in assignment (different base types)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:expected
restricted __le16 [usertype] frame_ctl
drivers/staging/rtl8
On 15-05-23 10:53 PM, tolga ceylan wrote:
> On 05/12/2015 08:55 PM, Tolga Ceylan wrote:
>> Error code returned from auth_parse() should in cpu byte order.
>>
>> Signed-off-by: Tolga Ceylan
>> ---
>> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
>> 1 file changed, 1 insertion(+)
On 05/25/2015 04:37 AM, Vaishali Thakkar wrote:
On 25 May 2015 14:49, "Dan Carpenter" mailto:dan.carpen...@oracle.com>> wrote:
>
> On Sun, May 24, 2015 at 07:11:40PM -0500, Larry Finger wrote:
> > On 05/24/2015 02:03 PM, Haggai Eran wrote:
> > >On 24 May 2015 at 00:16, Larry Finger mailto:la
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote:
I haven't been using kernel v4.1 so I haven't seen this warning, but looking
at the code it seems to originate from the two recent patches to remove
_cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1]
that changes del_tim
On 05/23/2015 04:16 PM, Larry Finger wrote:
The driver is reporting a warning at kernel/time/timer.c:1096 due to calling
del_timer_sync() while in interrupt mode. Such warnings are fixed by calling
del_timer() instead.
Signed-off-by: Larry Finger
Cc: Stable
Cc: Haggi Eran
---
Greg,
Please
On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
> On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > > the if comparison is always true as anything bitwise and-ing with 0x1E
> > > can never be equa
Good advice. This was actually found by Sparse and the changelog should
say:
Sparse complains about this:
ieee80211_softmac.c:1561:16: warning: cast from restricted __le16
ieee80211_softmac.c:1561:16: warning: incorrect type in return expression
(different base types)
ieee80211_softmac.c:1561:1
On Mon, May 25, 2015 at 12:00:42PM -0300, Gaston Gonzalez wrote:
> Silence the following sparse warning:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning:
> incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:3
On Mon, 2015-05-25 at 12:17 +0300, Dan Carpenter wrote:
> These are special intern patches that
> dont' go through the normal review process. The intern process is over
> this year. The lack of normal review introduced a number of bugs this
> year. I always complain to Greg about it and he says
On Mon, 2015-05-25 at 17:03 +0300, Dan Carpenter wrote:
> On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
> > Use dedicated macro to compare ethernet addresses in probe_rq_parse().
> >
> > Signed-off-by: Mateusz Kulikowski
> > ---
> > drivers/staging/rtl8192e/rtllib_softmac.c
On Mon, May 25, 2015 at 12:27:22PM +0300, Dan Carpenter wrote:
> On Mon, May 25, 2015 at 02:14:32AM +0300, Vladimirs Ambrosovs wrote:
> > From: Vladimirs Ambrosovs
> >
>
> No need for this, we get it from your email address.
>
> > This patch fixes the leak, which was present in fwserial driver
This patch fixes the leak, which was present in fwserial driver in the
init function. In case the tty driver allocation failed the function
returned error, leaving debugfs entry in the filesystem.
To fix the issue additional error label was added, so that the code will
jump to it in case of alloca
Signed-off-by: Shailendra Verma
---
drivers/staging/nvec/nvec.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 1bdc8d0..164634d 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -9
On 25/05/15 13:35, Dan Carpenter wrote:
> This is also wrong then.
>
> regards,
> dan carpenter
Hi Dan,
Yes, you are right. It is the next sparse warning in line for that file.
Including the fix for that, the patch would be as showed below.
There are similar endianness warnings for other variable
pcl812.c (resend of earlier patch)
Fixed lines exceeding 80 columns, correcting some spelling in process
Signed-off-by: Matthew Needes
---
drivers/staging/comedi/drivers/pcl812.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812
pcl812.c / pcl816.c (resend of earlier patch)
Fixed indentation problems.
Signed-off-by: Matthew Needes
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
drivers/staging/comedi/drivers/pcl816.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/dr
This fixes the following sparse warnings:
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38: warning: incorrect type
in argument 1 (different address spaces)
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:38:expected void
[noderef] *to
drivers/staging/lustre/lnet/lnet/api-ni.c:1926:3
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> It'd be better if the approved patches from the intern list
> (no idea what that is) were sent to lkml/devel@driverdev lists
> for review before actually being applied.
Its the outreachy program. And http://kernelnewbies.org/OutreachyAp
On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> > It'd be better if the approved patches from the intern list
> > (no idea what that is) were sent to lkml/devel@driverdev lists
> > for review before actually being applied.
>
On Mon, May 25, 2015 at 07:22:40PM +0300, Dan Carpenter wrote:
> On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
> > On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> > > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > > > the if comparison is al
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> > > It'd be better if the approved patches from the intern list
> > > (no idea what that is) were sent to lkml/
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons.
> This change was detected with the help of coccinelle tool
>
> Signed-off-by: Harisangam Sharvari S
you should not use initials in the Signed-off-by nam
On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan carpenter
> Hi Dan,
>
> Yes, you are right. It is the next sparse warning in line for that file.
> Including the fix for that, the patch
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> > > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > > > On Mon, May 25, 2015 at 10:37:28AM -0700,
35 matches
Mail list logo
