On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote:
> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
>
> Signed-off-by: Alex Dowad
> ---
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/st
Was the patch sent to the list? Maybe it was rejected for being too
large?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote:
> On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote:
>> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
>>
>> Signed-off-by: Alex Dowad
>> ---
>> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +-
>> 1 file chan
On 05/18/2015 10:06 AM, Lad, Prabhakar wrote:
> On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote:
>> On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote:
>>> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
>>>
>>> Signed-off-by: Alex Dowad
>>> ---
>>> drivers/stagin
Le 18/05/2015 10:04, Dan Carpenter a écrit :
> Was the patch sent to the list? Maybe it was rejected for being too
> large?
Yep is seems: it appears on driverdev-devel:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/069148.html
But it seems not on linux-wireless.
Bye
Also the use a subsystem prefix in the subject:
[PATCH] Staging: rtl8192u: whatever...
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, May 17, 2015 at 10:38:48PM +0200, Mateusz Kulikowski wrote:
> On 15.05.2015 01:14, Dan Carpenter wrote:
> > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
> >> On 13.05.2015 10:22, Dan Carpenter wrote:
> >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski w
This is a patch that fixes the function declarations in
visorbus/visorchipset.c by removing newlines after the function return
type
Signed-off-by: Wim de With
---
drivers/staging/unisys/visorbus/visorchipset.c | 225 ++---
1 file changed, 85 insertions(+), 140 deletions(-)
d
Hi,
For a project I needed to communicate with external hardware via the I2C
protocol. I took a look at the existing drivers in the linux kernel
source "drivers/i2c/busses".
Instead of buying yet another interface dongle (this time for I2C) I
decided to use an Arduino with an apropriate sket
On Mon, May 18, 2015 at 11:45:49AM +0200, Wim de With wrote:
> This is a patch that fixes the function declarations in
> visorbus/visorchipset.c by removing newlines after the function return
> type
But this is not an error nor it is a coding style error. Instead your
patch will now introduce new
Wim de With writes:
> This is a patch that fixes the function declarations in
> visorbus/visorchipset.c by removing newlines after the function return
> type
This patch doesn't fix things, it makes things worse!
If you want to post patches to this, do it properly and check the output
first.
NAC
replace the printk with netdev subsystem debug infrastructure.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtllib_rx.c
inde
On 16/05/15 05:16, Geliang Tang wrote:
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
3) The kernel version is next-20150515, 4.
This macro defines the maximum sequence number for an IEEE802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index 3c8b708..9ee08
replace the hard coded value for the maximum sequence number of a ieee
802.11 frame by a Macro.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c
b/driv
Fold this together with the other patch. Do 1 thing per patch, not half
a thing per patch. This change makes no sense on its own.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailma
On Mon, May 18, 2015 at 03:47:58PM +0300, Dan Carpenter wrote:
> Fold this together with the other patch. Do 1 thing per patch, not half
> a thing per patch. This change makes no sense on its own.
>
> regards,
> dan carpenter
>
I didn't think of it. I am sending v2 with both the related change
replace the hard coded value of 4096 with macro which defines the
maximum sequence number of a ieee 802.11 frame.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2: Previously send this as two different patches which is wrong
as the individual patches doesn't make sense.Resending as a sin
Hi Bernhard,
There are many cheap I2C adapter projects (mostly USB though). One of
the simple ones (i2c-tiny-usb) is included in the kernel, while LinkM
(https://github.com/todbot/LinkM) stayed userspace.
As regarding to cheap serial line based adapters, there are two I have
seen before
(ht
This patch adds more help description on android Kconfig for
- lowmemory killer
- Timed gpio (same for timed output)
Signed-off-by: Jagan Teki
Cc: Greg Kroah-Hartman
Cc: Brian Swetland
---
drivers/staging/android/Kconfig | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff -
Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)
pahole output for respective structures:
- addr->sa_data
struct sockaddr {
sa_family_tsa_family;/* 0
On Mon, May 18, 2015 at 07:47:06PM +0530, Jagan Teki wrote:
> struct eeprom_priv {
> u8 bautoload_fail_flag; /* 0 1 */
> u8 bempty; /* 1 1 */
> u8 sys_config; /* 2
setup_timer is used for timer parameter setup rather than direct
assignment
Signed-off-by: Gnanachandran Dhanapal
---
drivers/staging/rtl8192e/rtllib_module.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_module.c
b/drivers/staging/rtl8
On Sat, May 16, 2015 at 02:22:16PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 01:22:28PM -0400, Benjamin Romer wrote:
> > + hdr_info = kzalloc(sizeof(*hdr_info), GFP_KERNEL);
> > + if (!hdr_info) {
> > + rc = NULL;
> > + goto away_mem;
> > + }
> > +
> > dev_
On Sat, May 16, 2015 at 02:32:33PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 01:22:34PM -0400, Benjamin Romer wrote:
> > @@ -1022,29 +997,21 @@ create_visor_device(struct visor_device *bdev,
> > goto away;
> > }
> >
> > - /* note: device_register is simply device_ini
On Mon, May 18, 2015 at 10:52:25AM -0400, Don Zickus wrote:
> On Sat, May 16, 2015 at 02:22:16PM +0300, Dan Carpenter wrote:
> > On Wed, May 13, 2015 at 01:22:28PM -0400, Benjamin Romer wrote:
> >
> > We still leak hdr_info on some paths.
>
> Agreed. I noticed and fixed this up in patch 37 "Remo
On Sat, May 16, 2015 at 02:38:57PM +0300, Dan Carpenter wrote:
> On Wed, May 13, 2015 at 01:22:26PM -0400, Benjamin Romer wrote:
> > --- a/drivers/staging/unisys/visorbus/visorchipset.c
> > +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> > @@ -1197,6 +1197,7 @@ bus_create(struct controlvm_me
On Mon, 2015-05-18 at 11:33 +0300, Dan Carpenter wrote:
> Also the use a subsystem prefix in the subject:
>
> [PATCH] Staging: rtl8192u: whatever...
>
>
> regards,
> dan carpenter
>
Thanku for your comments, I will send an v2 patch version
regards, Pedro
__
Instead of creating a channel struct to temporarily hold the channel
info and passing it through multiple functions until the device is
created, just create the channel from the start.
This allows us to remove the channel_info struct.
I noticed 'chan_info.addr_type' was not being used, so I just
This patch removes the legacy dev_info struct and instead creates
and passes around a traditional struct device.
This allows us to remove a lot of the various look up code and
removes the doubt if the struct exists or not.
Half of the churn is just the conversion of visorchipset_device_info
to vi
Merge two pr_debug lines with literal strings splitted across several lines
into one single line, simplifying prism2_wep_init error check code.
Openning braces should never be in a new line, move them to the end of
the previous line.
Removed two useless lines at ieee80211_wep_null.
Signed-off-by:
On Mon, May 18, 2015 at 11:20:27AM -0400, Don Zickus wrote:
> What might be confusing you is the bus_info = bus_find() command above.
Yes. You are right. This was where I got confused. Was in too much of
a hurry. Sorry about that.
regards,
dan carpenter
_
Signed-off-by: Chaitanya Dhere
Reply-To:
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index d2e
On 18 May 2015 at 20:08, Dan Carpenter wrote:
> On Mon, May 18, 2015 at 07:47:06PM +0530, Jagan Teki wrote:
>> struct eeprom_priv {
>> u8 bautoload_fail_flag; /* 0 1 */
>> u8 bempty; /* 1 1 */
>> u8
On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
>
> Signed-off-by: Gnanachandran Dhanapal
your From: name and Signed-off-by: names are not matching. They should
be same.
> ---
> --- a/
#include
struct foo {
unsigned char one;
unsigned char two;
unsigned char three;
unsigned char mac_addr[6];
unsigned short channel_plan;
};
int main(void)
{
struct foo *p = NULL;
printf("%x\n", &p->mac_addr);
return 0;
}
This pr
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previ
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previ
Fixes Warning encounter this by applying checkpatch.pl against this file:
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)
pahole output for respective structures:
- addr->sa_data
struct sockaddr {
sa_family_tsa_family;/* 0
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.)
> > wrote:
> > > setup_timer is used for timer parameter setup rather than direct
> > > assignment
> >
Hi,
On 2015-05-18 15:00, Alex Beregszaszi wrote:
There are many cheap I2C adapter projects (mostly USB though). One of
the simple ones (i2c-tiny-usb) is included in the kernel [...]
I knew of the OpenSource project i2c-tiny-usb. But sadly the hardware
ist not sold anywhere (At least I didn'
This patch fixes line over 80 characters warninings while
running checkpatch.pl - "WARNING: line over 80 characters"
Signed-off-by: Jagan Teki
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 52 +++--
1 file changed, 36 insertio
Use kernel.h macro definition.
Signed-off-by: Fabian Frederick
---
drivers/staging/xgifb/vb_setmode.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index a47395e..3b0b4d3 100644
--
> void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
> {
> - ptimer->function = fun;
> - ptimer->data = data;
> init_timer(ptimer);
> + setup_timer(ptimer, fun, data);
> }
setup_timer also subsumes init_timer. Check the definition. Probably you
can
Sudip Mukherjee wrote:
> On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> > This patch fixes coding style errors reported by checkpatch.pl for
> > cb_pcidas64.c, about too long source code lines.
> >
> > Signed-off-by: Amaury Denoyelle
> > ---
>
> > }
> >
> > -/* adjusts
In the explanation of the function the name of the function was incorrect
Signed-off-by: Adrian Remonda
---
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c
b/drivers/staging/lustre/lustre/p
Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
'different lock contexts for basic block' by releasing the lock on each
iteration of the for loop.
Signed-off-by: Adrian Remonda
---
drivers/staging/lustre/lustre/ptlrpc/nrs.c | 6 ++
1 file changed, 2 insertions(+), 4 dele
This patch clears the warning given by sparse that the function should be
static.
Done by moving the declaration of the structure 'nrs_core' into the header
'ptlrpc_internal.h'
modified: drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
modified: drivers/staging/lustre/lust
This patch clears the warning given by sparse that the function should be
static.
Done by moving the declaration of the structure 'nrs_conf_fifo' into the header
'ptlrpc_internal.h'
modified: drivers/staging/lustre/lustre/ptlrpc/nrs.c
modified: drivers/staging/lustre/lustre/p
> Sudip Mukherjee wrote:
>
> > On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> > > This patch fixes coding style errors reported by checkpatch.pl for
> > > cb_pcidas64.c, about too long source code lines.
> > >
> > > Signed-off-by: Amaury Denoyelle
> > > ---
> >
> > > }
>
The first item in this submission documents previously introduced
vme_master_mmap() call. Following, there are three fixes for the tsi148
driver's DMA. There was one bug that rendered it imposible to use DMA
lists with more than one item. The other was related to the place where
dma_map_single was
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
Documentation/vme_api.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt
index ffe6e22..ca5b827 100644
--- a/Documentation/vme_api.txt
+++ b/Documentation/vme_api.txt
@@ -171,6 +
This moves DMA mapping of the first list element to vme_list_add, the
same place where other elements mappings occur. This prevents extra
mapping or over-unmapping in the cases when vme_list_exec is called more
or less than one time respectively.
Also adds dma_mapping_error check.
Signed-off-by:
This makes vme_user_llseek ignore all minors that don't have llseek
implementation.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/staging/vme/devices/vme_user.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vme/devices/vme
DMA lists on tsi148 weren't processed further than the first item
because of the broken logic. This regression was introduced in:
ac1a4f2caf7b071 "Staging: VME: Ensure TSI148 link list descriptors..."
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/vme/bridges/vme_tsi148.c | 4 ++-
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/vme/bridges/vme_ca91cx42.c | 15 +--
drivers/vme/bridges/vme_tsi148.c | 15 +--
2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/drivers/vme/bridges/vme_ca91cx42.c
b/drivers/vme/bridges/vme_ca9
This introduces a new dma device that provides a single ioctl call that
provides DMA read and write functionality to the user space.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/staging/vme/devices/vme_user.c | 174 -
drivers/staging/vme/devices/v
On Mon, 2015-05-18 at 21:53 +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > Merge two pr_debug lines with literal strings splitted across several lines
> > into one single line, simplifying prism2_wep_init error check code.
> > Openning braces
On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > Merge two pr_debug lines with literal strings splitted across several lines
> > into one single line, simplifying prism2_wep_init error check code.
> > Openning braces sh
On Mon, 2015-05-18 at 23:56 +0200, pmarzo wrote:
> On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > Merge two pr_debug lines with literal strings splitted across several
> > > lines
> > > into one single line, simp
On Mon, 2015-05-18 at 13:04 -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 23:56 +0200, pmarzo wrote:
> > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > > Merge two pr_debug lines with literal strings splitte
Hi,
On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
> replace the printk with netdev subsystem debug infrastructure.
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Tue, 2015-05-19 at 00:35 +0200, pmarzo wrote:
> On Mon, 2015-05-18 at 13:04 -0700, Joe Perches wrote:
> > btw: using:
> >
> > $ ./scripts/checkpatch.pl -f --strict --fix-inplace \
> >
> > --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space,space_before_tab,in
On Mon, May 18, 2015 at 11:56:08PM +0200, pmarzo wrote:
> On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > Merge two pr_debug lines with literal strings splitted across several
> > > lines
> > > into one single lin
On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> > setup_timer is used for timer parameter setup rather than direct
> > assignment
> >
> > Signed-off-by: Gnanachandran Dhanapal
>
> your From: name and Sign
On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote:
> Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' -
> 'different lock contexts for basic block' by releasing the lock on each
> iteration of the for loop.
>
That changelog doesn't sound correct at all. That's not
The checkpatch.pl script reports several errors and warnings at file
ieee80211_crypt_wep.c, this series of patches fixes them.
Pedro Marzo Perez (3):
ieee80211_crypt_wep: Simplify error check code at prism2_wep_init
ieee80211_crypt_wep: Remove two useless lines at ieee80211_wep_null
ieee8021
Removed two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
The first one because it has a C99 comment style and the second one because it
is a void
return which is useless.
Signed-off-by: Pedro Marzo Perez
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
Opening braces should never be in a new line.
Correct include indentation.
Signed-off-by: Pedro Marzo Perez
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt
Merge two pr_debug lines with literal strings splitted across several lines
into one single line, simplifying prism2_wep_init error check code.
Signed-off-by: Pedro Marzo Perez
---
.../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 22 +-
1 file changed, 9 insertions(+), 13
On Mon, May 18, 2015 at 08:34:48PM +0200, Adrian Remonda wrote:
> This patch clears the warning given by sparse that the function should be
> static.
> Done by moving the declaration of the structure 'nrs_conf_fifo' into the
> header
> 'ptlrpc_internal.h'
>
> modified: drivers/staging/l
On Tue, 2015-05-19 at 00:06 +0300, Dan Carpenter wrote:
> On Mon, May 18, 2015 at 11:56:08PM +0200, pmarzo wrote:
> > On Mon, 2015-05-18 at 19:15 +0300, Dan Carpenter wrote:
> > > On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> > > > Merge two pr_debug lines with literal string
On Mon, May 18, 2015 at 04:00:00PM +, Dhere, Chaitanya (C.) wrote:
> Signed-off-by: Chaitanya Dhere
Your subject line is too long :(
Put some information in the change log area here please, above the
signed-off-by line.
> Reply-To:
Why is this here?
Please fix up and resend.
thanks,
gr
On 18-5-2015 12:45, Jes Sorensen wrote:
> Wim de With writes:
>> This is a patch that fixes the function declarations in
>> visorbus/visorchipset.c by removing newlines after the function return
>> type
>
> This patch doesn't fix things, it makes things worse!
>
> If you want to post patches to
From: douglasbsf
Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
Signed-off-by: douglasbsf
---
drivers/staging/wlan-ng/prism2fw.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2fw.c
b/drivers/staging/wlan-ng/prism2fw.c
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf
>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
1) mention which coding style problem you fixed in the commit message.
2) no need to mention the challenge in the subject, the subject can b
thanks for yours hints.
930672e8693a is my ID on the challenge, I will take care about this
things in the future.
2015-05-19 2:03 GMT-03:00 Sudip Mukherjee :
> On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
>> From: douglasbsf
>>
>> Fixed Coding Style Problem in drivers/stag
On Mon, May 18, 2015 at 10:29:55PM +0200, Mateusz Kulikowski wrote:
> Hi,
>
> On 18.05.2015 13:27, Gujulan Elango, Hari Prasath (H.) wrote:
> > replace the printk with netdev subsystem debug infrastructure.
> >
> > Signed-off-by: Hari Prasath Gujulan Elango
> > ---
> > drivers/staging/rtl8192e/
On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
I would have split this patch into three.
1) introduce pr_fmt and remove "ieee80211
Dear Bernhard Kraft,
2015-05-18 18:53 GMT+02:00 Bernhard Kraft :
> Hi,
>
> On 2015-05-18 15:00, Alex Beregszaszi wrote:
>
>> There are many cheap I2C adapter projects (mostly USB though). One of
>> the simple ones (i2c-tiny-usb) is included in the kernel [...]
>
>
> I knew of the OpenSource proje
On Mon, May 18, 2015 at 08:51:29PM +0200, Amaury Denoyelle wrote:
> > Sudip Mukherjee wrote:
> >
> > > On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> Thanks for your review. I was aware of the coding style for multi-line
> comments, but I chose to follow the same convention
81 matches
Mail list logo
