On Thu, 2015-05-14 at 19:03 -0300, Gaston Gonzalez wrote:
> If Dan is a newbie to this, I would be a pre-under-newbie or something
> below that. That being said, understood your explication, I'll look for
> another way to deal with this warning.
I don't even see your original patch, so I have no
Currently the struct netvsc_stats has a member s_sync
of type u64_stats_sync.
This definition will break kernel build as the macro
netdev_alloc_pcpu_stats requires this member name to be syncp.
(see netdev_alloc_pcpu_stats definition in ./include/linux/netdevice.h)
This patch changes netvsc_stats'
Fixed comment spelling errors
Signed-off-by Colin Cronin
---
drivers/staging/dgap/dgap.c | 2 +-
drivers/staging/dgap/dgap.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 6766d5a..0691729 100644
--- a/driver
del_timer_sync() is not to be called in the interrupt context unless
the timer is irqsafe. but most of the functions where commits
6501c8e7d86cca5f and 382d020f4459cd77 touched were called in interrupt
context. And as a result the WARN_ON was getting triggered. Changed
to del_timer() in places whic
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > the if comparison is always true as anything bitwise and-ing with 0x1E
> > can never be equal to 0x03.
> >
> > Fixes bugzilla: https://bugzilla.kernel.org/show_bug.
On Fri, May 15, 2015 at 02:11:40AM -0700, Colin Cronin wrote:
> Fixed comment spelling errors
>
> Signed-off-by Colin Cronin
this is wrong. should be Signed-off-by:
regards
sudip
> ---
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
This trivial patch removes temporary variable to check return value of
a function and checks return value directly.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rts5208/ms.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rts5208/ms.c b/dr
Use a temporary value to hold the SD lock status thereby making the code
readable.This also fixes a coding style violation with the braces around
the if block.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rts5208/sd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
On Fri, May 15, 2015 at 12:09:42PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Use a temporary value to hold the SD lock status thereby making the code
> readable.This also fixes a coding style violation with the braces around
> the if block.
>
This isn't more readable than the original co
Attn. Pls kindly open the attached Halifax bank loan offer and send your
response to us.
Halifax Bank Loan.pdf
Description: Adobe PDF document
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinf
On May 15, 2015 4:10 PM, "David Laight" wrote:
> Why not just check the length. eg:
> unsigned int data_len = elt->length;
> if (data_len < sizeof(struct oz_get_desc_rsp) + 1)
> break;
Sure.
> >
Hello Martyn Welch,
The patch 2b82beb8c1bc: "Staging: vme: Add location monitor support
for ca91cx42" from Feb 18, 2010, leads to the following static
checker warning:
drivers/vme/bridges/vme_ca91cx42.c:1383 ca91cx42_lm_get()
warn: masked condition is always false. '(lm_ctl & (5 <
Fixed comment spelling errors
Signed-off-by: Colin Cronin
---
drivers/staging/dgap/dgap.c | 2 +-
drivers/staging/dgap/dgap.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 6766d5a..0691729 100644
--- a/drive
On 15/05/15 04:26, Johannes Berg wrote:
> On Thu, 2015-05-14 at 19:03 -0300, Gaston Gonzalez wrote:
>
>> If Dan is a newbie to this, I would be a pre-under-newbie or something
>> below that. That being said, understood your explication, I'll look for
>> another way to deal with this warning.
> I do
From: pmarzo
This patch just fixes some errors reported by checkpatch.pl script
Signed-off-by: Pedro Marzo Perez
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
From: keith.ma...@microsoft.com
Add support for Windows 10.
Signed-off-by: Keith Mange
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/connection.c |8 +---
include/linux/hyperv.h |4 +++-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/connection.c b/dri
On Sat, May 16, 2015 at 02:11:06AM +0200, Pedro Marzo Perez wrote:
> From: pmarzo
This line doesn't match your from: line in your email client, or the
line below in the signed-off-by part.
Also, please make your subject a bit more descriptive.
>
> This patch just fixes some errors reported by
visorchipset_file_init() and visorchipset_file_cleanup() functions
do not seem to be used from anywhere else and now are declared
as static. Sparse emitted "not declared" warnings for these two
functions.
Signed-off-by: Tolga Ceylan
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1
1) Fixed an error found by checkpatch.pl.
ERROR: space required after that ',' (ctx:VxV)
./drivers/ni_mio_common.c:3764
2) Changed "register 0x%x" to "register=0x%x" to keep the consistency
of this file.
3) The kernel version is next-20150515, 4.1.0-rc3
This patch just fixes some warnings and style errors reported by checkpatch.pl
script
- Braces should not start in a new line
- C99 comments are not allowed (never use //)
- Literal strings should never be parted in several lines
- There was a useless return on a void function
Sig
20 matches
Mail list logo
