Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function

2015-05-03 Thread Drokin, Oleg
On May 3, 2015, at 1:53 AM, Julia Lawall wrote: > On Sat, 2 May 2015, Drokin, Oleg wrote: > >> >> On May 2, 2015, at 5:16 PM, Julia Lawall wrote: >> >>> Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a >>> function, obd_cpt_alloc. >>> >>> Signed-off-by: Julia Lawall >>>

[PATCH 1/3] staging: lustre: ptlrpc: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

[PATCH 3/3] staging/lustre/ptlrpc: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

[PATCH 0/3] Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
The complete semantic patch used to make this transformation is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size,gfp; @@ - OBD_CPT_ALLOC_GFP(ptr, cptab, cpt, size, gfp) + ptr = kzalloc_node(size, gfp, cfs_cpt_spread_node(cptab, cpt)) @@ expression ptr,cptab,cpt,size

[PATCH 2/3] drivers: staging: lustre: lustre: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

[PATCH 3/3 v2] staging: lustre: ptlrpc: service: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

[PATCH 0/3 v2] Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
The complete semantic patch used to make this transformation is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size,gfp; @@ - OBD_CPT_ALLOC_GFP(ptr, cptab, cpt, size, gfp) + ptr = kzalloc_node(size, gfp, cfs_cpt_spread_node(cptab, cpt)) @@ expression ptr,cptab,cpt,size

[PATCH 1/3 v2] staging: lustre: ptlrpc: nrs: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

[PATCH 2/3 v2] staging: lustre: ptlrpc: nrs_fifo: Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Julia Lawall
Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by corresponding calls to kzalloc_node. The semantic patch for the OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/). // @@ expression ptr,cptab,cpt,size; @@ - OBD_CPT_ALLOC(ptr, cptab, cpt, size) + ptr = kzalloc_node(s

Re: [PATCH 0/3 v2] Replace OBD_CPT_ALLOC etc by kzalloc_node

2015-05-03 Thread Drokin, Oleg
All three are good from my perspective. Thanks! On May 3, 2015, at 10:07 AM, Julia Lawall wrote: > The complete semantic patch used to make this transformation is as follows: > (http://coccinelle.lip6.fr/). > > // > @@ > expression ptr,cptab,cpt,size,gfp; > @@ > > - OBD_CPT_ALLOC_GFP(ptr, cpta

Re: [PATCH 1/3] staging/lustre: Generic helpers for sysfs

2015-05-03 Thread Greg Kroah-Hartman
On Sat, May 02, 2015 at 11:10:06PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Add generic helpers to allow displaying oof lustre-specific values > in /sys/fs/lustre > > Signed-off-by: Oleg Drokin > --- > .../staging/lustre/lustre/include/lprocfs_status.h | 26 > +++

Re: [PATCH 2/3] staging/lustre: Move /proc/fs/lustre root level files to sysfs

2015-05-03 Thread Greg Kroah-Hartman
On Sat, May 02, 2015 at 11:10:07PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > except devices, for now. > > Signed-off-by: Oleg Drokin > --- > .../lustre/lustre/obdclass/linux/linux-module.c| 116 > + I need Documentation/ABI/ files for all of these sysf

Re: [PATCH 3/3] staging/lustre/llite: move some procfs files to sysfs

2015-05-03 Thread Greg Kroah-Hartman
On Sat, May 02, 2015 at 11:10:08PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Move just first few files from /proc/fs/lustre/llite/*/ > to /sys/fs/lustre/llite/*/: > blocksizefilesfree fstype kbytesfree max_read_ahead_mb > client_type filestotal kbytesavail kbytes

Re: [RFC PATCH 0/3] Moving lustre procfs stuff to sysfs & questions.

2015-05-03 Thread Greg Kroah-Hartman
On Sat, May 02, 2015 at 11:10:05PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Greg, I wonder if you can take at least a brief look and tell me if this > is the direction you were envisioning wrt this particular cleanup. > > It's not all-inclusive, but I have a long flight tomorro

Re: [PATCH 0/11] Use kzalloc and kfree

2015-05-03 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 05:51:11PM +0200, Julia Lawall wrote: > Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. The complete > semantic patch that makes these changes is as follows: > (http://coccinelle.lip6.fr/)

Re: [PATCH 0/11] Use kzalloc and kfree

2015-05-03 Thread Julia Lawall
On Sun, 3 May 2015, Greg Kroah-Hartman wrote: > On Fri, May 01, 2015 at 05:51:11PM +0200, Julia Lawall wrote: > > Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > > kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. The complete > > semantic patch that makes thes

Re: [PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

2015-05-03 Thread Greg KH
On Sat, May 02, 2015 at 11:58:21PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Create libcfs_kvzalloc and libcfs_kvzalloc_cpt are > are designed to replace OBD_ALLOC_LARGE and OBD_CPT_ALLOC_LARGE. > > Not a drop-in replacement as they also take gfp flags armument > for more flexib

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-05-03 Thread Greg Kroah-Hartman
On Thu, Apr 16, 2015 at 08:36:51PM +0200, Peter Senna Tschudin wrote: > On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox wrote: > > On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote: > >> On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: > >> > On Thu, Apr 16, 2015 at 3:39 PM, Pete

Re: [PATCH] Staging: dgnc: Using a temporary value for repeated dereferences.

2015-05-03 Thread Greg KH
On Mon, Apr 20, 2015 at 09:33:04AM +0200, Yorick Rommers wrote: > Sorry, it has been changed in the patch below. > > --- > > A patch for a line being too long (>80) in dgnc_mgmt.c, > fixed by making a temporary value for dgnc_Board[brd], > replacing all instanc

Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write()

2015-05-03 Thread Greg KH
On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: > Remove the dead code protected by in_user in dgnc_tty_write() because it is > set > to 0 and never changed to 1 thus the code in ifs never gets executed. Please wrap your commit lines at 72 columns in the future. __

Re: [PATCH] staging: comedi: daqboard2000: Use preferred comment style

2015-05-03 Thread Greg KH
On Sat, May 02, 2015 at 05:00:34PM +0200, Arno Tiemersma wrote: > Use the preferred block comment style for the copyright and driver > description header comments. > > Signed-off-by: Arno Tiemersma > --- > drivers/staging/comedi/drivers/daqboard2000.c | 196 > +- > 1 fil

Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()

2015-05-03 Thread Greg KH
On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote: > rtl8192e driver uses memcpy() to copy hw addresses in several places. > checkpatch.pl suggests to use ether_addr_copy(), but most of > addresses in driver may be unaligned. > This patch replaces all memcpy occurences with single

Re: [PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

2015-05-03 Thread Oleg Drokin
Hello! On May 3, 2015, at 2:31 PM, Greg KH wrote: >> -/* Allocations above this size are considered too big and could not be done >> - * atomically. >> - * >> - * Be very careful when changing this value, especially when decreasing it, >> - * since vmalloc in Linux doesn't perform well on multi-c

Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()

2015-05-03 Thread Mateusz Kulikowski
Hi, On 03.05.2015 21:10, Greg KH wrote: > On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote: >> rtl8192e driver uses memcpy() to copy hw addresses in several places. >> checkpatch.pl suggests to use ether_addr_copy(), but most of >> addresses in driver may be unaligned. >> This pa

Re: [PATCH v3] staging: sm750fb: use arch_phys_wc_add() and ioremap_wc()

2015-05-03 Thread Greg KH
On Tue, Apr 21, 2015 at 01:12:03PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The same area used for ioremap() is used for the MTRR area. > Convert the driver from using the x86 specific MTRR code to > the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() > will av

Re: [PATCH v2 2/2] staging: sm750fb: cleanup indentation

2015-05-03 Thread Greg KH
On Fri, Apr 24, 2015 at 11:10:56AM -0400, Charles Rose wrote: > This patch fixes indentation errors/warnings reported by checkpatch.pl. > > Signed-off-by: Charles Rose > --- > drivers/staging/sm750fb/ddk750_mode.c | 24 > 1 file changed, 16 insertions(+), 8 deletions(-)

Re: [RFC PATCH 0/3] Moving lustre procfs stuff to sysfs & questions.

2015-05-03 Thread Oleg Drokin
On May 3, 2015, at 2:15 PM, Greg Kroah-Hartman wrote: >> Also I found that cgroup does calls into kernfs directly, gaining >> ability to register seq_file files and otherwise do all sorts of >> stuff that would be cool to do from lustre too ;) > If you want to make lustrefs, be my guest, you can

Re: [PATCH] staging/lustre: Always try kmalloc first for OBD_ALLOC_LARGE

2015-05-03 Thread Greg KH
On Sun, May 03, 2015 at 03:14:58PM -0400, Oleg Drokin wrote: > Hello! > > On May 3, 2015, at 2:31 PM, Greg KH wrote: > > >> -/* Allocations above this size are considered too big and could not be > >> done > >> - * atomically. > >> - * > >> - * Be very careful when changing this value, especiall

Re: [PATCH 2/3] staging/lustre: Move /proc/fs/lustre root level files to sysfs

2015-05-03 Thread Oleg Drokin
On May 3, 2015, at 2:13 PM, Greg Kroah-Hartman wrote: >> >> -#if defined (CONFIG_PROC_FS) >> -static int obd_proc_version_seq_show(struct seq_file *m, void *v) >> +static ssize_t version_show(struct kobject *kobj, char *buf) >> { >> -seq_printf(m, "lustre: %s\nkernel: %s\nbuild: %s\n", >> -

Beloved !

2015-05-03 Thread Mrs.Sherr Page
From: Mrs.Sherry Page Address, Israel +97239150789 03/05/2015 Beloved I got your esteem contact out of desperate search for a reliable and trustworthy person. Your efficiency mercy is needed.The holy book emphasizes so much on goodness this offer must be kept secret, because whosoever that is

Re: [PATCH 1/1] drivers: staging: fbtft: fbtft-bus.c: Fix different address space warning on I/O mem

2015-05-03 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 11:40:35PM -0700, Tolga Ceylan wrote: > To fix sparse warning of incorrect type in assignment > (different address space), added annotation __iomem to > vmem8 and modified direct reads with ioread8(). > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/fbtft/fbtft-b

[PATCH v2] staging: comedi: daqboard2000: Use preferred comment style

2015-05-03 Thread Arno Tiemersma
Use the preferred block comment style for the copyright and driver description header comments. Signed-off-by: Arno Tiemersma --- drivers/staging/comedi/drivers/daqboard2000.c | 196 +- 1 file changed, 98 insertions(+), 98 deletions(-) diff --git a/drivers/staging/comedi