Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"pea...@linux-speakup.org,

2015-03-30 Thread Piotr Witosławski
On Mon, Mar 30, 2015 at 11:49:53AM +0530, Sudip Mukherjee wrote: > On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote: > > On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote: > > > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote: > > > > Changed bool to u8 to get r

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-30 Thread Dan Carpenter
On Sat, Mar 28, 2015 at 09:40:05PM +0100, Richard Weinberger wrote: > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > > index 1249f91..c955976 100644 > > --- a/drivers/staging/speakup/main.c > > +++ b/drivers/staging/speakup/main.c > > @@ -423,7 +423,8 @@ static voi

Re: [PATCH net-next 1/2] hv_netvsc: Cleanup the test for freeing skb when we use sendbuf mechanism

2015-03-30 Thread Dan Carpenter
On Sun, Mar 29, 2015 at 09:08:41PM -0700, K. Y. Srinivasan wrote: > In preparation for embedding the rndis state and other packet state into > the skb, cleanup the test for freeing the skb. > So there is no behavior change in applying this patch? regards, dan carpenter _

Re: [PATCH 4/4] staging: octeon-usb: make CVMX_WAIT_FOR_FIELD32 to take condition expression

2015-03-30 Thread Dan Carpenter
On Sat, Mar 28, 2015 at 09:24:34PM +0200, Aaro Koskinen wrote: > Make CVMX_WAIT_FOR_FIELD32 to take full condition expression. > This should make the usage simpler, and the macro more readable. > > Signed-off-by: Aaro Koskinen Hooray! We got a lot of patches "fixing" this a different way. :P r

[PATCH v2 6/6] staging/olpc: drop pci dependencies

2015-03-30 Thread Michael S. Tsirkin
This file does not use any pci APIs, drop pci header includes. Signed-off-by: Michael S. Tsirkin --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index bc7e664..d115f5c 10

RE: [PATCH net-next 1/2] hv_netvsc: Cleanup the test for freeing skb when we use sendbuf mechanism

2015-03-30 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, March 30, 2015 2:03 AM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; j

[PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

2015-03-30 Thread Dhere, Chaitanya (C.)
This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core

RE: [PATCH 7/7] staging: comedi: comedi_fops: extend spin-lock scope in comedi_event()

2015-03-30 Thread Hartley Sweeten
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote: > `comedi_event()` is called from low-level drivers to handle comedi > asynchronous command event flags. As a safety check, it checks the > subdevice's "run" flags to make sure an asynchronous command is running. > It can also change the run fla

RE: [PATCH 0/7] staging: comedi: comedi_fops: some runflag and event handling changes

2015-03-30 Thread Hartley Sweeten
On Friday, March 27, 2015 8:13 AM, Ian Abbott wrote: > Various changes to the core comedi code, mostly to do with spin-lock > usage for the comedi subdevice runflags and event handling. > > 1) staging: comedi: comedi_fops: rename comedi_set_subdevice_runflags() > 2) staging: comedi: comedi_fops: el

RE: [PATCH] staging: comedi: make comedi_internal.h self-reliant

2015-03-30 Thread Hartley Sweeten
On Friday, March 27, 2015 8:58 AM, Ian Abbott wrote, > Add `#include`s and declare incomplete types to "comedi_internal.h" so > that .c files still compile when it is the first file included. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/comedi_internal.h | 10 ++ > 1 file

RE: [PATCH 62/86] staging/comedi: use uapi/linux/pci_ids.h directly

2015-03-30 Thread Hartley Sweeten
On Sunday, March 29, 2015 10:35 AM, Ian Abbott wrote: > On 29/03/15 14:42, Michael S. Tsirkin wrote: >> Header moved from linux/pci_ids.h to uapi/linux/pci_ids.h, >> use the new header directly so we can drop >> the wrapper in include/linux/pci_ids.h. >> >> Signed-off-by: Michael S. Tsirkin >> ---

RE: [PATCH 00/60] staging: comedi: "comedi_fc.h" removal

2015-03-30 Thread Hartley Sweeten
On Friday, March 27, 2015 12:14 PM, Ian Abbott wrote: > This series migrates the `cfc_check_trigger_...()` functions out of > "comedi_fc.h" and into "comedidev.h", and renames them to start with > `comedi_` instead of `cfc_`. Finally, "comedi_fc.h" is removed. > > 01) staging: comedi: comedi_fc.h:

[PATCH V2] Staging: rtl8192 Clean up function definition

2015-03-30 Thread Eddie Kovsky
Change function definition to static, move the function further up in the file, and delete the function prototype. This fixes the following warning generated by sparse: drivers/staging/rtl8192u/r8192U_core.c:1970:6: warning: symbol 'rtl8192_update_ratr_table' was not declared. Should it be static