RE: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, February 4, 2015 1:01 AM > To: KY Srinivasan; de...@linuxdriverproject.org > Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang > Subject: [PATCH 1/4] Drivers: hv: vmbus: imple

Re: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Jason Wang
On Wed, Feb 4, 2015 at 1:00 AM, Vitaly Kuznetsov wrote: free_channel() function frees the channel unconditionally so we need to make sure nobody has any link to it. This is not trivial and there are several examples of races we have: 1) In vmbus_onoffer_rescind() we check for channel exist

Re: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Wednesday, February 4, 2015 1:01 AM >> To: KY Srinivasan; de...@linuxdriverproject.org >> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang >> Subject: [PATCH 1/4

Re: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Vitaly Kuznetsov
Jason Wang writes: > On Wed, Feb 4, 2015 at 1:00 AM, Vitaly Kuznetsov > wrote: >> free_channel() function frees the channel unconditionally so we need >> to make >> sure nobody has any link to it. This is not trivial and there are >> several >> examples of races we have: >> >> 1) In vmbus_onoffe

RE: [PATCH 1/4] Drivers: hv: vmbus: implement get/put usage workflow for vmbus channels

2015-02-04 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, February 4, 2015 17:32 PM > To: Dexuan Cui > Cc: KY Srinivasan; de...@linuxdriverproject.org; Haiyang Zhang; linux- > ker...@vger.kernel.org; Jason Wang > Subject: Re: [PATCH 1/4] Drivers: hv: vmbu

[PATCH 1/2] staging: rtl8188eu: odm: condition with no effect

2015-02-04 Thread Nicholas Mc Guire
needs a check by someone who knows the details of the driver as it could be that the two branches actually should be different. Patch was only compile-tested for x86_64_defconfig + CONFIG_STAGING=y CONFIG_R8188EU=m Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) drivers/staging

[PATCH 2/2] staging: rtl8188eu: odm: conditional setting with no effect

2015-02-04 Thread Nicholas Mc Guire
the comments it seems that an effect is actually intended so this may be a bug. The comment was updated to reflect the changes Patch was only compile-tested for x86_64_defconfig + CONFIG_STAGING=y CONFIG_R8188EU=m Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) drivers/stag

[PATCH] staging: rtl8188eu: core: switch with redundant cases

2015-02-04 Thread Nicholas Mc Guire
-tested for x86_64_defconfig + CONFIG_STAGING=y CONFIG_R8188EU=m Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers

Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases

2015-02-04 Thread Dan Carpenter
On Wed, Feb 04, 2015 at 06:04:38AM -0500, Nicholas Mc Guire wrote: > A few redundant switch cases as well as a redundant if/else > within one of the cases was consolidated to a single call. > The cases are intentionally retained for documentation purposes. This statement is not clear. It obviousl

Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases

2015-02-04 Thread Dan Carpenter
Btw, what tool are you using to find these? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases

2015-02-04 Thread Rasmus Villemoes
On Wed, Feb 04 2015, Nicholas Mc Guire wrote: > A few redundant switch cases as well as a redundant if/else > within one of the cases was consolidated to a single call. > The cases are intentionally retained for documentation purposes. > [...] > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlm

Re: [PATCH] staging: rtl8188eu: core: switch with redundant cases

2015-02-04 Thread Nicholas Mc Guire
On Wed, 04 Feb 2015, Dan Carpenter wrote: > Btw, what tool are you using to find these? > working on a set of coccinell scripts - they are not yet really clean - but this one is simply: virtual context virtual patch virtual org virtual report @assign@ position p; statement S1; @@ <+... * if@p

Re: [PATCH v3 03/20] power_supply: Add API for safe access of power supply function attrs

2015-02-04 Thread Pavel Machek
On Fri 2015-01-30 15:47:41, Krzysztof Kozlowski wrote: > Add simple wrappers for accessing power supply's function attributes: > - get_property -> power_supply_get_property > - set_property -> power_supply_set_property > - property_is_writeable -> power_supply_property_is_writeable > - external

Re: hyper-v: allow access to vmbus from userspace driver

2015-02-04 Thread Thomas Monjalon
Hi Stephen, 2015-02-03 11:03, stephen hemminger: > Brocade is submitting a hyper-v driver for DPDK > but this driver needs a hook in the hyper-v bus layer > to allow the additional hv_uio driver to access the shared vmbus > pages. The hv_uio driver lives in DPDK (like igb_uio) and provides > user

[RFC 08/10] fsl_qman: Add debugfs support

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I59a75a91b289193b5ab1d30a08f60119dc4d7568 Signed-off-by: Geoff Thorpe --- drivers/staging/fsl_qbman/Kconfig|7 + drivers/staging/fsl_qbman/Makefile |2 + drivers/staging/fsl_qbman/qman_debugfs.c | 1326 ++ drivers/s

[RFC 00/10] Freescale DPAA B/QMan drivers

2015-02-04 Thread Emil Medve
Hello, This is the first attempt to publish the Freescale DPAA B/QMan drivers. They are not to be applied yet. At this stage, this is more or less the drivers from the Freescale PowerPC SDK roughly squashed and split in a sequence of component patches. They still needs some work and cleanup bef

[RFC 06/10] fsl_qman: Add self-tester

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I314d36d94717cfc34053b6212899f71cb729d16c Signed-off-by: Geoff Thorpe --- drivers/staging/fsl_qbman/Kconfig | 24 ++ drivers/staging/fsl_qbman/Makefile | 24 +- drivers/staging/fsl_qbman/qman_test.c | 57 +++ drivers/staging/

[RFC 09/10] fsl_bman: Add HOTPLUG_CPU support

2015-02-04 Thread Emil Medve
From: Hai-Ying Wang Change-Id: I863d5c15c7f35f9de4ea3d985e4ff467167924b7 Signed-off-by: Hai-Ying Wang --- drivers/staging/fsl_qbman/bman_driver.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl_qbman/bman_driver.c b/driv

[RFC 10/10] fsl_qman: Add HOTPLUG_CPU support

2015-02-04 Thread Emil Medve
From: Hai-Ying Wang Change-Id: Ica4d1b2b0fd3c3ae5e043663febd9f4cb7c762cf Signed-off-by: Hai-Ying Wang --- drivers/staging/fsl_qbman/qman_driver.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/staging/fsl_qbman/qman_driver.c b/drivers/staging/fsl

[RFC 03/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA BMan

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I59de17c040cdd304f86306336fcf89f130f7db2d Signed-off-by: Geoff Thorpe --- arch/powerpc/Kconfig | 33 +++ arch/powerpc/platforms/85xx/Kconfig | 11 + arch/powerpc/platforms/85xx/corenet_generic.c | 2

[RFC 04/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA QMan

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I59de17c040cdd304f86306336fcf89f130f7db2d Signed-off-by: Geoff Thorpe --- arch/powerpc/platforms/85xx/corenet_generic.c | 8 +++- arch/powerpc/platforms/85xx/p1023_rdb.c | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/arch/po

[RFC 07/10] fsl_bman: Add debugfs support

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I7eea7aea8a58ad0c28451b70801c0d101e88d263 Signed-off-by: Geoff Thorpe --- drivers/staging/fsl_qbman/Kconfig| 7 ++ drivers/staging/fsl_qbman/Makefile | 2 + drivers/staging/fsl_qbman/bman_debugfs.c | 119 +++ drivers/st

[RFC 05/10] fsl_bman: Add self-tester

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: If1b44bb013addc1e855c73a4e6ff74bc8b6e4829 Signed-off-by: Geoff Thorpe --- drivers/staging/fsl_qbman/Kconfig| 26 drivers/staging/fsl_qbman/Makefile | 16 ++- drivers/staging/fsl_qbman/bman_test.c| 56 drivers/staging/f

[RFC 01/10] fsl_bman: Add drivers for the Freescale DPAA BMan

2015-02-04 Thread Emil Medve
From: Geoff Thorpe Change-Id: I075944acf740dbaae861104c17a9ff7247dec1be Signed-off-by: Geoff Thorpe --- drivers/staging/Kconfig |4 +- drivers/staging/Makefile |1 + drivers/staging/fsl_qbman/Kconfig| 52 ++ drivers/staging/fsl_qbman/Makefile

RE: [PATCH RFC] staging: comedi: dt282x: condition with no effect - if identical to else

2015-02-04 Thread Hartley Sweeten
On Tuesday, February 03, 2015 8:13 AM, Ian Abbott wrote: > On 03/02/15 12:38, Nicholas Mc Guire wrote: >> The if and the else branch code are identical - so the condition has no >> effect on the effective code - this patch removes the condition and the >> duplicated code. >> >> Signed-off-by: Nicho

Re: [PATCH RFC] staging: comedi: dt282x: condition with no effect - if identical to else

2015-02-04 Thread Nicholas Mc Guire
On Wed, 04 Feb 2015, Hartley Sweeten wrote: > On Tuesday, February 03, 2015 8:13 AM, Ian Abbott wrote: > > On 03/02/15 12:38, Nicholas Mc Guire wrote: > >> The if and the else branch code are identical - so the condition has no > >> effect on the effective code - this patch removes the condition a

[PATCH v2] staging: comedi: dt282x: condition with no effect - if identical to else

2015-02-04 Thread Nicholas Mc Guire
needed and, as suggested, the misleading comment is completely removed. Patch was only compile tested for x86_64_defconfig + CONFIG_STAGING=y CONFIG_COMEDI=m, COMEDI_ISA_DRIVERS=y, CONFIG_COMEDI_DT282X=m Patch is against 3.19.0-rc7 (localversion = -next-20150204) drivers/staging/comedi/drivers

Re: [PATCH] staging: gdm724x: gdm_tty: Fix for possible null pointer dereference

2015-02-04 Thread Rickard Strandqvist
2015-02-02 17:36 GMT+01:00 Sudip Mukherjee : > On Thu, Jan 29, 2015 at 07:46:10PM +0100, Rickard Strandqvist wrote: >> Fix a possible null pointer dereference, there is >> otherwise a risk of a possible null pointer dereference. >> >> This was found using a static code analysis program called cppch

Re: [PATCH v2] staging: comedi: dt282x: condition with no effect - if identical to else

2015-02-04 Thread Ian Abbott
= -next-20150204) drivers/staging/comedi/drivers/dt282x.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt282x.c b/drivers/staging/comedi/drivers/dt282x.c index 051dfb2..db21d21 100644 --- a/drivers/staging/comedi/drivers/dt282x.c

RE: [PATCH 0/4] Drivers: hv: Further protection for the rescind path

2015-02-04 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, February 3, 2015 9:01 AM > To: KY Srinivasan; de...@linuxdriverproject.org > Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang > Subject: [PATCH 0/4] Drivers: hv: Further prot

Re: [RFC 00/10] Freescale DPAA B/QMan drivers

2015-02-04 Thread Greg KH
On Wed, Feb 04, 2015 at 08:48:32AM -0600, Emil Medve wrote: > > Hello, > > > This is the first attempt to publish the Freescale DPAA B/QMan drivers. They > are > not to be applied yet. At this stage, this is more or less the drivers from > the > Freescale PowerPC SDK roughly squashed and spli

[PATCH 1/1 linux-next] staging: lustre: make obd_updatemax_lock static

2015-02-04 Thread Fabian Frederick
obd_updatemax_lock is only used in class_obd.c Signed-off-by: Fabian Frederick --- drivers/staging/lustre/lustre/obdclass/class_obd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/c

Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

2015-02-04 Thread Rickard Strandqvist
2015-02-02 17:51 GMT+01:00 Sudip Mukherjee : > On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote: >> Fix a possible null pointer dereference, there is >> otherwise a risk of a possible null pointer dereference. >> >> This was found using a static code analysis program called cppch

Caro usuário

2015-02-04 Thread ADMIN
Caro usuário, Esta é para informá-lo que alguém estava tentando entrar sua conta email de um local diferente {IP:37. 187.138.129 {França: 22/01/2015 02:36 GTM} Se você não estiver por favor siga as instruções abaixo para atualizar e Verifique apenas 12 horas de sua conta para fazer isso fim de

Re: [RFC 00/10] Freescale DPAA B/QMan drivers

2015-02-04 Thread Emil Medve
Hello Greg, Thanks for looking at this On 02/04/2015 12:40 PM, Greg KH wrote: > On Wed, Feb 04, 2015 at 08:48:32AM -0600, Emil Medve wrote: >> >> Hello, >> >> >> This is the first attempt to publish the Freescale DPAA B/QMan drivers. They >> are >> not to be applied yet. At this stage, this is

RE: [PATCH net] hyperv: Fix the error processing in netvsc_send()

2015-02-04 Thread Haiyang Zhang
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, February 4, 2015 2:29 AM > > The EAGAIN error doesn't normally happen, because we set the hi water > > mark > > to stop send queue. > > This is not true since only txq was stopped which means only net

[PATCH net-next v2] hyper-v: allow access to vmbus from userspace driver

2015-02-04 Thread Stephen Hemminger
This is enables the hyper-v driver for DPDK . The hv_uio driver needs to access the shared vmbus monitor pages. I would also like to put hv_uio in upstream kernel like other uio drivers, but need to get API accepted with DPDK first. Signed-off-by: Stas Egorov Signed-off-by: Stephen Hemminger -

Re: [RFC 00/10] Freescale DPAA B/QMan drivers

2015-02-04 Thread Greg KH
On Wed, Feb 04, 2015 at 04:16:30PM -0600, Emil Medve wrote: > Hello Greg, > > > Thanks for looking at this > > On 02/04/2015 12:40 PM, Greg KH wrote: > > On Wed, Feb 04, 2015 at 08:48:32AM -0600, Emil Medve wrote: > >> > >> Hello, > >> > >> > >> This is the first attempt to publish the Freescale

[Patch v4 01/23] ACPICA: Resources: Provide common part for struct acpi_resource_address structures.

2015-02-04 Thread Jiang Liu
From: Lv Zheng struct acpi_resource_address and struct acpi_resource_extended_address64 share substracts just at different offsets. To unify the parsing functions, OSPMs like Linux need a new ACPI_ADDRESS64_ATTRIBUTE as their substructs, so they can extract the shared data. This patch also sync

[PATCH] storvsc: assign wait_for_completion_timeout to appropriately typed var

2015-02-04 Thread Nicholas Mc Guire
is needed rather the declaration is simply updated. Patch was only compile tested for x86_64_defconfig + CONFIG_X86_VSMP=y CONFIG_HYPERV=m, SCSI_LOWLEVEL=y, CONFIG_HYPERV_STORAGE=m Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) drivers/scsi/storvsc_drv.c |6 -- 1 file