On 01/23/2015 12:09 AM, Rasmus Villemoes wrote:
The line above makes vel a 12-bit quantity (st->rx[] is u8). The
intention is to sign-extend vel using bit 11 as the sign bit. But
because of C's promotion rules "vel = (vel << 4) >> 4;" is actually a
no-op, since vel is promoted to int before the i
Jake Oshins writes:
> Signed-off-by: Jake Oshins
> ---
> drivers/hv/vmbus_drv.c | 85
> +
> drivers/video/fbdev/hyperv_fb.c | 2 +-
> include/linux/hyperv.h | 2 +-
> 3 files changed, 72 insertions(+), 17 deletions(-)
>
> diff --git a
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Wednesday, January 21, 2015 11:02 AM
>> To: KY Srinivasan; de...@linuxdriverproject.org
>> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui
>> Subject: [PATCH 2/3] Driver
On 22/01/15 17:07, Hartley Sweeten wrote:
On Thursday, January 22, 2015 3:31 AM, Ian Abbott wrote:
On 22/01/15 00:22, H Hartley Sweeten wrote:
A couple cleanup patches for the vmk80xx driver.
H Hartley Sweeten (2):
staging: comedi: vmk80xx: GPCT_RESET is not an (*insn_config) instruction
cppcheck warning:
(warnning) Logical disjunction always evaluates to true
Reported-by: David Binderman
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/d
Remove dath line at the end of file
Signed-off-by: Ahmad Hassan
---
drivers/staging/emxx_udc/emxx_udc.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h
b/drivers/staging/emxx_udc/emxx_udc.h
index d984bd2..7929c65 100644
--- a/drivers/staging/emxx_udc/
On Fri, Jan 23, 2015 at 03:09:08PM +0200, Ahmad Hassan wrote:
> #endif /* _LINUX_EMXX_H */
> +
> +
> +04f287a
> +00e55cb
Uh... What? Try again. :P
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdri
There are two functions call reset() so the allyesconfig breaks. Let's
make this one static.
Reported-by: Jim Davis
Signed-off-by: Dan Carpenter
---
Hi Jim, can you test this patch and see if it fixes the build issue?
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft
This is patch to file ni_labpc_cs.c that fix warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev
---
drivers/staging/comedi/drivers/ni_labpc_cs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drive
Add MAINTAINERS entry for staging/fbtft/
FBTFT is a framework for writing framebuffer drivers
for displays with LCD controllers having onchip RAM.
Signed-off-by: Noralf Trønnes
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2fa3853..0dbe
In these two files jr3_pci.c, jr3_pci.h, 80 character warnings are reduced.
jitendra kumar khasdev (2):
Staging: comedi: fix line over 80 characters warning
Staging: comedi: fix line over 80 characters warning
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
drivers/staging/comedi/drivers/j
This is patch to file jr3_pci.h that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev
---
drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers
This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature
of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
so that 80 character line over warning to be reduced.
Signed-off-by: Jitendra Ku
@ static int init_display(struct fbtft_par *par)
> return 0;
> }
>
> -void reset(struct fbtft_par *par)
> +static void reset(struct fbtft_par *par)
> {
> if (par->gpio.reset == -1)
> return;
> --
Looks good -- make allyesconfig with
The analog input (*do_cmdtest) in this driver currently validates that the
scan_begin_src is TRIG_FOLLOW or, if the board can_burst, TRIG_TIMER or
TRIG_EXT.
The rest of the driver is coded to assume that the scan_begin_src is always
TRIG_FOLLOW.
Simplify the driver by removing the, unused, TRIG_T
This function is only called by das16_cancel(). Absorb it to clarify code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/c
Remove the incomplete cmd->scan_begin_src handling and tidy up the async
command support.
H Hartley Sweeten (5):
staging: comedi: das16: simplify cmd->scan_begin_src validation
staging: comedi: das16: absorb das16_ai_enable()
staging: comedi: das16: remove unnecessary das16_ai_disable()
st
This function is only called by das16_cmd_exec(). Absorb it to clarify code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 26 --
1 file changed, 8 insertions(+), 18 deletions(-)
diff --git a/drivers
The das16_ai_disable() function disables interrupts and the pacer clock. This
function is called by the subdevice (*cancel) operation.
The comedi core will not call a subdevice (*insn_read) operation while an
async command is running due to the s->busy check in parse_insn(). Since all
async comman
The (*do_cmdtest) validates the cmd->convert_src as (TRIG_TIMER | TRIG_EXT |
TRIG_NOW). Only the TRIG_TIMER source validates the cmd->convert_arg using
the i8253_cascade_ns_to_timer() helper. The (*do_cmd) operation should only
program the pacer when the convert_src indicates that the pacer is used
On Fri, Jan 23, 2015 at 11:23:22PM +0530, jitendra kumar khasdev wrote:
> This is patch to file ni_labpc_cs.c that fix warning line
> over 80 character which is found by checkpatch tool.
>
> Signed-off-by: Jitendra Kumar Khasdev
> ---
> drivers/staging/comedi/drivers/ni_labpc_cs.c | 3 ++-
> 1 f
On Sat, Jan 24, 2015 at 12:41:20AM +0530, jitendra kumar khasdev wrote:
> This is patch to file jr3_pci.c that fix up warning line
> over 80 character which is found by checkpatch tool. Made change into
> signature
> of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a
> newli
Fixed 80 line warning in the code comments.
Signed-off-by: Sakshi Bansal
---
drivers/staging/dgnc/dgnc_cls.h | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index 465d79a..7444b00 100644
--- a/driv
Fixed 80 line warning in the code.
Signed-off-by: Sakshi Bansal
---
drivers/staging/dgnc/dgnc_driver.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index ba98ff3
24 matches
Mail list logo
