Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

Didn't Al change these to kvec instead of iovec? You have to look at the callers to figure out if it's actually a user space pointer or a kernel pointer. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxd

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

On Tue 2015-01-06 14:13:37, at...@opensource.altera.com wrote: > From: Alan Tull > > Add documentation under drivers/staging for new fpga manager's > sysfs interface. > > Signed-off-by: Alan Tull > --- > v5 : (actually second version, but keeping version numbers > aligned with rest of pa

[PATCH 1/3] staging: android: fix indentation to match open parenthesis

This patches fixes the following checkpatch.pl warning: ashmem.c:450: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis Signed-off-by: Fabian Holler --- drivers/staging/android/ashmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/st

[PATCH 2/3] staging: android: remove blank lines after open braces

This patch fixes the following checkpatch.pl warnings: ashmem.c:552: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' ashmem.c:801: CHECK:BRACES: Blank lines aren't necessary after an open brace Signed-off-by: Fabian Holler --- drivers/staging/android/ashmem.c

[PATCH 0/3] staging: android: fix checkpatch warnings in ashmem.c

Hello, this patchset fixes the checkpatch.pl warnings in drivers/staging/android/ashmem.c regards Fabian Fabian Holler (3): staging: android: fix indentation to match open parenthesis staging: android: remove unnecessary blank lines after open brace staging: android: remove unnecessary sp

[PATCH 3/3] staging: android: remove space after casts

This patch fixes the following checkpatch.pl warnings: ashmem.c:753: CHECK:SPACING: No space is necessary after a cast ashmem.c:756: CHECK:SPACING: No space is necessary after a cast ashmem.c:777: CHECK:SPACING: No space is necessary after a cast Signed-off-by: Fabian Holle

Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

2015-01-07 10:36 GMT+02:00 Dan Carpenter : > Didn't Al change these to kvec instead of iovec? You have to look at > the callers to figure out if it's actually a user space pointer or a > kernel pointer. I am looking at current linux-next checkout. -- Andrey Utkin ___

Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

On 2015/01/07, 1:36 AM, "Dan Carpenter" wrote: > Didn't Al change these to kvec instead of iovec? You have to look at > the callers to figure out if it's actually a user space pointer or a > kernel pointer. A patch was sent by Al on Dec 2 to replace iovec with kvec, in a thread titled "[PATCH] s

Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

2015-01-07 13:32 GMT+02:00 Dilger, Andreas : > On 2015/01/07, 1:36 AM, "Dan Carpenter" wrote: >> Didn't Al change these to kvec instead of iovec? You have to look at >> the callers to figure out if it's actually a user space pointer or a >> kernel pointer. > > A patch was sent by Al on Dec 2 to r

[PATCH] STAGING: Fix pcl818.c coding style issue

Signed-off-by: Simon Guo Correct coding style problem in pcl818.c --- drivers/staging/comedi/drivers/pcl818.c | 50 - 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818

Re: [PATCH] STAGING: Fix pcl818.c coding style issue

On Wed, Jan 07, 2015 at 10:39:24PM +0800, simon wrote: > Signed-off-by: Simon Guo > > Correct coding style problem in pcl818.c Why reverse the order here of things? And what specific coding style issue(s) were fixed, you have to be specific. please fix up and resend. thanks, greg k-h _

Re: [PATCH] staging: ft1000: Fix code style issue

On Wed, Jan 07, 2015 at 12:57:05PM +0530, Arjun AK wrote: > Remove unnecessary braces from single statement blocks. > > Signed-off-by: Arjun AK Is that the name you use to sign legal documents? If so, great, otherwise, please resend it with the correct name. thanks, greg k-h _

[PATCH] Fixed line over 80 characters warning

Signed-off-by: sakshi --- drivers/staging/vt6655/baseband.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 86c72ba..c138f9b 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt66

Re: [PATCH] Fixed line over 80 characters warning

On Wed, Jan 07, 2015 at 10:37:26PM +0530, sakshi wrote: > Signed-off-by: sakshi Your subject needs to provide a little bit more data, as what part of the kernel you are modifying, and the like. Look at existing patches for examples of this. Also, we need a changelog body, saying what you are do

[PATCH 0/8] staging: comedi: aio_iiro_16: cleaup driver

Tidy up this driver and add async command support for change-of-state detection of the digital inputs. H Hartley Sweeten (8): staging: comedi: aio_iiro_16: fix subdevice 0 'type' staging: comedi: aio_iiro_16: fix subdevice 1 'type' staging: comedi: aio_iiro_16: tidy up subdevice init stagi

[PATCH 4/8] staging: comedi: aio_iiro_16: tidy up multi-line comments

Tidy up the multi-line comments to follow the kernel CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 51 +--- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/drivers/s

[PATCH 3/8] staging: comedi: aio_iiro_16: tidy up subdevice init

For aesthetics, add some white space to the subdevice initialization. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drive

[PATCH 2/8] staging: comedi: aio_iiro_16: fix subdevice 1 'type'

Subdevice 1 is a digial input not a digital I/O subdevice. Fix the type and, for aesthetics, rename the (*insn_bits) function used to read the inputs. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 12 ++-- 1 f

[PATCH 1/8] staging: comedi: aio_iiro_16: fix subdevice 0 'type'

Subdevice 0 is a digial output not a digital I/O subdevice. Fix the type and, for aesthetics, rename the (*insn_bits) function used to set the outputs. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 12 ++-- 1

[PATCH 8/8] staging: comedi: aio_iiro_16: update the MODULE_DESCRIPTION

Update the MODULE_DESCRIPTION to something more useful than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 5/8] staging: comedi: aio_iiro_16: read intial state of the digital outputs

The relay registers are readable. Read them during the attach to get the initial state of the digital outputs. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_iiro_16.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 7/8] staging: comedi: aio_iiro_16: add command support for change of state detection

This board supports interrupts on change of state of the digital inputs. Add the necessary subdevice support and interrupt handler to allow async commands to detect the change of state. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/a

[PATCH 6/8] staging: comedi: aio_iiro_16: introduce aio_iiro_enable_irq()

This board supports interrupts on change of state of the digital inputs. Introduce a helper function to enable/disable the interrupt. Use the new helper function to ensure that interrupts are initially disabled during the driver (*attach). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Gre