[PATCH] staging: gdm724x: fix space coding style issue in gdm_mux.c

2015-01-04 Thread Ning Zhou
This is a patch to fix a space error found by the checkpatch.pl in file gdm_mux.c. Signed-off-by: Ning Zhou --- drivers/staging/gdm724x/gdm_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index b5b06

[PATCH] staging: gdm724x: fix line limit coding style issue in gdm_lte.c

2015-01-04 Thread Ning Zhou
This is a patch to fix "WARNING: line over 80 characters" found by checkpatch.pl in gdm_lte.c. Signed-off-by: Ning Zhou --- drivers/staging/gdm724x/gdm_lte.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-01-04 Thread Jonathan Cameron
On 02/01/15 09:02, Devendra Naga wrote: > This patch adds the error handling for the value returned from > ade7754_spi_read_reg_8. With this patch, the following randconfig > warnings get fixed automatically. > > drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used > uninitialized

[PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-04 Thread Piotr Kubus
This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool. Signed-off-by: Piotr Kubus --- drivers/staging/comedi/drivers/dmm32at.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/driver

Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue

2015-01-04 Thread Konrad Zapalowicz
On 01/04, Piotr Kubus wrote: > This is a patch to the dmm32at.c file that fixes up a code indent error found > by the checkpatch.pl tool. Nice however improve your commit message. The rule is that the lines should wrap at 72nd column except for quoted material such as compiler output, etc... The

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

2015-01-04 Thread Greg KH
On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote: > This is patch to file pcl812.c that fix up warning line > over 80 character which is found by checkpatch tool. > > Signed-off-by: Jitendra Kumar Khasdev > --- > drivers/staging/comedi/drivers/pcl812.c | 3 ++- > 1 file cha

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

2015-01-04 Thread jitendra kumar khasdev
Hello, Will I have to resubmit by combining all 5 into 1 patch? Please give me suggestion  so that I can do it in correct way. Regards, Jitendra Regards, Jitendra Kumar Khasdev, CSE-Student | GGITM jkhas...@gmail.com| Mo.8435260882 On Sun, 4 Jan 2015, Greg KH wrote: > On Sat, Jan 03, 2015 at

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-01-04 Thread sanjeev sharma
On Fri, Jan 2, 2015 at 2:32 PM, Devendra Naga wrote: > This patch adds the error handling for the value returned from > ade7754_spi_read_reg_8. With this patch, the following randconfig > warnings get fixed automatically. > > drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used >

Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning

2015-01-04 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Jan 05, 2015 at 09:34:57AM +0530, jitendra kumar khasdev wrote: > Hello, > Will I have to resubmit by combining all 5 into 1 patch? Please give me > suggestion  so that I can do it in correct

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga wrote: > the function cp_tm1217_mask_interrupt can return failure. > added the check and the failure path. > > Cc: Ramesh Agarwal > Signed-off-by: Devendra Naga > --- > > build tested only on x86_64. config is allmodconfig. > > drivers/staging/cpt

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma wrote: > On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga > wrote: >> the function cp_tm1217_mask_interrupt can return failure. >> added the check and the failure path. >> >> Cc: Ramesh Agarwal >> Signed-off-by: Devendra Naga >> --- >> >> build tes

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-01-04 Thread devendra.aaru
On Sun, Jan 4, 2015 at 6:06 AM, Jonathan Cameron wrote: > On 02/01/15 09:02, Devendra Naga wrote: >> This patch adds the error handling for the value returned from >> ade7754_spi_read_reg_8. With this patch, the following randconfig >> warnings get fixed automatically. >> >> drivers/staging/iio/me

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru wrote: > On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma > wrote: >> On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga >> wrote: >>> the function cp_tm1217_mask_interrupt can return failure. >>> added the check and the failure path. >>> >>> Cc: Ramesh

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:21 AM, sanjeev sharma wrote: > On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru > wrote: >> On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma >> wrote: >>> On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga >>> wrote: the function cp_tm1217_mask_interrupt can return failu

[PATCH v4] Staging: comedi: Fix over 80 character line limit

2015-01-04 Thread jitendra kumar khasdev
This is patch to pcl812.c that fix 80 character line limit which is found by checkpatch.pl tool. I have already sent this patch earlier but it was in 5 different patches, this time I have make it into one patch. Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/drivers/pcl812.c |

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread sanjeev sharma
On Mon, Jan 5, 2015 at 11:52 AM, devendra.aaru wrote: > On Mon, Jan 5, 2015 at 1:21 AM, sanjeev sharma > wrote: >> On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru >> wrote: >>> On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma >>> wrote: On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga w

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
>>> you are addressing the memory leak which is not mentioned in change-log. >> >> i am pasting part of commit log here: >> >> commit log: "added the check and the failure path". >> >> Is this not enough to understand ? > > you should have mentioned that memory is never released in previous > secti

Re: [PATCH v4] Staging: comedi: Fix over 80 character line limit

2015-01-04 Thread Sudip Mukherjee
On Mon, Jan 05, 2015 at 11:56:40AM +0530, jitendra kumar khasdev wrote: > This is patch to pcl812.c that fix 80 character line limit which is found > by checkpatch.pl tool. > I have already sent this patch earlier but it was in 5 different patches, > this time I have make it into one patch. this (