Eddie, all,
On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote:
> Fixes following warning generated by sparse:
>
> drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in
> argument 1 (different address spaces)
> drivers/staging/vt6655/baseband.c:2180:45:expected stru
Sage,
On Sun, Dec 21, 2014 at 02:49:29AM -0500, Sage Vaillancourt wrote:
> Jeremiah,
>
> I will get this patching business eventually. When you say "gratuitous
> spacing" do you refer to this line?
>
> > #define G_Gate_Polarity _bit13
>
> Because it looks fine in the code, but there's a tab tha
On 21/12/14 08:17, Jeremiah Mahler wrote:
Eddie, all,
On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote:
Fixes following warning generated by sparse:
drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument
1 (different address spaces)
drivers/staging/vt6655/b
This is a patch to the gdm_mux.c file that fixes a space before comma
coding style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c
This patch solves the space before , error of the checkpatch.pl
Signed-off-by: Mohammad Jamal
---
drivers/staging/iio/adc/ad7192.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index f6526aa..6f8ce6c 100
This patch solves the space before , coding style issue found by
checkpatch in ade7759.c
Signed-off-by: Mohammad Jamal
---
drivers/staging/iio/meter/ade7759.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b/drivers/staging/iio/meter/a
Removes some functions that are not used anywhere:
rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8723au/hal/rtl8723au_led.c| 23 --
this patch fixes following sparse warnings:
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in
argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25:expected void [noderef]
*
drivers/staging/vt6655/device_main.c:1503:25:got struct vnt_pr
On 21/12/14 13:56, Mike Krinkin wrote:
this patch fixes following sparse warnings:
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in
argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25:expected void [noderef]
*
drivers/staging/vt6655/
Added Andreas as reviewer (thanks!)
v2:
Added a second patch to address Dan Carpenter's concern with the
complexity of passing the sign through `mult'. Compile tested only.
Chris Rorvick (2):
drivers: staging: lustre: Use mult if units not specified
drivers: staging: lustre: Track sign sepa
Units can be passed to lprocfs_write_frac_u64_helper() via a suffix
(e.g., "...K", "...M", etc.) tacked onto the value. A comment states
that "specified units override the multiplier," though the multiplier is
overridden regardless. Update the conditional logic so that it only
applies when units
The `mult' parameter is negated if the user data begins with a '-' so
that the final value has the appropriate sign. But `mult' is only used
if the user data does not include a "units" suffix. In this case,
`mult' is overridden with the numeric scale conveyed by the units suffix,
but retains the
Removes some functions that are not used anywhere:
update_ibss_network() rtllib_SignalStrengthTranslate()
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8192e/rtllib_rx.c | 35 ---
Removes some functions that are not used anywhere:
SROMbAutoLoad() SROMvReadSubSysVenId() SROMvWriteEtherAddress()
SROMvWriteAllContents() SROMbIsRegBitsOff() SROMbIsRegBitsOn()
SROMvRegBitsOff() SROMvRegBitsOn()
This was partially found by using a static code analysis program called
cppcheck.
S
2014-12-18 1:11 GMT+01:00 Greg Kroah-Hartman :
> On Wed, Dec 17, 2014 at 11:05:00PM +0100, Rickard Strandqvist wrote:
>> Removed an unnecessary NULL check. And clarified a switch statement.
>
> That's two different things, please only do one thing in a patch, so
> this would be 2 different patches.
Removed an unnecessary NULL check.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b/drivers/staging/lustre/lustre/obdcla
Tidied up some code in a case statement after a discussion.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletio
Removes same unnecessary NULL check.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
b/drivers/staging/lustre/lustre/llite/ll
The NULL check was done to late, and there it was a risk
of a possible null pointer dereference.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/line6/toneport.c | 15 ---
1 file changed, 8 i
The NULL check was done to late, and there it was a risk
of a possible null pointer dereference.
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/lustre/lustre/include/lustre_update.h |4 +++-
1 file ch
From: Mathieu Poirier
Fixing errors related to the usage of do {} while (0) loop
in single statement macros, trailing semicolon in macros and
trailing whitespace.
Signed-off-by: Mathieu Poirier
---
drivers/staging/skein/skein_block.c | 17 -
drivers/staging/skein/skein_generi
On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote:
> From: Mathieu Poirier
>
> Fixing errors related to the usage of do {} while (0) loop
> in single statement macros, trailing semicolon in macros and
> trailing whitespace.
That's a lot of things all at once, please brea
Mathieu,
On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote:
> From: Mathieu Poirier
>
> Fixing errors related to the usage of do {} while (0) loop
> in single statement macros, trailing semicolon in macros and
> trailing whitespace.
Huh. iirc, I added those do {} while
On Mon, Dec 22, 2014 at 02:17:30AM +0100, Simone Weiss wrote:
>
> Signed-off-by: Simone Weiss
> Signed-off-by: Helene Gsaenger
> ---
> drivers/staging/dgnc/dgnc_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_sysfs.c
> b/drivers/s
On 21 December 2014 at 18:57, Jason Cooper wrote:
> Mathieu,
>
> On Sun, Dec 21, 2014 at 05:09:48PM -0700, mathieu.poir...@linaro.org wrote:
>> From: Mathieu Poirier
>>
>> Fixing errors related to the usage of do {} while (0) loop
>> in single statement macros, trailing semicolon in macros and
>>
On Fri, Dec 19, 2014 at 10:45 AM, wrote:
> From: Alan Tull
>
> New bindings document for Altera fpga manager.
>
> Signed-off-by: Alan Tull
> ---
> v5 : Move bindings to drivers/staging/fpga/Documentation/bindings
>
> v6 : No change in this patch for v6 of the patch set
>
> v7 : No change in thi
On Sun, 2014-12-21 at 23:08 +0100, Rickard Strandqvist wrote:
> Removes same unnecessary NULL check.
Depending on settings, these checks are necessary:
drivers/staging/lustre/lustre/include/obd_support.h:#define POISON(ptr, c, s)
memset(ptr, c, s)
[]
drivers/staging/lustre/lustre/include/obd_sup
On Sun, Dec 21, 2014 at 10:43 PM, Rickard Strandqvist
wrote:
> The NULL check was done to late, and there it was a risk
> of a possible null pointer dereference.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
>
1) The places which called copy_from_user() were returning the number
of bytes not copied instead of -EFAULT.
2) The user could trigger a memory leak if the condition
"(hdr.ioc_len != data->ioc_len)" was true. Instead of adding a new call
to OBD_FREE_LARGE(), I created a free_buf label and chang
29 matches
Mail list logo
