Both struct ieee80211_rts and struct ieee80211_hdr defined in
linux/ieee80211.h are declared as __aligned(2) so it is safe to use
ether_addr_copy() instead of memcpy().
Signed-off-by: Krzysztof Adamski
---
drivers/staging/vt6656/rxtx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
On Tue, 2014-12-16 at 09:30 +0100, Krzysztof Adamski wrote:
> Both struct ieee80211_rts and struct ieee80211_hdr defined in
> linux/ieee80211.h are declared as __aligned(2) so it is safe to use
> ether_addr_copy() instead of memcpy().
Just fyi:
That the structure is declared __aligned(2) is not
t
On Tue, Dec 16, 2014 at 12:42:06AM -0800, Joe Perches wrote:
On Tue, 2014-12-16 at 09:30 +0100, Krzysztof Adamski wrote:
Both struct ieee80211_rts and struct ieee80211_hdr defined in
linux/ieee80211.h are declared as __aligned(2) so it is safe to use
ether_addr_copy() instead of memcpy().
Just
On Tue, Dec 16, 2014 at 12:07:19AM +0100, Rickard Strandqvist wrote:
> Hi Dan
>
> Quite right! Had to try it.
>
> Do nothing then?
> But you must agree that it is still ugly and confusing code.
>
Yes. I agree that it's confusing. I also suspect that "obd" is never
NULL but I haven't actually
On Mon, Dec 15, 2014 at 11:23:25PM +0100, Rickard Strandqvist wrote:
> Hi Joe
>
> No, it does not look like end can be NULL then.
> Then remove the end != NULL instead?
> ...
> if (end != NULL && *end == '.') {
>
Yes. Please do.
regards,
dan carpenter
_
Am 15.12.2014 um 19:56 schrieb Greg KH:
> On Mon, Dec 15, 2014 at 10:41:03AM -0800, Greg KH wrote:
>> On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote:
>>> On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote:
I don't understand this kind of logic.
a) Binder
On Mon, Dec 15, 2014 at 11:41:49PM -0600, Chris Rorvick wrote:
> Units can be passed to lprocfs_write_frac_u64_helper() via a suffix
> (e.g., "...K", "...M", etc.) tacked onto the value. A comment states
> that "specified units override the multiplier," though the multiplier is
> overridden regard
Fixed a coding style error, "foo * bar" should be "foo *bar"
Signed-off-by: Asaf Vertz
---
drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c
b/drivers/staging/rtl8723au/core/r
On 2014/12/16, 2:41 AM, "Dan Carpenter" wrote:
>On Mon, Dec 15, 2014 at 11:41:49PM -0600, Chris Rorvick wrote:
>> Units can be passed to lprocfs_write_frac_u64_helper() via a suffix
>> (e.g., "...K", "...M", etc.) tacked onto the value. A comment states
>> that "specified units override the mult
On Tue, Dec 16, 2014 at 11:14:35AM +, Dilger, Andreas wrote:
>
> Sorry, that isn't right. Chris' patch is actually doing the right thing
> to check for units > 1.
It's not right because it discards the negative.
> The proposed change above discards "mult"
> entirely, which breaks the users
Asaf Vertz writes:
> Fixed a coding style error, "foo * bar" should be "foo *bar"
>
> Signed-off-by: Asaf Vertz
> ---
> drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++--
> 1 files changed, 6 insertions(+), 6 deletions(-)
If you want to fix the 'error' here, include it with a clean
On Tue, Dec 16, 2014 at 5:35 AM, Dan Carpenter wrote:
> On Tue, Dec 16, 2014 at 11:14:35AM +, Dilger, Andreas wrote:
> >
> > Sorry, that isn't right. Chris' patch is actually doing the right thing
> > to check for units > 1.
>
> It's not right because it discards the negative.
I don't think
On Tue, Dec 16, 2014 at 06:53:19AM -0600, Chris Rorvick wrote:
> On Tue, Dec 16, 2014 at 5:35 AM, Dan Carpenter
> wrote:
> > On Tue, Dec 16, 2014 at 11:14:35AM +, Dilger, Andreas wrote:
> > >
> > > Sorry, that isn't right. Chris' patch is actually doing the right thing
> > > to check for uni
Fixed a coding style error, "foo * bar" should be "foo *bar"
Signed-off-by: Asaf Vertz
---
Changes in v2:
- fix ugly multiline arguments to the functions
drivers/staging/rtl8723au/core/rtw_efuse.c | 32 ++-
1 files changed, 7 insertions(+), 25 deletions(-)
diff --gi
Asaf Vertz writes:
> Fixed a coding style error, "foo * bar" should be "foo *bar"
>
> Signed-off-by: Asaf Vertz
> ---
> Changes in v2:
> - fix ugly multiline arguments to the functions
>
> drivers/staging/rtl8723au/core/rtw_efuse.c | 32 ++-
> 1 files changed, 7 inser
Oh wait... You're right. This doesn't change the code how the code
works. My bad.
Still, it's better to just remove the condition instead of making the
condition even more complicated and confusing.
regards,
dan carpenter
___
devel mailing list
de...
This is a patch to r8190_rtl8256.c file that fixes space before , warning found
by checkpatch.pl tool
Signed-off-by: Mohammad Jamal
---
drivers/staging/rtl8192u/r8190_rtl8256.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/driv
The first two patches in this series are a resend; these were submitted
some months ago and as far as I know, there were no outstanding issues.
Win8 and win8 r2 hosts do support SPC-3 features but claim SPC-2 compliance.
This issue is fixed here as well.
K. Y. Srinivasan (4):
Drivers: scsi: sto
Commit 4cd83ecdac20d30725b4f96e5d7814a1e290bc7e changed the limits to
reflect the values on the host. It turns out that WS2008R2 cannot
correctly handle these new limits. Fix this bug by setting the limits
based on the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 15 +
The virtual HBA that storvsc implements can support multiple channels and
targets. So, scan the host when the host notifies that a scan is needed.
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 19 +++
1 files changed, 7 insertions(+), 12 deletions(-)
diff --
On win8 and win8 r2 hosts force SPC-3 compliance for MSFT virtual disks.
Ubuntu has been carrying a similar patch outside the tree for a while now.
Starting with win10, the host will support SPC-3 compliance. Based on all
the testing that has been done on win8 and win8 r2 hosts, we are comfortable
The host asks the guest to scan when a LUN is removed or added.
The only way a guest can identify the removed LUN is when an I/O is
attempted on a removed LUN - the SRB status code indicates that the LUN
is invalid. We currently handle this SRB status and remove the device.
Rather than waiting for
As suggested by Jason on a v0, I made a specific series for that work,
which intend to remove all remaining 'isl' prefix for Intersil to only
have 'isil'. More details below.
When Intersil ISL12057 driver was introduced by commit 70e123373c05
("rtc: Add support for Intersil ISL12057 I2C RTC chip"
"isil" and "isl" prefixes are used at various locations inside the kernel
to reference Intersil corporation. This patch is part of a series fixing
those locations were "isl" is used in compatible strings to use the now
expected "isil" prefix instead (NASDAQ symbol for Intersil and most used
versio
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of Dexuan Cui
> Sent: Wednesday, December 10, 2014 19:33 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; vkuzn...@redhat.com;
Added a second patch to address Dan Carpenter's concern with the
complexity of passing the sign through `mult'. Compile tested only.
Chris Rorvick (2):
drivers: staging: lustre: Use mult if units not specified
drivers: staging: lustre: Track sign separately
drivers/staging/lustre/lustre/obd
The `mult' parameter is negated if the user data begins with a '-' so
that the final value has the appropriate sign. But `mult' is only used
if the user data does not include a "units" suffix. In this case,
`mult' is overridden with the numeric scale conveyed by the units suffix,
but retains the
Units can be passed to lprocfs_write_frac_u64_helper() via a suffix
(e.g., "...K", "...M", etc.) tacked onto the value. A comment states
that "specified units override the multiplier," though the multiplier is
overridden regardless. Update the conditional logic so that it only
applies when units
On 2014/12/16, 9:24 PM, "Chris Rorvick" wrote:
>The `mult' parameter is negated if the user data begins with a '-' so
>that the final value has the appropriate sign. But `mult' is only used
>if the user data does not include a "units" suffix. In this case,
>`mult' is overridden with the numeric
On Tue, Dec 16, 2014 at 10:24:00PM -0600, Chris Rorvick wrote:
> Added a second patch to address Dan Carpenter's concern with the
> complexity of passing the sign through `mult'. Compile tested only.
Thanks. That does look cleaner.
regards,
dan carpenter
__
30 matches
Mail list logo
