[PATCH] Drivers:staging:wlan-ng: Fixed checkpatch warning

2014-11-25 Thread Athira Lekshmi C V
The following checkpatch warning was fixed WARNING: line over 80 characters Signed-off-by: Athira Lekshmi C V --- drivers/staging/wlan-ng/prism2fw.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/pris

Re: [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug

2014-11-25 Thread Mauro Carvalho Chehab
Em Fri, 21 Nov 2014 14:21:40 +0100 Abel Moyo escreveu: > Replaced printk with pr_debug in dprintk > > Signed-off-by: Abel Moyo > --- > drivers/staging/media/lirc/lirc_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/lirc/lirc_serial.c >

[PATCH] Drivers:staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Athira Lekshmi C V
Fixed the checkpatch warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Athira Lekshmi C V --- drivers/staging/vt6656/rxtx.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/v

Re: [PATCH] Drivers:staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Dan Carpenter
On Tue, Nov 25, 2014 at 05:45:40PM +0530, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are > __aligned(2) For these changes the change log must say how you determined both source and destination are aligned c

[PATCH] staging: octeon: Fix checkpatch warning

2014-11-25 Thread Luis de Bethencourt
This patch fixes the checkpatch.pl warnings: WARNING: line over 80 characters + int cores_in_use = core_state.baseline_cores - atomic_read(&core_state.available_cores); WARNING: line over 80 characters + skb->data = skb->head + work->packet_ptr.s.addr

[PATCH] Drivers:Staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Athira Lekshmi C V
Fixed the checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Athira Lekshmi C V --- drivers/staging/vt6656/rxtx.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.

Re: [PATCH] Drivers:Staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Dan Carpenter
On Tue, Nov 25, 2014 at 07:05:51PM +0530, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: else is not generally useful after a break or return > This patch adds a compile warning. > Signed-off-by: Athira Lekshmi C V Btw, signing and from should be your legal name that you

[PATCH 1/1] IMX-DRM-core: Deletion of a check before drm_fbdev_cma_restore_mode()

2014-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Nov 2014 16:06:19 +0100 The drm_fbdev_cma_restore_mode() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfr

[PATCH 1/1] staging: ozwpan: Deletion of unnecessary checks before the function call "oz_free_urb_link"

2014-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Nov 2014 16:51:08 +0100 The oz_free_urb_link() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread icyflame
Changing the following: Adapater -> Adapter STATUS_SUCESS -> STATUS_SUCCESS Signed-off by: Siddharth Kannan --- drivers/staging/bcm/nvm.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c inde

Re: [PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread Greg KH
On Tue, Nov 25, 2014 at 11:00:35PM +0530, icyflame wrote: > Changing the following: > > Adapater -> Adapter > STATUS_SUCESS -> STATUS_SUCCESS > > Signed-off by: Siddharth Kannan > --- > drivers/staging/bcm/nvm.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions

Re: [PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread Dan Carpenter
Your From email header should match your signed-off-by line. The BCM driver was deleted. You should be working against linux-next. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailm

Re: [PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread Dan Carpenter
Don't send private messages. On Tue, Nov 25, 2014 at 06:18:55PM +, Siddharth Kannan wrote: > Due to some network limitations, I was unable to clone the repository using > the ssh URL given on the KernelBuild Linux Newbies page. > > So, I cloned it from the github repo. (Linus Torvalds. torval

[PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread Siddharth Kannan
Changing the following: Adapater -> Adapter STATUS_SUCESS -> STATUS_SUCCESS Signed-off-by: Siddharth Kannan --- drivers/staging/bcm/nvm.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.c inde

Re: [PATCH] staging: bcm: nvm: Fixed spelling errors, that may break grep.

2014-11-25 Thread Dan Carpenter
On Tue, Nov 25, 2014 at 11:58:18PM +0530, Siddharth Kannan wrote: > Changing the following: > > Adapater -> Adapter > STATUS_SUCESS -> STATUS_SUCCESS > The driver you are changing doesn't exist any more. Work against linux-next. regards, dan carpenter _

[PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it breaks the ability to grep for the string. Fixing these. WARNING: quoted string split across lines Signed-off-by: Luis de Bethencour

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Joe Perches
On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: > checkpatch makes an exception to the 80-colum rule for quotes strings, and > Documentation/CodingStyle recommends not splitting quotes strings across lines > because it breaks the ability to grep for the string. Fixing these. [] > diff

[PATCH v2] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
checkpatch makes an exception to the 80-colum rule for quotes strings, and Documentation/CodingStyle recommends not splitting quotes strings across lines because it breaks the ability to grep for the string. Fixing these. WARNING: quoted string split across lines Signed-off-by: Luis de Bethencour

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: > On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: > > checkpatch makes an exception to the 80-colum rule for quotes strings, and > > Documentation/CodingStyle recommends not splitting quotes strings across > > lines > > bec

[PATCH] staging: lustre: fix pointer declarations

2014-11-25 Thread Zahari Doychev
This patch fixes pointer declarations from void * to void __user * in order to remove some sparse warnings. lib-lnet.h:798:48: warning: incorrect type in initializer (different address spaces) lib-lnet.h:798:48:expected void [noderef] *iov_base lib-lnet.h:798:48:got void *dest lib-lnet.h:

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Luis de Bethencourt
On Tue, Nov 25, 2014 at 01:00:07PM -0800, Joe Perches wrote: > On Tue, 2014-11-25 at 20:40 +, Luis de Bethencourt wrote: > > On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: > > > On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: > > > > checkpatch makes an exception to

[PATCH v2] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

2014-11-25 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 25 Nov 2014 22:33:45 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Haiyang Zhang --- driv

Re: [PATCH v2] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

2014-11-25 Thread David Miller
From: SF Markus Elfring Date: Tue, 25 Nov 2014 22:55:34 +0100 > From: Markus Elfring > Date: Tue, 25 Nov 2014 22:33:45 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle sof

Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

2014-11-25 Thread Joe Perches
On Tue, 2014-11-25 at 20:40 +, Luis de Bethencourt wrote: > On Tue, Nov 25, 2014 at 12:27:24PM -0800, Joe Perches wrote: > > On Tue, 2014-11-25 at 20:19 +, Luis de Bethencourt wrote: > > > checkpatch makes an exception to the 80-colum rule for quotes strings, and > > > Documentation/CodingS

Re: [PATCH v2 1/2] drm: imx: Move imx-drm driver out of staging

2014-11-25 Thread Dave Airlie
On 25 November 2014 at 01:33, Philipp Zabel wrote: > The imx-drm driver was put into staging mostly for the following reasons, > all of which have been addressed or superseded: > - convert the irq driver to use linear irq domains > - work out the device tree bindings, this lead to the common of_

Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-25 Thread Fabio Estevam
Hi Andy, On Mon, Nov 17, 2014 at 8:53 AM, Andy Yan wrote: > Andy Yan (11): > staging: imx-drm: imx-hdmi: make checkpatch happy > staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter > staging: imx-drm: imx-hdmi: convert imx-hdmi to drm_bridge mode > staging: imx-drm: imx

Re: [PATCH] staging: lustre: fix pointer declarations

2014-11-25 Thread Joe Perches
On Tue, 2014-11-25 at 21:44 +0100, Zahari Doychev wrote: > This patch fixes pointer declarations from void * to void __user * in order > to remove some sparse warnings. This patch does more than that. Please make sure to describe all of the changes in a patch in the commit message. > diff --git

Re: [PATCH v12 0/11] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2014-11-25 Thread Andy Yan
Hi Fabio: On 2014年11月26日 10:14, Fabio Estevam wrote: Hi Andy, On Mon, Nov 17, 2014 at 8:53 AM, Andy Yan wrote: Andy Yan (11): staging: imx-drm: imx-hdmi: make checkpatch happy staging: imx-drm: imx-hdmi: return defer if can't get ddc i2c adapter staging: imx-drm: imx-hdmi: convert i

[PATCH v2] staging: lustre: fix pointer declarations

2014-11-25 Thread Zahari Doychev
This patch fixes pointer declarations from void * to void __user * in order to remove some sparse warnings. The patch also enables again commented named initializers for the iovec structures. The corrected pointers are used in these structures as field member values. lib-lnet.h:798:48: warning: in