Hi Martyn,
Any update on this from your side?
Cheers!
On Mon, Nov 10, 2014 at 10:22 AM, Maurice Moss wrote:
> Hi Martyn,
>
> Thanks for your reply. I have pasted the code below. It is very much
> similar to your test code from the forum.
>
> Thanks!
>
> #define _XOPEN_SOURCE 500
> #define u32 u
On Mon, Nov 17, 2014 at 04:23:08PM -0800, Juston wrote:
> On Tue, 2014-11-18 at 01:46 +0300, Dan Carpenter wrote:
> > On Mon, Nov 17, 2014 at 02:23:48PM -0800, Juston Li wrote:
> > > FMODE_EXEC is type fmode_t but is used in operations
> > > with integers which leads to sparse warnings:
> > > drive
This patch removes unnecessary blank lines either before opening braces or
after closing braces, as reported by the checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/virthba/vi
This patch fixes the improper CamelCase usage for variables, reported by the
checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 122 +++---
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/unisys/virt
This patch fixes checkpatch checks where the logical operator should be at the
end of the line above, not beginning the next line.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff
This patch changes a couple of kzalloc calls to pass the variable name to the
call, rather than the variable struct type. This is a result of checks
generated during the checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c |4 ++--
1 file changed, 2 inser
This series fixes various issues in the virthba.c file that were reported by
the checkpatch script.
Ken Depro (11):
staging: unisys: virthba: Remove unneeded spaces after casts
staging: unisys: virthba: Fix CamelCase variables
staging: unisys: virthba: Fix open parenthesis alignment checks
This patch fixes the "alignment should match open parenthesis" checks from the
checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 74 +++---
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/unisys/vi
This patch removes all unnecessary spaces after casts, as reported by the
checkpatch script.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 130 +++---
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/unisys/virthba
This patch fixes a couple checkpatch checks where alignment of the parameters
did not match the open parenthesis of the function.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/uni
This patch fixes warnings generated by checkpatch script regarding lines over
80 characters long.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 40 --
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/unisys/vi
This patch fixes checkpatch warnings that resulted from the else portion of
if-else statements missing braces, so that it conforms with the rest of the
statement.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
This patch fixes a warning generated during the checkpatch script that stated
"else not useful after return". I modified the code to return a designated
status at the end of the function, and replaced the return statement in the
"else if" to set the status accordingly.
Signed-off-by: Ken Depro
-
This patch fixes a couple small issues reported by the checkpatch script:
Adds a blank line after a struct definition.
Removes unnecessary parentheses surrounding a struct member.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c |3 ++-
1 file changed, 2 insertions(+
Remove useless function and let the kernel call the actual
init function directly.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 3dd318a
Make keypad_type and lcd_type module params read-only.
This step also starts making it more clear what is
the precedence of device params coming from different
sources (device profile, runtime module param values etc).
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 71
Start decoupling module params from the actual device state,
both for lcd and keypad, by keeping the params read-only
and moving the device state to related structs.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 35 +--
1 file changed, 21 inser
Avoid values comparison and use a macro instead that checks
whether module param has been set by the user to some value
at loading time.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 88 ++-
1 file changed, 45 insertions(+), 43 deletion
This set of patches focuses on making current initialization
process easier to understand - especially it tries to emphasize
what are the priorities of the params coming from different
sources (Kconfig values, device profiles and module param values
set on loading). I paid attention not to change t
Use a macro instead of magic number comparison for checking
whether a module param value has been set.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drive
Move more or less all LCD-related state into struct lcd
in order to get better cohesion; use bool instead of int
where it makes sense.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 255 ++
1 file changed, 134 insertions(+), 121 deletion
Set default parport module param value to DEFAULT_PARPORT so that
a if-block can be avoided.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index
Get rid of magic numbers indicating that the value of a module param
is not set. Use a defined value instead.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/panel/panel.c
Rework lcd_init method to make it a little bit more clear about
the precedence of the params, move LCD geometry and pins layout
to the LCD struct and thus make the LCD-related module params
effectively read-only.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 304 +
On Tue, Nov 18, 2014 at 09:56:06PM +0100, Mariusz Gorski wrote:
> Set default parport module param value to DEFAULT_PARPORT so that
> a if-block can be avoided.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mailing list
de...@lin
On Tue, Nov 18, 2014 at 09:56:08PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers indicating that the value of a module param
> is not set. Use a defined value instead.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mail
On Tue, Nov 18, 2014 at 09:56:07PM +0100, Mariusz Gorski wrote:
> Remove useless function and let the kernel call the actual
> init function directly.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mailing list
de...@linuxdriverpr
On Tue, Nov 18, 2014 at 09:56:09PM +0100, Mariusz Gorski wrote:
> Avoid values comparison and use a macro instead that checks
> whether module param has been set by the user to some value
> at loading time.
>
> Signed-off-by: Mariusz Gorski
> ---
> drivers/staging/panel/panel.c | 88
> +
On Tue, Nov 18, 2014 at 09:56:10PM +0100, Mariusz Gorski wrote:
> Start decoupling module params from the actual device state,
> both for lcd and keypad, by keeping the params read-only
> and moving the device state to related structs.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
_
On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote:
> Make keypad_type and lcd_type module params read-only.
> This step also starts making it more clear what is
> the precedence of device params coming from different
> sources (device profile, runtime module param values etc).
>
> Sig
On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
> Rework lcd_init method to make it a little bit more clear about
> the precedence of the params, move LCD geometry and pins layout
> to the LCD struct and thus make the LCD-related module params
> effectively read-only.
>
> Signed-of
On Tue, Nov 18, 2014 at 09:56:13PM +0100, Mariusz Gorski wrote:
> Use a macro instead of magic number comparison for checking
> whether a module param value has been set.
>
> Signed-off-by: Mariusz Gorski
> ---
> drivers/staging/panel/panel.c | 21 +++--
> 1 file changed, 11 inse
On Tue, Nov 18, 2014 at 09:56:14PM +0100, Mariusz Gorski wrote:
> Move more or less all LCD-related state into struct lcd
> in order to get better cohesion; use bool instead of int
> where it makes sense.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
On Tue, Nov 18, 2014 at 10:20:34PM +0100, Willy Tarreau wrote:
> On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote:
> > Make keypad_type and lcd_type module params read-only.
> > This step also starts making it more clear what is
> > the precedence of device params coming from differen
On Tue, Nov 18, 2014 at 10:18:44PM +0100, Willy Tarreau wrote:
> On Tue, Nov 18, 2014 at 09:56:09PM +0100, Mariusz Gorski wrote:
> > Avoid values comparison and use a macro instead that checks
> > whether module param has been set by the user to some value
> > at loading time.
> >
> > Signed-off-b
On Tue, Nov 18, 2014 at 10:25:23PM +0100, Willy Tarreau wrote:
> On Tue, Nov 18, 2014 at 09:56:13PM +0100, Mariusz Gorski wrote:
> > Use a macro instead of magic number comparison for checking
> > whether a module param value has been set.
> >
> > Signed-off-by: Mariusz Gorski
> > ---
> > driver
On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote:
> On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
> > Rework lcd_init method to make it a little bit more clear about
> > the precedence of the params, move LCD geometry and pins layout
> > to the LCD struct and thus mak
On Tue, Nov 18, 2014 at 10:50:35PM +0100, Mariusz Gorski wrote:
> On Tue, Nov 18, 2014 at 10:20:34PM +0100, Willy Tarreau wrote:
> > On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote:
> > > Make keypad_type and lcd_type module params read-only.
> > > This step also starts making it mor
On Tue, Nov 18, 2014 at 10:51:08PM +0100, Mariusz Gorski wrote:
> On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote:
> > On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
> > > Rework lcd_init method to make it a little bit more clear about
> > > the precedence of the para
FMODE_EXEC is type fmode_t but is used in operations
with integers which leads to sparse warnings:
drivers/staging/lustre/lustre/mdc/mdc_lib.c:198:21: warning: restricted fmode_t
degrades to integer
drivers/staging/lustre/lustre/mdc/mdc_locks.c:300:49: warning: restricted
fmode_t degrades to inte
Caro usuário
Seu e-mail ultrapassou 2 GB criados pelo webmaster, que está atualmente em
execução no 2.30GB, o que não é possível enviar ou receber nova mensagem
dentro das próximas 24 horas, até que você verifique se você enviar e-mail
da conta.
Por favor, informe seus dados abaixo para veri
41 matches
Mail list logo