[PATCH 17/71] staging: unisys: Test_Vnic_channel camel case

From: Jeffrey Changed this channel header to test_vnic_channel in visorchipset_main.c Test_Vnic_channel => test_vnic_channel Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 29/71] staging: unisys: bus_destroy_response camel cases

From: Jeffrey Changed the camel cases for the static void bus_destroy_response busNo => busno Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/v

[PATCH 49/71] staging: unisys: device_changestate_responder camel cases

From: Jeffrey Changed the camel cases in the static void device_changestate_responders cmdId -> cmdid busNo -> busno devNo -> devno responseState -> responsestate Signed-off-by: Jeffrey Brown --- .../staging/unisys/visorchipset/visorchipset_main.c | 20 ++-- 1 file changed, 10

[PATCH 37/71] staging: unisys: platform_device camel case

From: Jeffrey Changed the static platform_device Visorchipset_platform_device to visorchipset_platform_device Visorchipset_platform_device => visorchipset_platform_device Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 16 1 file chan

[PATCH 33/71] staging: unisys: BusDev_Responders camel case

From: Jeffrey Changed the static struct to busdev_responders BusDev_Responders => busdev_responders Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorchi

[PATCH 15/71] staging: unisys: LIST_HEAD info list camel cases

From: Jeffrey Changed the camel cases for LIST_HEAD BusInfoList and DevInfoList BusInfoList => businfolist DevInfoList => devinfolist Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(

[PATCH 22/71] staging: unisys: Putfile_buffer_list_pool_name camel case

From: Jeffrey Changed this static const char to putfile_buffer_list_pool_name Putfile_buffer_list_pool_name => putfile_buffer_list_pool_name Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 67/71] staging: unisys: Unnecessary parentheses

From: Jeffrey Removed the unnecessasry parentheses around req->list on line 1776 Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c

[PATCH 16/71] staging: unisys: Controlvm_channel camel case

From: Jeffrey Changed the camel case for Controlvm_channel to controlvm_channel on line 105 Controlvm_channel => controlvm_channel Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 78 +++--- 1 file changed, 39 insertions(+), 39 deletions(-)

[PATCH 51/71] staging: unisys: bus_epilog camel cases

From: Jeffrey Fixed all camel cases in the static void bus_epilog busNo -> busno msgHdr -> msghdr needResponse -> needresponse pBusInfo -> pbusinfo Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 32 +++--- 1 file changed, 16 insertions(+),

[PATCH 64/71] staging: unisys: setup_crash_devices_work_queue camel cases

From: Jeffrey Fixed the camel cases in the static void setup_crash_devices_work_ queue localCrashCreateBusMsg -> localcrashcreatebusmsg localCrashCreateDevMsg -> localcrashcreatedevmsg localSavedCrashMsgOffset -> localsavedcrashmsgoffset localSavedCrashMsgCount -> localsavedcrashmsgcount Away ->

[PATCH 57/71] staging: unisys: my_device_changestate camel case

From: Jeffrey Changed the camel cases in the static void my_device_changestate busNo -> busno devNo -> devno pDevInfo -> pdevinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 30 +++--- 1 file changed, 15 insertions(+),

[PATCH 63/71] staging: unisys: controlvm_periodic_work camel cases

From: Jeffrey Fixed the camel cases for the static void controlvm_periodic_work gotAcommand -> gotacommand chanInfo -> chaninfo Poll_Count -> poll_count Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 30 +++--- 1 file chan

[PATCH 58/71] staging: unisys: my_device_destroy camel cases

From: Jeffrey Fixed the camel cases in the static void my_device_destroy busNo -> busno devNo -> devno pDevInfo -> pdevinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 26 +++--- 1 file changed, 13 insertions(+), 13 del

[PATCH 28/71] staging: unisys: bus_create_response camel cases

From: Jeffrey Changed the camel cases for the static void bus_create_response busNo => busno Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/vi

[PATCH 61/71] staging: unisys: chipset camel cases

From: Jeffrey Fixed the camel cases for the static voids: chipset_ready, chipset_ selftest, & chipset_notready msgHdr -> msghdr Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) di

[PATCH 71/71] staging: unisys: static const chars visorchipset_main.c

From: Jeffrey Switched chars* arrays to static const char * const in visorchipset _main.c 1020: char *envp[] => static const char * const envp[] 1490: char env_selftest => static const char env_selftext 1491: char envp[] => static const char * const envp[] 1645: char env_cmd => static const char

[PATCH 54/71] staging: unisys: bus_destroy camel cases

From: Jeffrey Changed the camel cases in the static void bus_destroy busNo -> busno pBusInfo -> pbusinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --g

[PATCH 48/71] staging: unisys: bus_responder camel case

From: Jeffrey Changed the camel cases in the static void bus_responder cmdId -> cmdid busNo -> busno Signed-off-by: Jeffrey Brown --- .../staging/unisys/visorchipset/visorchipset_main.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/

[PATCH 59/71] staging: unisys: initialize_controlvm_payload_info camel case

From: Jeffrey Fixed the camel cases in the static int initialize_controlvm_ payload_info Away -> cleanups Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/

[PATCH 68/71] staging: unisys: MESSAGE_ENVELOPE typedef

From: Jeffrey Changed the typedef struct MESSAGE ENVELOPE on line 74 to a normal struct. Also replaced all instances of MESSAGE_ENVELOPE with "MESSAGE_ENVELOPE" Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 40/71] staging: unisys: efisparindication camel cases

From: Jeffrey Changed the camel caes of EfiSparIndication to efisparindication in the static ssize_ts of boottotool_store and boottotool_show EfiSparIndication => efisparindication Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 12 ++-- 1 fil

[PATCH 53/71] staging: unisys: bus_create camel cases

From: Jeffrey Changed the camel cases in the static_void bus_create busNo -> busno pBusInfo -> pbusinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --gi

[PATCH 55/71] staging: unisys: bus_configure camel case

From: Jeffrey Chagned the camel cases in this static void busNo -> busno pBusInfo -> pbusinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 48 +++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/driver

[PATCH 66/71] staging: unisys: testUnicode camel case

From: Jeffrey Fixed the camel cases for the static void testUnicode testUnicode -> testunicode unicodeString -> unicodestring Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/

[PATCH 56/71] staging: unisys: my_device_create camel cases

From: Jeffrey Removed the camel cases in the static void of my_device_create busNo -> busno devNo -> devno pDevInfo -> pdevinfo pBusInfo -> pbusinfo Away -> cleanups Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 86 +++--- 1 file changed,

[PATCH 62/71] staging: unisys: handle_command camel cases

From: Jeffrey Removed the camel cases from the static BOOL handle_command parametersAddr -> parametersaddr parameterBytes -> parametersbytes isLocalAddr -> islocaladdr Signed-off-by: Jeffrey Brown --- .../unisys/visorchipset/visorchipset_main.c| 26 +++--- 1 file change

[PATCH 35/71] staging: unisys: Parahotplug_request_list_lock camel case

From: Jeffrey Changed the camel case to parahotplug_request_list_lock Parahotplug_request_list_lock => parahotplug_request_list_lock Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH 50/71] staging: unisys: device_responder camel cases

From: Jeffrey Changed the camel cases in the static void device_responder cmdId -> cmdid busNo -> busno devNo -> devno Signed-off-by: Jeffrey Brown --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dri

Re: [V2 PATCH 02/10] added media agnostic (MA) USB HCD roothubs

Thank you for your review. My responses are inline. Greg has requested that we clean up the driver internally before we resubmit another patchset to the mailing list. I will make sure the changes you requested make it in, but it may be a while before you see a patchset with the fixes included. Th

Re: [PATCH 05/10] added media specific (MS) TCP drivers

Thank You for reviewing our code. I believe most of the problems you pointed out in mausb_ioctl.c were addressed in [V2 PATCH 5/10]. I am working on adding the proper error checking to the TCP drivers. Greg has requested that we clean up our code internally before submitting another patchset to t

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

From: Haiyang Zhang Date: Tue, 11 Nov 2014 15:27:52 -0800 > - if (mtu < 68 || mtu > limit) > + if (mtu < ETH_DATA_LEN || mtu > limit) > return -EINVAL; This is not correct. The test is against the minimally supported MTU, which should be 68 not ETH_DATA_LEN which is 1500.

Re: [V2 PATCH 02/10] added media agnostic (MA) USB HCD roothubs

On Wed, 12 Nov 2014, Sean O. Stalley wrote: > > > --- /dev/null > > > +++ b/drivers/staging/mausb/drivers/mausb_hub.c > > > > > +/** > > > + * Returns true if the given is the superspeed HCD. Note: The primary > > > HCD is > > > + * High Speed and the shared HCD is SuperSpeed. > > > + */ > > >

Re: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

From: Haiyang Zhang Date: Wed, 12 Nov 2014 20:02:11 + > The Hyper-V host doesn't support MTU below 1500. If we try setting MTU to a > value < 1500, the host will use 1500 automatically and return 1500 in the > RNDIS_OID_GEN_MAXIMUM_FRAME_SIZE query and guest will also use it. That's > why

[PATCH v2 0/2] staging: rtl8188eu: Deletion of a few unnecessary checks

From: Markus Elfring Date: Wed, 12 Nov 2014 20:42:18 +0100 Another update suggestion was taken into account after patches were applied from static source code analysis. Markus Elfring (2): staging: rtl8188eu: Deletion of unnecessary checks before three function calls staging: rtl8188eu:

[PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls

From: Markus Elfring Date: Wed, 12 Nov 2014 20:25:49 +0100 The functions kfree(), rtw_free_netdev() and vfree() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

From: Markus Elfring Date: Wed, 12 Nov 2014 20:40:12 +0100 Memory releases were handled in an inefficient way by the implementation of the efuse_phymap_to_logical() function in case of an allocation failure. The corresponding clean-up was improved by reordering of kfree() calls and a few adjustme

Re: [PATCH 09/10] staging: unisys: parser.c braces

This whole series is fine and this patch is also fine. But I had some unrelated comments about the original code in this function. On Wed, Nov 12, 2014 at 11:28:24AM -0500, Jeffrey Brown wrote: > Inserted a necessary brace for an if statement on line 146 of > parser.c > > Signed-off-by: Jeffrey

[PATCH net-next, v2] hyperv: Add processing of MTU reduced by the host

If the host uses packet encapsulation feature, the MTU may be reduced by the host due to headroom reservation for encapsulation. This patch handles this new MTU value. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/netvsc.c |3 ++- drivers/net/hyperv/netvsc_drv.c |5 +++-- d

Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

On Wed, Nov 12, 2014 at 09:30:43PM +0100, SF Markus Elfring wrote: > From: Markus Elfring Please fix your email client instead. > + goto cleanup1; 1) Don't use GW-BASIC label names. Label names should reflect what the label does such as free_fuse_word or free_fuse_tabel. 2) Don't

Re: [PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls

On Wed, Nov 12, 2014 at 09:25:15PM +0100, SF Markus Elfring wrote: > @@ -487,8 +488,7 @@ static void rtw_usb_if1_deinit(struct adapter *if1) > DBG_88E("+r871xu_dev_remove, hw_init_completed=%d\n", > if1->hw_init_completed); > rtw_free_drv_sw(if1); > - if (pnetdev) > -

Re: [PATCH net-next,v2] hyperv: Add processing of MTU reduced by the host

From: Haiyang Zhang Date: Wed, 12 Nov 2014 14:07:44 -0800 > If the host uses packet encapsulation feature, the MTU may be reduced by the > host due to headroom reservation for encapsulation. This patch handles this > new MTU value. > > Signed-off-by: Haiyang Zhang Applied, thanks for adding th

Re: [PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls

>> @@ -487,8 +488,7 @@ static void rtw_usb_if1_deinit(struct adapter *if1) >> DBG_88E("+r871xu_dev_remove, hw_init_completed=%d\n", >> if1->hw_init_completed); >> rtw_free_drv_sw(if1); >> -if (pnetdev) >> -rtw_free_netdev(pnetdev); >> +rtw_free_netdev(pnet

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

Thanks for reviewing. My responses are inline. Greg has asked that we clean up this code internally before we send out another patchset to the mailing list. I will address the issues you pointed out, but it may be a while before you see another patchset. Thanks Again, Sean On Tue, Nov 11, 2014 a

Re: [PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls

> > This is especially true if you have trained yourself to know that > > free_netdev() can't accept NULL pointers. > > Do you need to adjust your concerns a bit over time when function variants > provide a corresponding safety check in their implementations? There would not seem to be any _need_

Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

>> +goto cleanup1; > > 1) Don't use GW-BASIC label names. Label names should reflect what the > label does such as free_fuse_word or free_fuse_tabel. > > 2) Don't use do-nothing labels. Just return directly. Does the document "CodingStyle" need any extensions for special cases? Are

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

On Wed, 12 Nov 2014, Sean O. Stalley wrote: > On Tue, Nov 11, 2014 at 10:54:30AM -0500, Alan Stern wrote: > > On Mon, 10 Nov 2014, Stephanie Wallick wrote: > > > > > +static struct mausb_hcd mhcd; > > > > Only one statically-allocated structure? What if somebody wants to > > have more than one

RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 3:04 PM > To: Haiyang Zhang > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.o

Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

On Wed, Nov 12, 2014 at 10:50:37PM +0100, SF Markus Elfring wrote: > >> + goto cleanup1; > > > > 1) Don't use GW-BASIC label names. Label names should reflect what the > > label does such as free_fuse_word or free_fuse_tabel. > > > > 2) Don't use do-nothing labels. Just return directly

Re: [PATCH v2 1/2] staging: rtl8188eu: Deletion of unnecessary checks before three function calls

On Wed, Nov 12, 2014 at 10:28:41PM +0100, SF Markus Elfring wrote: > > This is especially true if you have trained yourself to know that > > free_netdev() can't accept NULL pointers. > > Do you need to adjust your concerns a bit over time when function variants > provide a corresponding safety che

RE: [PATCH net-next] hyperv: Add processing of MTU reduced by the host

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, November 12, 2014 2:47 PM > To: Haiyang Zhang > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.o

Re: [V2 PATCH 01/10] added media agnostic (MA) USB HCD driver

Sorry, for got to respond to a couple comments. See responses below. On Wed, Nov 12, 2014 at 01:40:21PM -0800, Sean O. Stalley wrote: > Thanks for reviewing. My responses are inline. > > Greg has asked that we clean up this code internally before we > send out another patchset to the mailing list

[PATCH 0/4] staging: comedi: das6402: add basic AI async command support

This driver was _really_ broken and had to be rewritten. During that rewrite the async command support was stubbed in but not completed. This series adds support for basic AI async commands. H Hartley Sweeten (4): staging: comedi: das6402: add basic (*do_cmdtest) for AI async commands staging

[PATCH 3/4] staging: comedi: das6402: read analog input samples in interrupt handler

Currently the interrupt handler just clears the interrupt. Add the code necessary to read the analog input samples when running an async command. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das6402.c | 42 ++

[PATCH 1/4] staging: comedi: das6402: add basic (*do_cmdtest) for AI async commands

Currently the async command support in this driver consists of just the stubbed in functions. Flesh out the (*do_cmdtest) function for basic support of timed analog input acquisitions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/da

[PATCH 4/4] staging: comedi: das6402: add (*do_cmd) for AI async commands

Flesh out the (*do_cmd) function to support timed analog input acquisitions. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das6402.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/stag

[PATCH 2/4] staging: comedi: das6402: introduce das6402_ai_set_mode()

Introduce a helper function to set the analog input acquisition mode. This will be needed when the (*do_cmd) function is completed to support async commands. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das6402.c | 31 +++

Why does ion_cma_allocate need GFP_HIGHUSER | __GFP_ZERO flags?

Hi, I'm wondering why dma_alloc_coherent needs GFP_HIGHUSER | __GFP_ZERO flags in ion_cma_allocate(). I think dma_alloc_coherent can go to __dma_alloc if the system has CMA area. If __GFP_WAIT flag is set, it allocates memory from atomic pool. So I think calling dma_alloc_coherent with __GFP_WAI

<    1   2