before these NULL checks we are already checking it for NULL, and if
it is NULL then we are jumping to the error label and handling
the error before returning.
So we can reach this part of the code only if the variable is known
to be not NULL, and if we already know that it is not NULL, then no
nee
a variable is declared and initialized and then never updated in the
function.This default value is then used as the return from the
function.
So removed that unneeded return variable and returning that default
initial value directly.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rtl8188eu/
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and can only access by w
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width, 4K support, clk useage, and the crtc mux configuration
is also platform specific.
To reuse the imx h
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
CHECK: Alignment should match open parenthesis
+ if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
+ (hdmi->vic == 12) || (hdmi->vic == 13) ||
CHECK: braces {} should be used on all arms of this statement
+ if (hdmi->hdmi_data.video_mode.mdvi)
[...]
+ else {
[...]
Sign
drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdm
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width access (writeb,
readb) generates an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 49 +---
1 file changed, 46 insertions(+),
From: Yakir Yang
dw-hdmi is under drm/bridge, so it should be the bridge mode.
hange off the encoder to dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++---
Hi Boris,
Thank you for the update.
On Thu, Nov 06, 2014 at 10:56:59AM +0100, Boris Brezillon wrote:
> Rename mediabus formats and move the enum into a separate header file so
> that it can be used by DRM/KMS subsystem without any reference to the V4L2
> subsystem.
>
> Old v4l2_mbus_pixelcode no
Am Freitag, den 07.11.2014, 19:35 +0800 schrieb Andy Yan:
> On rockchip rk3288, only word(32-bit) accesses are
> permitted for hdmi registers. Byte width access (writeb,
> readb) generates an imprecise external abort.
>
> Signed-off-by: Andy Yan
> ---
> drivers/gpu/drm/bridge/dw_hdmi.c | 49
>
Em Fri, 07 Nov 2014 13:43:59 +0200
Sakari Ailus escreveu:
>> +enum media_bus_format {
>
> There's no really a need to keep the definitions inside the enum. It looks a
> little bit confusing to me. That made me realise something I missed
> yesterday.
>
> There's a difference: the enum in C++
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Thursday, November 06, 2014 9:11 PM
To: Sharma, Sanjeev
Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com;
de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re:
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Thursday, November 06, 2014 9:13 PM
To: Sharma, Sanjeev
Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com;
de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re:
the NULL check for memregion is not required as it has already been
checked for NULL after kzalloc. so we can reach this part of the code
only if memregion is not NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorutil/memregion_direct.c | 6 ++
1 file changed, 2 insertions
we can reach the label Away in total five situation and in four of
of them pDevInfo is NULL. so we were basically dereferencing a NULL
pointer.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Fri, 7 Nov 2014 13:43:59 +0200
Sakari Ailus wrote:
> Hi Boris,
>
> Thank you for the update.
>
> On Thu, Nov 06, 2014 at 10:56:59AM +0100, Boris Brezillon wrote:
> > Rename mediabus formats and move the enum into a separate header file so
> > that it can be used by DRM/KMS subsystem without
On 11/07/14 12:43, Sakari Ailus wrote:
> Hi Boris,
>
> Thank you for the update.
>
> On Thu, Nov 06, 2014 at 10:56:59AM +0100, Boris Brezillon wrote:
>> Rename mediabus formats and move the enum into a separate header file so
>> that it can be used by DRM/KMS subsystem without any reference to th
Hello,
This patch series prepares the use of media bus formats outside of
the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
driver where I have to configure my DPI/RGB bus according to the
connected display).
The series first defines MEDIA_BUS_FMT_ macros, and then replace all
Define MEDIA_BUS_FMT macros (re-using the values defined in the
v4l2_mbus_pixelcode enum) into a separate header file so that they can be
used from the DRM/KMS subsystem without any reference to the V4L2
subsystem.
Then set V4L2_MBUS_FMT definitions to the MEDIA_BUS_FMT values using the
V4L2_MBUS_
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed them with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Update the v4l documentation accordingly.
Signed-off-by: Boris Brezillon
---
Documentation/Doc
Replace references to the v4l2_mbus_pixelcode enum with the new
media_bus_format enum in all common headers.
Signed-off-by: Boris Brezillon
Acked-by: Sakari Ailus
---
include/media/v4l2-mediabus.h| 2 +-
include/media/v4l2-subdev.h | 2 +-
include/uapi/linux/v4l2-subdev.h | 6 +++---
3
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
users don't have access to these definitions.
We have to keep this definition for user-space users even though they're
encouraged to move to the new media_bus_format enum.
Signed-off-by: Boris Brezillon
---
include/uapi/li
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in pci drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all usb drivers.
Signed-off-by: Boris Brezillon
---
driver
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all media drivers residing in staging.
Signed-off-by: Boris Brezi
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in the ipu-v3 driver.
Signed-off-by: Boris Brezillon
---
driv
In order to have subsytem agnostic media bus format definitions we've
moved media bus definitions to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Replace all references to the old definitions in i2c drivers.
Signed-off-by: Boris Brezillon
In order to have subsytem agnostic media bus format definitions we've
moved media bus definition to include/uapi/linux/media-bus-format.h and
prefixed values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
Reference new definitions in all platform drivers.
Signed-off-by: Boris Brezillon
---
Docume
Nitpicks:
On 11/07/14 15:07, Boris Brezillon wrote:
> Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
> users don't have access to these definitions.
>
> We have to keep this definition for user-space users even though they're
> encouraged to move to the new media_bus_for
On 11/07/14 15:07, Boris Brezillon wrote:
> Hello,
>
> This patch series prepares the use of media bus formats outside of
> the V4L2 subsytem (my final goal is to use it in the Atmel HLCDC DRM
> driver where I have to configure my DPI/RGB bus according to the
> connected display).
>
> The series
Am Freitag, den 07.11.2014, 15:07 +0100 schrieb Boris Brezillon:
> In order to have subsytem agnostic media bus format definitions we've
> moved media bus definition to include/uapi/linux/media-bus-format.h and
> prefixed enum values with MEDIA_BUS_FMT instead of V4L2_MBUS_FMT.
>
> Reference new d
Hi Boris,
On Fri, Nov 07, 2014 at 03:07:40PM +0100, Boris Brezillon wrote:
> Define MEDIA_BUS_FMT macros (re-using the values defined in the
> v4l2_mbus_pixelcode enum) into a separate header file so that they can be
> used from the DRM/KMS subsystem without any reference to the V4L2
> subsystem.
On Fri, 07 Nov 2014 15:47:41 +0100
Hans Verkuil wrote:
> Nitpicks:
>
> On 11/07/14 15:07, Boris Brezillon wrote:
> > Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
> > users don't have access to these definitions.
> >
> > We have to keep this definition for user-space
"Sharma, Sanjeev" writes:
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, November 06, 2014 9:13 PM
> To: Sharma, Sanjeev
> Cc: larry.fin...@lwfinger.net; jes.soren...@redhat.com;
> de...@driverdev.osuosl.org; linux-wirel...@vger.kernel.org;
> li
Hi Sakari,
On Fri, 7 Nov 2014 17:24:16 +0200
Sakari Ailus wrote:
> Hi Boris,
>
> On Fri, Nov 07, 2014 at 03:07:40PM +0100, Boris Brezillon wrote:
> > Define MEDIA_BUS_FMT macros (re-using the values defined in the
> > v4l2_mbus_pixelcode enum) into a separate header file so that they can be
> >
On Fri, Nov 07, 2014 at 12:36:23AM +0100, Konrad Zapalowicz wrote:
> On 11/06, Greg KH wrote:
> > On Fri, Nov 07, 2014 at 12:05:34AM +0100, Konrad Zapalowicz wrote:
> > > This commit removes the staging/dgnc driver in favor of the serial/jsm
> > > driver.
> > >
> > > This is because the serial/jsm
Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
users don't have access to these definitions.
We have to keep this definition for user-space users even though they're
encouraged to move to the new media_bus_format enum.
Signed-off-by: Boris Brezillon
---
include/uapi/li
Define MEDIA_BUS_FMT macros (re-using the values defined in the
v4l2_mbus_pixelcode enum) into a separate header file so that they can be
used from the DRM/KMS subsystem without any reference to the V4L2
subsystem.
Then set V4L2_MBUS_FMT definitions to the MEDIA_BUS_FMT values using the
V4L2_MBUS_
This patch series addresses the following issues:
- Wrong error reporting for multiple filesystems case.
- Skip all readonly-mounted filesystems instead of skipping iso9660.
- Thaw all filesystems after an unsuccessful freeze attempt.
Vitaly Kuznetsov (3):
Tools: hv: vssdaemon: consult with errn
Instead of making a list of exceptions for readonly filesystems
in addition to iso9660 we already have it is better to skip freeze
operation for all readonly-mounted filesystems.
Signed-off-by: Vitaly Kuznetsov
---
tools/hv/hv_vss_daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
If one or more filesystems failed to freeze we need to thaw everything as
host doing backup won't issue THAW request after we return HV_E_FAIL and our
system will remain with frozen filesystems for ever.
There is no track of filesystems we freeze so in case there is some external
tool doing freeze
If ioctl() return 0 there is no point in examining errno and
it can actually produce misleading output. In case there was
no failure errno will contain the error code for previous failure
so user will see the following in the log:
Hyper-V VSS: VSS: freeze of /mnt/udf: Operation not supported
Hype
Signed-off-by: Ken Depro
---
drivers/staging/unisys/channels/Makefile |2 +-
drivers/staging/unisys/channels/chanstub.c | 75
drivers/staging/unisys/channels/chanstub.h | 23 -
drivers/staging/unisys/uislib/uislib.c |1 -
drivers/staging/uni
While fixing the CamelCase checks for the functions in the chanstub
source and header files, I discovered they are no longer being used.
This patch removes the two chanstub files, and deletes the #include
of these files from uislib.c and uisqueue.c. It also removes the
chanstub.o from the cha
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote:
>
> Signed-off-by: Ken Depro
Your Subject: is a bit long...
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Subject: [PATCH] staging: unisys: Remove chanstub files While fixing the
> CamelCase checks for the functions
in the chanstub source and header files, I discovered they are no longer being
used. This patch removes the
two chanstub files, and deletes the #include ...
[...]
> --
> 1.7.9.5
Res
On Fri, Nov 07, 2014 at 12:51:34PM -0500, Ken Depro wrote:
>>
>> Signed-off-by: Ken Depro
> Your Subject: is a bit long...
Sorry about that. I noticed it after it was posted. I resubmitted the patch
after fixing up the
Subject/comment merge.
Ken
On Fri, Nov 07, 2014 at 12:58:24PM -0500, Ken Depro wrote:
> While fixing the CamelCase checks for the functions in the chanstub
> source and header files, I discovered they are no longer being used.
> This patch removes the two chanstub files, and deletes the #include
> of these files from uis
On Tue, Oct 21, 2014 at 04:46:58PM +0200, Matej Mužila wrote:
> From: Matej Mužila
>
> Check if cpmsg->size is in limits of DATA_FRAGMENT
>
> Signed-off-by: Matej Mužila
> ---
>
> If corrupted data are read from /dev/vmbus/hv_fcopy, pwrite can
> read from memory outside of the buffer (defined
This patch removes all of the unnecessary spaces after casts within
the virthba.c file. The checkpatch script was run again after these
changes, and no "remove spaces after casts" checks were generated.
Signed-off-by: Ken Depro
---
drivers/staging/unisys/virthba/virthba.c | 130 +++
Octeon Ethernet driver is currently trying to wake up multiple
CPU cores for parallel NAPI processing when needed, to cope
with the fact that all network interfaces are handled through
the same receive queue processed by a single core/interrupt
(see http://marc.info/?l=linux-kernel&m=13720978491456
Move helper functions to make them visible to all functions.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/o
Eliminate cvmx_dprintf() usage and use dev_err() instead.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/octeon-hcd.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
i
On 11/07/2014 12:44 PM, Aaro Koskinen wrote:
Octeon Ethernet driver is currently trying to wake up multiple
CPU cores for parallel NAPI processing when needed, to cope
with the fact that all network interfaces are handled through
the same receive queue processed by a single core/interrupt
(see ht
Hi Philipp,
Thanks for the patch and sorry for a late reply. I did look at your
patches earlier too, but maybe not attentively enough, or maybe I'm
misunderstanding something now. In the scan_of_host() function in
soc_camera.c as of current -next I see:
epn = of_graph_get_next_
Hi,
On Fri, Nov 07, 2014 at 01:17:23PM -0800, David Daney wrote:
> On 11/07/2014 12:44 PM, Aaro Koskinen wrote:
> >Octeon Ethernet driver is currently trying to wake up multiple
> >CPU cores for parallel NAPI processing when needed, to cope
> >with the fact that all network interfaces are handled
Hi Boris,
Boris Brezillon wrote:
> @@ -102,6 +113,7 @@ enum v4l2_mbus_pixelcode {
>
> V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV_1X32),
> };
> +#endif /* __KERNEL__ */
>
> /**
> * struct v4l2_mbus_framefmt - frame format on the media bus
Was it intended to be this way, or did I miss some
On 11/07/2014 02:32 PM, Aaro Koskinen wrote:
Hi,
On Fri, Nov 07, 2014 at 01:17:23PM -0800, David Daney wrote:
On 11/07/2014 12:44 PM, Aaro Koskinen wrote:
Octeon Ethernet driver is currently trying to wake up multiple
CPU cores for parallel NAPI processing when needed, to cope
with the fact th
Hi Manohar/Dan,
Any idea regarding this?
Cheers,
Maurice
On Mon, Nov 3, 2014 at 5:25 PM, Maurice Moss wrote:
> Hi Martyn,
>
> Thanks for your help from previous emails. I managed to talk to my
> board using a VME-USB board. Now I am back to working with an SBC, and
> I have a different setup t
On Sat, 08 Nov 2014 00:47:25 +0200
Sakari Ailus wrote:
> Hi Boris,
>
> Boris Brezillon wrote:
> > @@ -102,6 +113,7 @@ enum v4l2_mbus_pixelcode {
> >
> > V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV_1X32),
> > };
> > +#endif /* __KERNEL__ */
> >
> > /**
> > * struct v4l2_mbus_framefmt - fram
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Saturday, November 8, 2014 1:09 AM
> To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Dexuan Cui
> Subject: [PATCH 0/3] Tools: hv: vssdaem
On 2014年11月07日 19:45, Lucas Stach wrote:
Am Freitag, den 07.11.2014, 19:35 +0800 schrieb Andy Yan:
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width access (writeb,
readb) generates an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/g
We found freescale imx6 and rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly difference, such as phy pll configuration, register width(imx hdmi
register is one byte, but rk3288 is 4 bytes width and can only access by w
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width, 4K support, clk useage, and the crtc mux configuration
is also platform specific.
To reuse the imx h
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile
CHECK: Alignment should match open parenthesis
+ if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
+ (hdmi->vic == 12) || (hdmi->vic == 13) ||
CHECK: braces {} should be used on all arms of this statement
+ if (hdmi->hdmi_data.video_mode.mdvi)
[...]
+ else {
[...]
Sign
drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdm
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Signed-off-by: Andy Yan
---
drivers/gpu/drm/bridge/dw_hdmi.c | 57 ++--
1 file changed, 55 insertions(+)
From: Yakir Yang
dw-hdmi is under drm/bridge, so it should be the bridge mode.
hange off the encoder to dw_hdmi-imx.c, keep the connector &
birdge in dw_hdmi.c
Signed-off-by: Andy Yan
Signed-off-by: Yakir Yang
---
drivers/gpu/drm/bridge/dw_hdmi.c | 217 ++
Signed-off-by: Andy Yan
---
.../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt
b/Docum
This patch remove unnecessary semicolons from macro.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/lmv/lmv_internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_internal.h
b/drivers/staging/lustre/lustre/lmv/lmv
This patch remove unnecessary parentheses.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
index 1a58212..32
73 matches
Mail list logo
