Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread DaeSeok Youn
Hi, 2014-10-13 12:25 GMT+09:00 Greg KH : > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: >> Re-arrange the functions for removing forward declarations. >> >> Signed-off-by: Daeseok Youn >> --- >> This patch has too many changes for re-arranging the functions. >> So I wonder that I

[PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-13 Thread Jia He
This fixes space related ERROR reports by checkpatch.pl Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING Already checked by text comparasion $git diff -w and binary comparasion of r8188eu.ko $objdiff diff

Re: [PATCH] staging: comedi: drivers: comedi_bond.c: Changed from using strncat to strlcat

2014-10-13 Thread Ian Abbott
On 12/10/14 13:23, Rickard Strandqvist wrote: Changed from using strncat to strlcat to simplify the code Signed-off-by: Rickard Strandqvist --- drivers/staging/comedi/drivers/comedi_bond.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/dri

Re: [PATCH 1/3] staging: comedi: usbduxsigma: updated contact details and status

2014-10-13 Thread Ian Abbott
On 10/10/14 20:32, Bernd Porr wrote: I've updated my contact details of the driver. I've also tested it thoroughly and it works perfectly. I've changed the status to stable. Signed-off-by: Bernd Porr --- drivers/staging/comedi/drivers/usbduxsigma.c | 8 1 file changed, 4 insertions(

Re: [PATCH 2/3] staging: comedi: usbdux: updated contact details / comments

2014-10-13 Thread Ian Abbott
On 10/10/14 20:34, Bernd Porr wrote: I've updated my contact details and removed obsolete comments. Signed-off-by: Bernd Porr --- drivers/staging/comedi/drivers/usbdux.c | 59 - 1 file changed, 28 insertions(+), 31 deletions(-) Reviewed-by: Ian Abbott -- -

Re: [PATCH 3/3] staging: comedi: usbduxfast: updated address details

2014-10-13 Thread Ian Abbott
On 10/10/14 20:35, Bernd Porr wrote: Updated the range of years, e-mail and added driver desription as usually done in comedi. Signed-off-by: Bernd Porr --- drivers/staging/comedi/drivers/usbduxfast.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Ian Abbott

Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 16:47 +0800, Jia He wrote: > This fixes space related ERROR reports by checkpatch.pl > Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ > xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING checkpatch isn't perfect. Always verify the o

[PATCH 2/3] staging: comedi: cb_pcimdas: update driver comment

2014-10-13 Thread Ian Abbott
The Comedi driver comment mentions a couple of manual configuration options, but manual configuration via the COMEDI_DEVCONFIG ioctl and comedi "attach" handler is no longer supported by this driver. Update the comment appropriately. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/

[PATCH 0/3] staging: comedi: cb_pcimdas: support PCIe-DAS1602/16

2014-10-13 Thread Ian Abbott
Fix up the block comment style and add support for the PCIe-DAS1602/16. This is the PCI-Express version of the PCIM-DAS1602/16 and is software compatible with it, apart from a different PCI device ID. 1) staging: comedi: cb_pcimdas: use preferred block comment style 2) staging: comedi: cb_pcimdas:

[PATCH 1/3] staging: comedi: cb_pcimdas: use preferred block comment style

2014-10-13 Thread Ian Abbott
Use the preferred block comment style for the copyright and Comedi driver description header comments. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcimdas.c | 71 +++-- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/drivers/staging/com

[PATCH 3/3] staging: comedi: cb_pcimdas: add support for PCIe-DAS1602/16

2014-10-13 Thread Ian Abbott
The Measurement Computing PCIe-DAS1602/16 is a PCI-Express version of the PCIM-DAS1602/16, but has a different PCI device ID. Add support for this device and update the driver description, Kconfig description and MODULE_DESCRIPTION. Thanks to Christoph Langbein for supplying the PCI device ID. S

Re: [PATCH] staging: lustre: lustre: ptlrpc: sec.c: Replacing strncat with strlcat to avoid overwrite size

2014-10-13 Thread Chen Gang
On 10/12/14 23:55, Rickard Strandqvist wrote: > Changed from using strncat with strlcat to avoid overwrite the max size. > Take the opportunity to change a snprint to strlcpy. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/lustre/lustre/ptlrpc/sec.c |5 ++--- > 1 file changed

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Joe Perches
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: > Hi, > > 2014-10-13 12:25 GMT+09:00 Greg KH : > > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: > >> Re-arrange the functions for removing forward declarations. > >> > >> Signed-off-by: Daeseok Youn > >> --- > >> This patch h

[PATCH 2/2] staging: comedi: comedidev.h: clarify async->event error/cancel detection

2014-10-13 Thread H Hartley Sweeten
Introduce COMEDI_CB_ERROR_MASK and COMEDI_CB_CANCEL_MASK to clarify the async->events that indicate errors and cancel an async command. Use the new defines to tidy up and clarify the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi

[PATCH 1/2] staging: comedi: comedidev.h: don't expose COMEDI_CB_* defines to userspace

2014-10-13 Thread H Hartley Sweeten
The COMEDI_CB_* defines are the comedi_async "events" that the drivers set to let the core detect the state of running async commands. These "events" are only relevant to the kernel modules and should not be exposed to userspace in the comedi.h user API header. Move the defines to comedidev.h to a

[PATCH] staging: dgnc: Fix a possible crash when the class_create fails

2014-10-13 Thread devendranaga4
From: Devendra Naga The class_create function can return a pointer with an error code stuffed inside it if it fails. Handled it to make sure device_register doesn't get an invalid pointer. Also removed assignment of rc to 0 in the beginning of function because it gets changed after the call to r

[PATCH 0/2] staging: comedi: tidy up the async event defines

2014-10-13 Thread H Hartley Sweeten
The async event defines, COMEDI_CB_*, are only used in the kernel. They should not be exposed to userspace in the comedi.h uapi header. Move the defines to the comedidev.h kernel header and tidy up the documentation. Also, introduce some mask defines to clarify the events that indicate error condi

Re: [PATCH] staging: comedi: drivers: comedi_bond.c: Changed from using strncat to strlcat

2014-10-13 Thread Rickard Strandqvist
2014-10-13 11:14 GMT+02:00 Ian Abbott : > On 12/10/14 13:23, Rickard Strandqvist wrote: >> >> Changed from using strncat to strlcat to simplify the code >> >> Signed-off-by: Rickard Strandqvist >> >> --- >> drivers/staging/comedi/drivers/comedi_bond.c |6 ++ >> 1 file changed, 2 inserti

Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c

2014-10-13 Thread Erich Cordoba
The idea was to reduce the length of the line (to 80 characters) by renaming this function. But, now reviewing the result I can see that the name of the function has lost meaning. Please ignore this patch. -Erich 12.10.2014, 21:28, "Greg KH" : > On Sun, Oct 12, 2014 at 09:29:32PM -0500, Eric

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread DaeSeok Youn
Hi, 2014-10-13 23:56 GMT+09:00 Joe Perches : > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: >> Hi, >> >> 2014-10-13 12:25 GMT+09:00 Greg KH : >> > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: >> >> Re-arrange the functions for removing forward declarations. >> >> >> >> S

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Greg KH
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: > > Hi, > > > > 2014-10-13 12:25 GMT+09:00 Greg KH : > > > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: > > >> Re-arrange the functions for removing forward declar

Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

2014-10-13 Thread Joe Perches
On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote: > On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote: > > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote: > > > 2014-10-13 12:25 GMT+09:00 Greg KH : > > > > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote: > > > >> Re-ar

[PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-13 Thread Jia He
This fixes space related ERROR reports by checkpatch.pl Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING Already checked by text comparasion $git diff -w and binary comparasion of r8188eu.ko $objdiff diff

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-13 Thread Hirokazu TAKATA
From: Guenter Roeck > arch/m32r/kernel/process.c | 8 Acked-by: Hirokazu Takata Thank you. -- takata ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-13 Thread Jia He
Sorry,seems git ate my one line words after mail subject: >From v1: suggested by j...@perches.com, fixed some points not checked or not correctly checked by checkpatch.pl On Tue, 14 Oct 2014 11:28:32 +0800 from hejia...@gmail.com wrote: > This fixes space related ERROR reports by checkpatch.pl >