>
> Perhaps a more common style is to use:
>
> if (!padapter->halpriv.hal_bus_init ||
> padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> return _FAIL;
>
>
Agreed. I will send updated patch.
Regards,
Nitin
___
deve
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur
---
drivers/staging/rtl8712/hal_init.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 81cd
On Thu, Oct 02, 2014 at 01:12:35AM +0300, Giedrius Statkevicius wrote:
> diff --git a/drivers/staging/rts5208/rtsx_chip.c
> b/drivers/staging/rts5208/rtsx_chip.c
> index 1411471..d604341 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -291,7 +291
On Wed, Oct 01, 2014 at 07:35:51PM -0700, Amber Thrall wrote:
> Fixed various coding sytles.
>
Fix one type of thing at a time.
> Signed-off-by: Amber Thrall
> ---
> drivers/staging/media/lirc/lirc_bt829.c | 2 +-
> drivers/staging/media/lirc/lirc_imon.c | 4 +-
> drivers/staging/media/li
On Thu, Oct 02, 2014 at 09:44:06AM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
>
> Signed-off-by: Nitin Kuppelur
> ---
> drivers/staging/rtl8712/hal_init.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/d
Fix 10 occurences of coding style errors where the line exceeds 80 characters
by breaking them into more lines.
Checkpatch.pl reports these errors as: 'WARNING: line over 80 characters'
Also, removes unnecessary returns in two void functions by removing the return
statements.
Checkpatch.pl report
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur
---
drivers/staging/rtl8712/hal_init.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 81cd
On Thu, 2014-10-02 at 14:13 +0300, Giedrius Statkevicius wrote:
> Fix 10 occurences of coding style errors where the line exceeds 80 characters
> by breaking them into more lines.
> Checkpatch.pl reports these errors as: 'WARNING: line over 80 characters'
> Also, removes unnecessary returns in two
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur
---
drivers/staging/rtl8712/hal_init.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c
b/drivers/staging/rtl8712/hal_init.c
index 81cd
On Wed, Oct 01, 2014 at 09:40:02PM -0700, Amber Thrall wrote:
> Fixed various coding style issues, including strings over 80 characters long
> and many
> deprecated printk's have been replaced with proper methods.
Only do one thing per patch, you are doing lots of different things
here, and as D
Em Wed, 01 Oct 2014 21:40:02 -0700
Amber Thrall escreveu:
> Fixed various coding style issues, including strings over 80 characters long
> and many
> deprecated printk's have been replaced with proper methods.
>
> Signed-off-by: Amber Thrall
> ---
> drivers/staging/media/lirc/lirc_bt829.c |
Commit 64f6ebe63914 ("MIPS: Netlogic: rename nlm_cop2_save/restore")
replaced nlm_cop2_enable with nlm_cop2_enable_irqsave and
nlm_cop2_restore with nlm_cop2_disable_irqrestore but it did not
update the xlr_net driver to use the new macros resulting into build
problems like this:
drivers/staging/n
COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
with allmodconfig under um):
CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o
drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implic
UNISYS_UISLIB, UNISYS_VISORCHIPSET, and UNISYS_VISORUTIL need HAS_IOMEM,
so depend on it. One of related error (with allmodconfig under um):
CC [M] drivers/staging/unisys/uislib/uislib.o
In file included from drivers/staging/unisys/uislib/uislib.c:34:0:
drivers/staging/unisys/include/uisu
On 2014.10.02 14:45, Joe Perches wrote:
> On Thu, 2014-10-02 at 14:13 +0300, Giedrius Statkevicius wrote:
>> Fix 10 occurences of coding style errors where the line exceeds 80
>> characters by breaking them into more lines.
>> Checkpatch.pl reports these errors as: 'WARNING: line over 80 character
Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard
provides an AXI interface to dynamically reconfigure the clocking
resources of Xilinx FPGAs.
Signed-off-by: Soren Brinkmann
---
v3:
- allow building the driver as module
- make speed grade positive
- document valid values
On Tue, Sep 30, 2014 at 12:07:48PM -0400, Benjamin Romer wrote:
> Just cleaning up the extra blank line from here.
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/timskmod.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/include/timskmod.
On Tue, Sep 30, 2014 at 12:07:49PM -0400, Benjamin Romer wrote:
> Adds in some missing spaces in the max macro in timskmod.h.
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/timskmod.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/stag
On Tue, Sep 30, 2014 at 12:07:56PM -0400, Benjamin Romer wrote:
> Remove all unnecesary blank lines after braces in uisqueue.h.
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisqueue.h | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --gi
On Tue, Sep 30, 2014 at 12:08:01PM -0400, Benjamin Romer wrote:
> Clean up CamelCase name:
> NetworkPolicy => network_policy
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisqueue.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/stagi
On Tue, Sep 30, 2014 at 12:08:03PM -0400, Benjamin Romer wrote:
> Fix CamelCase names:
> busNo => bus_no
> devNo => dev_no
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisqueue.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/sta
On Tue, Sep 30, 2014 at 12:08:05PM -0400, Benjamin Romer wrote:
> Clean up CamelCase names:
> busNo => bus_no
> devNo => dev_no
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisqueue.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/driver
On Tue, Sep 30, 2014 at 12:08:04PM -0400, Benjamin Romer wrote:
> Fix CamelCase names:
> busNo => bus_no
> devNo => dev_no
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisqueue.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/sta
On Tue, Sep 30, 2014 at 12:08:45PM -0400, Benjamin Romer wrote:
> Fix CamelCase names:
> Issue_VMCALL_MEASUREMENT_DO_NOTHING =>
> issue_vmcall_measurement_do_nothing
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisutils.h | 2 +-
> 1 file changed, 1 insertion(+)
On Tue, Sep 30, 2014 at 12:08:48PM -0400, Benjamin Romer wrote:
> Fix Camelcase name:
> Issue_VMCALL_FATAL_BYE_BYE => issue_vmcall_fatal
>
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/include/uisutils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/d
On Tue, Sep 30, 2014 at 12:07:44PM -0400, Benjamin Romer wrote:
> This patch series addresses the checkpatch.pl warnings and checks generated
> with the --strict option, in the include directory for the Unisys drivers.
>
> Most of the issues are fixed, except for CamelCase members of structs not
On Thu, Oct 02, 2014 at 11:55:44AM -0500, Romer, Benjamin M wrote:
> On Thu, 2014-10-02 at 09:41 -0700, Greg KH wrote:
> > > -
> > > /* @} */
> >
> > What is that odd comment?
>
> I think it's part of a doxygen block that starts above the #defines:
>
> /**
> * @addtogroup driverlogging
> *
On Thu, 2014-10-02 at 09:41 -0700, Greg KH wrote:
> > -
> > /* @} */
>
> What is that odd comment?
I think it's part of a doxygen block that starts above the #defines:
/**
* @addtogroup driverlogging
* @{
*/
To make sure, I'll ask the original author when I get the chance.
-- Ben
___
On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> with allmodconfig under um):
>
> CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o
> drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’:
>
On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote:
> Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall
> escreveu:
> > Fixed various coding style issues, including strings over 80 characters
> > long and many
> > deprecated printk's have been replaced with proper methods.
[]
> > diff
On Thu, 2014-10-02 at 17:01 +, Hartley Sweeten wrote:
> On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote:
> > COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error (
> > with allmodconfig under um):
> >
> > CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o
> > driv
Replaced memcpy with ether_addr_copy
Signed-off-by: Abel Moyo
---
drivers/staging/slicoss/slicoss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss/slicoss.c
index 56ca3b6..f48eeb1 100644
--- a/drivers/staging/slico
On Thu, Oct 02, 2014 at 07:36:34PM +0200, Abel Moyo wrote:
> Replaced memcpy with ether_addr_copy
>
The changelog has for ether_addr_copy() changes has to say how you
verified that this was safe. Resend with a fixed changelog.
regards,
dan carpenter
On Thursday, October 02, 2014 10:26 AM, Rostislav Lisovy wrote:
>
> Since "egrep -irn "ioremap" drivers/staging/comedi/drivers | wc -l"
> shows "39" does it mean that this should be added to all the other
> drivers as well?
The others are actually pci_ioremap_bar() and those drivers depend on PCI
On Thu, 2014-10-02 at 18:25 +0300, Giedrius Statkevicius wrote:
> On 2014.10.02 14:45, Joe Perches wrote:
> > On Thu, 2014-10-02 at 14:13 +0300, Giedrius Statkevicius wrote:
> >> Fix 10 occurences of coding style errors where the line exceeds 80
> >> characters by breaking them into more lines.
>
Hi Aaro,
Thank you for reviewing my patch!
On 10/01/2014 11:42 PM, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Oct 01, 2014 at 10:33:48PM +0200, Michael Opdenacker wrote:
>> Remove the use of the IRQF_DISABLED flag
>> from drivers/staging/nokia_h4p/nokia_core.c
>>
>> It's a NOOP since 2.6.35 and it wi
On 10/02/2014 07:45 PM, Joe Perches wrote:
On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote:
Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall
escreveu:
Fixed various coding style issues, including strings over 80 characters long
and many
deprecated printk's have been replaced
On Fri, 2014-10-03 at 02:58 +0300, Antti Palosaari wrote:
> On 10/02/2014 07:45 PM, Joe Perches wrote:
> > On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote:
> >> Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall
> >> escreveu:
> >>> Fixed various coding style issues, including strings
lirc_imon.c and lirc_sasem.c contain an incoming_packet method that
is using deprecated printk's. Removed blocks replacing with single
dev_info with a %*ph format instead.
Signed-off-by: Amber Thrall
---
drivers/staging/media/lirc/lirc_imon.c | 10 ++
drivers/staging/media/lirc/lirc_sa
39 matches
Mail list logo
