On 2014-09-22 at 23:28:03 +0200, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
>
> There are no known issues at this time.
>
> Signed-off-by: Mark Einon
> ---
>
> This patch will only apply once the last few pendin
On Tue, Sep 23, Thomas Shao wrote:
> In current hyper-v time sync service,it only gets the initial clock time
> from the host. It didn't process the following time samples. This change
> introduced a module parameter called host_time_sync. If it is set to true,
> the guest will periodically sychro
On Tue, Sep 23, 2014 at 12:48 PM, 朱辉 wrote:
>
>
> On 09/23/14 12:18, Greg KH wrote:
>> On Tue, Sep 23, 2014 at 10:57:09AM +0800, Hui Zhu wrote:
>>> The cause of this issue is when free memroy size is low and a lot of task is
>>> trying to shrink the memory, the task that is killed by lowmemkiller
On 22 September 2014 12:09, Roger Tseng wrote:
> On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote:
>> [...]
>>
>> >>
>> >> In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE.
>> >>
>> >> >
>> >> > if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at
>> >> > start,
>>
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
> > +/* et131x_rx_dma_memory_alloc
> > + *
> > + * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required,
> > + * and the Packet Status Ring.
> > +
On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote:
> On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
> >
> > There are no known issues at this time.
>
> This doesn't appl
On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote:
> > +config NET_VENDOR_AGERE
> > + bool "Agere devices"
> > + default y
> > + depends on PCI
> > + ---help---
> > + If you have a network (Ethernet) card belonging to this class, say =
> > Y
> > + and read the Ethernet-HO
On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote:
> On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
>
> Hi Tobias,
>
> Thanks for the details review. I've replied below -
>
> [...]
> > > +/* et131x_rx_dma_memory_alloc
> > > + *
> > > + * Allocates Free buffer ring 1 for sure, f
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Tuesday, September 23, 2014 3:56 PM
> To: Thomas Shao
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> driverdev-devel@linuxdriverproject.org; a...@canonical.com;
> jasow...@redhat.com; KY Srinivasan;
On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote:
> On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote:
> > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
> >
> > Hi Tobias,
> >
> > Thanks for the details review. I've replied below -
> >
> > [...]
> > > > +/* et131
On 09/23/14 16:00, Weijie Yang wrote:
> On Tue, Sep 23, 2014 at 12:48 PM, 朱辉 wrote:
>>
>>
>> On 09/23/14 12:18, Greg KH wrote:
>>> On Tue, Sep 23, 2014 at 10:57:09AM +0800, Hui Zhu wrote:
The cause of this issue is when free memroy size is low and a lot of task
is
trying to shrink
On Tuesday, September 23, 2014 2:36 AM, abbo...@mev.co.uk wrote:
>
> I will when I get a chance. Having some technical difficulties as
> our office burnt down at the weekend!
Ouch… Sorry to hear that.
Take your time. If it doesn’t make it before Greg closes his tree I will
make sure to either re-
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of KY Srinivasan
> Sent: Monday, September 15, 2014 11:39 AM
> To: Sitsofe Wheeler
> Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com;
> linux-ker...@vger.kernel.org;
Mark Einon :
[...]
> > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > directly, its members will be NULL and thus never called. Also, you can
> > make et131x_pm_ops const.
>
> Ok, I can change this.
>
> Btw, this appears to be a fairly standard way of using .driver.pm
On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
> Mark Einon :
> [...]
> > > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > > directly, its members will be NULL and thus never called. Also, you can
> > > make et131x_pm_ops const.
> >
> > Ok, I can change this
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6539a8a..10f20b3 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et13
If et131x_rx_dma_memory_alloc() allocates rx_ring->fbr[0] but fails to
allocate rx_ring->fbr[1], this leaves fbr[0]->ring_virtaddr with the
possibility of being accessed in et131x_rx_dma_memory_free() as it
contains a random value, potentially causing an oops.
Fix this by zeroing the fbr memory on
The Power Management functions can be conditional by assigning pm ops
directly to .driver.pm, instead of using #ifdef's, saving some lines of
code.
Reported-by: Tobias Klauser
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions
Casting a void* popinter to a struct pointer is unnecessary, don't do
it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 2889f86..6539a8a 100
On 23/09/2014 12:20 p.m., Ulf Hansson wrote:
On 22 September 2014 12:09, Roger Tseng wrote:
On Thu, 2014-09-18 at 23:14 +0200, Ulf Hansson wrote:
[...]
In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE.
if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start,
set
http://marc.info/?l=linux-driver-devel&m=141150128909523&w=2
-v2 patch formatted with '-M' git-format-patch flag
** Patch applies and tested on linux-next tag next-20140923, on top of the 8
patches at http://marc.info/?l=linux-driver-devel&m=141141591110262&w=2 and
Joe Perches :
> On Tue, 2014-09-23 at 21:02 +0200, Francois Romieu wrote:
[...]
> > How about kernel tinification ?
>
> The tiny case where a large number of ethernet drivers are included?
No.
A couple of bytes here and there vs a cosmetic kernel wide change.
--
Ueimor
___
On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
checkpatch type modification you might consider:
Reduce logging line count by consolidating repeated dev_warn
Use ether_addr_copy
Line w
Fixed a coding style issue.
Signed-off-by: Elshad Mustafayev
---
drivers/staging/android/binder.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index c69c40d..71424bf 100644
--- a/drivers/staging/andro
24 matches
Mail list logo
