From: Mark Einon
> Replace a long list of contiguous writel() calls with a for loop iterating
> over the same address values.
>
> Also remove redundant comments on the macstat registers, the variable names
> are good enough.
...
> - writel(0, &macstat->txrx_0_64_byte_frames);
...
> - write
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
> On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote:
>
> > do {
> > pci_read_config_dword(pdev,
> > - LBCIF_DATA_REGISTER, &val);
> > +
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction?
Hi Stephen, thanks for the review.
It'
On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> > - bool done = true;
> > + int count = 0;
> > + int limit = budget;
> > + bool not_done = false;
>
> Don't use negative variables. Better to keep the original
On Thu, Aug 21, 2014 at 08:40:20AM +, David Laight wrote:
> From: Mark Einon
> > Replace a long list of contiguous writel() calls with a for loop iterating
> > over the same address values.
> >
> > Also remove redundant comments on the macstat registers, the variable names
> > are good enough.
This implements NAPI support for et131x by:
-adding a napi_struct to the private adapter struct
-changing netfif_rx_skb() call to netif_receive_skb()
-changing et131x_handle_recv_interrupt() to et131x_handle_recv_pkts()
and taking a budget allocation.
-changing et131x_handle_send_interrupt() to e
Hi Mark,
On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote:
>
> Hi Fabio, thanks for the review.
>
> It's a space alignment of parameters to go with the previous change, to
> keep wrapping consistent in the file:
>
> - while (i2c_wack) {
> + while (1) {
> if (pci_writ
Adding Greg into CC list.
Sanjeev Sharma
-Original Message-
From: Sanjeev Sharma [mailto:sanjeev_sha...@mentor.com]
Sent: Wednesday, August 20, 2014 3:03 PM
To: ji...@kernel.org; kgene@samsung.com
Cc: linux-ker...@vger.kernel.org; linux-...@vger.kernel.org;
de...@driverdev.osuosl.or
Thanks greg TODO was very confusing.
@Lars: These drivers are looks stable enough to move out of staging tree and
Can we move to outside staging tree as per your 1st Comment.
Regards
Sanjeev Sharma
-Original Message-
From: gregkh [mailto:gre...@linuxfoundation.org]
Sent: Wednesday, Aug
This patch fixes the checkpatch.pl issue
Error: Required space after " '+' ',' '=' '(' ' if' "
Signed-off-by: Hema Prathaban
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
drivers/staging/lustre/lustre/ptlrpc/import
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote:
> Hi Mark,
>
> On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote:
>
> >
> > Hi Fabio, thanks for the review.
> >
> > It's a space alignment of parameters to go with the previous change, to
> > keep wrapping consistent in the file:
>
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon
---
Modified to remove function parameter indenting changes, which are
largely unrelated.
drivers/staging/et131x/et131x.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dr
Caro usuário
Seu e-mail ultrapassou 2 GB criadas pelo webmaster, você está executando
em 2.30GB, o que não é possível enviar ou receber nova mensagem no
próximo 24 horas até que você verificar e-mails conta.
Por favor, informe seus dados abaixo para verificar a sua conta:
(1) E-mail:
(2) Nome
Good day and God bless you.
I feel quite safe and satisfy dealing with you in this charity project.My name
is MRS PATRICIA WAGNER , a merchant in Dubai, in the U.A.E. I have been
diagnosed with Esophageal cancer . It has defiled all forms of medical
treatment, and right now I have only about a
From: Haiyang Zhang
Date: Tue, 19 Aug 2014 20:53:55 +
> @@ -200,12 +202,18 @@ static bool netvsc_set_hash(u32 *hash, struct sk_buff
> *skb)
> iphdr = ip_hdr(skb);
>
> if (iphdr->version == 4) {
> - if (iphdr->protocol == IPPROTO_TCP)
> + data = (u8 *)&ip
15 matches
Mail list logo
