Re: [PATCH] staging: xillybus: fix some coding style errors

On Wed, Jul 16, 2014 at 03:19:42PM +0200, Vincent Bernat wrote: > This includes: > - keep "else" on the same line as the closing brace > - don't use "else" after "return" > - don't issue a message for an out-of-memory error > - blank line after a declaration > > Signed-off-by: Vincent Bernat

Re: Fix the Signature 答复: [PATCH] drivers: android: fix watermark when cma enabled

On Fri, Aug 08, 2014 at 09:39:21AM +, Zengtao (B) wrote: > From: Zeng Tao > > Date: Tue, 5 Aug 2014 17:58:10 +0800 > Subject: [PATCH] drivers: android: fix watermark when cma enabled > > when cma is enabled, the watermark caculation will > include the cma pages, while it can't use cma pages.

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

On Sat, Aug 09, 2014 at 01:55:19AM +0200, Martin Berglund wrote: > On Fri, Aug 08, 2014 at 06:47:25AM -0700, Greg Kroah-Hartman wrote: > > On Fri, Aug 08, 2014 at 09:07:55AM +0200, Martin Berglund wrote: > > > On Thu, Aug 07, 2014 at 07:18:13PM -0700, Greg Kroah-Hartman wrote: > > > > On Thu, Aug 0

Re: [PATCH 07/13] staging: comedi: amplc_dio200: tidy up comedi_driver declaration

On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote: > For aesthetics, add some whitespace to the declaration. > > Signed-off-by: H Hartley Sweeten > Reviewed-by: Ian Abbott > --- > drivers/staging/comedi/drivers/amplc_dio200.c | 14 +++--- > 1 file changed, 7 insertions(+

Re: [PATCH] staging: dgnc: remove some unused code

On Sat, Aug 02, 2014 at 08:06:38PM +0900, Seunghun Lee wrote: > Remove some unused code. > > CC: Lidza Louina > CC: Mark Hounschell > Signed-off-by: Seunghun Lee > --- > drivers/staging/dgnc/dgnc_cls.c| 72 +- > drivers/staging/dgnc/dgnc_driver.c | 39 +- > drivers/staging/

Re: [PATCH] staging: lustre: use NULL instead of 0 for non-integers

On Sun, Aug 03, 2014 at 10:45:36PM +0200, Martin Kepplinger wrote: > This fixes sparse errors where 0 is used for non-integers. > > Signed-off-by: Martin Kepplinger > --- > applies to -next20140802 Someone else already did this same change, sorry :( greg k-h

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: > Fixes following checkpatch warning: > > WARNING: space prohibited between function name and open parenthesis '(' > > Signed-off-by: Srikrishan Malik Can you redo this whole series, based on the comments you have recieved? than

Re: [PATCH] staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

On Tue, Aug 05, 2014 at 09:03:48PM +0100, Miguel Oliveira wrote: > Fix sparse warning: > drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol > 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? > by making it static since it's only used once. > > Signed-off-by:

Re: [PATCH 01/17] Staging: bcm: Bcmchar.c: Fixed indentation of function arguments

On Tue, Aug 05, 2014 at 02:23:24PM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/Bcmchar.c | 56 > --- > 1 file changed, 31 insertions(+), 25 deletions(-) I'm confused, I have 2 series here from you, and I don't

Re: [PATCH] staging: rtl8192u: checkpatch: do not use C99 // comments

On Sun, Aug 03, 2014 at 09:28:20PM +0200, Martin Kepplinger wrote: > Use the common kernel coding style, so don't use C99 // comments. > If too long, where reasonable, they are shortened as well. > > Some old internal comments about date and author of changes are > removed. > > This provides a mo

Re: [PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

On Sun, Aug 03, 2014 at 05:20:58PM -0700, Hans Wennborg wrote: > Signed-off-by: Hans Wennborg > --- > drivers/staging/rtl8192ee/pci.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) This patch fails to apply to my tree :( ___ devel maili

Re: [PATCH] drivers: staging: lustre: fix sparse warnings / delete unused function

On Fri, Aug 08, 2014 at 06:26:22PM +0200, Benedict Boerger wrote: > drivers: staging: lustre: fix sparse warning: symbol XYZ was > not declared. Should it be static? > > This was done by declaring them static. This could be done because the > functions > were used only in this file. > > Deleted

Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.

On Fri, Aug 08, 2014 at 12:05:38PM +0300, Dan Carpenter wrote: > On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote: > > This patch clear some code that was not doing any help. > > Pointed out by Larry.Finger > > > > The patch is fine but the changelog doesn't inpsire confidence. It

Re: [PATCH 00/15] staging: comedi: 8255: tidy up the (*io) operations

On Mon, Aug 04, 2014 at 02:18:43PM +0100, Ian Abbott wrote: > On 2014-08-01 22:18, H Hartley Sweeten wrote: > >Now that the comedi_device has a 'mmio' and a 'iobase' member, this module > >can detect if the (*io) operations need to use readb/writeb for memory mapped > >I/O or inb/outb for port I/O.

Re: [PATCH 02/10] staging: ozwpan: Fix typo in typedef

On Mon, Aug 04, 2014 at 02:54:48PM +0200, Christoph Jaeger wrote: > Signed-off-by: Christoph Jaeger > --- > drivers/staging/ozwpan/ozproto.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ozwpan/ozproto.h > b/drivers/staging/ozwpan/ozproto.h > index

Re: [PATCH] drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse

On Sat, Aug 09, 2014 at 12:05:24AM -0700, Ovidiu Toader wrote: > This minor patch motivated by eudyptula challenge fixes the following > warnings issued > by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c: > .../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. > Should it b

Re: [PATCH 1/3] Staging: Netlogic: Fix compilation error

On Tue, Aug 05, 2014 at 07:44:23PM +0530, ganes...@broadcom.com wrote: > From: Ganesan Ramalingam > > Cop2 save and restore function names are changed, added that change I can't understand this sentance, what does it mean? What compilation error? Where is it broken, in Linus's tree now? Somewh

Re: [PATCH] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote: > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed > before it is initialised, by: > > - letting et131x_mii_write() take a phydev address, instead of using the one > stored in adapter by default. This is so e

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: > This patch fixes the checkpatch.pl 'Missing a blank line after declarations' > warning in speakup_soft.c. > > Signed-off-by: Artemiy Volkov > --- > drivers/staging/speakup/speakup_soft.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH] staging: xillybus: fix some coding style errors

❦ 9 août 2014 20:34 -0700, Greg Kroah-Hartman  : >> This includes: >> - keep "else" on the same line as the closing brace >> - don't use "else" after "return" > >> - don't issue a message for an out-of-memory error >> - blank line after a declaration >> >> Signed-off-by: Vincent Bernat >>

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

On Sat, Aug 09, 2014 at 08:22:48PM +, Junien Fridrick wrote: > Sorry for the noise, this is part of task 10 of the Eudyptula Challenge. It's not noise at all, but it's not needed in the changelog comment, as was pointed out. Can you resend without this line, and actually say _what_ coding sty

Re: [PATCH] staging: xillybus: fix some coding style errors

On Sun, Aug 10, 2014 at 02:16:04PM +0200, Vincent Bernat wrote: > ❦ 9 août 2014 20:34 -0700, Greg Kroah-Hartman  : > > >> This includes: > >> - keep "else" on the same line as the closing brace > >> - don't use "else" after "return" > > > >> - don't issue a message for an out-of-memory error

[PATCH 00/17] staging/bcm/Bcmchar.c variable rename patches

Hi, this is the requested resend of my patchset on the drivers/staging/bcm/Bcmchar.c file where I do rename variables. Please note, as always: As I do not have the appropriate hardware, I'm not able to test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Bey

[PATCH 01/17] Staging: bcm: Bcmchar.c: Fixed indentation of function arguments

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 56 --- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index c1e01f7..aff21d0 100644 --- a/drivers/staging/bcm/B

[PATCH 08/17] Staging: bcm: Bcmchar.c: Renamed variable "PktLen" -> "pkt_len"

Renamed variable "PktLen" -> "pkt_len" in bcm_char_read(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 1481074..36c7b27 100644 --

[PATCH 03/17] Staging: bcm: Bcmchar.c: Renamed variable "pReadData" -> "read_data"

Renamed variable "pReadData" -> "read_data" in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/dr

[PATCH 07/17] Staging: bcm: Bcmchar.c: Renamed variable "pTarang" -> "tarang"

Renamed variable "pTarang" -> "tarang" in bcm_char_open() bcm_char_release() bcm_char_read() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 46 +-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/stag

[PATCH 06/17] Staging: bcm: Bcmchar.c: Renamed variable "ulDSDMagicNumInUsrBuff" -> "dsd_magic_num_in_usr_buff"

Renamed variable "ulDSDMagicNumInUsrBuff" -> "dsd_magic_num_in_usr_buff" in handle_flash2x_adapter(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmc

[PATCH 04/17] Staging: bcm: Bcmchar.c: Renamed variable "stNVMReadWrite" -> "nvm_rw"

Renamed variable "stNVMReadWrite" -> "nvm_rw" in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drive

[PATCH 09/17] Staging: bcm: Bcmchar.c: Renamed variable "Packet" -> "packet"

Renamed variable "Packet" -> "packet" in bcm_char_read(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 36c7b27..40433da 1006

[PATCH 05/17] Staging: bcm: Bcmchar.c: Renamed variable "Status" -> "status"

Renamed variable "Status" -> "status" in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() bcm_char_ioctl_gpio_set_request() Signed

[PATCH 02/17] Staging: bcm: Bcmchar.c: Renamed variable "Adapter" -> "ad"

Renamed variable "Adapter" -> "ad" in bcm_handle_nvm_read_cmd() handle_flash2x_adapter() bcm_char_open() bcm_char_release() bcm_char_read() bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eep

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > This commit binds global variables of dgnc driver in a structure so > that it is logically consistent. The structure is accessed via getter > function and as a result the externing of globals is removed. The names > of the variabl

[PATCH 13/17] Staging: bcm: Bcmchar.c: Renamed variable "sWrmBuffer" -> "wrm_buff"

Renamed variable "sWrmBuffer" -> "wrm_buff" in bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drive

[PATCH 12/17] Staging: bcm: Bcmchar.c: Renamed variable "Bufflen" -> "buff_len"

Renamed variable "Bufflen" -> "buff_len" in bcm_char_ioctl_reg_read_private(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 7eac

[PATCH 10/17] Staging: bcm: Bcmchar.c: Renamed variable "sRdmBuffer" -> "rdm_buff"

Renamed variable "sRdmBuffer" -> "rdm_buff" in bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/stag

[PATCH 11/17] Staging: bcm: Bcmchar.c: Renamed variable "IoBuffer" -> "io_buff"

Renamed variable "IoBuffer" -> "io_buff" in bcm_char_ioctl_reg_read_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() bcm_char_ioctl_gpio_set_request() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmcha

[PATCH 17/17] Staging: bcm: Bcmchar.c: Renamed variable "uiOperation" -> "operation"

Renamed variable "uiOperation" -> "operation" in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 6ae95d

[PATCH 15/17] Staging: bcm: Bcmchar.c: Renamed variable "ucResetValue" -> "reset_val"

Renamed variable "ucResetValue" -> "reset_val" in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 062

[PATCH 14/17] Staging: bcm: Bcmchar.c: Renamed variable "uiTempVar" -> "tmp"

Renamed variable "uiTempVar" -> "tmp" in bcm_char_ioctl_reg_write_private() bcm_char_ioctl_eeprom_reg_read() Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging

[PATCH 16/17] Staging: bcm: Bcmchar.c: Renamed variable "uiBit" -> "bit"

Renamed variable "uiBit" -> "bit" in bcm_char_ioctl_gpio_set_request(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/Bcmchar.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index c63eb37..6a

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

On Sat, 9 Aug 2014, Greg KH wrote: On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: This patch fixes the checkpatch.pl 'Missing a blank line after declarations' warning in speakup_soft.c. Signed-off-by: Artemiy Volkov --- drivers/staging/speakup/speakup_soft.c | 3 +++ 1 fi

[PATCHv2] staging: rtl8192u: checkpatch: do not use C99 // comments

Use the common kernel coding style, so don't use C99 // comments in r8192U_core.c If too long, where reasonable, they are shortened as well. Some old internal comments about date and author of changes are removed. This provides a more consistent view and hopefully encourages to look at it. Signe

Re: [PATCH] staging: vt6655: wpactl.c: Fix sparse warnings

On Sat, Aug 09, 2014 at 08:36:55PM -0700, Greg Kroah-Hartman wrote: > On Sat, Aug 09, 2014 at 01:55:19AM +0200, Martin Berglund wrote: > > On Fri, Aug 08, 2014 at 06:47:25AM -0700, Greg Kroah-Hartman wrote: > > > On Fri, Aug 08, 2014 at 09:07:55AM +0200, Martin Berglund wrote: > > > > On Thu, Aug 0

Re: [PATCH 01/12] staging: lustre: remove space between function name and and open parenthesis

On Sat, Aug 09, 2014 at 09:32:22PM -0700, Greg KH wrote: > On Wed, Aug 06, 2014 at 10:42:51PM +0530, Srikrishan Malik wrote: > > Fixes following checkpatch warning: > > > > WARNING: space prohibited between function name and open parenthesis '(' > > > > Signed-off-by: Srikrishan Malik > > Can y

[PATCH 01/22] staging: rtl8188eu: Cleanup firmware initialization code

Using rtl8188ee's (drivers/net/wireless/rtlwifi/rtl8188ee/fw.c) neat and clean firmware initialization code to replace rtl8188eu's messy firmware initialization code. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile|1 + drivers/staging/rtl8188eu/hal/fw.c

[PATCH 05/22] staging: rtl8188eu: Remove unused function odm_ConfigRFReg_8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 25 .../staging/rtl8188eu/include/odm_RegConfig8188E.h |3 --- 2 files changed, 28 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/rtl8

[PATCH 04/22] staging: rtl8188eu: Remove unused functions odm_ConfigRF_Radio[A, B]_8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 19 --- .../staging/rtl8188eu/include/odm_RegConfig8188E.h |6 -- 2 files changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/

[PATCH 06/22] staging: rtl8188eu: Remove unused function odm_ConfigMAC_8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c |8 drivers/staging/rtl8188eu/include/odm_RegConfig8188E.h |2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/rtl8188eu

[PATCH 07/22] staging: rtl8188eu: Cleanup and simplify Baseband configuration code

Cleanup and consolidate Baseband configuration related code in HalHWImg8188E_BB.c file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c | 474 ++-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 15 - drivers/staging/rtl8188eu/hal/rtl8

[PATCH 03/22] staging: rtl8188eu: Cleanup and simplify RF configuration code

Cleanup and consolidate RF configuration related code in HalHWImg8188E_RF.c file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 269 drivers/staging/rtl8188eu/hal/odm_HWConfig.c | 14 - drivers/staging/rtl8188eu/hal/rtl8188e_p

[PATCH 02/22] staging: rtl8188eu: Cleanup and simplify MAC configuration code

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 120 ++-- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |7 -- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 37 -- drivers/staging/rtl8188eu/hal/usb_halinit.c| 1

[PATCH 11/22] staging: rtl8188eu: Remove unused function rtw_IOL_accquire_xmit_frame()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 36 --- drivers/staging/rtl8188eu/include/rtw_iol.h |1 - 2 files changed, 37 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.

[PATCH 08/22] staging: rtl8188eu: Remove odm_RegConfig8188E.[h, c] files

driver doesn't require these files anymore. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |1 - drivers/staging/rtl8188eu/hal/odm_RegConfig8188E.c | 86 .../staging/rtl8188eu/include/odm_RegConfig8188E.h | 32 drivers/st

[PATCH 09/22] staging: rtl8188eu: Remove unused function storePwrIndexDiffRateOffset()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 44 drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |2 - 2 files changed, 46 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu

[PATCH 10/22] staging: rtl8188eu: Hal8188EPhyCfg.h: Remove unused function declaration

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h b/drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h index 49e1825..161ad76 100644 --- a/driver

[PATCH 12/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_boundary_handle()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 13 - drivers/staging/rtl8188eu/include/rtw_iol.h |1 - 2 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 5401f7

[PATCH 14/22] staging: rtl8188eu: Remove unused function rtw_IOL_exec_cmds_sync()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c|5 - drivers/staging/rtl8188eu/include/rtw_iol.h |3 --- 2 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index ebc228d..4527

[PATCH 13/22] staging: rtl8188eu: Remove unused function rtw_IOL_append_WD_cmd()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 14 -- drivers/staging/rtl8188eu/include/rtw_iol.h |4 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index cd

[PATCH 17/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_buf_dump()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 17 - drivers/staging/rtl8188eu/include/rtw_iol.h |2 -- 2 files changed, 19 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 5

[PATCH 16/22] staging: rtl8188eu: Remove unused function rtw_IOL_cmd_tx_pkt_buf_dump()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 32 - drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 33 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188e

[PATCH 15/22] staging: rtl8188eu: Remove unused functions rtw_IOL_append_DELAY_[US, MS]_cmd()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 16 drivers/staging/rtl8188eu/include/rtw_iol.h |2 -- 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index 45

[PATCH 18/22] staging:rtl8188eu: Remove rtl8188e_IOL_exec_cmds_sync() and its wrapper function

rtl8188e_IOL_exec_cmds_sync() is a unused function. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c | 10 --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 32 - drivers/staging/rtl8188eu/include/hal_intf.h |7 - 3

[PATCH 22/22] staging: rtl8188eu: Declare Efuse_GetCurrentSize() as a static function

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_efuse.c|2 +- drivers/staging/rtl8188eu/include/rtw_efuse.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_efuse.c b/drivers/staging/rtl8188eu/core/rtw_efuse.c

[PATCH 19/22] staging: rtl8188eu: Remove unused function iol_ioconfig()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c index 16525b0..50b1332 100644 --- a/drivers/stag

[PATCH 21/22] staging: rtl8188eu: rtw_iol.h: Remove unused struct, enum and macro

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_iol.h | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_iol.h b/drivers/staging/rtl8188eu/include/rtw_iol.h index 8ebdddb..68aae7f 100644 --- a/drivers/staging

[PATCH 20/22] staging: rtl8188eu: rtw_iol.c: Remove unused functions

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 63 --- drivers/staging/rtl8188eu/include/rtw_iol.h | 18 2 files changed, 81 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/r

[PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

Cleaned all C99 comments related warnings Signed-off-by :Avinash Kumar Signed-off-by: Avinash kumar --- drivers/staging/vt6655/wpactl.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/stag

[PATCH] staging: wlan-ng: prism2mgmt.c Fix break not useful

This is the part of eudyptula task-10.This is a patch to the prism2mgmt.c file that fixes up warning break is not useful after a goto or return found in checkpatch.pl tool. Signed-off-by: Jeshwanth Kumar N K --- drivers/staging/wlan-ng/prism2mgmt.c | 3 --- 1 file changed, 3 deletions(-) diff

[PATCHv3 1/2] Staging: rtl8188eu: Lines over 80 characters fixed.

This is a patch to the hal/rtl8188eu_recv.c file that fixes up a "line over 80 characters" warning found by the checkpatch.pl tool. Signed-off-by: Adrian Remonda --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 28 +- 1 file changed, 18 insertions(+), 10 deletions(-)

[PATCHv3 2/2] Staging: rtl8188eu: Removed unneeded code.

This patch removes some unneeded code. 1) kzalloc() allocates 4 extra bytes so that we can align the return value. But actually the return value is already aligned so we can remove the + 4 and the call to N_BYTE_ALIGMENT(). 2) The memset() isn't needed because kzalloc() zeroes the allocation

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

On 08/10, Greg KH wrote: > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > > This commit binds global variables of dgnc driver in a structure so > > that it is logically consistent. The structure is accessed via getter > > function and as a result the externing of globals is re

[PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed before it is initialised, by: - letting et131x_mii_write() take a phydev address, instead of using the one stored in adapter by default. This is so et131x_mdio_write() can use it's own addr value. - removing implement

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

Do you have this hardware ? And did you test this ? How can you cc stable without an Tested by somebody else ? On Mon, Aug 11, 2014 at 12:16 AM, Mark Einon wrote: > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed > before it is initialised, by: > > - letting et131x_m

[PATCH v2] staging: lustre: fix coding style issue: missing space after 'if'

Coding style issue reported by checkpatch.pl Signed-off-by: Junien Fridrick --- This patch is part of task 10 of the eudyptula challenge Applies to next-20140808 v2 : fixed patch short summary and description drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +- 1 file changed, 1 insertion

[PATCH] drivers: android: fix watermark when cma enabled

From: Zeng Tao Date: Tue, 5 Aug 2014 17:58:10 +0800 Subject: [PATCH] drivers: android: fix watermark when cma enabled when cma is enabled, the watermark caculation will include the cma pages, while it can't use cma pages. this will cause oom while lowmemory killer don't work. Signed-off-by: Zen

[PATCH v2] drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse

This minor patch motivated by eudyptula challenge fixes the following warnings issued by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c: .../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static? .../r8192U_wx.c:961:22: warning: symbol 'r8192_get_wireless_st

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > > > > > > > > IMO the most feasible and need-the-least-change solution may be: > > > > the hyperv network VSC driver passes the event > > > > RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? > > > > > > > No, don't do

Re: [PATCH 16/19] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

On 08/09/2014 09:23 PM, Greg KH wrote: On Sun, Aug 03, 2014 at 05:20:58PM -0700, Hans Wennborg wrote: Signed-off-by: Hans Wennborg --- drivers/staging/rtl8192ee/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This patch fails to apply to my tree :( Sorry about that. I'

Re: staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

Re-sending patch based off of https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/staging ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192ee: fix %d confusingly prefixed with 0x in format strings

Signed-off-by: Hans Wennborg --- drivers/staging/rtl8192ee/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192ee/pci.c b/drivers/staging/rtl8192ee/pci.c index 0215aef..349e636 100644 --- a/drivers/staging/rtl8192ee/pci.c +++ b/drivers/staging/rt

RE: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

> -Original Message- > From: Dexuan Cui > Sent: Monday, August 11, 2014 11:24 AM > Now I understand it's not good to pass the event to the udev daemon, > and it's not good to use a SLEEP(10s) in the kernel space(even if it's in a > "work" task here). > > Please let me know if it's the corr

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

Le 10/08/2014 20:23, Dexuan Cui a écrit : -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] IMO the most feasible and need-the-least-change solution may be: the hyperv network VSC driver passes the event RNDIS_STATUS_NETWORK_CHANGE to the udev daemon? No, don't do t

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

On Sun, 10 Aug 2014, Florian Fainelli wrote: > Le 10/08/2014 20:23, Dexuan Cui a écrit : > >> -Original Message- > >> From: Greg KH [mailto:gre...@linuxfoundation.org] > > > > IMO the most feasible and need-the-least-change solution may be: > > the hyperv network VSC driver pas

Re: [PATCH RESEND] staging: et131x: Fix errors caused by phydev->addr accesses before initialisation

On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote: > Do you have this hardware ? And did you test this ? Mark is the maintainer of this driver, I assume he has the hardware, if not, I don't care, I trust him :) > How can you cc stable without an Tested by somebody else ? Since when is

Re: [PATCH] staging: dgnc: Encapsulate global variables in a structure

On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote: > On 08/10, Greg KH wrote: > > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote: > > > This commit binds global variables of dgnc driver in a structure so > > > that it is logically consistent. The structure is acce

Re: [PATCH] staging: wlan-ng: prism2mgmt.c Fix break not useful

On Mon, Aug 11, 2014 at 12:10:37AM +0530, Jeshwanth Kumar N K wrote: > This is the part of eudyptula task-10.This is a patch to the prism2mgmt.c > file that fixes up warning break is not useful after a goto or return found > in checkpatch.pl tool. That's a really long single line, please fix it

Re: [PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

On Sun, Aug 10, 2014 at 11:28:55PM +0530, Avinash kumar wrote: > Cleaned all C99 comments related warnings > > Signed-off-by :Avinash Kumar > > Signed-off-by: Avinash kumar Why is this line twice in here, the first one has the ':' in the wrong place. Please resend with it the line only once i

Re: [PATCH v2] Staging: speakup: Insert blank lines after declarations in speakup_soft.c

On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote: > > > On Sat, 9 Aug 2014, Greg KH wrote: > > >On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote: > >>This patch fixes the checkpatch.pl 'Missing a blank line after > >>declarations' warning in speakup_soft.c. > >> > >>

[PATCH] drivers: staging: vt6655: wpactl.c checkpatch clean-up

Cleaned all C99 comments related warnings Signed-off-by: Avinash kumar --- drivers/staging/vt6655/wpactl.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c index 8392