[PATCH 0/3] Enable discard on Hyper-V

On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > > I'm not sure this alone will work - won't sdev_bflags/bflags have > > > already been built

[PATCH 1/3] [SCSI] Add quirk for forcing logical block provisioning tests

Despite supporting modern SCSI features (such an UNMAP) some storage devices continue to claim conformance to an older version of the SPC spec for compatibility with legacy operating systems. Linux by default will not attempt to read VPD pages on devices that claim SPC-2 or older. Introduce a bla

[PATCH v2] staging: lustre: obdclass: fix sparse warnings about static declaration

Signed-off-by: Andrey Skvortsov --- changes since v1: removed from patch static declarations for functions obd_sysctl_init and obd_sysctl_clean to fix build issue. .../lustre/lustre/obdclass/linux/linux-sysctl.c| 24 ++-- 1 file changed, 12 insertions(+), 12 deletions

[PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

Microsoft Hyper-V targets currently only claim SPC-2 compliance / no compliance indicated even though they implement post SPC-2 features which means those features are not tested for. Add a blacklist flag to Hyper-V devices that forces said testing. See https://lkml.org/lkml/2014/7/21/627 for the

[PATCH 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

Some block devices (such as Hyper-V passthrough SSDs) support logical block provisioning (e.g. via UNMAP) but don't set lbpme thus disabling discard. If the try_lbp quirk is in use skip lbpme checks that lead up to the logical block provisioning tests. Signed-off-by: Sitsofe Wheeler --- drivers/

Re: [PATCH 1/1] staging: vme: removed useless breaks in vme_user.c

On 23/07/14 17:17, Tom Jorquera wrote: vme_user.c contained unnecessary breaks after gotos, which increased code size and caused code style warning. This is now fixed. Signed-off-by: Tom Jorquera Acked-by: Martyn Welch --- drivers/staging/vme/devices/vme_user.c | 4 1 file changed,

Re: XVME 6300 with TSI148 bridge on 64 bit Debian (Linux 3.2.57) vme_user issue

On 23/07/14 03:09, Maurice Moss wrote: Hi Martyn, Thanks for your patience with me. I have a couple of questions for you: 0. I put the SBC with the right settings for Geographical addressing. I did 2 tests by setting the board in each of the 2 slots available on my rack and the geo address was

[PATCH 1/2] staging: et131x: Fix typo in et131x

This patch fix spelling typos in comments and printk within et131x. Signed-off-by: Masanari Iida --- drivers/staging/et131x/et131x.c | 8 drivers/staging/et131x/et131x.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/

[PATCH 2/2] staging: et131x: Remove trailing semicolon from macros in et131x.h

This patch removes trailing semicolon from macros within et131x.h Signed-off-by: Masanari Iida --- drivers/staging/et131x/et131x.h | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/et131x/et131x.h b/drivers/staging/et13

[PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

v1 -> v2: Fix incorrectly named variable. Some block devices (such as Hyper-V passthrough SSDs) support logical block provisioning (e.g. via UNMAP) but don't set lbpme thus disabling discard. If the try_lbp quirk is in use skip lbpme checks that lead up to the logical block provisioning tests. Si

Re: [PATCH 0/3] Enable discard on Hyper-V

On Thu, Jul 24, 2014 at 08:47:39AM +0100, Sitsofe Wheeler wrote: > On Wed, Jul 23, 2014 at 09:13:41PM +0100, Sitsofe Wheeler wrote: > > On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > > > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > > > I'm not sure this

[PATCH] staging:bcm:DDRinit.c:coding style:line over 80 char

--- drivers/staging/bcm/DDRInit.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 4564f40..4226c93 100644 --- a/drivers/staging/bcm/DDRInit.c +++ b/drivers/staging/

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> Fix incorrectly named variable. Some block devices (such as Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning Sitsofe> (e.g. via UNMAP) but don't set lbpme thus disabling discard. The fix for an SSD that is known to suppor

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > compliance indicated even though they implement post SPC-2 features > which means those features are not tested for. Add a blacklist flag to > Hyper-V devices that forc

Re: [PATCH] staging: Change kzalloc to kcalloc

On Wed, Jul 23, 2014 at 07:03:01PM -0400, Nicholas Krause wrote: > This changes the call to kzalloc to kcalloc in ion_dummy_driver > for allocating the heap. > > Signed-off-by: Nicholas Krause > --- > drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 10:47:25 -0400 Steven Rostedt wrote: > The three parameters are the number of elements, the size of each individual > element, and then finally the flags used on how to allocate that memory. > I have to say, you did get the flags part correct. > > Now lets look at what you

[PATCH 3/3] staging: dgnc: Fix space required after that ','

This patch fixes checkpatch errors: "space required after that ','" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h index f7730a1

[PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

This patch fixes a checkpatch errors "Macros with complex values should be enclosed in parenthesis" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.h | 40 drivers/staging/dgnc/digi.h| 60 ++-- drivers/staging/

[PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL

This patch fixes checkpatch errors "do not initialise statics to 0 or NULL" Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_trace.c |2 +- drivers/staging/dgnc/dgnc_tty.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_trace.c

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > I'm very much against short-circuiting the LBP logic in a passthrough > driver because then we might end up in the exact situation we were > trying to avoid with this patch series. Namely sending down commands > unsupported by th

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > I agree - I'd like to pull in KY's simple fix as soon as I get a second > review for it. Ok, looks like I just got that from Hannes. Let's see if there's more to be done for the pass through case, but I'd rather wait for the nex

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Thu, Jul 24, 2014 at 09:54:24AM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Fix incorrectly named variable. Some block devices (such as > Sitsofe> Hyper-V passthrough SSDs) support logical block provisioning > Sitsofe> (e.g. via UNMAP) but don't

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> So we can see it is really a SATA device that announces discard Sitsofe> correctly and supports discard through WRITE_SAME(16). No, that's the SATA device that announces support for DSM TRIM, and as a result the Linux SATL reports support for W

Re: [PATCH] staging:bcm:DDRinit.c:coding style:line over 80 char

On Thu, Jul 24, 2014 at 06:19:46PM +0530, Sudip Mukherjee wrote: > --- > drivers/staging/bcm/DDRInit.c | 59 > --- > 1 file changed, 39 insertions(+), 20 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch

Re: [PATCH] staging: Change kzalloc to kcalloc

Steven Rostedt writes: > On Thu, 24 Jul 2014 10:47:25 -0400 > Steven Rostedt wrote: > >> The three parameters are the number of elements, the size of each individual >> element, and then finally the flags used on how to allocate that memory. >> I have to say, you did get the flags part correct.

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Thu, Jul 24, 2014 at 08:35:13AM -0700, Christoph Hellwig wrote: > On Thu, Jul 24, 2014 at 08:34:19AM -0700, Christoph Hellwig wrote: > > I agree - I'd like to pull in KY's simple fix as soon as I get a second > > review for it. > > Ok, looks like I just got that from Hannes. Let's see if there

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: > Steven Rostedt writes: > >> On Thu, 24 Jul 2014 10:47:25 -0400 >> Steven Rostedt wrote: >> >>> The three parameters are the number of elements, the size of each individual >>> element, and then finally the flags used on how to allocate tha

Re: [PATCH] staging: Change kzalloc to kcalloc

Nick Krause writes: > On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >> Steven Rostedt writes: >> >>> On Thu, 24 Jul 2014 10:47:25 -0400 >>> Steven Rostedt wrote: >>> The three parameters are the number of elements, the size of each individual element, and then finally

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>> Steven Rostedt writes: >>> On Thu, 24 Jul 2014 10:47:25 -0400 Steven Rostedt wrote: > The three parameters are the number of elements,

Re: [PATCH 2/3] staging: dgnc: Fix do not initialise statics to 0 or NULL

Seunghun Lee schreef op vr 25-07-2014 om 00:26 [+0900]: > This patch fixes checkpatch errors > "do not initialise statics to 0 or NULL" > > Signed-off-by: Seunghun Lee > --- > drivers/staging/dgnc/dgnc_trace.c |2 +- > drivers/staging/dgnc/dgnc_tty.c |2 +- > 2 files changed, 2 inserti

Re: [PATCH] staging: Change kzalloc to kcalloc

Nick Krause writes: > On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >> Nick Krause writes: >> >>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: Steven Rostedt writes: > On Thu, 24 Jul 2014 10:47:25 -0400 > Steven Rostedt wrote: > >> The three param

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:47 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >>> Nick Krause writes: >>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: > Steven Rostedt writes: > >> On Thu, 24 Jul 2014 10:47:

[PATCH 18/40] staging: comedi: ni_tio: convert global static const variables to defines

For aesthetics, convert the global static const varaibles into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 92 - 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/dri

[PATCH 00/40] staging: comedi: ni_tio: clean up driver

Start cleaning up this driver by: 1) fix all the checkpatch.pl warnings WARNING: line over 80 characters WARNING: Unnecessary space before function pointer arguments WARNING: Prefer [foo]_err to printk(KERN_ERR ... 2) remove a bunch of unreachable BUG() code 3) tidy up some of

[PATCH 10/40] staging: comedi: ni_tio: convert NI_660x_Gate_Pin_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 9 ++--- 1 file changed, 2 inserti

[PATCH 03/40] staging: comedi: ni_tio: tidy up some function declarations

Fix the whitespace in some of the function declarations to avoid the ugly line breaks and fix a couple checkpatch.pl issues: WARNING: line over 80 characters WARNING: Unnecessary space before function pointer arguments Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 16/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Second_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 ++ 1 file changed, 2 inser

[PATCH 28/40] staging: comedi: ni_tio: rename ni_tio_second_gate_registers_present()

For aesthetics, rename this function to shorten some of the long lines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/

[PATCH 31/40] staging: comedi: ni_tio: tidy up ni_tio_set_sync_mode()

Fix the > 80 char line issues in this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/

[PATCH 32/40] staging: comedi: ni_tio: absorb ni_tio_counter_status()

This function is only called to handle the INSN_CONFIG_GET_COUNTER_STATUS instruction. For aesthetics, absorb the code into ni_tio_insn_config(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 25 + 1

[PATCH 09/40] staging: comedi: ni_tio: convert NI_M_Series_PFI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 3 inse

[PATCH 29/40] staging: comedi: ni_tio: tidy up ni_m_series_source_select_bits()

Rename a local variable to fix the > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b

[PATCH 36/40] staging: comedi: ni_tio: absorb ni_tio_set_first_gate_modifiers()

This function is only called by ni_tio_set_gate_src(). For aesthetics, absorb the code into that function.. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 28 ++-- 1 file changed, 10 insertions(+), 18

[PATCH 11/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 9 ++--- 1 file changed, 2 inserti

[PATCH 17/40] staging: comedi: ni_tio: convert NI_660x_Up_Down_Pin_Second_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 ++- 1 file changed, 2 inse

[PATCH 14/40] staging: comedi: ni_tio: convert NI_660x_Source_Pin_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +++--- 1 file changed, 3 inser

[PATCH 26/40] staging: comedi: ni_tio: tidy up ni_gpct_device_{construct, destroy)()

For aesthetics, move these exported functions to the end of the file. Tidy up the functions a bit and remove the BUG_ON when (num_counters == 0). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 101 +-

[PATCH 01/40] staging: comedi: ni_tio: fix ni_tio_insn_read()

The comedi core expects the (*insn_read) operations to read insn->n values and return the number of values read. Fix this function to work line the core expects. For aesthetics, factor out the code that reads the SM_Save_Reg. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartm

[PATCH 06/40] staging: comedi: ni_tio: tidy up ni_m_series_set_first_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-

[PATCH 19/40] staging: comedi: ni_tio: remove counter_status_mask

For aesthetics, remove this global static const varaible. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/driver

[PATCH 37/40] staging: comedi: ni_tio: tidy up ni_tio_get_clock_src()

Remove the static const local variable and add a blank line after the declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 21/40] staging: comedi: ni_tio: tidy up enum ni_m_series_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 37 - 1 file changed, 18 inserti

[PATCH 39/40] staging: comedi: ni_tio: remove forward declarations

Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 392 1 file changed, 194 insertions(+), 198 deletions(-) diff --git

[PATCH 20/40] staging: comedi: ni_tio: tidy up enum ni_660x_second_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 31 +++ 1 file changed, 15 insertion

[PATCH 34/40] staging: comedi: ni_tio: tidy up ni_tio_set_other_src()

Invert the counter_dev->variant test to reduce the indent level of this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 50 - 1 file changed, 24 insertions(+), 26 deletions(-) diff -

[PATCH 13/40] staging: comedi: ni_tio: convert NI_M_Series_PFI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 13 ++--- 1 file changed, 2 in

[PATCH 02/40] staging: comedi: ni_tio: fix > 80 char comments

Tidy up some of the comments to fix some fo the the checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 44 - 1 file changed, 32 insertions

[PATCH 33/40] staging: comedi: ni_tio: tidy up ni_tio_get_gate_src() and helpers

Do some renaming of local vars, parameters, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 90 ++--- 1 file changed, 37

[PATCH 40/40] staging: comedi: ni_tio: convert printk to pr_err

Convert the printk(KERN_ERR ...) in ni_m_clk_src() to a pr_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/dr

[PATCH 12/40] staging: comedi: ni_tio: convert NI_M_Series_RTSI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 12 ++-- 1 file changed, 2 ins

[PATCH 25/40] staging: comedi: ni_tio: move defines to head of file

For aesthetics, move all the defines to the head of the file. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 131 1 file changed, 67 insertions(+), 64 deletions(-) diff --git a/drivers/stagi

[PATCH 07/40] staging: comedi: ni_tio: tidy up ni_660x_set_first_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletion

[PATCH 30/40] staging: comedi: ni_tio: tidy up ni_660x_source_select_bits()

Rename a local variable to fix the > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b

[PATCH 08/40] staging: comedi: ni_tio: convert NI_M_Series_RTSI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 3 inse

[PATCH 04/40] staging: comedi: ni_tio: remove unnecessary ni_gpct_variant BUG() cases

The enum ni_gpct_variant is used to handle hardware variations in the gpct timers handled by this driver. This enum is defined as: enum ni_gpct_variant { ni_gpct_variant_e_series, ni_gpct_variant_m_series, ni_gpct_variant_660x }; For all the switch statements where all thr

[PATCH 24/40] staging: comedi: ni_tio: tidy up enum ni_660x_clock_source

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 49 - 1 file changed, 23 inserti

[PATCH 05/40] staging: comedi: ni_tio: tidy up ni_660x_set_second_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 39 - 1 file changed, 14 insertions(+), 25

[PATCH 15/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +++--- 1 file changed, 3 inser

[PATCH 38/40] staging: comedi: ni_tio: tidy up ni_tio_set_clock_src() and helpers

Do some renaming of local vars, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 38 + 1 file changed, 15 insertions(

[PATCH 23/40] staging: comedi: ni_tio: tidy up enum ni_m_series_clock_source

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 62 - 1 file changed, 31 inserti

[PATCH 27/40] staging: comedi: ni_tio: tidy up ni_tio_init_counter()

This function is called to initialize/reset a gpct counter during a comedi drivers (*attach). For aesthetics, move this exported function toward the end of the file. Tidy up the functions a bit by just open coding the '0x0' values used to initialize some of the registers. Signed-off-by: H Hartle

[PATCH 22/40] staging: comedi: ni_tio: tidy up enum ni_660x_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 27 +-- 1 file changed, 13 insertions(+)

[PATCH 35/40] staging: comedi: ni_tio: tidy up ni_tio_set_gate_src() and helpers

Do some renaming of local vars, parameters, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 68 ++--- 1 file changed, 29

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 12:50:31 -0400 Nick Krause wrote: \ > > Most kernel devs most certainly did NOT get started by spamming lkml > > with unnecessary and incorrect patches despite being repeatedly told to > > go away and stop wasting everybody's time. Mans, shut up! That is uncalled for. > > >

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 12:50:31 -0400 > Nick Krause wrote: > >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > It's not just one patc

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 10:30:51 -0700 Harvey Harrison wrote: > On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > > On Thu, 24 Jul 2014 12:50:31 -0400 > > Nick Krause wrote: > > > > >> I am have this discussion with other kernel developers and just > >> because I send out one patch as a ne

Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

On Fri, 2014-07-25 at 00:26 +0900, Seunghun Lee wrote: > This patch fixes a checkpatch errors > "Macros with complex values should be enclosed in parenthesis" [] > diff --git a/drivers/staging/dgnc/dgnc_driver.h > b/drivers/staging/dgnc/dgnc_driver.h > @@ -111,32 +111,32 @@ > #endif > > #if d

[PATCH] staging: phison: remove driver

The driver hasn't been cleaned up and it doesn't look like anyone is working on it anymore (including the original author). So remove the driver from the kernel. If someone wants to work on cleaning it up and moving it out of staging, this commit can be reverted. Signed-off-by: Kristina Martšenko

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

On Thu, Jul 24, 2014 at 02:09:11PM +, James Bottomley wrote: > On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > > compliance indicated even though they implement post SPC-2 features > > which means those feature

Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

This patch adds a documentation file for all of the interfaces that were moved to sysfs by the other patches in this set. Signed-off-by: Benjamin Romer --- v3: documentation was revised based on changes in earlier patches. v2: whitespace errors were corrected. .../Documentation/ABI/sysfs-platfo

[PATCH 3/6 v3] staging: unisys: clean up diagdump proc entry code

Remove remnant code left over from the diagdump proc entry. Signed-off-by: Benjamin Romer --- v3: patch locations changed due to prior patches being revised. v2: patch locations changed due to prior patches being revised. drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 +--- 1 f

[PATCH 1/6 v3] staging: unisys: move installer to sysfs and split fields

The installer entry in /proc/visorchipset/installer was composed of three separate fields as one entry. This patch removes the proc entry and associated functions, and creates new fields with distinct entries under sysfs in the visorchipset/install directory. The fields are: textid: used t

[PATCH 5/6 v3] staging: unisys: move parahotplug to sysfs

Move the /proc/visorchipset/parahotplug interface to sysfs under /sys/devices/platform/visorchipset/parahotplug/deviceenabled and /sys/devices/platform/visorchipset/parahotplug/devicedisabled. The parahotplug interface is used to deal with SR-IOV recovery situations on s-Par guest partitions. The

[PATCH 2/6 v3] staging: unisys: move chipsetready to sysfs

Move the chipsetready proc entry to sysfs under a new directory guest. This entry is used by Unisys application software on the guest to acknowledge completion of specific events for integration purposes, but these acknowledgements are not required for the guest to operate correctly. The store fun

[PATCH 4/6 v3] staging: unisys: remove partition information from proc

Debugging information for the guest's channels was being exposed in proc. Remove the code that creates these entries, which are no longer needed. Signed-off-by: Benjamin Romer --- v3: patch location changed due to prior patches being revised. v2: patch location changed due to prior patches being

[PATCH 0/6 v3] staging: unisys: visorchipset proc fixes

This patch set moves several interfaces in the visorchipset module from procfs to sysfs, and removes the remaining proc interfaces from the module. It includes documentation for the new interfaces in Documentation/ABI, and some code cleanup in the new sysfs handler functions. In version 3 of the s

[PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

This patch adds a documentation file for all of the interfaces that were moved to sysfs by the other patches in this set. Signed-off-by: Benjamin Romer --- v3: documentation was revised based on changes in earlier patches. v2: whitespace errors were corrected. .../Documentation/ABI/sysfs-platfo

Re: Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

Please disregard this specific email - "Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries" - the subject was corrected and this individual patch was resent. Sorry for any confusion. -- Ben ___ devel mailing list de...@linu

[PATCH] Staging: vt6655: remove redundant comments from baseband.h

Removed redundant comments in baseband.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/baseband.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index e31bb76..d90c7f9 100644 --- a/dri

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 10:30:51 -0700 > Harvey Harrison wrote: > >> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: >> > On Thu, 24 Jul 2014 12:50:31 -0400 >> > Nick Krause wrote: >> >> > >> >> I am have this discussion with other ke

[PATCH] Staging: vt6655: remove redundant comments from bssdb.h

Removed redundant comments from bssdb.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/bssdb.h | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/staging/vt6655/bssdb.h b/drivers/staging/vt6655/bssdb.h index a0938b7..9337a

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: > Steve, > I have programming a lot in other areas just not the kernel. > You are right through I need to test my code better through. Nick, let's make a deal. Take the challenge at http://eudyptula-challenge.org. After you've solved all tasks

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger wrote: > On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >> Steve, >> I have programming a lot in other areas just not the kernel. >> You are right through I need to test my code better through. > > Nick, > > let's make a deal. > Take the ch

[PATCH] staging: quickstart: remove driver

The driver hasn't been cleaned up and it doesn't look like anyone is working on it anymore (including the original author). So remove the driver from the kernel. If someone wants to work on cleaning it up and moving it out of staging, this commit can be reverted. Signed-off-by: Kristina Martšenko

[PATCH] Staging: vt6655: remove redundant comments from card.h

Removed redundant comments from card.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/80211hdr.h |7 --- drivers/staging/vt6655/80211mgr.h | 38 - drivers/staging/vt6655/aes_ccmp.h |9 - drivers/staging/vt6655/baseband

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger > wrote: >> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >>> Steve, >>> I have programming a lot in other areas just not the kernel. >>> You are right through I need to test my code b

Re: [PATCH] staging: Change kzalloc to kcalloc

Am 24.07.2014 21:05, schrieb Nick Krause: > On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger >> wrote: >>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: Steve, I have programming a lot in other areas just not the kernel. >

Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote: > Fix following sh-allmodconfig errors reported on kisskb > " > drivers/built-in.o: In function `ion_vm_fault': > ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn' > drivers/built-in.o: In function `ion_buffer_sync_for_

Re: [PATCH 4/6 v3] staging: unisys: remove partition information from proc

On Thu, Jul 24, 2014 at 02:08:45PM -0400, Benjamin Romer wrote: > Debugging information for the guest's channels was being exposed in proc. > Remove the code that creates these entries, which are no longer needed. > > Signed-off-by: Benjamin Romer > --- > v3: patch location changed due to prior p

Re: [PATCH 0/6 v3] staging: unisys: visorchipset proc fixes

On Thu, Jul 24, 2014 at 02:08:41PM -0400, Benjamin Romer wrote: > This patch set moves several interfaces in the visorchipset module from procfs > to sysfs, and removes the remaining proc interfaces from the module. It > includes > documentation for the new interfaces in Documentation/ABI, and som

  1   2   >