[PATCH] staging: android: Fixed missing blank line

2014-07-17 Thread sanjeev sharma
From: root This patch will add an blank line after declaration reported by checkpatch.pl script. Signed-off-by: Sanjeev Sharma --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c inde

Re: [PATCH] staging: android: Fixed missing blank line

2014-07-17 Thread Dan Carpenter
On Thu, Jul 17, 2014 at 12:48:44PM +0530, sanjeev sharma wrote: > From: root You shouldn't be doing this stuff as root... Also fix your From header so that your name is capitalized on your emails. regards, dan carpenter ___ devel mailing list de...@l

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-17 Thread h...@infradead.org
On Wed, Jul 16, 2014 at 03:20:00PM -0400, Martin K. Petersen wrote: > The block layer can only describe one contiguous block range in a > request. My copy offload patches introduces the bi_special field that > allows us to attach additional information to an I/O. I have > experimented with doing th

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 09:27:58AM +0800, Chen Gang wrote: [...] > diff --git a/include/linux/device.h b/include/linux/device.h > index c2421e0..a7500c3 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -630,7 +630,16 @@ extern unsigned long devm_get_free_pages(struct device

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 04:37 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 09:27:58AM +0800, Chen Gang wrote: > [...] >> diff --git a/include/linux/device.h b/include/linux/device.h >> index c2421e0..a7500c3 100644 >> --- a/include/linux/device.h >> +++ b/include/linux/device.h >> @@ -630,7 +630,16

[PATCH v2] staging: android: Fixed missing blank line

2014-07-17 Thread sanjeev sharma
From: sanjeevs1 This patch will add an blank line after declaration reported by checkpatch.pl script. Signed-off-by: Sanjeev Sharma --- Changes in v2: - Fixed frm header drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c

Re: [PATCH v2] staging: android: Fixed missing blank line

2014-07-17 Thread Dan Carpenter
On Thu, Jul 17, 2014 at 02:43:27PM +0530, sanjeev sharma wrote: > From: sanjeevs1 Only use this if you are sending on behalf of someone else. > > This patch will add an blank line after > declaration reported by checkpatch.pl script. > > Signed-off-by: Sanjeev Sharma > --- > Changes in v2: >

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Dan Carpenter
On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: > >> + return (__force void __iomem *)ERR_PTR(-ENXIO); > > > > There's apparently an IOMEM_ERR_PTR() for this nowadays... > > > > IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "./include". > But may we move it from "lib/devre

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 05:16 PM, Dan Carpenter wrote: > On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: + return (__force void __iomem *)ERR_PTR(-ENXIO); >>> >>> There's apparently an IOMEM_ERR_PTR() for this nowadays... >>> >> >> IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > gfp_t gfp_mask, unsigned int order); > extern void devm_free_pages(struct device *dev, unsigned long addr); > > +#ifdef CONFIG_HAS_IOMEM > void __iomem *devm_ioremap_resource(struct device *dev, struct

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 11:20, schrieb Arnd Bergmann: > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >> gfp_t gfp_mask, unsigned int order); >> extern void devm_free_pages(struct device *dev, unsigned long addr); >> >> +#ifdef CONFIG_HAS_IOMEM >> void __iome

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 05:20 PM, Arnd Bergmann wrote: > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >> gfp_t gfp_mask, unsigned int order); >> extern void devm_free_pages(struct device *dev, unsigned long addr); >> >> +#ifdef CONFIG_HAS_IOMEM >> void __i

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 05:29:31PM +0800, Chen Gang wrote: > > > On 07/17/2014 05:20 PM, Arnd Bergmann wrote: > > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > >> gfp_t gfp_mask, unsigned int > >> order); > >> extern void devm_free_pages(struct de

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: [...] > score should set HAS_IOMEM and doesn't > even have public compilers This begs an interesting question. Should it be made a requirement to have publicly available compilers for new architectures so that the

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: > Am 17.07.2014 11:20, schrieb Arnd Bergmann: > > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > >> gfp_t gfp_mask, unsigned int > >> order); > >> extern void devm_free_pages(struct device *

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: > On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: > [...] > > score should set HAS_IOMEM and doesn't > > even have public compilers > > This begs an interesting question. Should it be made a requirement to

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 17:29:31 Chen Gang wrote: > > > > COMPILE_TEST is a great tool in general, but it has its limits. > > In particular, the case for !CONFIG_IOMEM is completely obscure > > and we won't find any bugs by allowing more drivers to be built > > in those configurations, but attemp

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Lars-Peter Clausen
On 07/17/2014 11:20 AM, Arnd Bergmann wrote: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); extern void devm_free_pages(struct device *dev, unsigned long addr); +#ifdef CONFIG_HAS_IOMEM void __iomem *devm_ior

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote: > On 07/17/2014 11:20 AM, Arnd Bergmann wrote: > > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: > >> gfp_t gfp_mask, unsigned int > >> order); > >> extern void devm_free_pages(struct devic

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Thierry Reding
On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote: > On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: > > On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: > > [...] > > > score should set HAS_IOMEM and doesn't > > > even have public compilers >

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:28, schrieb Arnd Bergmann: > On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: >> Am 17.07.2014 11:20, schrieb Arnd Bergmann: >>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order); >>

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:55 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote: >> On Thursday 17 July 2014 11:56:58 Thierry Reding wrote: >>> On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote: >>> [...] score should set HAS_IO

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 12:58:55 Richard Weinberger wrote: > > This is what I got upon trying earlier. I have not attempted to look into > > why this is happening. Note this is on linux-next from yesterday, > > not mainline as I incorrectly stated above. > > > > In file included from ../arch/um/i

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:48 PM, Arnd Bergmann wrote: > On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote: >> On 07/17/2014 11:20 AM, Arnd Bergmann wrote: >>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote: gfp_t gfp_mask, unsigned int order);

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:58 PM, Richard Weinberger wrote: > Am 17.07.2014 12:28, schrieb Arnd Bergmann: >> On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: >>> Am 17.07.2014 11:20, schrieb Arnd Bergmann: On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chen Gang
On 07/17/2014 06:38 PM, Arnd Bergmann wrote: > On Thursday 17 July 2014 17:29:31 Chen Gang wrote: >>> >>> COMPILE_TEST is a great tool in general, but it has its limits. >>> In particular, the case for !CONFIG_IOMEM is completely obscure >>> and we won't find any bugs by allowing more drivers to

Re: [PATCH 00/28] staging: comedi: ni_mio_common: more cleanup

2014-07-17 Thread Ian Abbott
On 2014-07-16 17:36, Hartley Sweeten wrote: On Wednesday, July 16, 2014 3:54 AM, Ian Abbott wrote: On 2014-07-14 20:23, H Hartley Sweeten wrote: The ni_mio_common.c file is included by a number of National Instruments drivers to provide the "common" driver support. This series does some more cl

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-17 Thread Mark Hounschell
On 07/16/2014 08:42 PM, DaeSeok Youn wrote: 2014-07-16 23:17 GMT+09:00 Mark Hounschell : On 07/16/2014 05:26 AM, DaeSeok Youn wrote: 2014-07-16 8:50 GMT+09:00 Greg KH : On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: Hi, 2014-07-16 0:29 GMT+09:00 Greg KH : On Tue, Jul 15,

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-17 Thread Martin K. Petersen
> "Christoph" == hch@infradead org writes: Christoph> That's mostly because we don't support larger than 512 byte Christoph> TRIM payloads yet.. I did add support for that a few years back but all hell broke loose and we had to revert it. There were several drives that failed with more than

Re: [PATCH] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-17 Thread Mark Hounschell
On 07/16/2014 09:35 PM, Daeseok Youn wrote: > When a configration file is parsed with dgap_parsefile(), > makes nodes for saving configrations for board. > > Making a node will allocate node memory and strings for saving > configrations with kstrdup(). > > So these are freed when dgap is unloaded

[PATCH 1/2] staging: xillybus: Fix if-else coding style errors

2014-07-17 Thread Eli Billauer
According to Documentation/CodingStyle, when one branch of an if-else statement has multiple statements, both branches should be enclosed in curly brackets. Signed-off-by: Eli Billauer --- drivers/staging/xillybus/xillybus_core.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-)

[PATCH 2/2] staging: xillybus: Removed outdated part in README

2014-07-17 Thread Eli Billauer
The dedicated memory management routines have been replaced with devres API, so the related part is removed from the doc. Signed-off-by: Eli Billauer --- drivers/staging/xillybus/README | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/drivers/stagin

[PATCH] staging: gdm72xx: replace print_hex_dump_debug() with dev_dbg()

2014-07-17 Thread Michalis Pappas
Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_sdio.c | 15 +++ drivers/staging/gdm72xx/gdm_usb.c | 10 ++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c index 6a23bef..

[PATCH] staging: gdm72xx: remove debug code

2014-07-17 Thread Michalis Pappas
Removed dump_eth_packet() and helper functions called upon packet tx/rx. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 106 1 file changed, 106 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72x

[PATCH 2/4] drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: fix negativity check

2014-07-17 Thread Andrey Utkin
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]: (style) Checking if unsigned variable 'val' is less than zero. val = get_oneshot_mode(ipipeif->input); if (val < 0) { pr_err("ipipeif: links setup required"); return -EINVAL; } but static int get

[PATCH 3/4] drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c: drop incorrect checks

2014-07-17 Thread Andrey Utkin
Dropped some "< 0" and ">= 0" checks on unsigned int values. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501 Reported-by: David Binderman Signed-off-by: Andrey Utkin --- .../comedi/drivers/addi-data/hwdrv_apci3200.c| 20 ++-- 1 file changed, 10 insertions(+),

[PATCH 1/2] staging: unisys: simplify controlvm channel address function

2014-07-17 Thread Benjamin Romer
There is no reason to have controlvm_get_channel_address() defined in a separate file. Move it to visorchipset_main.c, remove the no-op functions controlvm_init() and controlvm_deinit() from visorchipset_main.c, and remove the controlvm.h and controlvm_direct.c files from the module. Signed-off-by

[PATCH 2/2] staging: unisys: detect controlvm channel on module load

2014-07-17 Thread Benjamin Romer
The controlvm channel is not removable from a guest after the guest starts, so it makes no sense to constantly check for it. Move the channel address discovery to visorchipset_init(), and remove all of the checks for the channel address from the rest of the module, as the module will not load if th

[PATCH 0/2] staging: unisys: ControlVM channel fixes

2014-07-17 Thread Benjamin Romer
These patches simplify the code in the visorchipset module, in preparation for moving the module's proc entries to sysfs. Benjamin Romer (2): staging: unisys: simplify controlvm channel address function staging: unisys: detect controlvm channel on module load drivers/staging/unisys/visorchip

[PATCH] staging: comedi: ni_670x: fix compile on ARCH=arm

2014-07-17 Thread H Hartley Sweeten
The kbuild test robot reported a build error on ARCH=arm about implicit declaration of the functions 'kmalloc' and 'kfree'. On ARCH=x86 the slab.h header is indirectly included by pci.h, this does not occur on ARCH=arm. Include slab.h directly instead of relying on some other header to include it

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:48, schrieb Arnd Bergmann: > AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take > a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff > to build on UML seems pointless to me and we special-case it in a number of > places already. If UM

This requires a private arrangement

2014-07-17 Thread Ms.Sarah C.Davis
Good Day, It is my desire to introduce this business to you and hoping you will take the opportunity for our mutual benefits. I contact you through this medium now in order to provide the link for detail discussion. I will provide more information with my personal resume for your acquaintance an

[PATCH 23/29] staging: comedi: adv_pci1724: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 07/29] staging: comedi: ni_labpc: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 20/29] staging: comedi: amplc_pci230: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 18/29] staging: comedi: comedi_test: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 10/29] staging: comedi: cb_pcidas64: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 21/29] staging: comedi: amplc_dio_common: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 06/29] staging: comedi: ni_mio_common: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 28/29] staging: comedi: hwdrv_apci1500: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 26/29] staging: comedi: hwdrv_apci3120: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 11/29] staging: comedi: icp_multi: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 29/29] staging: comedi: remove comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. All of the users of this function have been converted to use dev_err() directly. Remove the now unused function. Signed-off-by: H Hartl

[PATCH 19/29] staging: comedi: cb_pcidas: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 15/29] staging: comedi: das1800: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 12/29] staging: comedi: dt282x: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 03/29] staging: comedi: pcl816: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 02/29] staging: comedi: pcl818: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 00/29] staging: comedi: remove comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 05/29] staging: comedi: ni_pcidio: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 24/29] staging: comedi: adl_pci9118: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 01/29] staging: comedi: s626: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 27/29] staging: comedi: hwdrv_apci1564: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 17/29] staging: comedi: das08: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 16/29] staging: comedi: das16m1: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 13/29] staging: comedi: dt2814: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 22/29] staging: comedi: adv_pci_dio: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 09/29] staging: comedi: ni_660x: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 08/29] staging: comedi: ni_at_a2150: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 25/29] staging: comedi: addi_apci_3501: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 04/29] staging: comedi: pcl711: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 14/29] staging: comedi: dmm32at: remove use of comedi_error()

2014-07-17 Thread H Hartley Sweeten
The comedi_error() function is just a wrapper around dev_err() that adds the dev->driver->driver_name prefix to the message and a terminating new-line character. The addition of the driver_name is just added noise and some of the users of comedi_error() add unnecessary additional new-line character

[PATCH 3/5] staging: comedi: cb_pcidas64: remove unused pr_fmt() macro

2014-07-17 Thread H Hartley Sweeten
This macro is not used. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcid

[PATCH 0/5] staging: comedi: cleanup pr_{level} messages

2014-07-17 Thread H Hartley Sweeten
Where possible, convert all the pr_{level} messages to dev_{level}. H Hartley Sweeten (5): staging: comedi: usbduxfast: convert pr_err() to dev_err() staging: comedi: usbduxfast: convert pr_warn() to dev_warn() staging: comedi: cb_pcidas64: remove unused pr_fmt() macro staging: comedi: ni_

[PATCH 5/5] staging: comedi: comedi_fops: use pr_fmt()

2014-07-17 Thread H Hartley Sweeten
There are a number of pr_{level} messages in this file that are used to print kernel messages when the device pointer is not available for a dev_{level} message. Use pr_fmt() to ensure all of these messages have the module prefix. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-H

[PATCH 4/5] staging: comedi: ni_labpc: tidy up labpc_ai_scan_mode()

2014-07-17 Thread H Hartley Sweeten
This function checks the cmd->chanlist to determine the scan mode used to sample the analog inputs. All possible modes are checked so the final pr_err() and return 0 can never be reached. Tidy up the function a bit and remove the unreachable code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 2/5] staging: comedi: usbduxfast: convert pr_warn() to dev_warn()

2014-07-17 Thread H Hartley Sweeten
Use dev_warn() to output the warning message. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcimio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c b/drivers/staging/

[PATCH 1/5] staging: comedi: usbduxfast: convert pr_err() to dev_err()

2014-07-17 Thread H Hartley Sweeten
Use dev_err() to output the error message and remove the unnecessary pr_fmt() macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbduxfast.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH] staging: iio: adis16203: Use devm_iio_device_register

2014-07-17 Thread Himangi Saraogi
This patch introduces the use of iio_device_register and does away with the call to the corressponding unregister function in the probe and remove functions of the driver respectively. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/staging/iio/accel/adis16203_core.c | 3 +--

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Chris Metcalf
On 7/17/2014 7:28 AM, Chen Gang wrote: On 07/17/2014 06:48 PM, Arnd Bergmann wrote: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff to build on UML seems pointless to me and we special-case it in

Re: [PATCH] staging: iio: adis16203: Use devm_iio_device_register

2014-07-17 Thread Lars-Peter Clausen
On 07/17/2014 10:40 PM, Himangi Saraogi wrote: This patch introduces the use of iio_device_register and does away with the call to the corressponding unregister function in the probe and remove functions of the driver respectively. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall No, yo

[PATCH 10/13] staging: rtl8723au: rtl8723a_InitBeaconParameters(): Remove unused variable

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 5c4751c..8523908 100644 --- a/dr

[PATCH 11/13] staging: rtl8723au: ODM_IC_11N_SERIES is always true for SupportICType

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 142 +++--- drivers/staging/rtl8723au/include/odm.h | 4 - drivers/staging/rtl8723au/include/odm_interface.h | 11 +- 3 files changed, 75 insertions(+), 82 deletio

[PATCH 00/13] staging: rtl8723au: Remove more code obfuscation

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Greg, Another round of code obfuscation removal, mostly getting rid of no-op and unncessary wrappers. Cheers, Jes Jes Sorensen (12): staging: rtl8723au: Eliminate Set_MSR() wrapper call staging: rtl8723au: Reduce number of duplicate defines for link state staging: rtl

[PATCH 06/13] staging: rtl8723au: Remove no-op usb_AggSetting*()

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 50 - 1 file changed, 50 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 227a363..4161409 1006

[PATCH 01/13] staging: rtl8723au: Eliminate Set_MSR() wrapper call

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 18 +- drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 5

[PATCH 05/13] staging: rtl8723au: Remove write-only variable UsbRxHighSpeedMode

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 3 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_h

[PATCH 03/13] staging: rtl8723au: Use rtl8723au_set_media_status() to replace _InitNetworkType()

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Reduce yet another duplicate implementation of set_media_status() Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 13 + drivers/staging/rtl8723au/include/rtl8723a_spec.h | 8 2 files changed, 1 insertion(+), 20 deleti

[PATCH 07/13] staging: rtl88723au: Remove no-op _InitOperation_mode() function

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 4161409..0c760e5 100644 --- a/drivers/staging/r

[PATCH 09/13] staging: rtl8723au: Use proper name REG_CAMCMD and remove wrapper invalidate_cam_all23a()

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_wlan_util.c| 7 +-- drivers/staging/rtl8723au/hal/hal_com.c | 8 drivers/staging/rtl8723au/hal/usb_halinit.c | 2 +- drivers/staging/rtl8723au/include/hal_com.h | 2 +- d

[PATCH 13/13] staging: rtl8723au: Remove pointless IS_STA_VALID() macro

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 8 drivers/staging/rtl8723au/hal/odm_HWConfig.c | 2 +- drivers/staging/rtl8723au/include/odm.h | 4 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/stagin

[PATCH 12/13] staging: rtl8723au: Remove unused odm_RegDefine11AC.h

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- .../staging/rtl8723au/include/odm_RegDefine11AC.h | 49 -- drivers/staging/rtl8723au/include/odm_precomp.h| 1 - 2 files changed, 50 deletions(-) delete mode 100644 drivers/staging/rtl8723au/include/odm_RegDefine11AC.

[PATCH 04/13] rtl8723au: Corrections in the coding style

2014-07-17 Thread Jes . Sorensen
From: Raphael Silva Some corrections were made to the code in order to conform to the Kernel Coding Style. Jes: Fix build problem Signed-off-by: Raphael Silva Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 42 ++-- 1 file changed, 27 in

[PATCH 08/13] staging: rtl8723au: Remove RegBcnCtrlVal

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen The value saved in RegBcnCtrlVal was never used. In addition the code was highly endian broken, declaring it as a u32, then accessing it via a u8 * later. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 +- drivers/stagi

[PATCH 02/13] staging: rtl8723au: Reduce number of duplicate defines for link state

2014-07-17 Thread Jes . Sorensen
From: Jes Sorensen We use the MSR bits to define link state anyway, so no point having an additional two sets of defines for the same thing. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_ap.c | 8 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 112 +

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Arnd Bergmann
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote: > On 7/17/2014 7:28 AM, Chen Gang wrote: > > On 07/17/2014 06:48 PM, Arnd Bergmann wrote: > >> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take > >> a shortcut here and make COMPILE_TEST depend on !UML? Getting random s

Re: [PATCH] staging: iio: adis16203: Use devm_iio_device_register

2014-07-17 Thread Julia Lawall
On Thu, 17 Jul 2014, Lars-Peter Clausen wrote: > On 07/17/2014 10:40 PM, Himangi Saraogi wrote: > > This patch introduces the use of iio_device_register and does away with > > the call to the corressponding unregister function in the probe and > > remove functions of the driver respectively. > >

Re: question regarding drivers/staging/iio/adc/ad7280a.c

2014-07-17 Thread Greg Kroah-Hartman
On Thu, Jul 17, 2014 at 11:40:04PM +0530, Himangi Saraogi wrote: > Hi, > > I have sent in a patch for adding devm_kasprintf https://lkml.org/lkml/2014/7/ > 16/667. > I will be updating this file and send in a patch once it is accepted. Was it > the right thing > to do to send the devm_kasprintf pa

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-17 Thread KY Srinivasan
> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Friday, June 20, 2014 2:37 PM > To: Jens Axboe; James Bottomley; micha...@cs.wisc.edu > Cc: linux-s...@vger.kernel.org;

Re: [PATCH] xillybus: place 'else' on same line as '}'

2014-07-17 Thread Greg Kroah-Hartman
On Sun, Jul 13, 2014 at 08:07:00PM -0700, Jeremiah Mahler wrote: > Place 'else' on same line as closing brace '}' as per > Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl. > > Signed-off-by: Jeremiah Mahler > --- > drivers/staging/xillybus/xillybus_core.c | 3 +-- > 1 file chang

  1   2   >