[PATCH 09/10] staging: rtl8723au: Remove obfuscating wrapper ODM_ConfigMACWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 7 --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 3 +-- drivers/staging/rtl8723au/include/odm_HWConfig.h | 2 -- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/driv

[PATCH 08/10] staging: rtl8723au: Remove unused ODM_MacStatusQuery23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 9 - drivers/staging/rtl8723au/include/odm_HWConfig.h | 8 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl872

[PATCH 03/10] staging: rtl8723au: Eliminate wrapper ODM_ConfigRFWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 15 --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 6 ++ drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c| 8 ++-- drivers/staging/rtl8723au/include/odm_HWC

[PATCH 01/10] staging: rtl8723au: Remove horrendous code obfuscation READ_AND_CONFIG*()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723au/hal/odm_HWConfig.c index 82b1b83..388

[PATCH 05/10] staging: rtl8723au: Remove pointless wrappers for calling odm_ConfigRFReg_8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_RF.c | 5 +++-- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 14 -- drivers/staging/rtl8723au/include/odm_RegConfig8723A.h | 4 3 files changed, 3 insertions(+), 2

[PATCH 10/10] staging: rtl8723au: Remove unncessary wrapper PHY_RFConfig8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c| 12 drivers/staging/rtl8723au/hal/usb_halinit.c| 4 ++-- drivers/staging/rtl8723au/include/Hal8723APhyCfg.h | 1 - 3 files changed, 2 insertions(+), 15 deletions(-) di

[PATCH 04/10] staging: rtl8723au: Remove zero value calculation added to address

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c b/drivers/staging/rtl8723au/hal/odm_RegConfig8723

[PATCH 02/10] staging: rtl8723au: Call to ODM_ConfigRFWithHeaderFile23a path is identical for RF_PATH_[AB]

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c index c30bd23..6686a29 100644 --- a/dri

[PATCH 06/10] staging: rtl8723au: Remove unused ODM_ReadAndConfig_PHY_REG_PG_8723A() and related code+data

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/HalHWImg8723A_BB.c | 160 - drivers/staging/rtl8723au/hal/odm_RegConfig8723A.c | 28 .../staging/rtl8723au/include/HalHWImg8723A_BB.h | 6 - .../staging/rtl8723au/include/odm_RegConf

[PATCH 00/10] staging-next: rtl8723au: Reducing code obfuscation

From: Jes Sorensen Greg, Please find attached another smaller set of changes for the rtl8723au driver. IT's mainly removing code obfuscation in the hal layer. Cheers, Jes Jes Sorensen (10): staging: rtl8723au: Remove horrendous code obfuscation READ_AND_CONFIG*() staging: rtl8723au: Ca

[PATCH 07/10] staging: rtl8723au: Remove ugly wrapper ODM_ConfigBBWithHeaderFile23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 16 drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 10 ++ drivers/staging/rtl8723au/include/odm.h | 8 drivers/staging/rtl8723au/include/odm_HWCo

Re: [PATCH] staging: iio: adc: ad7192: fix coding style

On 12/07/14 20:16, Marcus Folkesson wrote: Line over 80 characters. This is for Eudyptula Challenge. Signed-off-by: Marcus Folkesson Sorry Marcus, There is a level of trivial cleanup below which it's not worth taking patches. The 80 character limit is not a hard and fast rule. Here, if this h

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

As I said before, some configurations don't make sense. I don't think all of the patches are necessary. Best, Lennox 2014-07-13 11:45 GMT+08:00 Marek Vasut : > On Sunday, July 13, 2014 at 05:07:10 AM, Chen Gang wrote: >> Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. >

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

Am 13.07.2014 11:27, schrieb Lennox Wu: > As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support iomem. Thanks, //richard

Re: [PATCH V3 0/7] Drivers: scsi: storvsc: Bug fixes and improvements

The series looks good to me, although I'll probably put the commit message for the timer patch into the comment for the eh_timed_out handler. Can I get another set of reviews? I've seen Olaf has put them into the SLES tree, so I'd expect he's done a review already? __

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 05:45 PM, Richard Weinberger wrote: > Am 13.07.2014 11:27, schrieb Lennox Wu: >> As I said before, some configurations don't make sense. > > If such a configuration can be achieved using allmod/yesconfig it has to be > fixed. > Chen's fixes seem reasonable as not all architectures s

PLEASE HELP THEM WITH THE MONEY

Good day Private Message to you, Greetings to you in the name of our heavenly God. This mail might come to you as a surprise and the temptation to ignore it could come into your mind, but please, consider it as a Divine Wish of God and accept it with a deep sense of humility. My Name is Isabell

[PATCH] drivers/staging/iio/adc/Kconfig: Let MXS_LRADC depend on HAS_IOMEM

MXS_LRADC need HAS_IOMEM, so let it depend on HAS_IOMEM The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: "devm_ioremap_resource" [drivers/staging/iio/adc/mxs-lradc.ko] undefined! Signed-off-by: Chen Gang --- drivers/staging/iio/adc/Kconfig | 2 +- 1 file c

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "KY" == KY Srinivasan writes: KY> Windows hosts do support UNMAP and set the field in the KY> EVPD. However, since the host advertises SPC-2 compliance, Linux KY> does not even query the VPD page. >> If we want to enable UNMAP in this case I'd prefer a blacklist entry >> than trying UNMAP

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support io

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: > On 07/13/2014 11:45 AM, Richard Weinberger wrote: >> Am 13.07.2014 11:27, schrieb Lennox Wu: >>> As I said before, some configurations don't make sense. >> >> If such a configuration can be achieved using allmod/yesconfig it has to be >> fixed. >>

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I said before, some configurations don't make sense. If such a configuration can be achieved using a

Re: [PATCH] drivers/staging/iio/adc/Kconfig: Let MXS_LRADC depend on HAS_IOMEM

On Sunday, July 13, 2014 at 01:44:38 PM, Chen Gang wrote: > MXS_LRADC need HAS_IOMEM, so let it depend on HAS_IOMEM > > The related error (with allmodconfig under score): > > MODPOST 1365 modules > ERROR: "devm_ioremap_resource" [drivers/staging/iio/adc/mxs-lradc.ko] > undefined! > > > Si

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: > On 07/13/2014 03:40 PM, Richard Weinberger wrote: >> Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: >>> On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: > As I said before, some configurations don

[PATCH] staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure --- drivers/staging/android/binder.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 04:03 PM, Richard Weinberger wrote: Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: On 07/13/2014 11:45 AM, Richard Weinberger wrote: Am 13.07.2014 11:27, schrieb Lennox Wu: As I

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 11:14 AM, Chen Gang wrote: [...] > And also find a compiler issue, I will try to fix it, but shall not notify > kernel mailing list, again. The related issue is below (it seems a kernel > issue, but in fact, it is a compiler's issue): > > CC [M] drivers/staging/lustre/lustre/ptl

[PATCH 01/16] staging: rtl8188eu: Remove unused function rtw_use_tkipkey_handler()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_security.c| 25 -- drivers/staging/rtl8188eu/include/rtw_security.h |1 - 2 files changed, 26 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/cor

[PATCH 07/16] staging: rtl8188eu: Remove unused function rtw_set_802_11_remove_wep()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 25 - drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - 2 files changed, 26 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/c

[PATCH 04/16] staging: rtl8188eu: Remove unused function rtw_validate_ssid()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 26 - drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - 2 files changed, 27 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/c

[PATCH 06/16] staging: rtl8188eu: Remove unused function rtw_set_802_11_remove_key()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 38 - drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |2 -- 2 files changed, 40 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/

[PATCH 03/16] staging: rtl8188eu: Remove unused function rtw_set_scan_mode()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 17 - drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/core/

[PATCH 05/16] staging: rtl8188eu: Remove unused function rtw_set_802_11_add_key()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 352 - drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - 2 files changed, 353 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/rtl8188eu/

[PATCH 02/16] staging: rtl8188eu: Remove function rtw_set_channel_plan()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c| 15 +-- drivers/staging/rtl8188eu/include/rtw_ioctl_set.h |1 - 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c b/drivers/staging/r

[PATCH 09/16] staging: rtl8188eu: Remove unused function rtw_get_timestampe_from_ie()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c|5 - drivers/staging/rtl8188eu/include/rtw_mlme.h |1 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c index 1eef47d..33

[PATCH 11/16] staging: rtl8188eu: Rename _rtw_find_network() to rtw_find_network()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 14 +- drivers/staging/rtl8188eu/include/rtw_mlme.h |5 - 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/cor

[PATCH 08/16] staging: rtl8188eu: Remove unused function _rtw_IOL_append_WW_cmd()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_iol.c| 14 -- drivers/staging/rtl8188eu/include/rtw_iol.h |2 -- 2 files changed, 16 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index e6fd

[PATCH 12/16] staging: rtl8188eu: Make _rtw_free_network() static

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c|2 +- drivers/staging/rtl8188eu/include/rtw_mlme.h |3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c i

[PATCH 13/16] staging: rtl8188eu: Remove unused function _rtw_dequeue_network()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 19 --- drivers/staging/rtl8188eu/include/rtw_mlme.h |2 -- 2 files changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c

[PATCH 10/16] staging: rtl8188eu: Rename _rtw_free_network_queue() to rtw_free_network_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c|8 +--- drivers/staging/rtl8188eu/include/rtw_mlme.h |2 -- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme

[PATCH 14/16] staging: rtl8188eu: Remove unused function _rtw_enqueue_network()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c| 15 --- drivers/staging/rtl8188eu/include/rtw_mlme.h |2 -- 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c inde

[PATCH 16/16] staging: rtl8188eu: Rename _rtw_init_mlme_priv() to rtw_init_mlme_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c|9 + drivers/staging/rtl8188eu/include/rtw_mlme.h |3 --- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_

[PATCH 15/16] staging: rtl8188eu: Rename _rtw_free_mlme_priv() to rtw_free_mlme_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c|8 +--- drivers/staging/rtl8188eu/include/rtw_mlme.h |2 -- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlm

[PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

Some of architectures have already defined 'die' as macro, so can not use this common name as declaration in other modules, or will cause compiling issue. So use more precise name 'force_die' (like 'wrap_bulk') instead of. The related error (with allmodconfig under score): CC [M] drivers/sta

[RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Signed-off-by: Lucas Tanure --- drivers/staging/android/binder.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/13/2014 10:25 PM, Lars-Peter Clausen wrote: > On 07/13/2014 04:03 PM, Richard Weinberger wrote: >> Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: >>> On 07/13/2014 03:40 PM, Richard Weinberger wrote: Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: > On 07/13/2014 11:45 AM, Richard

[PATCH 1/2] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Based on latests staging-next. drivers/staging/vt6656/baseband.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a

[PATCH 2/2] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Based on latest staging-next. drivers/staging/vt6656/main_usb.c | 118 +- 1 file changed, 54 insertions(+), 64 deletions(-) di

[PATCH] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Additionally this typedef was removed from card.h: typedef enum _CARD_PHY_TYPE { PHY_TYPE_AUTO = 0, PHY_TYPE_11B, PHY_TYPE_11G, PHY_TYPE_11A } CARD_PHY_TYPE, *PCARD_PHY_TYPE; Tested by compilation only. Signed-off-by

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote: > Kernel coding style. Remove useless else statement after return. > > Signed-off-by: Lucas Tanure > --- > drivers/staging/android/binder.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) Why the

[PATCH] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. This patch change the following enums: - typedef enum __device_msg_level - typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Made against latest staging-next. drivers/staging/vt

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

I missed on trailing whitespace in first patch. Didn't saw a ERROR: trailing whitespace in the first patch. Sorry, Thanks -- Lucas Tanure +55 (19) 988176559 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mail

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 01:38:45PM -0300, Lucas Tanure wrote: > I missed on trailing whitespace in first patch. > Didn't saw a ERROR: trailing whitespace in the first patch. Ok. Please, always say that this is a 'v2' patch, and what the difference is between this one, and the previous version, ot

Re: Anybody working on ced1401?

On Fri, Jun 27, 2014 at 05:11:45PM +0200, Luca Ellero wrote: > Hi Greg, > > On 27/06/2014 16:55, Greg KH wrote: > >On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote: > >>Il 26/06/2014 21:23, Greg KH ha scritto: > >>>On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois Schloegl wrote: > On

Re: [PATCH v3 1/5] staging:iio:hmc5843: Added regmap support

On 08/07/14 14:38, Josef Gajdusek wrote: This patch changes hmc5843.c to use regmap. This provides transparent caching to the code as well as abstraction necessary to add support for SPI-based hmc5983. Signed-off-by: Josef Gajdusek Applied to the togreg branch of iio.git. Ideally we would hav

RE: [PATCH V3 0/7] Drivers: scsi: storvsc: Bug fixes and improvements

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Sunday, July 13, 2014 2:51 AM > To: KY Srinivasan > Cc: jasow...@redhat.com; a...@canonical.com; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels.com;

Re: [PATCH v3 2/5] staging:iio:hmc5843: Split hmc5843.c to multiple files

On 08/07/14 14:39, Josef Gajdusek wrote: This patch splits hmc5843.c to multiple files - the interface-agnostic hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is another step to add support of SPI-enabled hmc5983. Signed-off-by: Josef Gajdusek Something rather odd i

Re: [PATCH] drivers/staging/iio/adc/Kconfig: Let MXS_LRADC depend on HAS_IOMEM

On 13/07/14 14:27, Marek Vasut wrote: On Sunday, July 13, 2014 at 01:44:38 PM, Chen Gang wrote: MXS_LRADC need HAS_IOMEM, so let it depend on HAS_IOMEM The related error (with allmodconfig under score): MODPOST 1365 modules ERROR: "devm_ioremap_resource" [drivers/staging/iio/adc/mxs-lr

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Sunday, July 13, 2014 5:59 AM > To: KY Srinivasan > Cc: h...@infradead.org; James Bottomley; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org

Re: [PATCH 2/2] staging: vt6556: Cleanup coding style issues

On Sun, Jul 13, 2014 at 05:39:55PM +0200, Peter Senna Tschudin wrote: > This patch cleanup coding style issues reported by checkpatch. > > Tested by compilation only. > > Signed-off-by: Peter Senna Tschudin > --- > Based on latest staging-next. You just sent me 4 patches, all with the same subj

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote: > Some of architectures have already defined 'die' as macro, so can not use > this common name as declaration in other modules, or will cause compiling > issue. So use more precise name 'force_die' (like 'wrap_bulk') instead of. > > The re

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote: > Kernel coding style. Remove useless else statement after return. > > Signed-off-by: Lucas Tanure > --- > drivers/staging/android/binder.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) You did

[PATCH V2 2/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/main_usb.c | 118 +-

[PATCH V2 3/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Additionally this typedef was removed from card.h: typedef enum _CARD_PHY_TYPE { PHY_TYPE_AUTO = 0, PHY_TYPE_11B, PHY_TYPE_11G, PHY_TYPE_11A } CARD_PHY_TYPE, *PCARD_PHY_TYPE; Tested by compilation only. Signed-off-by

[PATCH V2 4/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. This patch change the following enums: - typedef enum __device_msg_level - typedef enum __DEVICE_NDIS_STATUS Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Mad

[PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/baseband.c | 28 1 file cha

RE: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote: > Use the addi_watchdog module to provide support for the watchdog > subdevice. > > Also, rearrange the subdevice init blocks so that the order makes sense. > Digital input/output subdevices and subdevices for DI/DO interrupt > support, fol

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: > On 07/13/2014 04:03 PM, Richard Weinberger wrote: > >Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: > >>On 07/13/2014 03:40 PM, Richard Weinberger wrote: > >>>Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: > On 07/13/2014

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: > This patch cleanup coding style issues reported by checkpatch. > > Tested by compilation only. > > Signed-off-by: Peter Senna Tschudin > --- > Cahnges from V1: > - Sent all patches in a series Why did you forget the other

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: > On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: >> On 07/13/2014 04:03 PM, Richard Weinberger wrote: >>> Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: On 07/13/2014 03:40 PM, Richard Weinberger wrote: > Am 13.07.2014

Re: [RESEND PATCH] staging: android: Clean up binder_send_failed_reply

Sorry, I didn't know. I will fix. Thanks -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 4:07 PM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 11:49:29AM -0300, Lucas Tanure wrote: >> Kernel coding style. Remove useless else statement after return. >> >> Signed-off-by: Lucas T

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: > Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: > > On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: > >> On 07/13/2014 04:03 PM, Richard Weinberger wrote: > >>> Am 13.07.2014 15:56, schrieb Lars-Peter Clausen

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote: >> Some of architectures have already defined 'die' as macro, so can not use >> this common name as declaration in other modules, or will cause compiling >> issue. So use more precise name

[PATCH] Staging: rtl8821ae: fix coding style issues in cam.c Fix all coding style error and warnings in cam.c reported by checkpatch.pl

Signed-off-by: Joerg C. Meyer --- drivers/staging/rtl8821ae/cam.c | 57 +++-- 1 file changed, 27 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c index 3bc6b3d..835bc3b 100644 --- a/drivers/staging/r

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On 07/14/2014 05:41 AM, Chen Gang wrote: > On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote: >> On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote: >>> Some of architectures have already defined 'die' as macro, so can not use >>> this common name as declaration in other modules, or will caus

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On 07/14/2014 06:31 AM, Chen Gang wrote: > On 07/14/2014 05:41 AM, Chen Gang wrote: >> On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote: >>> On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote: Some of architectures have already defined 'die' as macro, so can not use this common nam

Re: [PATCH] Staging: rtl8821ae: fix coding style issues in cam.c Fix all coding style error and warnings in cam.c reported by checkpatch.pl

On Sun, Jul 13, 2014 at 11:47:57PM +0200, Joerg C. Meyer wrote: > Signed-off-by: Joerg C. Meyer Your changelog body ended up in the Subject: line (that happens if you don't put a blank line after the first line in your git commit. Also, you don't say _what_ issues you fixed here, please be speci

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On Mon, Jul 14, 2014 at 06:38:24AM +0800, Chen Gang wrote: > On 07/14/2014 06:31 AM, Chen Gang wrote: > > On 07/14/2014 05:41 AM, Chen Gang wrote: > >> On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote: > >>> On Sun, Jul 13, 2014 at 10:50:55PM +0800, Chen Gang wrote: > Some of architectures hav

Re: [PATCH] drivers: staging: lustre: Use 'force_die' instead of 'die' to avoid compiling issue

On 07/14/2014 06:50 AM, Greg Kroah-Hartman wrote: > On Mon, Jul 14, 2014 at 06:38:24AM +0800, Chen Gang wrote: >> On 07/14/2014 06:31 AM, Chen Gang wrote: >>> On 07/14/2014 05:41 AM, Chen Gang wrote: On 07/14/2014 03:05 AM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 10:50:55PM +08

[PATCH v3] staging: android: Clean up else statement from binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration of "struct binder_transaction *next" made outside of while, and initialized with NULL. Signed-off-by: Lucas Tanure --- drivers/staging/android/binder

Re: [PATCH v3] staging: android: Clean up else statement from binder_send_failed_reply

On Sun, Jul 13, 2014 at 08:25:13PM -0300, Lucas Tanure wrote: > Kernel coding style. Remove useless else statement after return. > Changes from v1 and v2: Fix warning for mixed declarations and code. > Declaration of "struct binder_transaction *next" made outside of while, > and initialized with NU

[PATCH v4] staging: android: Clean up else statement from binder_send_failed_reply

Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration of "struct binder_transaction *next" made outside of while. Changes from v3: Removed initialization to NULL for next variable. Signed-off-by: Lucas Tan

Re: [PATCH v3] staging: android: Clean up else statement from binder_send_failed_reply

Ok. I will do it. 4th could be the right one =p. Thanks for your time Cheers -- Lucas Tanure +55 (19) 988176559 On Sun, Jul 13, 2014 at 9:13 PM, Greg Kroah-Hartman wrote: > On Sun, Jul 13, 2014 at 08:25:13PM -0300, Lucas Tanure wrote: >> Kernel coding style. Remove useless else statement after

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> -Original Message- > From: KY Srinivasan > Sent: Sunday, July 13, 2014 11:50 AM > To: 'Martin K. Petersen' > Cc: h...@infradead.org; James Bottomley; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org; > linux-s...@vger.kernel.org; o

[PATCH] xillybus: place 'else' on same line as '}'

Place 'else' on same line as closing brace '}' as per Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl. Signed-off-by: Jeremiah Mahler --- drivers/staging/xillybus/xillybus_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xillybus/xilly

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

On Sun, Jul 13, 2014 at 2:17 PM, Hartley Sweeten wrote: > On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote: >> Use the addi_watchdog module to provide support for the watchdog >> subdevice. >> >> Also, rearrange the subdevice init blocks so that the order makes sense. >> Digital input/out

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev- > devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Sunday, July 13, 2014 7:38 PM > To: Martin K. Petersen > Cc: linux-s...@vger.kernel.org; jasow...@redhat.com; linux- >

Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. In this version

Re: [PATCH V3 2/7] Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the Host

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: Set cmd_per_lun to reflect value supported by the Host. In this version of the patch I have addressed comments from Christoph Hellwig Signed-off-by: K. Y. Srinivasan Cc: --- drivers/scsi/storvsc_drv.c |2 +- 1 files changed, 1 insertions(

Re: [PATCH V3 4/7] Drivers: scsi: storvsc: Fix a bug in handling VMBUS protocol version

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: Based on the negotiated VMBUS protocol version, we adjust the size of the storage protocol messages. The two sizes we currently handle are pre-win8 and post-win8. In WS2012 R2, we are negotiating higher VMBUS protocol version than the win8 version.

Re: [PATCH V3 3/7] Drivers: scsi: storvsc: Filter commands based on the storage protocol version

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: Going forward it is possible that some of the commands that are not currently implemented will be implemented on future Windows hosts. Even if they are not implemented, we are told the host will corrrectly handle unsupported commands (by returning a

Re: [PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: On Azure, we have seen instances of unbounded I/O latencies. To deal with this issue, implement handler that can reset the timeout. Note that the host gaurantees that it will respond to each command that has been issued. Signed-off-by: K. Y. Srini

Re: [PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR. Correctly handle this. Note that there is sufficient sense information to support scsi error handling even in this case. In this version of the patch I have addressed co

Re: [PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases

On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the Windows host require this. The host validates the command and SRB flags prior to passing the command down to native driver stack. Signed-off-by: K. Y. Srinivasan Cc: --

Re: [PATCH] xillybus: place 'else' on same line as '}'

Hi, Thanks for this. And since I looked at the part in Codingstyle that deals with if-else, I found another few mistakes regarding braces around a single statement. The rules say, it turns out, that if one of the clauses in an if-else is longer than one statement, both clauses should be wrapp