Hi Pawel,
Am Samstag, 5. Juli 2014, 22:30:54 schrieb Pawel Lebioda:
> The following patches fix some warnings reported by checkpatch.pl
>
> Pawel Lebioda (2):
> staging: nvec: remove unnecessary 'else' after 'return' statement
> staging: nvec: remove unneccessary 'out of memory' message
>
>
If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m:
drivers/built-in.o: In function `solo_osd_print':
(.text+0x1c7a1f): undefined reference to `byte_rev_table'
make: *** [vmlinux] Error 1
Reported-by: kbuild test robot
Signed-off-by: Geert Uytterhoeven
---
drivers/staging/media/solo6x10
CC kbuild test robot
On Sun, Jul 6, 2014 at 10:58 AM, Geert Uytterhoeven
wrote:
> If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m:
>
> drivers/built-in.o: In function `solo_osd_print':
> (.text+0x1c7a1f): undefined reference to `byte_rev_table'
> make: *** [vmlinux] Error 1
>
> Reporte
On Sun, Jul 6, 2014 at 10:59 AM, Geert Uytterhoeven
wrote:
> CC kbuild test robot
Doh, this time for real...
> On Sun, Jul 6, 2014 at 10:58 AM, Geert Uytterhoeven
> wrote:
>> If CONFIG_SOLO6X10=y, but CONFIG_BITREVERSE=m:
>>
>> drivers/built-in.o: In function `solo_osd_print':
>> (.tex
From: Sami Laine
Sparse warning corrections for:
drivers/staging/rtl8821ae/base.c:1370:16: warning: symbol
'rtl_make_smps_action' was not declared. Should it be static?
drivers/staging/rtl8821ae/base.c:1543:6: warning: symbol 'rtl_find_221_ie' was
not declared. Should it be static?
drivers/sta
From: Sami Laine
Sparse warning correction:
vers/staging/rtl8821ae/debug.c:80:23: warning: symbol 'proc_topdir' was
not declared. Should it be static?
Signed-off-by: Sami Laine
---
diff --git a/drivers/staging/rtl8821ae/debug.c b/drivers/staging/rtl8821ae/debug
index 8aefbf1..e4a19ba 100644
--
On 04-07-2014 22:30:27, Pawel Lebioda wrote:
> Hi,
>
> This patch fixes almost all 'missing blank line after declaration'
> warnings reported by checkpatch.pl for drivers/staging/bcm.
>
> Regards
> Pawel Lebioda
>
> Signed-off-by: Pawel Lebioda
> drivers/staging/bcm/CmHost.c| 1 +
> dr
Use standard dynamic debug features instead of relying on the custom
configuration option CONFIG_RTS5208_DEBUG and a series of home grown
macros.
Fabio Falzoi (4):
Use standard pr_debug instead of a custom macro
Use standard print_hex_dump_debug instead of a custom macro
Remove CONFIG_RTS520
Use print_hex_dump_debug to have memory properly dumped only when dynamic
debug is enabled.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 6 --
drivers/staging/rts5208/rtsx_chip.c | 6 --
drivers/staging/rts5208/rtsx_scsi.c | 10 +-
drivers/staging/rts52
Fix an incorrect use of the %d format specifier in dev_err that caused a
warning.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 4f5f7a3.
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208/
Have I to fix just the commit message or is this behaviour not suitable?
In the latter case, could you please suggest a way to fix this?
Thank you,
Fabio
On Sun, Jul 6, 2014 at 6:23 PM, Joe Perches wrote:
> On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote:
>> Use print_hex_dump_debug to hav
On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote:
> Have I to fix just the commit message or is this behaviour not suitable?
> In the latter case, could you please suggest a way to fix this?
Hi Fabio.
I think it's not appropriate.
I'd've changed it to something like:
#if DEBUG
#define rtsx_
On Sat, Jul 5, 2014 at 8:39 PM, Greg KH wrote:
> On Sat, Jul 05, 2014 at 04:37:37PM +0100, Alan Cox wrote:
>> On Fri, 2014-07-04 at 21:48 +0300, Kristina Martšenko wrote:
>> > Hi,
>> >
>> > I'm going over some "older" drivers in the staging tree and wanted to
>> > ask about cptm1217 and ste_rmi4.
With the 3.14 kernel Hyper-V no longer reliably enables its networking
devices in time on cloud images leading to network devices permanently
remaining offline.
After a painful round of bisection I've narrowed this down to commit
b679ef73edc251f6d200a7dd2396e9fef9e36fc3 :
# bad: [455c6fdbd219161b
Hi,
I am having a problem with this driver on an Wondermedia 8850
computer. I can get it work, it can scan all the wireless networks but
cannot connect to them.
Do you have any suggestions about what to try? If you want I can
attach you the dmesg output having loaded the driver with higher debug
le
Null checks for tty, un and ch are already done by caller,
so replace parameter "tty" with "ch" and "un".
And also use a pointer for returning new bytes_available instead of
return variable.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 29 +++--
1 file
On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote:
> Use print_hex_dump_debug to have memory properly dumped only when dynamic
> debug is enabled.
Not true.
Now it prints all the time when !CONFIG_DYNAMIC_DEBUG
and CONFIG_PRINTK.
> diff --git a/drivers/staging/rts5208/trace.h b/drivers/stagin
On Sat, Jul 05, 2014 at 10:30:55PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: else is not generally useful after a break or return
> 235: FILE: drivers/staging/nvec/nvec.c:235
>
> Signed-off-by: Pawel Lebioda
> ---
> drivers/staging/nvec/nvec
On Sat, Jul 05, 2014 at 10:30:56PM +0200, Pawel Lebioda wrote:
> Fix the following warning reported by checkpatch.pl:
>
> WARNING: Possible unnecessary 'out of memory' message
> 811: FILE: drivers/staging/nvec/nvec.c:811
>
> Signed-off-by: Pawel Lebioda
> ---
> drivers/staging/nvec/nvec.c | 5 +
20 matches
Mail list logo
