There are two functions used for the 'get_enable' callback, s626_get_enable_a()
function is used for the channel 0-2 encoders and s626_get_enable_b() is used
for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_enable() function and use the
encoder channel number to hand
There are two functions used for the 'set_load_trig' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_set_load_trig() function and use
the encoder channel number to handle the differences.
Remove the then
There are two functions used for the 'pulse_index' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_pulse_index() function and use
the encoder channel number to handle the differences.
Remove the then unne
Add the comedi "chan" number to the encoder private data so we can then
remove some of the members of the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 8
1 file changed, 8 insertions(+)
diff --git a/d
The struct s626_enc_info is used in this driver to defined the callbacks and
other data needed to handle each encoder "channel". These "channel" numbers
are the same as the comedi_subdevice channels.
The channels specific stuff can easily be handled run-time by just using
the subdevice channel num
There are two functions used for the 'reset_cap_flags' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_reset_cap_flags() function and use
the encoder channel number to handle the differences.
Remove the t
Abosorb the s626_read_latch() helper and tidy up this function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 43 ++-
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/sta
Redefining the Counter Preload/Latch registers as a macro that calculates
the register offset based on the comedi channel number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 12 ++--
drivers/staging/comedi/drivers/s
The only member left in this struct is the 'chan' which is the
comedi channel of the encoder.
Remove the struct and refactor the code to pass/use the comedi
channel instead.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 334
There are two functions used for the 'get_load_trig' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_load_trig() function and use
the encoder channel number to handle the differences.
Remove the then
There are two functions used for the 'get_mode' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Add a helper function, s626_get_mode(), that uses the encoder channel number
to determine which function to call.
Remove the then unnecessary 'get_mode' m
Start cleaning up the 'struct s626_enc_info' by redefining the my_cra
and my_crb members based on the comedi channel number.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 24
drivers/staging/comedi/dr
There are two functions used for the 'set_mode' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Add a helper function, s626_set_mode(), that uses the encoder channel number
to determine which function to call.
Remove the then unnecessary 'set_mode' m
This member of the encoder private data can be calculated based on
the comedi channel stored in the 'chan' member of the private data.
Do that instead and remove the unnecessary member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s6
There are two functions used for the 'get_int_src' callback. One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_get_int_srsc() function and use
the encoder channel number to handle the differences.
Remove the then unn
There are two functions used for the 'set_int_src' callback, One is used for
the channel 0-2 encoders and the other for the channel 3-5 encoders.
Refactor the two callbacks into a single s626_set_int_src() function and use
the encoder channel number to handle the differences.
Remove the then unne
On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote:
> On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> > The function iwctl_siwscan() is defined in iwctl.c as:
> > int iwctl_siwscan(struct net_device *dev,
> > struct iw_request_info *info,
> >
On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote:
> Greg Kroah-Hartman writes:
>
> > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> >> All of the code is #if 0'd out, and the change just replaces a
> >> space with a newline, so this obviously doesn't change an
This is all #if 0'ed out, and it contains some rather weird stuff
(post-increment of a bool, for example). Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl88
On Friday, June 20, 2014 09:19:07 PM Xose Vazquez Perez wrote:
> Kristina wrote:
>
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving rtl8712 out of staging in
> > over a year. Are there any plans to clean it up and move it o
From: Ramesh Basukala
Attached is a patch which fixes coding style warning message while
running checkpatch script.
This patch is currently against a linux 3.15.0-rc15-next kernel. I am
submitting this patch as a part of Eudyptula Challenge task.
Signed-off-by: Ramesh Basukala
--- xlr_net.c
> -Original Message-
> From: Jens Axboe [mailto:ax...@kernel.dk]
> Sent: Friday, June 6, 2014 11:23 AM
> To: James Bottomley; micha...@cs.wisc.edu
> Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
> de...@linuxdriverproject.org; a...@canonical.com; KY Srinivasan; linux-
> s...@vger.
On Fri, Jun 20, 2014 at 12:40:40PM -0700, Greg KH wrote:
> On Fri, Jun 20, 2014 at 03:02:11PM -0400, Kevin McKinney wrote:
> > On Fri, Jun 20, 2014 at 11:46:06AM -0700, Greg KH wrote:
> > > On Fri, Jun 20, 2014 at 02:07:32PM -0400, Kevin McKinney wrote:
> > > > On Fri, Jun 20, 2014 at 1:13 PM, Step
This patch fixes the following checkpatch.pl issue in
ft1000/ft1000-pcmcia/ft1000_dnld.c
ERROR: code indent should use tabs where possible
Signed-off-by: Quentin Lee
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
Thanks for the feedback I will resend the patch fixed.
Otherwise please use Larry's idea.
Cheers Nick
On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
>> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
>> > Rewrites the
Is this patch being merged or is this not an issue. I am confused
did I make a mistake in my patch or is there being a different
patch being merged.
Thank Nick
On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote:
> On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote:
>> Thanks for the feedback I
The functions iwctl_giwscan() and iwctl_siwscan() are only referenced
within iwctl.c -- so, remove their function declarations from iwctl.h
and mark these functions as static.
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.c |4 ++--
drivers/staging/vt6655/iwctl.h | 10
On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote:
> Thanks for the feedback I will resend the patch fixed.
Please do not.
> Otherwise please use Larry's idea.
It's not Larry's idea. Larry is the primary
contributor for Realtek drivers in staging.
__
201 - 228 of 228 matches
Mail list logo
