[PATCH] staging: omap4iss: copy paste error in iss_get_clocks

2014-06-05 Thread Vitaly Osipov
It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The current code looks like an oversight in pasting the block just above this one. Signed-off-by: Vitaly Osipov --- drivers/staging/media/omap4iss/iss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH] staging: comedi: describe members involved when reading/writing buffer

2014-06-05 Thread Ian Abbott
Signed-off-by: Ian Abbott --- I was originally going to put it in comedidev.h but as that gets passed through the compiler more often, I thought it would be better in comedi_buf.c. --- drivers/staging/comedi/comedi_buf.c | 60 + 1 file changed, 60 insertions(+)

Re: [PATCH 0/3] staging: comedi: ni_stc.h: cleanup the ni_private data

2014-06-05 Thread Ian Abbott
On 2014-05-29 18:56, H Hartley Sweeten wrote: The comedi drivers that use the ni_mio_common.c source share a private data struct. This struct is defined in ni_stc.h as a macro so that the real driver can add additional members to the struct. These additional members are not actually needed since

Re: [PATCH v2 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

2014-06-05 Thread Ian Abbott
On 2014-06-04 03:32, Chase Southwood wrote: This patchset introduces a new private data struct for this driver, adds all of the code required to support Change-of-State interrupts for the digital input subdevice, and finally fixes apci1564_interrupt() to service this type of interrupt correctly.

[PATCH v2 1/2] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include/vbus

[PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../staging/unisys/common-spar/include/channels/vbuschannel.h | 11 ++- drivers/staging/unisys/com

[PATCH v2 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings. In the first patch, we clean up the function names so they are acceptable then we add the new functions in the second patch. __

Re: [PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Greg KH
On Thu, Jun 05, 2014 at 11:04:32AM -0500, Ken Cox wrote: > Added I/O versions for the functions vbuschannel_devinfo_to_string() > and ultra_vbus_init_channel() to get rid of noderef sparse warnings when > accessing I/O space. > > Signed-off-by: Ken Cox > --- > .../staging/unisys/common-spar/incl

Re: [PATCH v2 2/2] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
On 06/05/2014 11:22 AM, Greg KH wrote: On Thu, Jun 05, 2014 at 11:04:32AM -0500, Ken Cox wrote: Added I/O versions for the functions vbuschannel_devinfo_to_string() and ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../s

video_omap4 and control module access (was ... from opensuse-arm list)

2014-06-05 Thread Nishanth Menon
Full thread in opensuse mailing list: http://lists.opensuse.org/archive/opensuse-arm/2014-06/msg4.html Moving this thread out of opensuse to kernel public lists +CC of maintainers relevant to the control module/clk. On 06/05/2014 11:17 AM, Nishanth Menon wrote: > On 06/05/2014 10:56 AM, Laur

Re: video_omap4 and control module access (was ... from opensuse-arm list)

2014-06-05 Thread Matwey V. Kornilov
2014-06-05 20:47 GMT+04:00 Nishanth Menon : > Full thread in opensuse mailing list: > > http://lists.opensuse.org/archive/opensuse-arm/2014-06/msg4.html > > Moving this thread out of opensuse to kernel public lists +CC of > maintainers relevant to the control module/clk. Full build log (600KB)

Re: video_omap4 and control module access (was ... from opensuse-arm list)

2014-06-05 Thread Laurent Pinchart
Hi Nishanth, On Thursday 05 June 2014 11:47:19 Nishanth Menon wrote: > Full thread in opensuse mailing list: > > http://lists.opensuse.org/archive/opensuse-arm/2014-06/msg4.html > > Moving this thread out of opensuse to kernel public lists +CC of > maintainers relevant to the control module/

[Patch v3 3/4] Staging: unisys: make function names Linux compliant

2014-06-05 Thread Ken Cox
Changed function declarations in drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h so that the function names follow Linux coding standards. Signed-off-by: Ken Cox --- .../unisys/common-spar/include/vbusdeviceinfo.h| 28 +++--- 1 file changed, 14 insertions(+), 14

[Patch v3 2/4] Staging: unisys: Fix sparse warnings in uislib

2014-06-05 Thread Ken Cox
Added I/O version for the function ultra_vbus_init_channel() to get rid of noderef sparse warnings when accessing I/O space. Signed-off-by: Ken Cox --- .../common-spar/include/channels/vbuschannel.h | 40 -- drivers/staging/unisys/uislib/uislib.c | 2 +- 2 fi

[Patch v3 1/4] Staging: unisys: use Linux coding convention for function names

2014-06-05 Thread Ken Cox
Changed function declarations for VBUSCHANNEL_devInfoToStringBuffer() and ULTRA_VBUS_init_channel() to conform to Linux kernel coding convention. Signed-off-by: Ken Cox --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 4 ++-- drivers/staging/unisys/common-spar/include/vbus

[PATCH v3 0/2] Staging: unisys: uislib: address sparse noderef warnings

2014-06-05 Thread Ken Cox
This series gets rid of some sparse noderef warnings by adding I/O versions of the functions that are producing the warnings and also removing __iomem declarations where they are not needed. While we are at it, we fix up the function names of the functions that we are modifying so that they com

[Patch v3 4/4] Staging: unisys: Fix noderef sparse warnings in vbusdeviceinfo.h

2014-06-05 Thread Ken Cox
vbuschannel_devinfo_to_string() was declared with the devinfo argument as a pointer to __iomem space. No callers of this function need the __iomem space, so I removed that constraint. Same thing goes for vbuschannel_sanitize_buffer(). It doesn't need to operate on I/O space. Signed-off-by: Ken

[PATCH 2/3] Staging: rtl8192u: r8192U_core.c Rearranged statements to fix code-style errors

2014-06-05 Thread Chaitanya Hazarey
Rearranged statements around if and switch statements to address the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 553 - 1 file changed, 402 insertions(+), 151 de

[PATCH 1/3] Staging: rtl8192u: r8192U_core.c Added a space after ','

2014-06-05 Thread Chaitanya Hazarey
Added spaces after ',' to fix the following warning: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/r

[PATCH 3/3] Staging: rtl8192u: r8192U_core.c Converted some C99 comments to fix code-style errors

2014-06-05 Thread Chaitanya Hazarey
Converted some C99 warnings to fix the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey --- drivers/staging/rtl8192u/r8192U_core.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/

[PATCH 1/5] staging: lirc: remove sa1100 support

2014-06-05 Thread Arnd Bergmann
The LIRC support for sa1100 appears to have never worked because it relies on header files that have never been present in git history. Actually trying to build the driver on an ARM sa1100 kernel fails, so let's just remove the broken support. Signed-off-by: Arnd Bergmann Cc: Jarod Wilson Cc: Ma

[PATCH 3/5] staging: sn9c102 depends on USB

2014-06-05 Thread Arnd Bergmann
If the USB code is a loadable module, this driver cannot be built-in. This adds an explicit dependency on CONFIG_USB so that Kconfig can force sn9c102 to be a module in this case. Signed-off-by: Arnd Bergmann Cc: Luca Risolia Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-.

[PATCH 5/5] staging: rtl8712, rtl8712: avoid lots of build warnings

2014-06-05 Thread Arnd Bergmann
The rtl8712 driver has an 'extern inline' function that contains an 'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES overriding the definition of 'if': drivers/staging/rtl8712/ieee80211.h:759:229: warning: '__f' is static but declared in inline function 'ieee80211_get_hdrl

[PATCH 2/5] staging/iio: IIO_SIMPLE_DUMMY_BUFFER neds IIO_BUFFER

2014-06-05 Thread Arnd Bergmann
An obviously missing 'select' statement, without this we get a link error Signed-off-by: Arnd Bergmann Cc: Jonathan Cameron Cc: linux-...@vger.kernel.org --- drivers/staging/iio/Kconfig | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/Kconfig b/dr

[PATCH 4/5] staging: wlags49_h2: avoid PROFILE_ALL_BRANCHES warnings

2014-06-05 Thread Arnd Bergmann
Using an 'if()' inside of an 'extern inline' function causes a gcc warning when CONFIG_PROFILE_ALL_BRANCHES is set every time the function is called, which gets very noisy: In file included from /git/arm-soc/drivers/staging/wlags49_h2/wl_wext.c:73:0: drivers/staging/wlags49_h2/wl_internal.h:1035:2

[PATCH 0/5] randconfig build fixes for staging

2014-06-05 Thread Arnd Bergmann
Hi Greg, Here are a couple of simple fixes from my backlog of ARM randconfig bugs. Nothing urgent, they can probably all go into next for 3.17 after the merge window, but see for yourself. Arnd Arnd Bergmann (5): staging: lirc: remove sa1100 support staging/iio: IIO_SIMPLE_DUMMY_BUFF

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-05 Thread Mike Christie
On 06/04/2014 12:15 PM, KY Srinivasan wrote: > > >> -Original Message- >> From: James Bottomley [mailto:jbottom...@parallels.com] >> Sent: Wednesday, June 4, 2014 10:02 AM >> To: KY Srinivasan >> Cc: linux-ker...@vger.kernel.org; a...@canonical.com; >> de...@linuxdriverproject.org; h...@i

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-06-05 Thread KY Srinivasan
> -Original Message- > From: Mike Christie [mailto:micha...@cs.wisc.edu] > Sent: Thursday, June 5, 2014 6:33 PM > To: KY Srinivasan > Cc: James Bottomley; linux-ker...@vger.kernel.org; a...@canonical.com; > de...@linuxdriverproject.org; h...@infradead.org; linux- > s...@vger.kernel.org; o

[PATCH 1/1] Staging:tidspbridge Fix minor checkpatch.pl warning

2014-06-05 Thread Adithya
From: Adithya K Fixed checkpatch "WARNING: Missing a blank line after declarations" Signed-off-by: Adithya Krishnamurthy --- drivers/staging/tidspbridge/core/chnl_sm.c |1 + drivers/staging/tidspbridge/core/io_sm.c |1 + drivers/staging/tidspbridge/core/tiomap3430.c|

Re: [PATCH 1/1] Staging:tidspbridge Fix minor checkpatch.pl warning

2014-06-05 Thread Joe Perches
On Fri, 2014-06-06 at 10:24 +0530, Adithya wrote: > From: Adithya K > > Fixed checkpatch "WARNING: Missing a blank line after declarations" [] > diff --git a/drivers/staging/tidspbridge/gen/gh.c > b/drivers/staging/tidspbridge/gen/gh.c [] > @@ -28,6 +28,7 @@ struct gh_node { > struct gh_t_hash_