Managed device resource API replaces code that reinvents it for memory
allocation, page allocation and DMA mapping.
Suggested-by: Baruch Siach
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus.h | 38 +--
drivers/staging/xillybus/xillybus_core.c | 186 +--
This patchset consists of new functions to the managed device resource
API, followed by a patch for the Xillybus driver, which is my motivation
and what I tested with.
This is a resubmission after changing the API slightly.
Rationale: While migrating the staging/xillybus driver to rely completely
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt |2 ++
include/asm-generic/pci-dma-compat.h | 18 ++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/Documentation/driver-model/devres.txt
b/Documentation/driver-model/devres.txt
index 2
dmam_map_single() and dmam_unmap_single() are the managed counterparts
for the respective dma_* functions.
Note that dmam_map_single() returns a status value rather than the DMA handle.
The DMA handle is passed to the caller through a pointer in the arguments.
The reason for this API change is th
dmam_map_single_attrs() and dmam_unmap_single_attrs() replace the non-*_attrs
functions, which are implemented as defines instead.
The case of a non-NULL @attrs parameter has not been tested.
Suggested-by: Tejun Heo
Signed-off-by: Eli Billauer
---
Documentation/driver-model/devres.txt|
This patch get rid of all memcmp() on ethernet addresses in wlan-ng.
Replaced with ether_addr_equal_unaligned().
Signed-off-by: Denis Pithon
---
drivers/staging/wlan-ng/p80211conv.c | 6 +++---
drivers/staging/wlan-ng/prism2sta.c | 16 +---
2 files changed, 12 insertions(+), 10 del
On Sun, 2014-06-01 at 09:22 +0200, Denis Pithon wrote:
> This patch get rid of all memcmp() on ethernet addresses in wlan-ng.
> Replaced with ether_addr_equal_unaligned().
ether_addr_equal_unaligned is only useful for
code symmetry when some uses are known to be
ether_addr_equal.
At least one of
This patch simply fixes the style errors in panel.c
that scripts/checkpatch.pl reported
Signed-off-by: Vincent Heuken
---
drivers/staging/panel/panel.c | 244 +-
1 file changed, 121 insertions(+), 123 deletions(-)
diff --git a/drivers/staging/panel/panel.
There is a risk for memory leak in when something unexpected happens
and the function returns.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c |1 +
1 file changed, 1 inserti
There is a risk for memory leak in when something unexpected happens
and the function returns.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8712/rtl871x_mlme.c | 16 +++-
1 file changed, 1
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalPhyRf.c |8
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |2 --
drivers/staging/rtl8188eu/include/HalPhyRf.h |2 --
3 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/HalPhyR
Move ODM_GetRightChnlPlaceforIQK() from HalPhyRf.c to HalPhyRf_8188e.c.
Move ODM_TARGET_CHNL_NUM_2G_5G from HalPhyRf.h to HalPhyRf_8188e.h.
After the movement of function and macro HalPhyRf.[h|c] files are redundant.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile
Use unregistering flag from struct usb_interface to find
driver registration status.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |2 +-
drivers/staging/rtl8188eu/os_dep/os_intfs.c |6 --
drivers/staging/rtl8188eu/os_dep/usb_intf.c |6 +-
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl81
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_debug.c |1 -
drivers/staging/rtl8188eu/include/rtw_debug.h |2 +-
drivers/staging/rtl8188eu/include/rtw_version.h |1 -
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c |1 -
drivers/staging/rtl8188eu/os_de
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 22 +-
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index d33aeb9..21bf74d 100644
--- a/
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 8cbdab5..d38f861 100644
--- a/drivers/staging/rtl8188eu/
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 28 ++-
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 21bf74d..45d2608 100644
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 1841d54..c99b9c2 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 31814
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index d38f861..3181418 100644
--- a/drivers/staging/rtl8188eu/inc
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index f40db1a..8cbdab5 100644
--- a/drivers/staging/rtl8188eu/i
struct rtw_usb_drv contains only one member usb_driver structure,
so no use of keeping it.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 7586de71..f7db553 100644
--- a/drivers/staging/rtl8188eu
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index f7db553..9195cf3 100644
--- a/drivers/staging/rtl8188eu/
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |6 --
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 10 --
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188e
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |1 -
drivers/staging/rtl8188eu/include/drv_types.h |1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 141f85a.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 17 +
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |5 -
drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 -
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
b/drivers/staging/rtl8188eu/hal/rtl8188e_h
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 5fa2e17..de3b70c 100644
--- a/drivers/staging/rtl8188eu/incl
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/usb_halinit.c |3 ---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 8831be
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/include/drv_types.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/drv_types.h
b/drivers/staging/rtl8188eu/include/drv_types.h
index 9cdab6a..a459206 100644
--- a/drivers/staging/rtl81
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 19 ---
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |4
3 files changed, 24 deletions(-)
diff --git a/drivers/staging/rtl8188eu/c
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_br_ext.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c
b/drivers/staging/rtl8188eu/core/rtw_br_ext.c
index 3f602bc..70b8f07 100644
--- a/drivers/staging/rtl8188eu
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile | 32 ++---
drivers/staging/rtl8188eu/core/rtw_br_ext.c| 61
drivers/staging/rtl8188eu/include/recv_osdep.h |1 -
3 files changed, 16 insertions(+), 78 deletions(-)
diff
driver doesn't use value stored in bCardDisableWOHSM.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c |1 -
drivers/staging/rtl8188eu/include/drv_types.h |1 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |4
3 files changed, 6 deletions(-)
diff
When firmware is not available, net device is not created. Upon
disconnect, we must check for net device existence before trying to
release net device private data.
Signed-off-by: Thomas Vegas
---
drivers/staging/rtl8712/usb_intf.c | 44 +++---
1 file changed, 22
The net device only exists when firmware is loaded successfully.
Firmware presence variable is only used through r871xu_dev_remove() and
this function already checks for net device existence.
Signed-off-by: Thomas Vegas
---
drivers/staging/rtl8712/drv_types.h | 1 -
drivers/staging/rtl8712/hal_i
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8192u/r8192U_core.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/tidspbridge/pmgr/dspapi.c |8
1 file changed, 4 insertions(+), 4 deletion
This patch fixes coding style errors reported by checkpatch.pl.
It adds new lines after declarations in two places.
Signed-off-by: Simon Boulay
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c
b
This commit fixes the following sparse warnings in ps.c:
- 702: warning: symbol 'rtl_p2p_noa_ie' was not declared. Should it be static?
- 802: warning: symbol 'rtl_p2p_action_ie' was not declared. Should it be
static?
Signed-off-by: Marcus Farkas
---
drivers/staging/rtl8821ae/ps.c | 6 -
Removes unnecessary code that does not do anything useful.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a
The if block should be placed in a new line rather
than after the if statement.
Blank line required between variable declarations and code.
Signed-off-by: Josep Puigdemont
---
ID: 31f7..b1
drivers/staging/lustre/lustre/llite/llite_nfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(
motivation: eudyptula challenge
This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
The new version of the file pleases checkpatch.pl when run with
"--ignore LONG_LINE".
Signed-off-by: Ovidiu Toader
---
drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 20 ++
On Sun, Jun 01, 2014 at 03:28:35PM +0200, Rickard Strandqvist wrote:
> There is a risk that the variable will be used without being initialized.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
I've looked at the code, but I don't see this variable actuall
Hi Dan
I agree, this looks strange.
Have been looking for a while in history with, to see if the code has
been removed. I start my search using cppcheck for over three months
ago.
But could not find anything. Sorry about that :-(
But I'll make a patch that completely removes testing variable then
On Sun, 1 Jun 2014 13:32:20 +0200, Rickard Strandqvist
wrote:
> There is a risk for memory leak in when something unexpected happens
> and the function returns.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
This
Hi Christian!
Yes! I mail about this for the first time in early May, but ther were
many other faults in the design of my patch, had several different
types of errors in the same path etc.
So good that they have already been solved then :)
Best regards
Rickard Strandqvist
2014-06-01 23:50 G
On Sun, 1 Jun 2014 13:30:43 +0200, Rickard Strandqvist
wrote:
> There is a risk for memory leak in when something unexpected happens
> and the function returns.
>
> This was largely found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
This patch fixes the following sparse warning in bpctl_mod.c:
warning: symbol 'bpvm_lock' was not declared. Should it be static?
Signed-off-by: James A Shackleford
---
drivers/staging/silicom/bpctl_mod.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/silic
This patch fixes the following sparse warnings:
skein_block.c:43:6: warning: symbol 'skein_256_process_block' was not declared.
Should it be static?
skein_block.c:252:6: warning: symbol 'skein_512_process_block' was not
declared. Should it be static?
skein_block.c:483:6: warning: symbol 'skein_1
This patch fixes the following sparse warnings:
skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should
it be static?
skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should
it be static?
skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not dec
This patch fixes the following sparse warnings:
dpc.c:65:21: warning: symbol 'acbyRxRate' was not declared. Should it be static?
dpc.c:272:9: warning: symbol 'MngWorkItem' was not declared. Should it be
static?
dpc.c:288:1: warning: symbol 'device_receive_frame' was not declared. Should it
be st
The function iwctl_siwscan() is defined in iwctl.c as:
int iwctl_siwscan(struct net_device *dev,
struct iw_request_info *info,
struct iw_point *wrq,
char *extra)
{
...
This patch updates iwctl.h so that the type of the 3rd parameter (*wqr) in
Update declaration of iwctl_private_args to match definition in iwctl.c
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/iwctl.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
index 4ad5e48..1056
This patch fixes the following sparse warnings:
iwctl.c:76:22: warning: symbol 'iwctl_get_wireless_stats' was not declared.
Should it be static?
iwctl.c:118:5: warning: symbol 'iwctl_giwname' was not declared. Should it be
static?
iwctl.c:131:5: warning: symbol 'iwctl_siwscan' was not declared.
Don't use spaces as tabs, and fix other style errors and warnings.
Signed-off-by: Thomas Wood
---
I think that this is correctly indented now, but I didn't touch the double
parentheses on line 322 because I wasn't sure if they were necessary or not.
drivers/staging/ft1000/ft1000-usb/ft1000_de
Signed-off-by: James A Shackleford
---
drivers/staging/vt6655/baseband.c | 300 ++---
1 file changed, 150 insertions(+), 150 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c
b/drivers/staging/vt6655/baseband.c
index 6f95fb6..490ca96 100644
--- a/drive
On Fri, May 30, 2014 at 12:26 PM, Hartley Sweeten
wrote:
> On Thursday, May 29, 2014 9:44 PM, Chase Southwood wrote:
>> Move the function apci1564_interrupt() from hwdrv_apci1564.c to
>> addi_apci_1564.c. On moving, for now just strip out all of the
>> code for interrupts that the driver does not
The dgap_probe1() function is just calling dgap_found_board().
So it is removed and dgap_found_board() is called directly.
Signed-off-by: Daeseok Youn
---
RESEND : this patch is included into newly serise of patches
so renumbered and resend.
drivers/staging/dgap/dgap.c |8 +---
1 files
Adds a label for "kfree(brd)". And also remove
a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
Because "brd" will free after failure.
Signed-off-by: Daeseok Youn
---
RESEND: this patch is included into newly series of patches.
drivers/staging/dgap/dgap.c | 19
- The channels array were set to NULL in dgap_found_board().
- Removes redundant null check for channels array in for loop,
if one of the channel cannot be allocated, dgap_tty_init() just returns
an error.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 13 -
1 files
If the kzalloc() fails for channels, it need to handle
that error. It should free channels which were already
allocated.
And also removes the call to dgap_tty_uninit() in
dgap_firmware_load().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 18 +-
1 files changed
- The dgap_tty_register_ports() needs to handle if the
tty_port_register_device() fails.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 44 +-
1 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/dr
The dgap_config_buf is only used in dgap_firmware_load().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 3e716fe..c78c8e2 100644
--- a/drivers/
Adds a label for "kfree(brd)". And also remove
a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
Because "brd" will free after failure.
Signed-off-by: Daeseok Youn
Reviewed-by: Dan Carpenter
---
RESEND: this patch is included into newly series of patches.
V2: add "Reviewed-by"
Hi,
Please check below line comments.
2014-06-02 12:06 GMT+09:00 James A Shackleford :
> Signed-off-by: James A Shackleford
> ---
> drivers/staging/vt6655/baseband.c | 300
> ++---
> 1 file changed, 150 insertions(+), 150 deletions(-)
>
> diff --git a/drivers/s
69 matches
Mail list logo