Re: [PATCH]staging:iio:ad2s1200 fix missing parenthesis in a for statment.

2014-04-26 Thread Jonathan Cameron
On 25/04/14 03:52, Jimmy Li wrote: Signed-off-by: Jimmy Li Applied to the fixes-togreg branch of iio.git Thanks, --- drivers/staging/iio/resolver/ad2s1200.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/

[PATCH] staging: cxt1e1: Avoid using 0 instead of NULL

2014-04-26 Thread Thomas Vegas
Fixed the following sparse warnings: drivers/staging/cxt1e1/hwprobe.c:162:38: warning: Using plain integer as NULL pointer drivers/staging/cxt1e1/hwprobe.c:163:38: warning: Using plain integer as NULL pointer drivers/staging/cxt1e1/hwprobe.c:179:46: warning: Using plain int

[PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-26 Thread Christian Engelmayer
Some board pointer are assigned twice via comedi_board() in the comedi low level driver attach functions. Remove the duplicate assignment from the variable definition where the pointer is not used anyway until assigned later in the function when dev->board_ptr, that comedi_board() relies on, is set

[PATCH/V2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-26 Thread Masanari Iida
Fix spelling typo in comments within rtl8192e. Signed-off-by: Masanari Iida Reviewed-by: James Cameron --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 2 +- drivers/stagi

[PATCH] staging: dgnc: redundant NULL checks before kfree()

2014-04-26 Thread Vitaly Osipov
Removed redundant NULL checks before calling kfree() Signed-off-by: Vitaly Osipov --- drivers/staging/dgnc/dgnc_driver.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index b1a39b2..e2c

[PATCH] staging: lustre: return -EFAULT instead of bytes remaining

2014-04-26 Thread Vitaly Osipov
return -EFAULT instead of the value returned by copy_from_user() Signed-off-by: Vitaly Osipov --- .../lustre/lustre/libcfs/linux/linux-module.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-module.c b/driv

[PATCH] staging: lustre: check for integer overflow

2014-04-26 Thread Vitaly Osipov
In ll_ioctl_fiemap(), a user-supplied value is used to calculate a length of a buffer which is later allocated with user data. Signed-off-by: Vitaly Osipov --- drivers/staging/lustre/lustre/llite/file.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/lustre/lustre/llit

[PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections

2014-04-26 Thread Sami Laine
From: Sami Laine Sparse warning corrections: - declarations made static where they should be such - changed NULL-pointers as NULL instead of static 0's - added __force to a few casts seemingly safe enough Signed-off-by: Sami Laine --- diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/s

Re: [PATCH next-20140424] staging/cxt1e1: hwprobe.c sparse warning corrections

2014-04-26 Thread Greg KH
On Sat, Apr 26, 2014 at 06:30:33PM +0300, Sami Laine wrote: > From: Sami Laine > > Sparse warning corrections: > - declarations made static where they should be such > - changed NULL-pointers as NULL instead of static 0's > - added __force to a few casts seemingly safe enough You did 3 differ

[PATCH next-20140424] staging/cxt1e1: sparse warning corrections

2014-04-26 Thread Sami Laine
From: Sami Laine Corrected sparse static declaration warnings. Signed-off-by: Sami Laine --- diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c index cc2151e..2899258 100644 --- a/drivers/staging/cxt1e1/hwprobe.c +++ b/drivers/staging/cxt1e1/hwprobe.c @@ -40,10

Re: [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions

2014-04-26 Thread Ian Abbott
On 26/04/14 15:04, Christian Engelmayer wrote: Some board pointer are assigned twice via comedi_board() in the comedi low level driver attach functions. Remove the duplicate assignment from the variable definition where the pointer is not used anyway until assigned later in the function when dev-

[PATCH] staging: rtl8188eu: Use USB subsystem functions to check endpoint type

2014-04-26 Thread navin patidar
Use inline functions provided by USB subsystem to check endpoint type, instead of macros implemented by driver to do the same. Unnecessary debugging messages are also removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 92 --- 1 file

[PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Laurent Navet
The strcpy operation may write past the end of the fixed-size destination buffer if the source buffer is too large. Found by coverity scan : CID 144979 Signed-off-by: Laurent Navet --- build tested only drivers/staging/line6/audio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

Re: [PATCH/V2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-26 Thread Randy Dunlap
On 04/26/14 07:35, Masanari Iida wrote: > Fix spelling typo in comments within rtl8192e. > > Signed-off-by: Masanari Iida > Reviewed-by: James Cameron > > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- > drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +- > drivers/stagi

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-26 Thread Dan Carpenter
On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: > Hi, > > please check below my comments. > > 2014-04-25 23:41 GMT+09:00 Mark Hounschell : > > On 04/25/2014 08:59 AM, Dan Carpenter wrote: > >> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote: > >>> On 04/25/2014 07:02

Re: [rfc PATCH] checkpatch: allow multiple const * types

2014-04-26 Thread Dan Carpenter
On Fri, Apr 25, 2014 at 08:29:59PM -0700, Joe Perches wrote: > On Fri, 2014-04-25 at 10:50 +0300, Dan Carpenter wrote: > > On Fri, Apr 25, 2014 at 01:06:44AM -0300, Nicolas Del Piano wrote: > > > diff --git a/drivers/staging/comedi/drivers.c > > > b/drivers/staging/comedi/drivers.c > [] > > > @@ -

[PATCH] staging: rtl8723au: Remove unused pointer in rtw_wdev_free()

2014-04-26 Thread Christian Engelmayer
Pointer 'pwdev_priv' in function rtw_wdev_free() is unused - thus remove it. Signed-off-by: Christian Engelmayer --- Compile tested and applies against v3.15-rc2 as well as branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git --- drivers/staging/rtl8723au/os_dep

[PATCH] staging: silicom: Remove unused pointer in bypass_init_module()

2014-04-26 Thread Christian Engelmayer
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove it. Signed-off-by: Christian Engelmayer --- Compile tested and applies against v3.15-rc2 as well as branch staging-next of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git --- drivers/staging/silicom/bp

[PATCH] staging: silicom: Remove needless calls of get_status_port_fn()

2014-04-26 Thread Christian Engelmayer
Remove a needless pointer initialisation and call to get_status_port_fn() in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable 'pbpctl_dev_b' is set correctly later in the function before first use. Signed-off-by: Christian Engelmayer --- Compile tested and applies against v3.15-rc2 a

Re: [PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Mateusz Guzik
On Sat, Apr 26, 2014 at 07:09:22PM +0200, Laurent Navet wrote: > The strcpy operation may write past the end of the fixed-size destination > buffer if the source buffer is too large. > > Found by coverity scan : CID 144979 > > Signed-off-by: Laurent Navet > --- > build tested only > > drivers/

Re: [PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Dan Carpenter
On Sat, Apr 26, 2014 at 10:47:05PM +0200, Mateusz Guzik wrote: > On Sat, Apr 26, 2014 at 07:09:22PM +0200, Laurent Navet wrote: > > The strcpy operation may write past the end of the fixed-size destination > > buffer if the source buffer is too large. > > > > Found by coverity scan : CID 144979 >

Re: [PATCH] staging: line6: fix possible overrun

2014-04-26 Thread Mateusz Guzik
On Sun, Apr 27, 2014 at 12:36:21AM +0300, Dan Carpenter wrote: > On Sat, Apr 26, 2014 at 10:47:05PM +0200, Mateusz Guzik wrote: > > On Sat, Apr 26, 2014 at 07:09:22PM +0200, Laurent Navet wrote: > > > The strcpy operation may write past the end of the fixed-size destination > > > buffer if the sour

[RFC PATCH 0/8] component helper improvements

2014-04-26 Thread Russell King - ARM Linux
A while back, Laurent raised some comments about the component helper, which this patch set starts to address. The first point it addresses is the repeated parsing inefficiency when deferred probing occurs. When DT is used, the structure of the component helper today means that masters end up par

[PATCH RFC 5/8] imx-drm: update to use component match support

2014-04-26 Thread Russell King
Update the imx-drm driver to use the component match support rather than add_components. Signed-off-by: Russell King --- drivers/staging/imx-drm/imx-drm-core.c | 57 +++--- 1 file changed, 4 insertions(+), 53 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-

[GIT PULL] Staging driver fixes for 3.15-rc3

2014-04-26 Thread Greg KH
The following changes since commit a798c10faf62a505d24e5f6213fbaf904a39623f: Linux 3.15-rc2 (2014-04-20 11:08:50 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-3.15-rc3 for you to fetch changes up to 2704f807f94

[PATCH 1/6] staging: comedi: addi_apci_1564: remove eeprom support code

2014-04-26 Thread Chase Southwood
Reading the eeprom on this board is not necessary. All information required is in the boardinfo. Remove the eeprom support code which is not really useful here. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/staging/comedi/drivers/addi_apci_1564.c | 46 +-

[PATCH 3/6] staging: comedi: addi_apci_1032: board has 32 digital inputs

2014-04-26 Thread Chase Southwood
This board always has 32 digital inputs. Remove the test when initializing the subdevice. Also, since this board is the only one supported by this driver, remove the boardinfo about the digital inputs and just use the data directly in the subdevice init. Signed-off-by: Chase Southwood Cc: Ian Ab

[PATCH 2/6] staging: comedi: addi_apci_1564: remove unnecessary include

2014-04-26 Thread Chase Southwood
This include is no longer needed. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/staging/comedi/drivers/addi_apci_1564.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/addi_apci_1564.c b/drivers/staging/comedi/drivers/addi_ap

[PATCH 4/6] staging: comedi: addi_apci_1564: simplify the PCI bar reading and don't read the unused bars

2014-04-26 Thread Chase Southwood
This driver only uses PCI bar 1 (devpriv->i_IobaseAmcc), and PCI bar 2 (dev->iobase) doon't bother reading the unused PCI bars. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- Hartley, As far as I can tell from reading the I/O Mapping you sent me, these bar numbers are

[PATCH 6/6] staging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters

2014-04-26 Thread Chase Southwood
This driver no longer reads the eeprom to find the board specific data, all the necessary data is in the boardinfo. Use the boardinfo directly instead of passing through devpriv->s_EeParameters. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- Ian and Hartley, The auto_a

[PATCH 5/6] staging: comedi: addi_apci_2032: remove unnecessary info from boardinfo

2014-04-26 Thread Chase Southwood
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo was only needed to work out the usage of the PCI bars. Now that that is squared away, this info is no longer needed and can be removed. Signed-off-by: Chase Southwood Cc: Ian Abbott Cc: H Hartley Sweeten --- drivers/stag