Fix coding style problems (incorrect indentation).
Signed-off-by: Loïc Pellegrino
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
b/drivers/staging/rtl8192u/r8190_rtl8256.c
index 40b1
If CONFIG_PM=n:
drivers/staging/rts5139/rts51x_transport.c:649: warning: ‘media_not_present’
defined but not used
drivers/staging/rts5139/rts51x_transport.c:651: warning: ‘invalid_cmd_field’
defined but not used
Move the variables inside the #ifdef CONFIG_PM, and make them const while
we're at
This patch solves some sparse warnings about "symbol [...] was not
declared. Should it be static?" by including the correct header files.
Signed-off-by: Jonas Hahnfeld
---
Tested by compile only
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c | 1 +
drivers/staging/rtl8187se/ieee8021
This fixes coding style warning "Missing a blank line after
declarations" in files sep_dev.h and sep_crypto.c (linux-next).
Sorry for the previous mail, tabs all got converted into spaces due to
gmail webclient ... (thanks Greg).
Signed-off-by: Camille Bordignon
---
diff --git a/drivers/staging/
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld
Reviewed-by: Josh Triplett
> Tested by compile only
>
On Sun, Apr 06, 2014 at 05:43:31PM +0200, Gmail wrote:
Your "From" line above doesn't match up with your "Signed-off-by:" line
down below :(
> This fixes coding style warning "Missing a blank line after
> declarations" in files sep_dev.h and sep_crypto.c (linux-next).
>
> Sorry for the previous
Signed-off-by: Camille Bordignon
---
Fix coding style warning "Missing a blank line after declarations"
---
diff --git a/drivers/staging/sep/sep_crypto.c
b/drivers/staging/sep/sep_crypto.c
index 965485f..415f8ec 100644
--- a/drivers/staging/sep/sep_crypto.c
+++ b/drivers/staging/sep/sep_crypto.c
@
On Sun, Apr 06, 2014 at 06:21:27PM +0200, Camille Bordignon wrote:
> Signed-off-by: Camille Bordignon
> ---
> Fix coding style warning "Missing a blank line after declarations"
No, this needs to go up above your signed-off-by:, it was the "fixed
after Greg's response" that could go below.
Don't
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl
On Sun, Apr 06, 2014 at 01:23:15PM -0500, Joel Pelaez Jorge wrote:
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
> symbol 'r8192_wx_handlers_def' was not declared. Should it be static
>
> Signed-off-by: Joel Pelaez Jorge
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |2
Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was not declared. Should it be static?
Signed-off-by: Jo
On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
> Fix a sparse warning, non static symbol is no declared as such.
> And fix a conflict with static function declared extern to include
> rtl_wx.h header.
>
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
> symbol 'r8
El 06/04/14 13:49, Joe Perches escribió:
On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:132
El 06/04/14 14:01, Greg Kroah-Hartman escribió:
On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
Fix a sparse warning, non static symbol is no declared as such.
And fix a conflict with static function declared extern to include
rtl_wx.h header.
drivers/staging/rtl8192e/rtl8192
On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
> Fix a sparse warning, non static symbol is no declared as such.
> And fix a conflict with static function declared extern to include
> rtl_wx.h header.
>
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
> symbol 'r8192_wx_
On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote:
> El 06/04/14 14:01, Greg Kroah-Hartman escribió:
> > On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
> >> Fix a sparse warning, non static symbol is no declared as such.
> >> And fix a conflict with static functi
El 06/04/14 15:26, Greg Kroah-Hartman escribió:
> On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote:
>> El 06/04/14 14:01, Greg Kroah-Hartman escribió:
>>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote:
Fix a sparse warning, non static symbol is no declared
On Sun, Apr 06, 2014 at 03:43:42PM -0500, Joel Pelaez Jorge wrote:
> El 06/04/14 15:26, Greg Kroah-Hartman escribió:
> > On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote:
> >> El 06/04/14 14:01, Greg Kroah-Hartman escribió:
> >>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelae
In the kernel driver: rtl8192e, exists some problems related
to source check, using the tool sparse, but for fix it, is necessary
remove a bad declaration that keep off the patch.
Because it is resolved before apply the "main" patch.
Joel Pelaez Jorge (2):
Staging: rtl8192e: Remove bad 'extern'
Remove extern declaration to a static function:
iw_statistics *r8192_get_wireless_stats(struct net_device *dev);
Signed-off-by: Joel Pelaez Jorge
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.h
b/drivers
Include the header 'rtl_wx.h' to 'rtl_wx.c'
'rtl_wx.h' has the declarations used for some source files of
the driver. It has:
extern struct iw_handler_def r8192_wx_handlers_def;
That fix the problem:
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning:
symbol 'r8192_wx_handlers_def' was
On Sun, 2014-04-06 at 16:30 -0500, Joel Pelaez Jorge wrote:
> Include the header 'rtl_wx.h' to 'rtl_wx.c'
>
> 'rtl_wx.h' has the declarations used for some source files of
> the driver. It has:
>
> extern struct iw_handler_def r8192_wx_handlers_def;
Likely this extern should be
extern const stru
Pass the actual variable to sizeof instead of a type definition.
Signed-off-by: L. Alberto Giménez
---
drivers/staging/line6/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 661080b..a3136b1 100644
--- a/dri
On Sun, 2014-04-06 at 14:00 -0500, Joel Pelaez Jorge wrote:
> El 06/04/14 13:49, Joe Perches escribió:
> > On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
[]
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
[]
> >> -static struct iw_statistics *r8192_get_wireless_stats(struc
fix some coding style issues in rts51x.c (from rts5139 module)
This is for task 10 of the Eudyptula challenge
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5139/rts51x.c | 62
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/st
On Mon, Apr 07, 2014 at 12:45:05AM +0200, Fabio Falzoi wrote:
> fix some coding style issues in rts51x.c (from rts5139 module)
What specific coding style issues did you fix here?
You need to be explicit, and if you do more than one type of change in
the same patch, it needs to be broken up into d
On Sun, Apr 06, 2014 at 04:25:23PM -0500, Joel Pelaez Jorge wrote:
> In the kernel driver: rtl8192e, exists some problems related
> to source check, using the tool sparse, but for fix it, is necessary
> remove a bad declaration that keep off the patch.
>
> Because it is resolved before apply the "
The kbuild test robot reports the following build errors for
x86_64-randconfig-c1-0407:
All error/warnings:
net/built-in.o: In function `wiphy_new':
>> (.text+0x7684c): undefined reference to `rfkill_alloc'
net/built-in.o: In function `wiphy_rfkill_start_polling':
>> (.text+0x76da4): undef
Hi
On Sunday 06 April 2014, Josh Triplett wrote:
> On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > This patch solves some sparse warnings about "symbol [...] was not
> > declared. Should it be static?" by including the correct header files.
> >
> > Signed-off-by: Jonas Hahnfel
The two declarations with issues in rtl_wx.h:
* function: struct iw_statistics *r8192_get_wireless_stats();
* variable: extern struct iw_handler_def r8192_wx_handlers_def;
The symbol 'r8192_get_wireless_stats' is declared as 'extern'
but it is only used in the local scope. The declaration is
Fix checkpatch.pl error where a static variable was explicitly
initialised to false
Signed-off-by: Angus Gibson
---
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
b/drivers/staging
Signed-off-by: Daeseok Youn
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
b/drivers/staging/lustre/lustre/obdclass/obd_mount.c
index 6f8ba54..41
The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
Signed-off-by: Daeseok Youn
---
drivers/staging/silicom/bpctl_mod.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/staging/silicom/bpctl_mod.c
index 6b9
Fix two instances of the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Garret Kelly
---
drivers/staging/goldfish/goldfish_audio.c | 1 +
drivers/staging/goldfish/goldfish_nand.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging
On Tue, Mar 11, 2014 at 11:46:11AM +0800, Shawn Guo wrote:
> I just came across a couple problems when testing the series on
> my imx6dl-sabresd board in dual display case - HDMI + LVDS. I tested it
> using Russell's branch below, which I believe has all the pieces put
> together.
>
> git://ftp
Fix checkpatch.pl error where a static variable was explicitly
initialised to false
Signed-off-by: Angus Gibson
---
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.c
b/drivers/staging
At Mon, 7 Apr 2014 00:12:30 +0200,
L. Alberto Giménez wrote:
>
> Pass the actual variable to sizeof instead of a type definition.
>
> Signed-off-by: L. Alberto Giménez
Acked-by: Takashi Iwai
BTW, does anyone work on line6 stuff actively?
It's been in staging forever, and it's difficult to pr
The ->SupportedRates[] array has NDIS_802_11_LENGTH_RATES_EX (16)
elements. Since "ie_len" comes from then network and can go up to 255
then it means we should add a range check to prevent memory corruption.
Fixes: d6846af679e0 ('staging: r8188eu: Add files for new driver - part 7')
Signed-off-by
38 matches
Mail list logo
