Re: [PATCH] staging: goldfish: switch from spinlock to mutex

On 04/04/14 16:30, Dan Carpenter wrote: > On Fri, Apr 04, 2014 at 02:46:14PM +0300, Kristina Martšenko wrote: > >> Yes, I didn't find any interrupt handlers either, which is partially why >> I thought it was (probably) safe. > > What's the other part of why it was safe? Put that stuff in the > c

[PATCH] imx-hdmi: Propagate the real error code on platform_get_irq() failure

From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Signed-off-by: Fabio Estevam --- drivers/staging/imx-drm/imx-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/imx-hdmi.c b/drivers/staging/imx-drm/imx-h

[PATCH] imx-hdmi: Make checkpatch happy

From: Fabio Estevam Fix the following checkpatch warnings: WARNING: Missing a blank line after declarations #162: FILE: drivers/staging/imx-drm/imx-hdmi.c:162: + u8 val = hdmi_readb(hdmi, reg) & ~mask; + val |= data & mask; WARNING: Missing a blank line after declarations #663: FILE

[PATCH] staging: dt3155v4l: Fixed global symbol

Made q_ops static, as suggested by sparse. Signed-off-by: Michalis Pappas --- drivers/staging/media/dt3155v4l/dt3155v4l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging/media/dt3155v4l/dt3155v4l.c index e729e52.

[PATCH 1/1] staging: sep: Fix coding style

This fixes coding style warning "Missing a blank line after declarations" in files sep_dev.h and sep_crypto.c. Signed-off-by: Camille Bordignon --- diff --git a/drivers/staging/sep/sep_crypto.c b/drivers/staging/sep/sep_crypto.c index 965485f..415f8ec 100644 --- a/drivers/staging/sep/sep_crypto.c

Re: [PATCH 1/1] staging: sep: Fix coding style

On Sat, Apr 05, 2014 at 08:24:04PM +0200, Camille Bordignon wrote: > This fixes coding style warning "Missing a blank line after > declarations" in files sep_dev.h and sep_crypto.c. > > Signed-off-by: Camille Bordignon > --- > diff --git a/drivers/staging/sep/sep_crypto.c > b/drivers/staging/sep

[PATCH 01/10] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 47 - 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 04/10] driver: staging: wlan-ng: Setting character pointers as const

changed declaration of ctlx_str to: static const char * const ctlx_str[] Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_us

[PATCH 03/10] driver: staging: wlan-ng: switched to pr_warn

changed printk(KERN_WARNING .. to pr_warn Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 943de9c..01284

[PATCH 02/10] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 6

[PATCH 07/10] driver: staging: wlan-ng: Fixed white spaces issues

In hfa384x_usb.c: Moved Logical continuations to the correct lines Removed unnecessary blank lines Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 09/10] driver: staging: wlan-ng: Removed #if 0 lines from hfa384x_usb.c

Removed lines that were ignored by #if 0 Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index cf27030..867edb4 100644 --- a/dri

[PATCH 05/10] driver: staging: wlan-ng: Removed Unnecessary space after function pointer name

Removed Unnecessary space after function pointer name Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 74db234..

[PATCH 08/10] driver: staging: wlan-ng: Removed multiple assignments

Removed multiple assignments from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 1a6116a..cf27

[PATCH 06/10] driver: staging: wlan-ng: Fixed Alignment to match open parenthesis

Fixed Alignment to match open parenthesis in hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 121 + 1 file changed, 63 insertions(+), 58 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/stagi

[PATCH 10/10] driver: staging: wlan-ng: Removed unnecessary spaces after cast from hfa384x_usb.c

Fixed: No space is necessary after a cast Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning

On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote: > Wrap lines > 80 columns. > This patch is part of eudyptula challenge > > Signed-off-by: Camille Begue > --- > drivers/staging/comedi/comedi_fops.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/dri

Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning

On Sat, Apr 05, 2014 at 03:09:27PM -0700, Greg Kroah-Hartman wrote: > On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote: > > Wrap lines > 80 columns. > > This patch is part of eudyptula challenge > > > > Signed-off-by: Camille Begue > > --- > > drivers/staging/comedi/comedi_fops.c |

[PATCH] staging: ashmem: Fix coding style

Keep checkpatch happy by addressing the following: CHECK: Alignment should match open parenthesis CHECK: Blank lines aren't necessary after an open brace '{' CHECK: No space is necessary after a cast Signed-off-by: Zi Shen Lim --- drivers/staging/android/ashmem.c | 12 +--- 1 file change

[PATCH] staging: r8723au: Fix randconfig build errors

The kbuild test robot got the following errors for i386-randconfig-c0-04060652: ERROR: "wiphy_free" [drivers/staging/rtl8723au/r8723au.ko] undefined! ERROR: "bridge_tunnel_header" [drivers/staging/rtl8723au/r8723au.ko] undefined! ERROR: "ieee80211_frequency_to_channel" [drivers/staging/rtl8723au/r

Re: [PATCH] staging: r8723au: Fix randconfig build errors

On Sat, Apr 05, 2014 at 10:48:59PM -0500, Larry Finger wrote: > The kbuild test robot got the following errors for > i386-randconfig-c0-04060652: > > ERROR: "wiphy_free" [drivers/staging/rtl8723au/r8723au.ko] undefined! > ERROR: "bridge_tunnel_header" [drivers/staging/rtl8723au/r8723au.ko] > und

[PATCH 3.14.0/linux-next]: staging/line6: playback.c style corrections

From: Sami Laine Five coding style corrections to drivers/staging/line6/playback.c. Signed-Off-by: Sami Laine --- --- linux-next/drivers/staging/line6/playback.c.orig2014-04-06 08:19:30.190381250 +0300 +++ linux-next/drivers/staging/line6/playback.c 2014-04-06 08:27:25.721393581 +0300 @@