[PATCH] staging: lirc: fix NULL pointer dereference

2014-04-02 Thread Daeseok Youn
coccicheck says: drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: ERROR: ir is NULL but dereferenced. Signed-off-by: Daeseok Youn --- drivers/staging/media/lirc/lirc_igorplugusb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/lirc/lir

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Paul Bolle
On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > Staging driver pull request for 3.15-rc1 > > Here's the huge drivers/staging/ update for 3.15-rc1. > > Loads of cleanup fixes, a few drivers removed, and some new ones added. > > All have been in linux-next for a while. > >[...] > > Insop Song

Re: [PATCH] staging: lirc: fix NULL pointer dereference

2014-04-02 Thread Dan Carpenter
On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote: > > coccicheck says: > drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: > ERROR: ir is NULL but dereferenced. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/media/lirc/lirc_igorplugusb.c |4 ++-- > 1 files chang

[PATCH] Staging: xgifb: Coding style cleanup, newline added after declarations

2014-04-02 Thread Martin Berglund
Added newlines after declarations. Signed-off-by: Martin Berglund --- drivers/staging/xgifb/XGI_main_26.c | 2 ++ drivers/staging/xgifb/vb_init.c | 2 ++ drivers/staging/xgifb/vb_setmode.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/

Re: [PATCH] staging: lirc: fix NULL pointer dereference

2014-04-02 Thread DaeSeok Youn
You are right. remove whole thing and send it again. Thanks. Daeseok Youn 2014-04-02 18:13 GMT+09:00 Dan Carpenter : > On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote: >> >> coccicheck says: >> drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21: >> ERROR: ir is NULL but derefer

[PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc()

2014-04-02 Thread Daeseok Youn
"ir" is already checked before calling unregister_from_lirc(). Signed-off-by: Daeseok Youn --- drivers/staging/media/lirc/lirc_igorplugusb.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/

Re: [PATCH] staging: lirc: fix NULL pointer dereference

2014-04-02 Thread DaeSeok Youn
Please drop this patch. I made a patch as Dan's comment and sent it. Thanks. Daeseok Youn. 2014-04-02 18:41 GMT+09:00 DaeSeok Youn : > You are right. remove whole thing and send it again. > > Thanks. > Daeseok Youn > > 2014-04-02 18:13 GMT+09:00 Dan Carpenter : >> On Wed, Apr 02, 2014 at 05:18:3

Re: [PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc()

2014-04-02 Thread Dan Carpenter
On Wed, Apr 02, 2014 at 02:49:03AM -0700, Daeseok Youn wrote: > > "ir" is already checked before calling unregister_from_lirc(). > Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.

[PATCH] staging: rts5208: fix static checker warnings

2014-04-02 Thread micky_ching
From: Micky Ching The patch fa590c222fba: "staging: rts5208: add support for rts5208 and rts5288" from Nov 12, 2013, leads to the following static checker warning: drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int() warn: add curly braces? This warning is produced becaus

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Shuah Khan
On Tue, Apr 1, 2014 at 12:48 PM, Greg KH wrote: > The following changes since commit dcb99fd9b08cfe1afe426af4d8d3cbc429190f15: > > Linux 3.14-rc7 (2014-03-16 18:51:24 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ > tag

Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-04-02 Thread Lee Jones
On Tue, 01 Apr 2014, Andrew Morton wrote: > On Tue, 1 Apr 2014 11:20:32 +0800 Roger wrote: > > > On 03/25/2014 06:44 PM, rogera...@realtek.com wrote: > > > From: Roger Tseng > > > > > > Realtek USB memstick host driver provides memstick host support based on > > > the > > > Realtek USB card re

[PATCH v2 0/4] staging: vt6655: style fixes

2014-04-02 Thread Guido Martínez
Miscellaneous style fixes for the vt6655 driver. Should not affect functionality at all. Also remove dead code and some stale comments. Shrink driver size by 1100 lines. Guido Martínez (4): staging: vt6655: fix DBG_PRT and PRINT_K macros staging: vt6655: remove mention of nonexistent function

[PATCH v2 1/4] staging: vt6655: fix DBG_PRT and PRINT_K macros

2014-04-02 Thread Guido Martínez
Wrap both macros inside a 'do { ... } while(0)' to prevent breakage if used within another 'if'. Also fix a usage of DBG_PRT with a missing semicolon. Signed-off-by: Guido Martínez --- drivers/staging/vt6655/device.h | 13 +++-- drivers/staging/vt6655/wpactl.c | 2 +- 2 files changed, 1

[PATCH v2 2/4] staging: vt6655: remove mention of nonexistent function CARDbSetBasicRate

2014-04-02 Thread Guido Martínez
Comments mention a function CARDbSetBasicRate, but it never existed in the source tree. Remove all mention of it. Signed-off-by: Guido Martínez --- drivers/staging/vt6655/card.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6

Re: [PATCH v2 0/4] staging: vt6655: style fixes

2014-04-02 Thread Dan Carpenter
Looks ok to me. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 07:06:00AM -0600, Shuah Khan wrote: > On Tue, Apr 1, 2014 at 12:48 PM, Greg KH wrote: > > The following changes since commit dcb99fd9b08cfe1afe426af4d8d3cbc429190f15: > > > > Linux 3.14-rc7 (2014-03-16 18:51:24 -0700) > > > > are available in the git repository at: > > >

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > > Staging driver pull request for 3.15-rc1 > > > > Here's the huge drivers/staging/ update for 3.15-rc1. > > > > Loads of cleanup fixes, a few drivers removed, and some new ones added

[no subject]

2014-04-02 Thread Sarath Lakshman
___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: nokia_h4p: Fix a coding style problem

2014-04-02 Thread code
From: Sarath Lakshman Fold a line to make it less than 80 characters Signed-off-by: Sarath Lakshman --- drivers/staging/nokia_h4p/nokia_fw-bcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/nokia_h4p/nokia_fw-bcm.c b/drivers/staging/nokia_h4p/nokia_fw-

RE: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Insop Song
On Wed, April 02, 2014 1:04 PM, Greg KH wrote: > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: > > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > > > Staging driver pull request for 3.15-rc1 > > > > > > Here's the huge drivers/staging/ update for 3.15-rc1. > > > > > > Loads of cl

[PATCH] driver: staging: wlan-ng: Fixed coding style

2014-04-02 Thread Sherif Shehab Aldin
Fixed coding style for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 70 - 1 file changed, 33 insertions(+), 37 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb

[PATCH] staging: vme: Fix a small coding style issue in vme_user.c

2014-04-02 Thread Bojan Prtvar
The checkpatch.pl complains about missing blank line after declaration. This patch silence the warning. Signed-off-by: Bojan Prtvar --- This patch is for Eudyptula Challenge task 10 drivers/staging/vme/devices/vme_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/vme/d

Re: [PATCH] driver: staging: wlan-ng: Fixed coding style

2014-04-02 Thread Greg KH
On Thu, Apr 03, 2014 at 12:16:56AM +0200, Sherif Shehab Aldin wrote: > Fixed coding style for hfa384x_usb.c You do a lot of different types of cleanup in this patch, you are going to have to be more specific. Also, only do 1 thing per patch, I see whitespace cleanups, typedef removal and other th

[PATCH] staging: gs_fpgaboot: Fixed code style issues

2014-04-02 Thread Rocco Folino
Fixed missing a blank line after declarations warning Signed-off-by: Rocco Folino --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- drivers/staging/gs_fpgaboot/io.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b

[PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Sherif Shehab Aldin
Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

Re: [PATCH] driver: staging: wlan-ng: Fixed coding style

2014-04-02 Thread Sherif
I resubmitted a new patch with only one style rule fixed. the rest will follow. On 04/03/2014 12:28 AM, Greg KH wrote: On Thu, Apr 03, 2014 at 12:16:56AM +0200, Sherif Shehab Aldin wrote: Fixed coding style for hfa384x_usb.c You do a lot of different types of cleanup in this patch, you are g

Re: [GIT PULL] Staging driver patches for 3.15-rc1

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 08:52:18PM +, Insop Song wrote: > On Wed, April 02, 2014 1:04 PM, Greg KH wrote: > > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: > > > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > > > > Staging driver pull request for 3.15-rc1 > > > > > > > > Here'

[PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Sherif Shehab Aldin
Fixed coding style rule "Breaking long lines and strings" for hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Sherif
done and sent in a new mail. BTW regarding "Alignment should match open parenthesis" rule, It's missing from Documentation/CodingStyle On 04/03/2014 01:21 AM, Joe Perches wrote: On Thu, 2014-04-03 at 01:17 +0200, Sherif Shehab Aldin wrote: Fixed coding style rule "Breaking long lines and str

Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Joe Perches
On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote: > BTW regarding "Alignment should match open parenthesis" rule, It's > missing from Documentation/CodingStyle It's "maintainer's preference" in at least net/, drivers/net and drivers/staging. Maybe it's true for drivers/usb too. Greg? __

Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Greg KH
On Wed, Apr 02, 2014 at 04:40:38PM -0700, Joe Perches wrote: > On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote: > > BTW regarding "Alignment should match open parenthesis" rule, It's > > missing from Documentation/CodingStyle > > It's "maintainer's preference" in at least > net/, drivers/net and

Re: [PATCH] driver: staging: wlan-ng: Fixed Breaking long lines and strings style rule

2014-04-02 Thread Joe Perches
On Wed, 2014-04-02 at 16:48 -0700, Greg KH wrote: > On Wed, Apr 02, 2014 at 04:40:38PM -0700, Joe Perches wrote: > > On Thu, 2014-04-03 at 01:37 +0200, Sherif wrote: > > > BTW regarding "Alignment should match open parenthesis" rule, It's > > > missing from Documentation/CodingStyle > > > > It's

Re: [PATCH v2 0/4] staging: vt6655: style fixes

2014-04-02 Thread Ezequiel García
Hi Guido, On 2 April 2014 14:53, Guido Martínez wrote: > Miscellaneous style fixes for the vt6655 driver. Should not affect > functionality at all. Also remove dead code and some stale comments. > Shrink driver size by 1100 lines. > Just a suggestion for future patches. It's good practice to add

[PATCH] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

2014-04-02 Thread Sherif Shehab Aldin
Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 5b

[PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c

2014-04-02 Thread Sherif Shehab Aldin
Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin --- drivers/staging/wlan-ng/hfa384x_usb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 4cfd074..4e05