[...]
> >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t
> >>message)
> >>+{
> >>+ struct rtsx_ucr *ucr =
> >>+ (struct rtsx_ucr *)usb_get_intfdata(intf);
> >>+
> >>+ dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
> >>+ __func__, m
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote:
> On 03/26/2014 10:36 PM, Oliver Neukum wrote:
> > On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote:
> >> From: Roger Tseng
> >> + if (ret)
> >> + goto out_init_fail;
> >> +
> >> + /* initialize USB SG transfer timer */
> >>
"EntryNo" comes from the user in rtl8192_ioctl(). We should limit it
to 31 to prevent memory corruption.
Also we may as well return on invalid data in setKey() as well.
Signed-off-by: Dan Carpenter
---
Static analysis. I'm not certain this fix is enough to solve the whole
problem. Please revi
On 03/28/2014 04:31 PM, Oliver Neukum wrote:
On Fri, 2014-03-28 at 11:33 +0800, Roger wrote:
On 03/26/2014 10:36 PM, Oliver Neukum wrote:
On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote:
From: Roger Tseng
+ if (ret)
+ goto out_init_fail;
+
+ /* ini
checkpatch script returns the following warning:
WARNING: line over 80 characters
310: FILE: drivers/staging/netlogic/xlr_net.c:310:
+ void *accel_priv, select_queue_fallback_t fallback)
This patch fixes the coding style issue.
Signed-off-by: Neil Armstrong
---
drivers/staging/net
On Fri, Mar 28, 2014 at 10:43:43AM +0100, Neil Armstrong wrote:
> checkpatch script returns the following warning:
> WARNING: line over 80 characters
> 310: FILE: drivers/staging/netlogic/xlr_net.c:310:
> + void *accel_priv, select_queue_fallback_t fallback)
>
> This patch fixes the
The subject should be:
[PATCH] Staging: netlogic: long lines in xlr_net.c
You were missing the subsystem prefix: "Staging: netlogic:".
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/
On Fri, Mar 14, 2014 at 12:39:11AM +0900, Jérôme Pinot wrote:
> On 03/13/14 02:28, Greg Kroah-Hartman wrote:
> > On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote:
> [...]
> > > diff --git a/drivers/staging/ozwpan/ozcdev.c
> > > b/drivers/staging/ozwpan/ozcdev.c
> > > index 5de5981..10c
These patches are fine and they were applied already.
On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd,
> uchar __user *ubios, int len)
> /*
> * Checks to see if the BIOS completed running on the card.
On Thu, Mar 13, 2014 at 12:30:48AM -0400, Gary Rookard wrote:
> I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
> should be immediately below its function warning fix.
>
Checkpatch.pl is wrong here and your patch breaks the build if LPROCFS
is defined. (Probably it breaks the bu
On Thu, Mar 13, 2014 at 03:39:18PM -0500, Ken Cox wrote:
> Clean up multiple sparse warnings mostly due to different address spaces
> when accessing I/O memory.
The missing calls to readl() are bug fixes, not cleanups. (Cleanups
mean it doesn't change how the code works).
> -visor_signal_insert(
On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote:
> Clean up code to get rid of sparse warnings, mostly due to accessing I/O
> space.
>
> Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(),
> and visorchannel_safesignalinsert() since they were not called from anywhere.
>
On 03/28/2014 07:34 AM, Dan Carpenter wrote:
> These patches are fine and they were applied already.
>
> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd,
>> uchar __user *ubios, int len)
>> /*
>> * Ch
On 03/28/2014 09:08 AM, Mark Hounschell wrote:
> On 03/28/2014 07:34 AM, Dan Carpenter wrote:
>> These patches are fine and they were applied already.
>>
>> On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
>>> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_load(struct board_t *brd
(adding Andrew Morton, David Miller and LKML to cc's)
On Fri, 2014-03-28 at 14:18 +0300, Dan Carpenter wrote:
> On Fri, Mar 14, 2014 at 12:39:11AM +0900, Jérôme Pinot wrote:
> > On 03/13/14 02:28, Greg Kroah-Hartman wrote:
> > > On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote:
> > [..
On 03/28/2014 07:53 AM, Dan Carpenter wrote:
On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote:
Clean up code to get rid of sparse warnings, mostly due to accessing I/O space.
Remove visorchannel_get_safe_queue(), visorchannel_safesignalremove(),
and visorchannel_safesignalinsert() since
On Fri, Mar 28, 2014 at 09:05:38AM -0500, Ken Cox wrote:
>
> On 03/28/2014 07:53 AM, Dan Carpenter wrote:
> >On Thu, Mar 13, 2014 at 03:39:21PM -0500, Ken Cox wrote:
> >>Clean up code to get rid of sparse warnings, mostly due to accessing I/O
> >>space.
> >>
> >>Remove visorchannel_get_safe_queue
cal matter, and is neare
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
In usbdux_ao_cmd(), the channels for the command are transfered from the
cmd->chanlist and stored in the private data 'ao_chanlist'. The channel
numbers are bit-shifted when stored so that they become the "command"
that is transfered to the device. The channel to command conversion
results in the '
checkpatch script returns the following warning:
WARNING: line over 80 characters
310: FILE: drivers/staging/netlogic/xlr_net.c:310:
+ void *accel_priv, select_queue_fallback_t fallback)
This patch fixes the coding style issue.
Signed-off-by: Neil Armstrong
---
drivers/staging/net
On Fri, Mar 28, 2014 at 02:43:01PM +0100, Neil Armstrong wrote:
> checkpatch script returns the following warning:
> WARNING: line over 80 characters
> 310: FILE: drivers/staging/netlogic/xlr_net.c:310:
> + void *accel_priv, select_queue_fallback_t fallback)
>
> This patch fixes the
On Fri, Mar 28, 2014 at 09:08:34AM -0400, Mark Hounschell wrote:
> On 03/28/2014 07:34 AM, Dan Carpenter wrote:
> > These patches are fine and they were applied already.
> >
> > On Wed, Mar 12, 2014 at 12:50:55PM -0400, Mark Hounschell wrote:
> >> @@ -4368,15 +4364,16 @@ static void dgap_do_bios_l
On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote:
> On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote:
> > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c
>
> Making code checkpatch clean shouldn't be the primary goal here.
Perhaps not, but it was *my* goal :)
> Removing uses of Hu
From: Jake Edge
Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c
Against next-20140328 tree
Signed-off-by: Jake Edge
---
There were two > 80 lines that I couldn't find a sensible way to split
up, otherwise it is checkpatch clean
v2: fixes suggested by Joe Perches
diff
Good Day,
Going through dossiers of personalities and properties in your Country, I
discretely selected you for this proposition I am about to make you in,I am
Khan Habib a personal consultant to Colonel Mauma Gaddafi of Libya. As you
may be aware of the civil revolution that has just engulfed Lib
>From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
From: Paul McQuade
Date: Fri, 28 Mar 2014 22:16:22 +
Subject: [PATCH] Staging:et131x: change memcpy() ether_addr_copy()
replace memcpy() with ether_addr_copy()
make checkpatch.pl clean
Signed-off-by: Paul McQuade
---
On Fri, 2014-03-28 at 22:27 +, paulmcquad wrote:
> replace memcpy() with ether_addr_copy()
> make checkpatch.pl clean
broken.
You at least need to change this definition:
drivers/staging/et131x/et131x.c:static const u8 default_mac[] = { 0x00,
0x05, 0x3d, 0x00, 0x02, 0x00 };
and add _
commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
Author: Benjamin Tissoires
Date: Thu Feb 20 15:24:49 2014 -0500
HID: make .raw_request mandatory
SET_REPORT and GET_REPORT are mandatory in the HID specification.
Make the corresponding API in hid-core mandatory too, which removes the
On Mar 28 2014 or thereabouts, K. Y. Srinivasan wrote:
> commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> Author: Benjamin Tissoires
> Date: Thu Feb 20 15:24:49 2014 -0500
>
> HID: make .raw_request mandatory
>
> SET_REPORT and GET_REPORT are mandatory in the HID specification.
>
On Fri, 28 Mar 2014, K. Y. Srinivasan wrote:
> commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> Author: Benjamin Tissoires
> Date: Thu Feb 20 15:24:49 2014 -0500
>
> HID: make .raw_request mandatory
>
> SET_REPORT and GET_REPORT are mandatory in the HID specification.
> Make the
The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
A driver for it has been available in a GitHub repo for several months.
Jes Sorensen at RedHat has made many improvements to the vendor code,
and he has been doing the testing. I do not have access to this device.
Signed-off-by:
This commit also creates a TODO file.
Signed-off-by: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/Kconfig| 2 ++
drivers/staging/Makefile | 1 +
drivers/staging/rtl8723au/Kconfig | 37
drivers/staging/rtl8723au/Makefile | 58 +++
On 03/28/2014 10:26 PM, Joe Perches wrote:
On Fri, 2014-03-28 at 21:37 -0500, Larry Finger wrote:
The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
A driver for it has been available in a GitHub repo for several months.
[]
133 files changed, 89878 insertions(+)
eek. rea
On Fri, 2014-03-28 at 21:37 -0500, Larry Finger wrote:
> The Realtek USB device RTL8723AU is found in Lenovo Yoga 13 tablets.
> A driver for it has been available in a GitHub repo for several months.
[]
> 133 files changed, 89878 insertions(+)
eek. realtek don't do small or concise.
__
From: "Lad, Prabhakar"
This patch fixes following checkpatch warning,
media/davinci_vpfe/dm365_ipipe.c:1271: WARNING: Missing a blank line after
declarations
media/davinci_vpfe/dm365_ipipe.c:1313: WARNING: Missing a blank line after
declarations
Signed-off-by: Lad, Prabhakar
---
drivers/stag
> -Original Message-
> From: Jiri Kosina [mailto:jkos...@suse.cz]
> Sent: Friday, March 28, 2014 6:43 PM
> To: KY Srinivasan
> Cc: gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> benjamin.tissoi...@redhat.com; dh.herrm...@gmail.com
> Subjec
36 matches
Mail list logo
