Re: [PATCH v2 0/2] mmc: rtsx: add new cmd type handle and modify error handle

2014-03-27 Thread Ulf Hansson
On 27 March 2014 06:35, wrote: > From: Micky Ching > > v2: > fix checkpatch warning. > WARNING: Missing a blank line after declarations > > v1: > Add new command type(R1 without CRC) handle, without this > patch mmc card initialize will be failed. > > Using a more careful handle in request timeo

[RFC] staging:dgap: sparse errors/warnings

2014-03-27 Thread Mark Hounschell
checkpatch now gives 0 warnings or errors on both dgap.c and dgap.h so I'm now looking at sparse errors/warnings. There are many and I'm not really clear as to the best way to address them. This is my first exposure to sparse. A quick internet search reveals that using "__iomem" in some way is the

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-27 Thread Aaron Sierra
- Original Message - > From: "DaeSeok Youn" > Sent: Wednesday, March 26, 2014 8:47:51 PM > > 2014-03-27 3:51 GMT+09:00 Aaron Sierra : > > - Original Message - > >> From: "Daeseok Youn" > >> Sent: Tuesday, March 25, 2014 10:01:48 PM > >> Subject: [PATCH] staging: vme: fix memory l

[PATCH] Staging: slicoss: Fix smatch warning in slicoss.c

2014-03-27 Thread Monam Agarwal
This patch fixes following smatch warning: slicoss/slicoss.c:1429 slic_cmdq_addcmdpage() error: we previously assumed 'pslic_handle' could be null Signed-off-by: Monam Agarwal --- drivers/staging/slicoss/slicoss.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

[PATCH] staging: dgnc: cleanup dgnc_finalize_board_init()

2014-03-27 Thread Antoine Sirinelli
Trivial cleanups: - Transform a printk() to a dev_err() call - Fix 2 lines over 80 characters Signed-off-by: Antoine Sirinelli --- drivers/staging/dgnc/dgnc_driver.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging

[PATCH] taging: lustre: use __func__ instead of __FUNCTION__

2014-03-27 Thread Christoph Jaeger
__FUNCTION__ is gcc specific; use __func__ instead. Signed-off-by: Christoph Jaeger --- drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++-- drivers/staging/lustre/lustre/include/linux/obd.h | 2 +- drivers/staging/lustre/lustre/include/lu_ref.h | 4 ++--

re: staging: rts5208: add support for rts5208 and rts5288

2014-03-27 Thread Dan Carpenter
Hello Micky Ching, The patch fa590c222fba: "staging: rts5208: add support for rts5208 and rts5288" from Nov 12, 2013, leads to the following static checker warning: drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int() warn: add curly braces? drivers/staging/rts5208/rtsx_

Re: [RFC] staging:dgap: sparse errors/warnings

2014-03-27 Thread Dan Carpenter
On Thu, Mar 27, 2014 at 09:22:36AM -0400, Mark Hounschell wrote: > checkpatch now gives 0 warnings or errors on both dgap.c and dgap.h > so I'm now looking at sparse errors/warnings. There are many and I'm > not really clear as to the best way to address them. This is my first > exposure to sparse

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-27 Thread DaeSeok Youn
2014-03-27 23:30 GMT+09:00 Aaron Sierra : > > - Original Message - >> From: "DaeSeok Youn" >> Sent: Wednesday, March 26, 2014 8:47:51 PM >> >> 2014-03-27 3:51 GMT+09:00 Aaron Sierra : >> > - Original Message - >> >> From: "Daeseok Youn" >> >> Sent: Tuesday, March 25, 2014 10:01:48

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-27 Thread Jimmy Li
On Wed, Mar 26, 2014 at 12:42:43AM -0700, Jimmy Li wrote: > fix a sparse warning. > drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted > gfp_t > drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in > argument 2 (different base types) > drivers/staging/vt6655/iwctl.c

I need your help,

2014-03-27 Thread H . Khan
Good Day, Going through dossiers of personalities and properties in your Country, I discretely selected you for this proposition I am about to make you in,I am Khan Habib a personal consultant to Colonel Mauma Gaddafi of Libya. As you may be aware of the civil revolution that has just engulfed Lib

Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-27 Thread Roger
On 03/26/2014 10:36 PM, Oliver Neukum wrote: On Tue, 2014-03-25 at 18:44 +0800, rogera...@realtek.com wrote: From: Roger Tseng +static int rtsx_usb_probe(struct usb_interface *intf, +const struct usb_device_id *id) +{ + struct usb_device *usb_dev = interface_t