Re: [PATCH v2] staging: line6: Add blank lines after declarations

2014-03-25 Thread Stefan Hajnoczi
On Mon, Mar 24, 2014 at 11:46 PM, Fabian Mewes wrote: > Use the more common kernel coding style. > > Signed-off-by: Fabian Mewes > --- > applies to next-20140324 > v1..v2: improve commit message as suggested by Joe > > drivers/staging/line6/driver.c | 1 + > drivers/staging/line6/playback.c |

[PATCH 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

2014-03-25 Thread micky_ching
From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags unhandled in realtek pci host driver. This will make MMC card failed initialize, this patch is used to handle the new cmd.flags condition and MMC card can be used. Signed-off-by: Micky Ching --- drivers/mmc

[PATCH 0/2] mmc: rtsx: add new cmd type handle and modify error handle

2014-03-25 Thread micky_ching
From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover capability. Debug info is printed using non DMA mode, this would help print more accurately for D

[PATCH 2/2] mmc: rtsx: modify error handle and remove smatch warnings

2014-03-25 Thread micky_ching
From: Micky Ching Using non-DMA dump-regs, which would be more exactly for DMA transfer failed. More careful handle when cmd/data timeout, add stop(CMD12) cmd before go to finish request when multi-rw timeout. Remove some static checher warings. on commit: drivers/mmc/host/rtsx_pci_sdmmc.c:194

Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify error handle

2014-03-25 Thread Ulf Hansson
On 25 March 2014 10:47, wrote: > From: Micky Ching > > Add new command type(R1 without CRC) handle, without this > patch mmc card initialize will be failed. > > Using a more careful handle in request timeout, this would > improve error recover capability. Debug info is printed > using non DMA mo

[PATCH v5 3/3] memstick: Add realtek USB memstick host driver

2014-03-25 Thread rogerable
From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/memstick/host/Kconfig | 10 + drivers/memstick/host/Makefile | 1 + drivers/memstick/host/rtsx_usb_ms.c | 839

[PATCH v5 0/3] Add modules for realtek USB card reader

2014-03-25 Thread rogerable
From: Roger Tseng This patchset adds modules to support Realtek USB vendor specific class flash card reader: one base module in MFD subsystem and two host modules in both mmc and memstick subsystems. The architecture is similar to rtsx_pci. This work is done primarily to replace the staging driv

[PATCH v5 1/3] mfd: Add realtek USB card reader driver

2014-03-25 Thread rogerable
From: Roger Tseng Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng --- drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile

[PATCH v5 2/3] mmc: Add realtek USB sdmmc host driver

2014-03-25 Thread rogerable
From: Roger Tseng Realtek USB SD/MMC host driver provides mmc host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/mmc/host/Kconfig |7 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/rtsx_usb_sdmmc.c | 1462 ++

Re: [PATCH] staging: comedi: s626: use comedi_timeout() on remaining loops

2014-03-25 Thread Ian Abbott
On 2014-03-25 05:09, Chase Southwood wrote: There were just a handful of more while loops in this file that need timeouts, and this patch takes care of them, using comedi_timeout(). A couple of new callbacks are introduced, but there was one case where the appropriate callback function was alrea

[PATCH v2] staging/usbip: fix store_attach() sscanf return value check

2014-03-25 Thread Shuah Khan
sscanf() parses the input buffer for four input items. However, the return value check is incorrect, as it checks for one input item instead of four which is what it is expecting in the input buffer. As a result, sscanf() will always fail even when the input buffer is correct. Signed-off-by: Shuah

Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

2014-03-25 Thread Sergei Shtylyov
Hello. On 03/25/2014 02:12 AM, Shuah Khan wrote: Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7 Please also specify that commit's summary line in parens. Also, there's now an established format for such things: Fixes: <12-digit SHA ID> ("") You can place such line before your

[PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Marcos A. Di Pietro
Fixes code style errors in drivers/staging/bcm/Qos.c Patch submitted as part of the Eudyptula Challenge. Signed-off-by: Marcos A. Di Pietro --- drivers/staging/bcm/Qos.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging

[PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Wilfried Klaebe
staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls It looks like someone did a search-and-replace on that driver, putting spaces before "=" characters, without checking this is OK everywhere. Also, in some places, there's memcpm()s/strncmp()s checking for some different length

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: > Fixes code style errors in drivers/staging/bcm/Qos.c > > Patch submitted as part of the Eudyptula Challenge. > > Signed-off-by: Marcos A. Di Pietro > --- > drivers/staging/bcm/Qos.c | 13 - > 1 file changed, 8 in

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls > > It looks like someone did a search-and-replace on that driver, putting > spaces before "=" characters, without checking this is OK everywhere. > Also, in s

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Marcos Di Pietro
Thank you for the advise and the heads up. On Tue, Mar 25, 2014 at 2:14 PM, Greg KH wrote: > On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote: >> Fixes code style errors in drivers/staging/bcm/Qos.c >> >> Patch submitted as part of the Eudyptula Challenge. >> >> Signed-off-by:

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Wilfried Klaebe
Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: > > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls > > > > It looks like someone did a search-and-replace on that driver, putting > > spaces before

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 06:36:18PM +, Wilfried Klaebe wrote: > Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > > On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: > > > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls > > > > > > It looks like

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Wilfried Klaebe
Am Tue, Mar 25, 2014 at 11:51:45AM -0700 schrieb Greg KH: > On Tue, Mar 25, 2014 at 06:36:18PM +, Wilfried Klaebe wrote: > > Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > > > On Tue, Mar 25, 2014 at 05:59:39PM +, Wilfried Klaebe wrote: > > > > staging: rtl8188eu: remove spaces

[PATCH 04/06] staging: dgap: remove volatiles from dgap.h

2014-03-25 Thread Mark Hounschell
This patch fixes checkpatch warnings about using volatiles in dgap.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman Tested-by: Mark Hounschell --- drivers/staging/dgap/dgap.h | 152 ++-- 1 file changed, 76 insertions(+), 76 deletions(-) diff --gi

[PATCH 06/06] staging: dgap: fix checkpatch warning about adding typedefs

2014-03-25 Thread Mark Hounschell
This patch fixes a checkpatch warning about adding typedefs in dgap.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dgap.h index 2fce41c

[PATCH 00/06] staging: dgap: Digi International dgap driver

2014-03-25 Thread Mark Hounschell
patch 1: remove some extra empty lines not previously caught. patch 2: the firmware loading provess loads the config file for each board found. It only needs to load it once. patch 3: fixes a checkpatch warning about a macro needing parenthesis patch 4: removes volatiles from dgap.h as rec

[PATCH 03/06] staging: dgap: Macros with complex values should be enclosed in parenthesis

2014-03-25 Thread Mark Hounschell
This patch fixes a checkpatch warning "Macros with complex values should be enclosed in parenthesis" Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgap/dgap.h b/drivers/st

[PATCH 01/06] staging: dgap: Removes excessive empty lines from dgap.h

2014-03-25 Thread Mark Hounschell
This patch removes excessive empty lines from dgap.h not previously caught. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/staging/dgap/dgap.h b/drivers/staging/dgap/dga

RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread Haiyang Zhang
> -Original Message- > From: Haiyang Zhang [mailto:haiya...@microsoft.com] > Sent: Friday, March 21, 2014 4:44 PM > To: da...@davemloft.net; net...@vger.kernel.org > Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; > linux-ker...@vger.kernel.org; driverdev-devel@linu

[PATCH 05/06] staging: dgap: fix/change a pr_info

2014-03-25 Thread Mark Hounschell
This patch just fixes a pr_info. brd->state is not proper at this point in time. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap

[PATCH 02/06] staging: dgap: Only read config file dgap.conf once

2014-03-25 Thread Mark Hounschell
The config file is currently read for each board found. It only needs to be read one time. The buffer it is read into can now be freed immediately after it is parsed instead of at driver unload time. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 18

[PATCH 1/3] staging: vt6655: removed incorrect casting in wpactl.c

2014-03-25 Thread silvio
From: Silvio F This patch fixes the following type of sparse warnings: drivers/staging/vt6655/wpactl.c:596:47: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:638:68: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:860:42: warning: cast from restricted gfp

[PATCH 3/3] staging: vt6655: removed incorrect casting in iwctl.c

2014-03-25 Thread silvio
From: Silvio F This patch fixes the following type of sparse warning: drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted gfp_t Signed-off-by: Silvio F --- drivers/staging/vt6655/iwctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt66

[PATCH 2/3] staging: vt6655: removed incorrect casting in ioctl.c

2014-03-25 Thread silvio
From: Silvio F This patch fixes the following type of sparse warnings: drivers/staging/vt6655/ioctl.c:308:104: warning: cast from restricted gfp_t drivers/staging/vt6655/ioctl.c:579:109: warning: cast from restricted gfp_t Signed-off-by: Silvio F --- drivers/staging/vt6655/ioctl.c | 6 --

[WIP] [PATCH 0/3] remove wrong cast of gfp_t flags

2014-03-25 Thread silvio
From: Silvio F Hi, I have seen this patch, but in this and two other files we have the same wrong casting. This three little patches remove wrong cast for gfp_t-flags in kamlloc, kzalloc, ... Please review this patch. These patches are WIP because I have no hardware and can only do a compile

Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls

2014-03-25 Thread Greg KH
On Tue, Mar 25, 2014 at 07:04:34PM +, Wilfried Klaebe wrote: > Am Tue, Mar 25, 2014 at 11:51:45AM -0700 schrieb Greg KH: > > On Tue, Mar 25, 2014 at 06:36:18PM +, Wilfried Klaebe wrote: > > > Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > > > > On Tue, Mar 25, 2014 at 05:59:39P

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread David Miller
From: Haiyang Zhang Date: Tue, 25 Mar 2014 20:37:43 + > Do we know when the dependency (commit: 8a7206a89f) will be merged > into net-next tree? You're really not very patient, to say the least. It's done now and I'm working to integrate your patch. That patch has been in under review stat

Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread David Miller
From: David Miller Date: Tue, 25 Mar 2014 20:43:43 -0400 (EDT) > From: Haiyang Zhang > Date: Tue, 25 Mar 2014 20:37:43 + > >> Do we know when the dependency (commit: 8a7206a89f) will be merged >> into net-next tree? > > You're really not very patient, to say the least. > > It's done now a

[PATCH] staging: rtl8192u: fix checkpatch braces warning

2014-03-25 Thread Rui Miguel Silva
fix some code style related to the use of braces in a one statement block Signed-off-by: Rui Miguel Silva --- drivers/staging/rtl8192u/r8192U_dm.c | 7 +++ drivers/staging/rtl8192u/r8192U_wx.c | 3 +-- drivers/staging/rtl8192u/r819xU_firmware.c | 6 ++ drivers/staging/rtl8192

Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle

2014-03-25 Thread micky
Hi Ulf, On 03/25/2014 06:44 PM, Ulf Hansson wrote: On 25 March 2014 10:47, wrote: From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover capability

Re: [PATCH] staging: comedi: s626: use comedi_timeout() on remaining loops

2014-03-25 Thread Chase Southwood
Ian, >On Tuesday, March 25, 2014 7:13 AM, Ian Abbott wrote: >>On 2014-03-25 05:09, Chase Southwood wrote: >>There were just a handful of more while loops in this file that need timeouts, >>and this patch takes care of them, using comedi_timeout().  A couple of new >>callbacks are introduced, but

[PATCH] staging: vme: fix memory leak in vme_user_probe()

2014-03-25 Thread Daeseok Youn
If vme_master_request() returns NULL when it failed, it need to free buffers for master. And also removes unreachable code in vme_user_probe(). Signed-off-by: Daeseok Youn --- drivers/staging/vme/devices/vme_user.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, March 25, 2014 8:47 PM > To: Haiyang Zhang > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org >

[PATCH v2] staging: comedi: s626: use comedi_timeout() on remaining loops

2014-03-25 Thread Chase Southwood
There were just a handful of more while loops in this file that needed timeouts, and this patch takes care of them. One new callback is introduced, and all of the proper comedi_timeout() calls are then used. Signed-off-by: Chase Southwood --- 2: s626_i2c_handshake_eoc() can be used in s626_initi

Re: [PATCH net-next, v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

2014-03-25 Thread Greg KH
On Wed, Mar 26, 2014 at 03:23:47AM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, March 25, 2014 8:47 PM > > To: Haiyang Zhang > > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > > jasow...@redhat.

[PATCH] staging: silicom: hide conditionally used function in condition

2014-03-25 Thread SeongJae Park
bp_proc_create() be called only when BP_PROC_SUPPORT defined but its definition live outside of #ifdef BP_PROC_SUPPORT and cause following trivial build warning: drivers/staging/silicom/bpctl_mod.c:6786:12: warning: ‘bp_proc_create’ defined but not used [-Wunused-function] static int bp_proc_creat