[PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

This patch fixes "incorrect type in argument 1" warning from sparse. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/staging/cxt1e1/hwprobe.c |6 +++--- drivers/staging/cxt1e1/pmcc4_private.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH r2 1/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes sparse warnings. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -28,6 +28,7 @@

[PATCH r2 2/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10 +

[PATCH r2 3/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10 @@ #d

[PATCH r2 4/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH r2 5/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -42

[PATCH r2 6/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepro

[PATCH r2 7/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

Removes unncessary curly braces. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -133,9 +

Re: [PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

On Sun, Mar 23, 2014 at 09:01:48AM -0500, Michael Welling wrote: > This patch series resolves the following sparse warnings: > > CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c > drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol > 'eeprom_put_byte' was not declared. Should it be st

Re: [PATCH r2 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

On Sun, Mar 23, 2014 at 08:58:21AM -0700, Greg Kroah-Hartman wrote: > On Sun, Mar 23, 2014 at 09:01:48AM -0500, Michael Welling wrote: > > This patch series resolves the following sparse warnings: > > > > CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c > > drivers/staging/cxt1e1/pmc93x6_eeprom.c

[PATCH v3 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

This patch series resolves the following sparse warnings: CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol 'eeprom_put_byte' was not declared. Should it be static? drivers/staging/cxt1e1/pmc93x6_eeprom.c:183:1: warning: symbol 'eepr

[PATCH v3 1/7] STAGING: cxt1e1: Remove sparse warnings

Removes sparse warnings by including a header and adding static to some functions. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 78cc170..e16f0d6 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/

[PATCH v3 2/7] STAGING: cxt1e1: Indentation fixes

Indentation fixes using Lindent. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index e16f0d6..a027708 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -44,10 +

[PATCH v3 3/7] STAGING: cxt1e1: Fixes comment blocks

Comment block fixes. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index a027708..572bd2e 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -49,10 +49,10 @@ #d

[PATCH v3 4/7] STAGING: cxt1e1: Remove volatile variable

Removes volatile variable. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 572bd2e..ab6fa73 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -286,7 +286,7

[PATCH v3 5/7] STAGING: cxt1e1: Formatting fixes checkpatch issues

Removes spaces before & where needed. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index ab6fa73..d7d240a 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eeprom.c @@ -42

[PATCH v3 6/7] STAGING: cxt1e1: More formatting fixes

Removes parens as are not necessary for return. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index d7d240a..6153499 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1e1/pmc93x6_eepro

[PATCH v3 7/7] STAGING: cxt1e1: Remove curly braces

Removes unnecessary curly braces from for loop in eeprom_delay. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/cxt1e1/pmc93x6_eeprom.c b/drivers/staging/cxt1e1/pmc93x6_eeprom.c index 6153499..ba588f1 100644 --- a/drivers/staging/cxt1e1/pmc93x6_eeprom.c +++ b/drivers/staging/cxt1

Re: [PATCH v3 0/7] STAGING: cxt1e1: Remove sparse warnings and resolve checkpatch issues

On Sun, Mar 23, 2014 at 11:13:58AM -0500, Michael Welling wrote: > This patch series resolves the following sparse warnings: > > CHECK drivers/staging/cxt1e1/pmc93x6_eeprom.c > drivers/staging/cxt1e1/pmc93x6_eeprom.c:158:1: warning: symbol > 'eeprom_put_byte' was not declared. Should it be st

Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Making code checkpatch clean shouldn't be the primary goal here. Removing uses of Hungarian-style notation, CamelCase naming, and long variable names would be more helpful overall. > di

[PATCH] drivers/staging: Use RCU_INIT_POINTER(x, NULL) in fwserial/fwserial.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, r

Re: [PATCH] staging: octeon-usb: prevent memory corruption

Hi, On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote: > scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5 > sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB) > usb 1-1: reset high-speed USB device number 2 using OcteonUSB > usb 1-1: reset

[PATCH] Staging: media: Fix sparse warnings for incorrect types in lirc_bt829.c

This patch fixes following sparse warnings in lirc_bt829.c drivers/staging/media/lirc/lirc_bt829.c:182:22: warning: incorrect type in assignment (different address spaces) drivers/staging/media/lirc/lirc_bt829.c:182:22:expected unsigned char *static [toplevel] pci_addr_lin drivers/staging/me

[PATCH 1/2] mmc: rtsx: add R1-no-CRC mmc command type handle

From: Micky Ching commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a produced a cmd.flags unhandled in realtek pci host driver. This will make MMC card failed initialize, this patch is used to handle the new cmd.flags condition and MMC card can be used. Signed-off-by: Micky Ching --- drivers/mmc

[PATCH 2/2] mmc: rtsx: modify error handle and remove smatch warnings

From: Micky Ching Using non-DMA dump-regs, which would be more exactly for DMA transfer failed. More careful handle when cmd/data timeout, add stop(CMD12) cmd before go to finish request when multi-rw timeout. Remove some static checher warings. on commit: drivers/mmc/host/rtsx_pci_sdmmc.c:194

mmc: rtsx: add new cmd type handle and modify error handle

From: Micky Ching Add new command type(R1 without CRC) handle, without this patch mmc card initialize will be failed. Using a more careful handle in request timeout, this would improve error recover capability. Debug info is printed using non DMA mode, this would help print more accurately for D

[PATCH V2 05/21] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include/ske

[PATCH V2 04/21] staging: crypto: skein: remove skein_port.h

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644 d

[PATCH V2 03/21] staging: crypto: skein: remove brg_*.h includes

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions(-) dele

[PATCH V2 00/21] staging: add skein/threefish crypto algos

Greg, all, Changes from RFC: - dropped scripts/objdiff patch to be submitted separately - rebased onto staging-next and resolved conflicts -- updated original text to reflect the above -- Attached is a series I've sat on for the past month and a half. I'm hoping that by posting it in it's i

[PATCH V2 13/21] staging: crypto: skein: remove trailing whitespace

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c |

[PATCH V2 15/21] staging: crypto: skein: fix do/while brace formatting

Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein/skein_blo

[PATCH V2 08/21] staging: crypto: skein: use u8, u64 vice uint*_t

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18 +++

[PATCH V2 07/21] staging: crypto: skein: remove all typedef {struct, enum}

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42 +

[PATCH V2 06/21] staging: crypto: skein: remove unneeded typedefs

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein/sk

[PATCH V2 09/21] staging: crypto: skein: fixup pointer whitespace

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18 +

[PATCH V2 02/21] staging: crypto: skein: allow building statically

These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since RFC: - rebased ont

[PATCH V2 16/21] staging: crypto: skein: fix brace placement errors

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff --

[PATCH V2 19/21] staging: crypto: skein: remove braces from single-statement block

Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b/drivers

[PATCH V2 21/21] staging: crypto: skein: add TODO file

Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null ++

[PATCH V2 20/21] staging: crypto: skein: remove unnecessary line continuation

Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c +++

[PATCH V2 18/21] staging: crypto: skein: remove externs from .c files

Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a/dri

[PATCH V2 17/21] staging: crypto: skein: wrap multi-line macros in do-while loops

Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a/

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

On Tue, Mar 18, 2014 at 02:28:20PM +, Greg KH wrote: > On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: > > On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > > > On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: > > > > These are the minimum changes required to

[PATCH V3 02/21] staging: crypto: skein: allow building statically

These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since V2: - fixed whites