On 03/07/2014 05:46 PM, Dan Carpenter wrote:
I still prefer my patch. Unless I'm missing something? Could you
review it and I will submit it as a patch tomorrow.
regards,
dan carpenter
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index d00283a226a2..783cd75a2d96 1006
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, March 8, 2014 12:07 PM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subje
This is a resend of the patches sent a few days ago, including
the migration of USB/IP userspace side to use libudev instead
of libsysfs and various other fixes, all ordered in a big patch
series.
The patches have been modified according to received feedback.
Valentina Manea (18):
staging: usbi
This patch adds autoconf check for libudev and migrates
usbip_bind to the new library.
libsysfs will still be used until all userspace is modified.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/configure.ac | 6 +
.../staging/usbip/userspace
This patch removes useless libsysfs.h includes in various
userspace files.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_attach.c | 1 -
drivers/staging/usbip/userspace/src/usbip_detach.c | 2 --
drivers/staging/usbip/userspace/src/usbip_network.h | 1 -
3 files
This patch modifies usbip_list to use libudev.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/src/usbip_list.c | 133 +--
1 file changed, 50 insertions(+), 83 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip_list.c
b/drivers/staging/us
This was deleted in the driver conversion patch. It didn't need
to be deleted; showing more information is ok.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++-
drivers/staging/usbip/userspace/src/usbipd.c
This patch modifies usbip_host_driver to use libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
.../staging/usbip/userspace/libsrc/usbip_common.c | 76 ++
.../staging/usbip/userspace/libsrc/usbip_common.h | 5 +-
.../usbip/userspace/libsrc/usbip_host_driver.c | 285
Since it offers a API to both usbip tools and libusbip,
it is more appropriate to be place in the library.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 ++-
.../staging/usbip/userspace/libsrc/sysfs_utils.c | 31 ++
.../staging/u
The class device lists were used only when being initialized,
being populated and being destroyed. They had no real meaning
and thus the code was useless.
Signed-off-by: Valentina Manea
---
.../staging/usbip/userspace/libsrc/vhci_driver.c | 178 -
.../staging/usbip/userspac
A sysfs attribute is used to announce kernel space that a
new driver probing session should be triggered for the just
unbinded device.
In order to have the address of struct device associated to this
USB device, a new member has been added to struct bus_id_priv.
Signed-off-by: Valentina Manea
--
Take the linked list implementation from the Linux Kernel
and strip it down to what it is needed.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/list.h | 136 ++
1 file changed, 136 insertions(+)
create mode 100644 drivers/staging/usbip/userspa
Since usbip-host is now a device driver and the client
has full access to the shared device, it makes sense to
let the client choose device configuration.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/stub_dev.c | 10 +-
drivers/staging/usbip/stub_rx.c | 26 +++---
When a device has just been bound to usbip-host but the client hasn't
set a configuration on it, certain attributes will not exist. Don't
treat this as an error.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17 +++--
1 file changed, 15 in
A device should not be able to be used concurrently both by
the server and the client. Claiming the port used by the
shared device ensures no interface drivers bind to it and
that it is not usable from the server.
Signed-off-by: Valentina Manea
Acked-by: Alan Stern
---
drivers/staging/usbip/stu
This patch modifies usbip_unbind to use libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
drivers/staging/usbip/userspace/src/usbip_unbind.c | 93 +++---
1 file changed, 29 insertions(+), 64 deletions(-)
diff --git a/drivers/staging/usbip/userspace/src/usbip_u
libsysfs is now completely removed from USB/IP.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index a5193c6..25b
Add libudev as dependency and remove libsysfs.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/userspace/README
b/drivers/staging/usbip/userspace/README
index 00a1658..6ead290
This is an optional dependency since USB/IP can fully work without
it. However, it is needed to display device information such as
vendor.
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/README | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/usbip/users
Signed-off-by: Valentina Manea
---
drivers/staging/usbip/userspace/configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/userspace/configure.ac
b/drivers/staging/usbip/userspace/configure.ac
index 25bf160..607d05c 100644
--- a/drivers/staging/usbi
This patch migrates vhci_driver to libudev.
Signed-off-by: Valentina Manea
Reviewed-by: Shuah Khan
---
.../staging/usbip/userspace/libsrc/usbip_common.h | 1 -
.../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++---
.../staging/usbip/userspace/libsrc/vhci_driver.h |
Correct spelling typo in lustre/include/lustre
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/include/linux/lustre_acl.h | 2 +-
drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 6 +++---
drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 4 ++--
3 files c
This path fix spelling typo in lustre/include.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/include/cl_object.h | 8
drivers/staging/lustre/lustre/include/ioctl.h | 2 +-
drivers/staging/lustre/lustre/include/lclient.h | 2 +-
drivers/staging/lustr
Fix typo in comments within lustre/include.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +-
.../staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++--
drivers/staging/lustre/lustre/include/lustre_export.h | 4 ++--
drivers/staging/lustre/
This patch fix spelling typo in comments within various part
of luster sources.
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 2 +-
drivers/staging/lustre/lustre/lvfs/lvfs_linux.c | 2 +-
drivers/s
Fix spelling typo in lustre/lustre/llite
Signed-off-by: Masanari Iida
---
drivers/staging/lustre/lustre/llite/dcache.c | 2 +-
drivers/staging/lustre/lustre/llite/file.c | 10 +-
drivers/staging/lustre/lustre/llite/llite_close.c| 2 +-
drivers/staging/lustre/lustr
Fix minor checkpatch.pl style issues (80-char line limits) in
addi_apci_1500.c.
Signed-off-by: Conrad Meyer
---
drivers/staging/comedi/drivers/addi_apci_1500.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1500.c
b/drivers/sta
On Sat, Mar 08, 2014 at 02:38:38PM -0500, Conrad Meyer wrote:
> Fix minor checkpatch.pl style issues (80-char line limits) in
> addi_apci_1500.c.
>
> Signed-off-by: Conrad Meyer
> ---
> drivers/staging/comedi/drivers/addi_apci_1500.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Rename some very long functions in addi-data/hwdrv_apci1500.c.
Signed-off-by: Conrad Meyer
---
.../staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 18 --
drivers/staging/comedi/drivers/addi_apci_1500.c| 4 ++--
2 files changed, 10 insertions(+), 12 deletions(-)
dif
dgap_driver_start and dgap_Major_Control_Registered are used
to keep status of initialization of the driver as a whole and its "Major
Control".
But the code that checks them is executed once on module init/unload.
That makes no sense in these variables as far as their values are predictable
at any
dgap_start() ignored errors in class_create() and device_create().
The patch implements proper error handling.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/staging/dgap/dgap.c | 18 +-
1 file changed, 17 insertions(
From: KY Srinivasan
Date: Sat, 8 Mar 2014 10:27:54 +
> "len" would have gotten decremented prior to the check and in the
> case we are talking about, "len" would be zero and so j would not
> get incremented.
You are correct, this is the part of the logic in this case which I
missed.
Thanks.
The following changes since commit 0414855fdc4a40da05221fc6062cccbc0c30f169:
Linux 3.14-rc5 (2014-03-02 18:56:16 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.15-rc6
for you to fetch changes up to 084b6e7765b
On Sat, Mar 08, 2014 at 03:47:24PM -0500, Conrad Meyer wrote:
> Rename some very long functions in addi-data/hwdrv_apci1500.c.
>
> Signed-off-by: Conrad Meyer
When you update a patch, it's better to have the subject be:
[PATCH v2] Staging:
Otherwise what are you going to do for the
Fixed coding style warnings in comedidev.h which had an extra space
after the function pointer name.
Signed-off-by: Nick Davies
---
drivers/staging/comedi/comedidev.h | 48 +++---
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/come
Enable receive side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 33 -
drivers/net/hyperv/netvsc_drv.c | 19 +++
drivers/net/hyperv/rndis_filter.c |4 +++-
3 files c
Enable segmentation offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 40 +++
drivers/net/hyperv/netvsc_drv.c | 38 +---
2 files changed, 74 insertions(+), 4 deletions
Cleanup the code and enable scatter gather I/O.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/netvsc_drv.c | 153 +--
1 files changed, 114 insertions(+), 39 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/driv
This patch set enables both checksum as well as segmentation offload.
As part of this effort I have enabled scatter gather I/O a well.
In version 2 of these patches, I addressed comments from David Miller and
Dan Carpenter.
In this version I have addressed the latest comments from David Miller.
Enable send side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 10 ++
drivers/net/hyperv/netvsc_drv.c | 69 +-
2 files changed, 77 insertions(+), 2 deletions(-)
diff --git a/drivers
Prior to enabling guest side offloads, enable the offloads on the host.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 55 +
drivers/net/hyperv/rndis_filter.c | 80 +
2 files chan
In preparation for enabling offloads, cleanup the send path.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |7 +---
drivers/net/hyperv/netvsc_drv.c | 88 +
drivers/net/hyperv/rndis_filter.c | 66 ---
Minor style cleanup per checkpatch.pl.
Signed-off-by: Conrad Meyer
---
.../comedi/drivers/addi-data/hwdrv_apci1500.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
b/drivers/staging/come
Brought to you with the help of sed and manual clean-up after.
$ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \
addi-data/hwdrv_apci1500.c
Since all of these printk()s were for invalid API inputs and most of
them returned -EINVAL, I fixed the rest of them to return -EINVAL as
well.
On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
> This patch changes a handful of while loops to timeouts to prevent
> infinite looping on hardware failure. A couple such loops are in a
> function (s626_debi_transfer()) which is called from critical sections,
> so comedi_timeout()
On Sun, Mar 09, 2014 at 11:45:51AM +1100, Nick Davies wrote:
> Fixed coding style warnings in comedidev.h which had an extra space
> after the function pointer name.
>
> Signed-off-by: Nick Davies
> ---
> drivers/staging/comedi/comedidev.h | 48
> +++---
> 1 file
Hi Greg,
>On Saturday, March 8, 2014 9:00 PM, Greg KH wrote:
>>On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
>>This patch changes a handful of while loops to timeouts to prevent
>>infinite looping on hardware failure. A couple such loops are in a
>>function (s626_debi_transfer
This patch changes a handful of while loops to timeouts to prevent
infinite looping on hardware failure. A couple such loops are in a
function (s626_debi_transfer()) which is called from critical sections,
so comedi_timeout() is unusable for them, and an iterative timeout is
used instead. For the w
Fixed coding style warnings in ni_tio.h which had an extra space
after the function pointer name.
Signed-off-by: Nick Davies
---
drivers/staging/comedi/drivers/ni_tio.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_tio.h
b/drivers/
Hi,
I was going through lov_pack.c and in the function lov_unpackmd before
checking for lmm we are using the lmm_pattern value and doing
allocation. In case lmm is null use of pattern =
le32_to_cpu(lmm->lmm_pattern); will throw a null pointer exception.
I was thinking of moving the null check abo
On Fri, Mar 07, 2014 at 09:03:04AM +0900, Daeseok Youn wrote:
>
> The mkret() change a value of error from positive to
> negative. This patch is modified to return negative value
> when it failed. It doesn't need to call with function
> for changing from positive to negative.
>
> Signed-off-by: D
This patch cleans up a few trivial style issues, including fixing crazy
indentation problems in the defines near the top of the file, removing a
couple of unneeded braces, and wrapping a couple of long comments onto new
lines to fix lines which were in excess of 80 characters.
Signed-off-by: Chase
On Sun, Mar 09, 2014 at 11:45:51AM +1100, Nick Davies wrote:
> Fixed coding style warnings in comedidev.h which had an extra space
> after the function pointer name.
>
> Signed-off-by: Nick Davies
> ---
> drivers/staging/comedi/comedidev.h | 48
> +++---
> 1 file
Hi people,
I will be on vacation for the next two weeks.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sat, Mar 08, 2014 at 02:53:18PM +0200, Valentina Manea wrote:
> This is a resend of the patches sent a few days ago, including
> the migration of USB/IP userspace side to use libudev instead
> of libsysfs and various other fixes, all ordered in a big patch
> series.
Very nice work, thanks so mu
This patch fixes a few function names that are very long and are
not in the correct naming style
Signed-off-by: Fred Akers
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 62 ++
drivers/staging/comedi/drivers/addi_apci_1564.c| 16 +++---
2 files changed, 36 inser
56 matches
Mail list logo
