Ok.
I will fix it and send again.
Thanks.
Daeseok Youn
2014-03-07 4:58 GMT+09:00 Greg KH :
> On Thu, Mar 06, 2014 at 05:12:48PM +0900, Daeseok Youn wrote:
>>
>> It doesn't need to assign name array address to np pointer.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> v2: replace sprintf() with snpr
Hi Russell,
Time for me to jump in. The more, the merrier I suppose.
On Wednesday 26 February 2014 22:19:39 Russell King - ARM Linux wrote:
> On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote:
> > Hi Russell
> >
> > (I suspect this my email will be rejected by ALKML too like
On Thursday 27 February 2014 16:10:41 Tomi Valkeinen wrote:
> On 27/02/14 15:43, Russell King - ARM Linux wrote:
> > That may be - but the problem with CDF solving this problem is that it's
> > wrong. It's fixing what is in actual fact a *generic* problem in a much
> > too specific way. To put it
On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> Networking prefers this style, so warn when it's not used.
>
> Networking uses:
>
> void foo(int bar)
> {
> int baz;
>
> code...
> }
>
> not
>
> void foo(int bar)
> {
> int baz;
> code...
> }
>
> There are a lim
Networking prefers this style, so warn when it's not used.
Networking uses:
void foo(int bar)
{
int baz;
code...
}
not
void foo(int bar)
{
int baz;
code...
}
There are a limited number of false positives when using
macros to declare variables like:
WARNING: ne
On Thu, 06 Mar 2014 15:42:30 -0800 Joe Perches wrote:
> On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
> > On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> > > Networking prefers this style, so warn when it's not used.
> > > void foo(int bar)
> > > {
> > > int baz;
> > >
> > >
checkpatch.pl error in linux.c:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 31 +++
1 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/
clean up checkpatch.pl error in linux.c:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 67 ---
1 files changed, 21 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/cxt1e
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c | 72 +---
The name array doens't need to set to 0. Because
sprintf/snprintf adds a terminating '\0'.
And also it doesn't need to assign name array
address to np pointer.
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/linux.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff
Make the test system wide, modify the message too.
Signed-off-by: Joe Perches
---
> OK, let's do this for now. Could you please cook up a followon patch
> which makes this kernel-wide? I'll play with that for a while then I'll
> decide how much I feel like irritating people.
scripts/checkpatc
On Thu, 2014-03-06 at 15:51 -0800, John de la Garza wrote:
> Added code to check return value of sscanf.
[]
> diff --git a/drivers/staging/usbip/usbip_common.c
> b/drivers/staging/usbip/usbip_common.c
[]
> @@ -55,7 +55,8 @@ static ssize_t usbip_debug_store(struct device *dev,
>
Added code to check return value of sscanf.
Signed-off-by: John de la Garza
---
drivers/staging/usbip/usbip_common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/usbip_common.c
b/drivers/staging/usbip/usbip_common.c
index 4a2aab1..2a11233 100644
On Thu, 2014-03-06 at 15:35 -0800, Andrew Morton wrote:
> On Thu, 06 Mar 2014 15:28:40 -0800 Joe Perches wrote:
> > Networking prefers this style, so warn when it's not used.
> > void foo(int bar)
> > {
> > int baz;
> >
> > code...
> > }
> >
> > not
> >
> > void foo(int bar)
> > {
> >
This patch set enables both checksum as well as segmentation offload.
As part of this effort I have enabled scatter gather I/O a well.
In this version of the patches, I have addressed comments from David Miller and
Dan Carpenter.
K. Y. Srinivasan (6):
Drivers: net: hyperv: Enable scatter gather
Prior to enabling guest side offloads, enable the offloads on the host.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 55 +
drivers/net/hyperv/rndis_filter.c | 80 +
2 files chan
Cleanup the code and enable scatter gather I/O.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/netvsc_drv.c | 153 +--
1 files changed, 114 insertions(+), 39 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/driv
Enable send side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 10 ++
drivers/net/hyperv/netvsc_drv.c | 69 +-
2 files changed, 77 insertions(+), 2 deletions(-)
diff --git a/drivers
Enable receive side checksum offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 33 -
drivers/net/hyperv/netvsc_drv.c | 19 +++
drivers/net/hyperv/rndis_filter.c |4 +++-
3 files c
Enable segmentation offload.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 40 +++
drivers/net/hyperv/netvsc_drv.c | 38 +---
2 files changed, 74 insertions(+), 4 deletions
In preparation for enabling offloads, cleanup the send path.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |7 +---
drivers/net/hyperv/netvsc_drv.c | 88 +
drivers/net/hyperv/rndis_filter.c | 66 ---
pcmd->parmbuf->pbuf has been allocated if command is
GEN_CMD_CODE(_Set_Drv_Extra),
and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by
rtw_dequeue_cmd.
The memory leak happened on this branch "if( _FAIL == rtw_cmd_filter(pcmdpriv,
pcmd) )"
which goto post_process directly against
Increase the maximum number of pfns we can handle is a single vmbus packet.
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 330ec44..ab7359f 100644
--- a/inc
On Thu, Mar 06, 2014 at 11:15:08PM -0800, K. Y. Srinivasan wrote:
> Increase the maximum number of pfns we can handle is a single vmbus packet.
Is that a correct sentance?
>
> Signed-off-by: K. Y. Srinivasan
> ---
> include/linux/hyperv.h |2 +-
> 1 files changed, 1 insertions(+), 1 delet
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Friday, March 7, 2014 12:19 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> o...@aepfle.de; a...@canonical.com; jasow...@redhat.com
> Subject: Re: [PATCH 1/1] Driver
Increase the number of PFNs we can handle in a single vmbus packet.
Some network packets may have more PFNs than the current limit we have.
This is not a bug and this patch can be applied to the *next tree.
Signed-off-by: K. Y. Srinivasan
---
include/linux/hyperv.h |2 +-
1 files changed, 1
How many warnings does this generate does this generate when you run it
across the whole tree?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
101 - 127 of 127 matches
Mail list logo
