[PATCH] staging: rtl8187se: fix checkpatch.pl issues

2014-02-20 Thread axel . rasmussen1
From: Axel Rasmussen Date: Mon, 17 Feb 2014 23:50:05 -0700 Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues Reformatted many lines which were too long, replaced various printk calls with appropriate netdev_* calls, and fixed some spelling errors. Signed-off-by: Axel Rasmussen ---

Re: [PATCH 19/19] Add in-kernel firmware loading support

2014-02-20 Thread Dan Carpenter
On Wed, Feb 19, 2014 at 04:01:59PM -0500, Mark Hounschell wrote: > OK, thanks Dan. I'll followup with a new 19/19 patch. It did compile and > work with no complaints about the above though. I should have checked > that last one better as it is > new code added. > No worries. This is the review

Re: [PATCH 19/19] [v4] Add in-kernel firmware loading support

2014-02-20 Thread Dan Carpenter
On Wed, Feb 19, 2014 at 04:54:15PM -0500, Mark Hounschell wrote: > This patch adds in-kernel firmware loading support and removes > support for the original userland firmware loading process. > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman Still has checkpatch errors. total: 10 err

Re: [PATCH] et131x: fix allocation failures

2014-02-20 Thread Dan Carpenter
On Thu, Feb 20, 2014 at 11:03:45AM +0800, Zhao, Gang wrote: > On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote: > > On Wed, 19 Feb 2014 09:14:19 +0800 > > "Zhao\, Gang" wrote: > > > >> Alan, thanks for resending this patch. But it seems you overlooked > >> something we discussed ear

[PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Compostella, Jeremy
Hi, I've found a bug in the binder driver and I propose the attached patch to fix it. This bug could manifest itself in several situations, here is the one that made me hunt it last week. When an Android device is encrypted, Android starts all the init services of core and main levels, then it a

[PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Compostella, Jeremy
Hi, I've found a bug in the binder driver and I propose the attached patch to fix it. This bug could manifest itself in several situations, here is the one that made me hunt it last week. When an Android device is encrypted, Android starts all the init services of core and main levels, then it a

[PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Compostella, Jeremy
Hi, I've found a bug in the binder driver and I propose the attached patch to fix it. This bug could manifest itself in several situations, here is the one that made me hunt it last week. When an Android device is encrypted, Android starts all the init services of core and main levels, then it a

Re: [PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Dan Carpenter
Yeah. Sorry about that. Your fix is correct. Is there any way you could resend it with the explanation from the email in the changelog? Remove the "confidential material" footer because those are not allowed on the email list and conflict with the GPL. Can you use git send-email to send the pa

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Laurent Pinchart
Hi Michael, What's the status of this patch ? Do expect Prabhakar to pick it up, or do you plan to push all your IRQF_DISABLED removal patches in one go ? On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote: > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a N

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Michael Opdenacker
Hi Laurent, On 02/20/2014 12:36 PM, Laurent Pinchart wrote: > Hi Michael, > > What's the status of this patch ? Do expect Prabhakar to pick it up, or do > you > plan to push all your IRQF_DISABLED removal patches in one go ? It's true a good number of my patches haven't been picked up yet, even

Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

2014-02-20 Thread Laurent Pinchart
Hi Michael, On Thursday 20 February 2014 14:17:09 Michael Opdenacker wrote: > On 02/20/2014 12:36 PM, Laurent Pinchart wrote: > > Hi Michael, > > > > What's the status of this patch ? Do expect Prabhakar to pick it up, or do > > you plan to push all your IRQF_DISABLED removal patches in one go ?

Re: [PATCH 19/19] [v4] Add in-kernel firmware loading support

2014-02-20 Thread Mark Hounschell
On 02/20/2014 03:58 AM, Dan Carpenter wrote: > On Wed, Feb 19, 2014 at 04:54:15PM -0500, Mark Hounschell wrote: >> This patch adds in-kernel firmware loading support and removes >> support for the original userland firmware loading process. >> >> Signed-off-by: Mark Hounschell >> Cc: Greg Kroah-Ha

[PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Compostella, Jeremy
From: "Compostella, Jeremy" This bug can manifest itself in several situations, here is the one that made me hunt it last week: When an Android device is encrypted, Android starts all the init services of core and main levels, then it asks for the password and checks it trying to mount /data. O

Re: [PATCH] Android / binder: Fix broken walk in binder_node_release()

2014-02-20 Thread Dan Carpenter
Fantastic. Thanks. Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] [v5] Add in-kernel firmware loading support

2014-02-20 Thread Mark Hounschell
This patch adds in-kernel firmware loading support and removes support for the original userland firmware loading process. Signed-off-by: Mark Hounschell --- drivers/staging/dgap/dgap.c | 525 +++- 1 file changed, 323 insertions(+), 202 deletions(-) diff

[PATCH] [v5] Add in-kernel firmware loading support

2014-02-20 Thread Mark Hounschell
This patch adds in-kernel firmware loading support and removes support for the original userland firmware loading process. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 525 +++- 1 file changed, 323 insertions(+),

Re: [PATCH] [v5] Add in-kernel firmware loading support

2014-02-20 Thread Dan Carpenter
Much better. Now it looks like proper kernel code! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread K. Y. Srinivasan
Fix a bug in the resource walking code. Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index b37c91b..2352ae48 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/h

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread Greg KH
On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote: > Fix a bug in the resource walking code. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/vmbus_drv.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Is this for 3.14-final or 3.15? I ask this every time, so

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, February 20, 2014 3:06 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI > specified >

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread Greg KH
On Thu, Feb 20, 2014 at 03:45:12PM -0800, K. Y. Srinivasan wrote: > Fix a bug in the resource walking code. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/vmbus_drv.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Fails to apply to my char-misc-next branch (if you want it

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, February 20, 2014 3:47 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI > specified >

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, February 20, 2014 3:47 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI > specified >

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread KY Srinivasan
> -Original Message- > From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-devel- > boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Thursday, February 20, 2014 4:19 PM > To: Greg KH > Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org > Su

Re: [PATCH v2 0/3] mmc: rtsx: fix bug and support nonblocking request

2014-02-20 Thread micky
Hi Chris, Could you please give me some idea about this patch-set? I send this patch-set many times, but didn't get any reply. Best Regards. micky On 02/17/2014 04:45 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching First we fix the card poweroff bug: the card power is not shutdown w

Re: [PATCH] et131x: fix allocation failures

2014-02-20 Thread Zhao, Gang
On Thu, 2014-02-20 at 17:03:39 +0800, Dan Carpenter wrote: > On Thu, Feb 20, 2014 at 11:03:45AM +0800, Zhao, Gang wrote: >> On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote: >> > On Wed, 19 Feb 2014 09:14:19 +0800 >> > "Zhao\, Gang" wrote: >> > >> >> Alan, thanks for resending this

Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread Greg KH
On Fri, Feb 21, 2014 at 12:19:22AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, February 20, 2014 3:47 PM > > To: KY Srinivasan > > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org > > Subjec

RE: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, February 20, 2014 6:21 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI > specified >

[PATCH 1/1] Drivers: hv: vmbus: Fix a bug in getting ACPI specified resources

2014-02-20 Thread K. Y. Srinivasan
Fix a bug in the resource walking code. This patch depends on commit number: 90f3453585479d5beb75058da46eb573ced0e6ac Signed-off-by: K. Y. Srinivasan --- drivers/hv/vmbus_drv.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv

[PATCH v2,0/2] Re-sending two patches for hyperv_fb

2014-02-20 Thread Haiyang Zhang
They were sent out during tree closing, I'm re-sending them now. --- v2: Updated the variable type gen2vm to int, because efi_enabled() returns int. Haiyang Zhang (2): hyperv_fb: Add screen refresh after pause/resume operation hyperv_fb: Add support for Gen2 VM drivers/video/hyperv_fb.c |

[PATCH v2,2/2] hyperv_fb: Add support for Gen2 VM

2014-02-20 Thread Haiyang Zhang
This patch enables Hyper-V FB driver to run on Gen2 VM. The Gen2 VM provides MMIO area for synthetic video from ACPI module, which is exported by vmbus. The generic video is provided by UEFI. PCI video in Gen1 is no longer available. To support synthetic video on Hyper-V Gen2 VM, this patch updat

[PATCH v2, 1/2] hyperv_fb: Add screen refresh after pause/resume operation

2014-02-20 Thread Haiyang Zhang
This is necessary because after VM is pause/resumed, some portion of the screen may need refresh. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/video/hyperv_fb.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/video/hyperv_fb.c

[PATCH] staging: et131x: let the freeing of memory more reasonable in error path

2014-02-20 Thread Zhao, Gang
The original code relies on the caller to deal with "fail in the middle" memory allocation failure in et131x_rx_dma_memory_alloc(). The relying on the caller to handle this memory allocation failure could cause some inconveniences: Code reviewer has to check the caller of this function to make sur

Re: [PATCH] staging: et131x: let the freeing of memory more reasonable in error path

2014-02-20 Thread Dan Carpenter
I don't think this is the right thing because it is needless code. Overall it doesn't really simplify anything. You are worried that reviewers will be confused and think there is a leak in et131x_rx_dma_memory_alloc() and then add a kfree() which breaks the code. I think you are right that a revi