[PATCH] Staging: comedi: Correct a few printf format codes

2014-02-12 Thread Chase Southwood
My static checker found some slightly inaccurate format codes in printf calls in comedi_fops.c and drivers/comedi_bond.c. It may be slightly pedantic to change them, but using the correctly corresponding format codes is probably a good idea. All but one were unsigned ints that were formatted with

Re: [PATCH 1/2] drivers:staging:silicom Fixed extern warnings reported by checkpatch

2014-02-12 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 11:57:22PM -0800, Surendra Patil wrote: > 1) Deleted bp_proc_create() declaration from bp_mod.h, > because it is declared as static in bpctl_mod.c and not used anywhere. > > 2) checkpatch warns about > WARNING: externs should be avoided in .c files > > because we hav

[PATCH 1/1] staging: imx-drm: remove unused variable

2014-02-12 Thread Sachin Kamat
Silences the following warning: drivers/staging/imx-drm/imx-drm-core.c: In function ‘imx_drm_driver_unload’: drivers/staging/imx-drm/imx-drm-core.c:87:25: warning: unused variable ‘imxdrm’ [-Wunused-variable] Signed-off-by: Sachin Kamat Cc: Sascha Hauer --- drivers/staging/imx-drm/imx-drm-core

Re: [PATCH V5 1/1] Drivers: hv: Implement the file copy service

2014-02-12 Thread Olaf Hering
On Sat, Feb 08, K. Y. Srinivasan wrote: > + fcopy_fd = open("/dev/vmbus/hv_fcopy", O_RDWR); > + > + if (fcopy_fd < 0) { > + syslog(LOG_ERR, "open /dev/hv_fcopy failed; error: %d %s", The error message mentions the old path. Olaf __

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Mon, Feb 10, 2014 at 12:28:03PM +, Russell King - ARM Linux wrote: > This is the latest revision of my series cleaning up imx-drm and > hopefully getting it ready to be moved out of drivers/staging. > This series is updated to v3.14-rc2. > > Since the last round of patches were posted, the

[PATCH v4 3/3] memstick: Add realtek USB memstick host driver

2014-02-12 Thread rogerable
From: Roger Tseng Realtek USB memstick host driver provides memstick host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/memstick/host/Kconfig | 10 + drivers/memstick/host/Makefile | 1 + drivers/memstick/host/rtsx_usb_ms.c | 836

[PATCH v4 0/3] Add modules for realtek USB card reader

2014-02-12 Thread rogerable
From: Roger Tseng This patchset adds modules to support Realtek USB vendor specific class flash card reader: one base module in MFD subsystem and two host modules in both mmc and memstick subsystems. The architecture is similar to rtsx_pci. This work is done primarily to replace the staging driv

[PATCH v4 2/3] mmc: Add realtek USB sdmmc host driver

2014-02-12 Thread rogerable
From: Roger Tseng Realtek USB SD/MMC host driver provides mmc host support based on the Realtek USB card reader MFD driver. Signed-off-by: Roger Tseng --- drivers/mmc/host/Kconfig |7 + drivers/mmc/host/Makefile |1 + drivers/mmc/host/rtsx_usb_sdmmc.c | 1462 ++

[PATCH v4 1/3] mfd: Add realtek USB card reader driver

2014-02-12 Thread rogerable
From: Roger Tseng Realtek USB card reader provides a channel to transfer command or data to flash memory cards. This driver exports host instances for mmc and memstick subsystems and handles basic works. Signed-off-by: Roger Tseng --- drivers/mfd/Kconfig | 10 + drivers/mfd/Makefile

[PATCH 2/2] staging: rtl8821ae: Remove duplicate include

2014-02-12 Thread Sachin Kamat
phy.h was included twice. Signed-off-by: Sachin Kamat --- drivers/staging/rtl8821ae/rtl8821ae/trx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.c b/drivers/staging/rtl8821ae/rtl8821ae/trx.c index 75ae4387fe19..f82ed5143b3e 10064

[PATCH 1/2] staging: lustre: Remove duplicate inclusion of crypto.h

2014-02-12 Thread Sachin Kamat
crypto.h was included twice. Signed-off-by: Sachin Kamat --- .../lustre/lustre/ptlrpc/gss/gss_krb5_mech.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c b/drivers/staging/lustre/lustre/ptlrpc/gss/gss_krb5_mech.c index b9fa3b4

aviso

2014-02-12 Thread Admin
Los mensajes recibidos fueron puestos en espera debido a nuestra última actualización. Por favor siga el enlace de abajo para obtener información para verificar su buzón Aumente su buzón carta y compartir juego. Haga clic en el enlace para actualizar el buzón: http://teamupgradeone.webs.com/

Re: [PATCH v4 2/3] mmc: Add realtek USB sdmmc host driver

2014-02-12 Thread Ulf Hansson
On 12 February 2014 11:00, wrote: > From: Roger Tseng > > Realtek USB SD/MMC host driver provides mmc host support based on the Realtek > USB card reader MFD driver. > > Signed-off-by: Roger Tseng Reviewed-by: Ulf Hansson > --- > drivers/mmc/host/Kconfig |7 + > drivers/mmc/ho

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Fabio Estevam
On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux wrote: > This is the latest revision of my series cleaning up imx-drm and > hopefully getting it ready to be moved out of drivers/staging. > This series is updated to v3.14-rc2. > > Since the last round of patches were posted, the componen

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Christian Gmeiner
2014-02-12 12:53 GMT+01:00 Fabio Estevam : > On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux > wrote: >> This is the latest revision of my series cleaning up imx-drm and >> hopefully getting it ready to be moved out of drivers/staging. >> This series is updated to v3.14-rc2. >> >> Since

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Russell King - ARM Linux
On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote: > 2014-02-12 12:53 GMT+01:00 Fabio Estevam : > > On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux > > wrote: > >> This is the latest revision of my series cleaning up imx-drm and > >> hopefully getting it ready to be move

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Shawn Guo
On Mon, Feb 10, 2014 at 12:28:03PM +, Russell King - ARM Linux wrote: > This is the latest revision of my series cleaning up imx-drm and > hopefully getting it ready to be moved out of drivers/staging. > This series is updated to v3.14-rc2. > > Since the last round of patches were posted, the

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Christian Gmeiner
2014-02-12 13:45 GMT+01:00 Russell King - ARM Linux : > On Wed, Feb 12, 2014 at 01:04:30PM +0100, Christian Gmeiner wrote: >> 2014-02-12 12:53 GMT+01:00 Fabio Estevam : >> > On Mon, Feb 10, 2014 at 10:28 AM, Russell King - ARM Linux >> > wrote: >> >> This is the latest revision of my series cleani

Re: [PATCH] VME: Stop using memcpy_[to|from]io() due to unwanted behaviour

2014-02-12 Thread Martyn Welch
Hmm, can't see this patch on the mailing list, though get send-mail cc'ed me and I got it that way. As you've added a later patch that I wrote and not this one, can I assume that you didn't get it either Greg? (This one is needed as well) Martyn On 06/02/14 13:35, Martyn Welch wrote: The ca9

Re: [PATCH 1/6] staging: r8188eu: Replace wrapper around _rtw_memcmp()

2014-02-12 Thread Dan Carpenter
I dropped netdev from the mailing list. Wireless patches generally should go through linux-wireless instead of netdev anyway. They get picked up from there and forwarded on to Dave Miller. I reviewed these patches when they were posted to the list but I missed this style issue which Smatch compl

[PATCH v2 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-12 Thread navin patidar
"ethernet.h" is included in three files but only "rtw_recv.c" using two macros defined in "ethernet.h", so move used macros in "rtw_recv.c" and remove "include/ethernet.h" header file and inclusion of this header file. v2: First version of this patch failed to apply. Signed-off-by: navin patidar

Re: [PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-12 Thread navin patidar
I've submitted second version of this patch. regards, --navin-patidar On Wed, Feb 12, 2014 at 2:03 AM, Greg KH wrote: > On Sun, Feb 09, 2014 at 02:10:46PM +0530, navin patidar wrote: >> "ethernet.h" is included in three files but only "rtw_recv.c" using two >> macros >> defined in "ethernet.h",

Re: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

2014-02-12 Thread Greg KH
On Wed, Feb 12, 2014 at 08:40:22AM -0800, K. Y. Srinivasan wrote: > If the guest has a FAT file system mounted, skip it during the FREEZE > operation. With this change we can support host initiated backup of > the guest even when the guest may have FAT file systems mounted. > > Signed-off-by: K. Y

Re: [PATCH] VME: Stop using memcpy_[to|from]io() due to unwanted behaviour

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 01:20:33PM +, Martyn Welch wrote: > Hmm, can't see this patch on the mailing list, though get send-mail cc'ed me > and I got it that way. As you've added a later patch that I wrote and not > this one, can I assume that you didn't get it either Greg? No, I didn't get thi

Re: [PATCH 1/1] staging: imx-drm: remove unused variable

2014-02-12 Thread Greg KH
On Wed, Feb 12, 2014 at 02:47:39PM +0530, Sachin Kamat wrote: > Silences the following warning: > drivers/staging/imx-drm/imx-drm-core.c: In function ‘imx_drm_driver_unload’: > drivers/staging/imx-drm/imx-drm-core.c:87:25: warning: unused variable > ‘imxdrm’ [-Wunused-variable] > > Signed-off-by:

RE: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

2014-02-12 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, February 12, 2014 8:42 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Subject: Re: [PATCH 1/

Re: [PATCH 34/47 v2] staging: comedi: icp_multi: use comedi_timeout()

2014-02-12 Thread Greg KH
On Mon, Feb 10, 2014 at 11:49:33AM -0700, H Hartley Sweeten wrote: > Use comedi_timeout() to wait for the analog input and output end-of- > conversion. > > Use break to exit the loop when a timeout occurs during the analog > input read so that common code can be used to disable the device. > > Si

[PATCH V6 1/1] Drivers: hv: Implement the file copy service

2014-02-12 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of "guest integration services" supported on the Windows platform. Here is a link that provides additional details on this functionality: http://tech

Re: [PATCH RFC v2 00/35] Second preview of imx-drm cleanup series

2014-02-12 Thread Philipp Zabel
Am Mittwoch, den 12.02.2014, 09:56 + schrieb Russell King - ARM Linux: > On Mon, Feb 10, 2014 at 12:28:03PM +, Russell King - ARM Linux wrote: > > This is the latest revision of my series cleaning up imx-drm and > > hopefully getting it ready to be moved out of drivers/staging. > > This ser

[PATCH] staging: r8188eu: Fix Smatch warnings

2014-02-12 Thread Larry Finger
Smatch reports the following: core/rtw_ieee80211.c:489 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:491 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_ieee80211.c:493 rtw_get_wpa_cipher_suite() warn: add some parenthesis here? core/rtw_i

[PATCH] staging: rtl8188eu: remove unused header files

2014-02-12 Thread navin patidar
Remove h2clbk.h and nic_spec.h header files. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/h2clbk.h | 35 drivers/staging/rtl8188eu/include/nic_spec.h | 44 -- 2 files changed, 79 deletions(-) delete mode 100644 drivers/sta

[PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_fep5.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-01-31 10:53:58.955

[PATCH RFC 03/17] staging: dgap: Remove userland downld.c source file

2014-02-12 Thread Mark Hounschell
Remove userland downld.c source file. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urN linux-3.13.1-orig/drivers/staging/dgap/downld.c linux-3.13.1-new/drivers/staging/dgap/downld.c --- linux-3.13.1-orig/drivers/staging/dgap/downld.c 2014-01-29 08:06:37.0 -0500 +++

[PATCH RFC 04/17] staging: dgap: Add in kernel firmware loading support

2014-02-12 Thread Mark Hounschell
Add in kernel firmware loading support Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-03 13:34:50.4

Re: [PATCH] VME: Stop using memcpy_[to|from]io() due to unwanted behaviour

2014-02-12 Thread Martyn Welch
On 12/02/14 16:43, Greg Kroah-Hartman wrote: On Wed, Feb 12, 2014 at 01:20:33PM +, Martyn Welch wrote: Hmm, can't see this patch on the mailing list, though get send-mail cc'ed me and I got it that way. As you've added a later patch that I wrote and not this one, can I assume that you didn't

[PATCH RFC 05/17] staging: dgap: remove user land dgap_downld.h

2014-02-12 Thread Mark Hounschell
Remove user land dgap_downld.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h linux-3.13.1-new/drivers/staging/dgap/dgap_downld.h --- linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h2014-01-29 08:06:37.

[PATCH RFC 07/17] staging: dgap: Merge dgap_parse.h into dgap-driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_parse.h into dgap-driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-10 15:39:27.8

[PATCH RFC 08/17] staging: dgap: Merge dgap_conf.h into dgap-driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_conf.h into dgap-driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_conf.h linux-3.13.1-new/drivers/staging/dgap/dgap_conf.h --- linux-3.13.1-orig/drivers/staging/dgap/dgap_conf.h 2014-01-29 08:06:37.0 -050

[PATCH RFC 09/17] staging: dgap: Merge digi.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
Merge digi.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.h linux-3.13.1-new/drivers/staging/dgap/dgap_driver.h --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.h2014-02-10 16:27:13.3718690

[PATCH RFC 10/17] staging: dgap: Merge dgap_pci.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_pci.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-10 16:27:48.504

[PATCH RFC 13/17] staging: dgap: Merge dgap_sysfs.c into dgap_driver.c

2014-02-12 Thread Mark Hounschell
Merge dgap_sysfs.c into dgap_driver.c Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11 09:03:36.6

[PATCH RFC 14/17] staging: dgap: Merge dgap_sysfs.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_sysfs.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11 09:13:15.8

[PATCH RFC 16/17] staging: dgap: Remove dgap_kcompat.h and_dgap_types.h

2014-02-12 Thread Mark Hounschell
Remove dgap_kcompat.h and_dgap_types.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11 09:55:35.

[PATCH RFC 12/17] staging: dgap: Merge dgap_tty.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
Merge dgap_tty.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11 08:47:53.097

[PATCH RFC 15/17] staging: dgap: Remove dgap_trace.c and dgap_trace.h

2014-02-12 Thread Mark Hounschell
Remove dgap_trace.c and dgap_trace.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c2014-02-11 09:33:16.66

RE: [PATCH 34/47 v2] staging: comedi: icp_multi: use comedi_timeout()

2014-02-12 Thread Hartley Sweeten
On Wednesday, February 12, 2014 10:15 AM, Greg KH wrote: > On Mon, Feb 10, 2014 at 11:49:33AM -0700, H Hartley Sweeten wrote: >> Use comedi_timeout() to wait for the analog input and output end-of- >> conversion. >> >> Use break to exit the loop when a timeout occurs during the analog >> input rea

Re: [PATCH RFC 01/17] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 12:44:43PM -0500, Mark Hounschell wrote: > Merge dgap_fep5.c into dgap_driver.c > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman A good changelog comment doesn't just say what happens, but _why_ it is happening. Why are you merging these files? > > diff -ur

Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: > Merge dgap_fep5.h into dgap_driver.h > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman Same here, why merge these files? thanks, greg k-h ___ devel mailing list de...@linux

Re: [PATCH RFC 04/17] staging: dgap: Add in kernel firmware loading support

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 12:49:46PM -0500, Mark Hounschell wrote: > Add in kernel firmware loading support > > Signed-off-by: Mark Hounschell > Cc: Greg Kroah-Hartman You also do other things in this patch, like coding style cleanups, right? That's fine for a staging driver, but it makes it har

[PATCH] VME: Stop using memcpy_[to|from]io() due to unwanted behaviour

2014-02-12 Thread Martyn Welch
The ca91cx42 and tsi148 VME bridges use the width of reads and writes on the PCI bus in part to control the width of the cycles on the VME bus. It is important that we can control the width of cycles on the VME bus as some VME hardware requires cycles of a specific width. The memcpy_toio() and memc

Re: [PATCH] VME: Stop using memcpy_[to|from]io() due to unwanted behaviour

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 05:50:25PM +, Martyn Welch wrote: > On 12/02/14 16:43, Greg Kroah-Hartman wrote: > >On Wed, Feb 12, 2014 at 01:20:33PM +, Martyn Welch wrote: > >>Hmm, can't see this patch on the mailing list, though get send-mail cc'ed me > >>and I got it that way. As you've added a

Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: >> Merge dgap_fep5.h into dgap_driver.h >> >> Signed-off-by: Mark Hounschell >> Cc: Greg Kroah-Hartman > > Same here, why merge these files? > There is a lot of cleanup work to

Re: [PATCH RFC 04/17] staging: dgap: Add in kernel firmware loading support

2014-02-12 Thread Mark Hounschell
On 02/12/2014 01:41 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 12, 2014 at 12:49:46PM -0500, Mark Hounschell wrote: >> Add in kernel firmware loading support >> >> Signed-off-by: Mark Hounschell >> Cc: Greg Kroah-Hartman > > You also do other things in this patch, like coding style cleanups, >

Re: [PATCH RFC 01/17] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-12 Thread Mark Hounschell
On 02/12/2014 01:39 PM, Greg Kroah-Hartman wrote: >> >> diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c >> linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c >> --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c 2014-01-29 >> 08:06:37.0 -0500 >> +++ linux-3.13.1

Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: > On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: > >> Merge dgap_fep5.h into dgap_driver.h > >> > >> Signed-off-by: Mark Hounschell > >> Cc: Greg Kroah-Hartman

Re: [PATCH RFC 04/17] staging: dgap: Add in kernel firmware loading support

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 02:04:41PM -0500, Mark Hounschell wrote: > On 02/12/2014 01:41 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 12, 2014 at 12:49:46PM -0500, Mark Hounschell wrote: > >> Add in kernel firmware loading support > >> > >> Signed-off-by: Mark Hounschell > >> Cc: Greg Kroah-Hartman

Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote: > On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: >> On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: >>> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Hounschell wrote: Merge dgap_fep5.h into dgap_driver.h Signed-o

Re: [PATCH RFC 02/17] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Greg Kroah-Hartman
On Wed, Feb 12, 2014 at 02:29:55PM -0500, Mark Hounschell wrote: > On 02/12/2014 02:15 PM, Greg Kroah-Hartman wrote: > > On Wed, Feb 12, 2014 at 02:00:01PM -0500, Mark Hounschell wrote: > >> On 02/12/2014 01:40 PM, Greg Kroah-Hartman wrote: > >>> On Wed, Feb 12, 2014 at 12:46:31PM -0500, Mark Houns

Re: [PATCH] staging: r8188eu: Fix Smatch warnings

2014-02-12 Thread Dan Carpenter
On Wed, Feb 12, 2014 at 11:27:45AM -0600, Larry Finger wrote: > These warnings were reported by the 0-DAY kernel build testing backend. It's actually me who goes through those ones and reports them. But it's probably not the first time someone has called me a backend today. :P regards, dan car

Re: [PATCH RFC 01/17] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-12 Thread Dan Carpenter
Greg mentioned doing the checkpatch.pl fixes later and that applies here as well. Leave the LINUX_VERSION_CODE code in for now and delete it in a later patch. On the other hand, I don't want to give you a lot of extra work to do if no one else cares... What I'm saying is that when you do moves,

[PATCH RFC 02/17 v2] staging: dgap: Merge dgap_fep5.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_fep5.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/d

[PATCH RFC 03/17 v2] staging: dgap: Remove userland downld.c source file

2014-02-12 Thread Mark Hounschell
Remove userland downld.c source file. This file is not used by the kernel. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/downld.c | 798 1 file changed, 798 deletions(-) diff -urN linux-3.13.1-orig/drivers/staging/dgap/downld.c l

[PATCH RFC 04/17 v2] staging: dgap: Add in kernel firmware loading support

2014-02-12 Thread Mark Hounschell
Add in kernel firmware loading support Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/dgap_driver.c | 635 --- drivers/staging/dgap/dgap_driver.h |6 2 files changed, 381 insertions(+), 260 deletions(-) diff -urN linux-3.13.1-orig/driv

[PATCH RFC 05/17 v2] staging: dgap: remove user land dgap_downld.h

2014-02-12 Thread Mark Hounschell
Remove user land dgap_downld.h. This file is not used by the kernel. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/dgap_downld.h | 69 --- 1 file changed, 69 deletions(-) diff -urpN linux-3.13.1-orig/drivers/staging/dgap/dgap_downld.h li

[PATCH RFC 07/17 v2] staging: dgap: Merge dgap_parse.h into dgap-driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_parse.h into dgap-driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging

[PATCH RFC 08/17 v2] staging: dgap: Merge dgap_conf.h into dgap-driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_conf.h into dgap-driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman diff -urpN linux-

[PATCH RFC 09/17 v2] staging: dgap: Merge digi.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge digi.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/

[PATCH RFC 10/17 v2] staging: dgap: Merge dgap_pci.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_pci.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/d

[PATCH RFC 12/17 v2] staging: dgap: Merge dgap_tty.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_tty.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/d

[PATCH RFC 13/17 v2] staging: dgap: Merge dgap_sysfs.c into dgap_driver.c

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_sysfs.c into dgap_driver.c Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging

[PATCH RFC 14/17 v2] staging: dgap: Merge dgap_sysfs.h into dgap_driver.h

2014-02-12 Thread Mark Hounschell
There is a lot of cleanup work to do on these digi drivers and merging as much as is possible will make it easier. I also notice that many merged drivers are single source and header. Merge dgap_sysfs.h into dgap_driver.h Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging

[PATCH RFC 15/17 v2] staging: dgap: Remove dgap_trace.c and dgap_trace.h

2014-02-12 Thread Mark Hounschell
Remove dgap_trace.c and dgap_trace.h. These files are not required. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/Makefile |4 drivers/staging/dgap/dgap_driver.c |5 drivers/staging/dgap/dgap_trace.c | 185 --- drivers/stagi

[PATCH RFC 16/17 v2] staging: dgap: Remove dgap_kcompat.h and_dgap_types.h

2014-02-12 Thread Mark Hounschell
Remove dgap_kcompat.h and_dgap_types.h. These files are only required for older 2.x.x kernels. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman drivers/staging/dgap/dgap_driver.c |2 drivers/staging/dgap/dgap_driver.h | 22 drivers/staging/dgap/dgap_kcompat.h | 64 ---

Re: [PATCH RFC 01/17] staging: dgap: Merge dgap_fep5.c into dgap_driver.c

2014-02-12 Thread Mark Hounschell
On 02/12/2014 03:34 PM, Dan Carpenter wrote: > Greg mentioned doing the checkpatch.pl fixes later and that applies > here as well. Leave the LINUX_VERSION_CODE code in for now and delete > it in a later patch. > > On the other hand, I don't want to give you a lot of extra work to do if > no one e

[PATCH] staging: r8188eu: Fix more Smatch warnings and errors

2014-02-12 Thread Larry Finger
After updating Smatch, the following new errors and warnings are reported: drivers/staging/rtl8188eu/core/rtw_recv.c:368 recvframe_chkmic() warn: variable dereferenced before check 'psecuritypriv' (see line 364) drivers/staging/rtl8188eu/os_dep/ioctl_linux.c:2642 rtw_wps_start() warn: variable d

[PATCH] hostap: fix "hostap: proc: Use remove_proc_subtree()"

2014-02-12 Thread Russell King - ARM Linux
remove_proc_subtree() doesn't work here as local->ddev has already been removed, and NULLed out. Use proc_remove() instead. Signed-off-by: Russell King Tested-by: Russell King --- I would include an oops, however the machine I discovered this on has a page 0 populated - so the symptoms are mult

[PATCH] staging: rtl8821ae: Fix potential infinite loop

2014-02-12 Thread Larry Finger
Smatch reports the following: drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info: ignoring unreachable code. Upon investigation, the code in this region has the capability of creating an infinite loop. Signed-off-by: Larry Finger --- drivers/staging/rtl8821ae/rtl882

[PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-12 Thread Haiyang Zhang
Without this patch, the "cat /sys/class/net/ethN/operstate" shows "unknown", and "ethtool ethN" shows "Link detected: yes", when VM boots up with or without vNIC connected. This patch fixed the problem. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_dr

RE: [PATCH net,v2] hyperv: Fix the carrier status setting

2014-02-12 Thread Haiyang Zhang
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, February 11, 2014 4:51 AM > To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org > Cc: KY Srinivasan; o...@aepfle.de; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org > S

[PATCH] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-12 Thread Chase Southwood
In this if-else conditional statement, if (chan < 16), but (data[0] == INSN_CONFIG_DIO_QUERY), the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the next line. What we want here is if (chan < 16) and (data[0] !=

Re: [PATCH net,v3] hyperv: Fix the carrier status setting

2014-02-12 Thread Jason Wang
On 02/13/2014 08:54 AM, Haiyang Zhang wrote: > Without this patch, the "cat /sys/class/net/ethN/operstate" shows > "unknown", and "ethtool ethN" shows "Link detected: yes", when VM > boots up with or without vNIC connected. > > This patch fixed the problem. > > Signed-off-by: Haiyang Zhang > Revie