[PATCH] Staging: rtl8821ae: fix up some spacing issues.

2014-01-25 Thread Gary Rookard
I fixed up some operator spacing issues, and other minor spacing issues. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/rtl8821ae/base.c | 138 +++ 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 1/3] Staging: ozwpan: Fix null dereference

2014-01-25 Thread Salym Senyonga
If net_dev is NULL memcpy() will Oops. Signed-off-by: Salym Senyonga --- drivers/staging/ozwpan/ozproto.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c index cb06036..5d965cf 100644 --- a/drivers/sta

[PATCH 3/3] Staging: ozwpan: Change kmalloc() to kzalloc()

2014-01-25 Thread Salym Senyonga
changing to kzalloc lets us get rid of some lines. The other concern here is that some members of binding->ptype are still uninitialized at the end of the function. Signed-off-by: Salym Senyonga --- drivers/staging/ozwpan/ozproto.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-)

[PATCH 2/3] Staging: ozwpan: reduce indent levels in oz_binding_add().

2014-01-25 Thread Salym Senyonga
When hit error then we can return immediately. This makes the code simpler and lets us remove some indenting. Signed-off-by: Salym Senyonga --- drivers/staging/ozwpan/ozproto.c | 44 ++--- 1 files changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/

Re: [PATCH] drivers: staging: Mark functions as static and remove unused function in bpctl_mod.c

2014-01-25 Thread Josh Triplett
On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote: > Mark functions as static in bpctl_mod.c because they are not used > outside this file. Remove unused function from bpctl_mod.c. > [...] > > Signed-off-by: Rashika Kheria Reviewed-by: Josh Triplett ___

Re: [Suggestion] drivers: staging: dgrp: dgrp_net_ops.c: 'buf' is used without initialized.

2014-01-25 Thread Chen Gang
On 01/23/2014 11:16 PM, Dan Carpenter wrote: > On Tue, Dec 10, 2013 at 01:05:46PM +0300, Dan Carpenter wrote: >> On Tue, Dec 10, 2013 at 03:27:55PM +0530, Rashika Kheria wrote: >>> Should I attempt to rectify the code in handle_data_in_packet() ? >> >> Yes, please. >> > > What ever happened with t

Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))" for the related union

2014-01-25 Thread Chen Gang
On 01/21/2014 06:36 PM, James Hogan wrote: > Hi Dan, > > On 20/01/14 21:13, Dan Carpenter wrote: >> I made a quick and dirty sparse patch to check for this. I don't think >> I will bother trying to send it to sparse upstream, but you can if you >> want to. >> >> It found 289 unions which might ne

Re: [PATCH] drivers: staging: android: ion: ion_dummy_driver: include "linux/io.h"

2014-01-25 Thread Chen Gang
Hello Maintainers: Please help check this patch when you have time, thanks. On 01/18/2014 05:04 PM, Chen Gang wrote: > Need add "linux/io.h" to pass compiling under metag architecture with > allmodconfig (which use the default 'virt_to_phys'), the related error: > > CC drivers/staging/a

Re: [PATCH] x86, hyperv: bypass the timer_irq_works() check

2014-01-25 Thread Jason Wang
On 01/25/2014 05:20 AM, H. Peter Anvin wrote: > On 01/23/2014 10:02 PM, Jason Wang wrote: >> This patch bypass the timer_irq_works() check for hyperv guest since: >> >> - It was guaranteed to work. >> - timer_irq_works() may fail sometime due to the lpj calibration were >> inaccurate >> in a hyp