[PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-17 Thread Marek Szyprowski
GFP_ATOMIC is not a single gfp flag, but a macro which expands to the other flags and LACK of __GFP_WAIT flag. To check if caller wanted to perform an atomic allocation, the code must test __GFP_WAIT flag presence. Signed-off-by: Marek Szyprowski --- .../lustre/include/linux/libcfs/libcfs_privat

Re: [PATCH v8] Staging: comedi: convert while loop to timeout in ni_mio_common.c

2014-01-17 Thread Ian Abbott
On 2014-01-16 18:27, Chase Southwood wrote: This patch for ni_mio_common.c changes out a while loop for a timeout, which is preferred. Signed-off-by: Chase Southwood --- Okay, back to v2, basically. I fixed the checkpatch warning from v2, and added the error checking that was from v3, but oth

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-17 Thread Greg Kroah-Hartman
On Fri, Jan 17, 2014 at 09:46:56AM +0100, Marek Szyprowski wrote: > GFP_ATOMIC is not a single gfp flag, but a macro which expands to the other > flags and LACK of __GFP_WAIT flag. To check if caller wanted to perform an > atomic allocation, the code must test __GFP_WAIT flag presence. > > Signed-

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-17 Thread Dan Carpenter
We will want to get rid of lustre's custom allocator before this gets out of staging. But one feature that the lustre allocator has which is pretty neat is that it lets you debug how much memory the filesystem is using. Is there a standard way to find this information? regards, dan carpenter __

Re: [PATCH] staging: lustre: fix GFP_ATOMIC macro usage

2014-01-17 Thread Greg Kroah-Hartman
On Fri, Jan 17, 2014 at 05:51:28PM +0300, Dan Carpenter wrote: > We will want to get rid of lustre's custom allocator before this gets > out of staging. > > But one feature that the lustre allocator has which is pretty neat is > that it lets you debug how much memory the filesystem is using. Is >

Re: [PATCH 1/8] staging: dgap: Fix trailing whitespace in digi.h

2014-01-17 Thread Lidza Louina
Acked-by: Lidza Louina On Tue, Jan 14, 2014 at 10:40 AM, Masanari Iida wrote: > This patch fixed trailing whitespace error found by > checkpatch.pl in dgap/digi.h > > Signed-off-by: Masanari Iida > --- > drivers/staging/dgap/digi.h | 24 > 1 file changed, 12 insertions

Re: [PATCH 1/2] staging: dgap: removes KERNEL_VERSION conditionals

2014-01-17 Thread Lidza Louina
I'll try this patchset again after Masanari Iida's patches are accepted after the merge window. Lidza On Fri, Jan 17, 2014 at 11:01 AM, Lidza Louina wrote: > This patch removes the KERNEL_VERSION conditionals. > The driver is built for this kernel version, so the > conditionals are not needed. >

[PATCH 1/2] staging: crystalhd: enclose multi statements macro

2014-01-17 Thread SeongJae Park
Enclose multiple statements macro with do - while block. Signed-off-by: SeongJae Park --- drivers/staging/crystalhd/crystalhd_hw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index 8d0

[PATCH 2/2] staging: crystalhd: remove unnecessary parenthesis

2014-01-17 Thread SeongJae Park
Signed-off-by: SeongJae Park --- drivers/staging/crystalhd/crystalhd_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index ccfa3b8..4765d52 100644 --- a/drivers/staging/crystalhd/crys