This patch series reformats the bssdb.c file of the vt6656 driver in
staging. It resolves all errors and some warnings which checkpatch.pl
discovered.
However some occurrences of the following warnings are not patched:
- Lines over 80 characters
- Too many indentation levels
- printk should includ
From: Simon Schuster
Adds spaces around operators (like &&, ||, !=, +, ...) and removes
spaces before postfix increment and decrement operators. Parentheses
around return values are removed, too.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c
From: Simon Schuster
After some blocks in bssdb.c there are semicolons that are not
required to be there. Therefore they are removed with this patch.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c | 14 +++---
1 file changed, 7 inserti
From: Simon Schuster
Changes C99-style comments to C89-style ones to conform to the linux
coding guidelines. Additionally removes plus and minus signs from the
function description comments.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c | 218
Removes unrequired parentheses around comparisons in complex
conditions.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c | 138 -
1 file changed, 69 insertions(+), 69 deletions(-)
diff --git a/drivers/stag
From: Simon Schuster
Long lines are split into multiple ones to reduce the line length.
Additionally some alignment fixes are made that previous patches
missed.
Unfortunately, due to the high indentation levels present in parts of
bssdb.c, this patch leaves some lines which are longer than 80
ch
Explicit comparisons of pointers agains NULL
(like if (p != NULL) ...) are not as readable as the implicit
comparison (like if (p) ...). This patch converts all these explicit
comparisons to implicit ones.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/
From: Simon Schuster
This patch reduces the level of indentation in bssdb.c of the vt6656
driver by transforming nested conditions to a series of logical
conjunctions. E.g.
if (cond1) {
if (cond2) {
block();
}
}
is transformed to
if (cond1 && cond2) {
bl
From: Simon Schuster
An else belongs in the same line as the closing curly brace of the
previous block. Hence, this patch removes line feeds separating a
curly brace from the corresponding else.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c |
From: Simon Schuster
Adds missing spaces between an if-statement and its condition as well
as between the condition and the following curly brace. At casts
there is also a space added between the type and the variable.
Spaces that either follow an opening parenthese or the sizeof operator
or tha
From: Simon Schuster
This patch combines single ifs within the block of an else to a single
else if statement.
Therefore code that looks like that
else {
if (cond) {
statements;
} else {
other_statements;
}
}
is converted to code that loo
From: Simon Schuster
A space in a format string is unnecessary if it is followed by a line
feed. These spaces are removed by this patch.
Signed-off-by: Sebastian Rachuj
Signed-off-by: Simon Schuster
---
drivers/staging/vt6656/bssdb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Simon Schuster
Conforming to the linux coding style guidelines, a single line block
of an if statement does not require curly braces unless another block
of the if cascade requires them. Therefore unnecessary curly braces
are removed by this patch and missing ones are added.
Signed-off-by:
13 matches
Mail list logo
