[PATCH] staging: xillybus: Removed force to be a module

The driver was forced to "module only" following a previous failure to build into the kernel. The problem was resolved several months ago. This has been successfully tested with "make allyesconfig" on x86_64. Reported-by: Stephen Rothwell Signed-off-by: Eli Billauer --- drivers/staging/xillybu

Re: [PATCH 10/10] Staging: bcm: DDRInit: tidy up comments.

On Sat, Dec 07, 2013 at 02:40:02AM -0500, Gary Rookard wrote: > This is the tenth patch of a series. Why is this in the changelog entry? It says nothing as to what the patch does. And I don't see the previous 9 patches of this series, only a bunch of X/9 patches, nothing X/10. Please fix all of

Re: [PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

On Sat, Dec 07, 2013 at 02:35:52PM -0800, Preetam D'Souza wrote: > This patch fixes an unecessary return statement parantheses error > found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has > no more errors/warnings! > > Signed-off-by: Preetam D'Souza > --- > drivers/staging/andro

Re: [PATCH 1/7 v2] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

On Sat, Dec 07, 2013 at 05:22:57PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) I have a mess of some patches resend in the series and others not. Please always just

Re: [PATCH 03/10] Staging: bcm: DDRInit: added space after commas.

On Sat, Dec 07, 2013 at 02:49:05AM -0500, Gary Rookard wrote: > This is the third patch of a series. What series? Again, this isn't an ok changelog entry, did you read Documentation/SubmittingPatches for what should be here? thanks, greg k-h ___ devel

Re: [PATCH 11/11] Staging: bcm: DDRInint: tidy up indent issue.

On Sat, Dec 07, 2013 at 03:46:48AM -0500, Gary Rookard wrote: > This is the eleventh patch of a series. No it isn't :) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 9272548..5a45465 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH v3 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d16ac57..9272548 100644 --- a/drivers/staging/et131x

[PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5dd2170..d16ac57 100644 --- a/drivers/staging/et131x/et131x.c +++ b/d

[PATCH v3 7/7] staging: et131x: remove unnecessary pointer typecast

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 89bd8ca..fdb19df 100644 --- a/drivers/staging/et131x/et131x.c +++ b/dri

[PATCH v3 5/7] staging: et131x: reduce split lines in nic_rx_pkts

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f498eec..89bd8ca 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drivers/staging/

[PATCH v3 4/7] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5a45465..f498eec 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drive

[PATCH v3 6/7] staging: et131x: remove item that have been done in TODO file

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/README | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 8da96a6..3befc45 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -13,10 +13,6 @@

Re: [PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang > --- > drivers/staging/et131x/et131x.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) What happened to all of Mark's Acked-by: lines? You should have put them in the patch

Re: [PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

On Mon, Dec 9, 2013 at 4:53 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote: >> Signed-off-by: ZHAO Gang >> --- >> drivers/staging/et131x/et131x.c | 24 ++-- >> 1 file changed, 10 insertions(+), 14 deletions(-) > > What happened to al

Re: [PATCH v3 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

On Mon, Dec 09, 2013 at 05:00:01PM +0800, ZHAO Gang wrote: > On Mon, Dec 9, 2013 at 4:53 PM, Greg Kroah-Hartman > wrote: > > On Mon, Dec 09, 2013 at 04:46:08PM +0800, ZHAO Gang wrote: > >> Signed-off-by: ZHAO Gang > >> --- > >> drivers/staging/et131x/et131x.c | 24 ++-- > >>

[PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker Acked-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH v2] Staging: TIDSPBRIDGE: Remove UUID helper

From: Ivaylo Dimitrov Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It can also be made way simpler by using sscanf. Signed-off-by: Ivaylo Dimitrov --- drivers/staging/tidspbridge/Makefile |2 +- drivers/staging/tidspbridge/gen/uu

[PATCH v4 2/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_alloc

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 48 - 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index d16ac57..9272548 100644 --- a/

[PATCH v4 1/7] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5dd2170..d16ac57 100644 --- a/drivers/staging/e

[PATCH v4 4/7] staging: et131x: reduce split lines in nic_return_rfd

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 5a45465..f498eec 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drive

[PATCH v4 6/7] staging: et131x: remove item that have been done in TODO file

Signed-off-by: ZHAO Gang --- drivers/staging/et131x/README | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README index 8da96a6..3befc45 100644 --- a/drivers/staging/et131x/README +++ b/drivers/staging/et131x/README @@ -13,10 +13,6 @@

[PATCH v4 5/7] staging: et131x: reduce split lines in nic_rx_pkts

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f498eec..89bd8ca 100644 --- a/drivers/staging/et131x/et131x.c

[PATCH v4 7/7] staging: et131x: remove unnecessary pointer typecast

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 89bd8ca..fdb19df 100644 --- a/drivers/staging/et1

[PATCH v4 3/7] staging: et131x: reduce split lines in et131x_rx_dma_memory_free

Signed-off-by: ZHAO Gang Acked-by: Mark Einon --- drivers/staging/et131x/et131x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 9272548..5a45465 100644 --- a/drivers/s

Re: [PATCH 1/3] drm: Add LCD display clock polarity flags

On Tuesday, December 03, 2013 at 12:44:52 PM, Shawn Guo wrote: > On Mon, Dec 02, 2013 at 04:39:26PM +0100, Marek Vasut wrote: > > Add DRM flags for the LCD display clock polarity so the pixelclk-active > > DT property can be properly handled by drivers using the DRM API. > > > > Signed-off-by: Mar

Re: [PATCH v2] Staging: TIDSPBRIDGE: Remove UUID helper

On Mon 2013-12-09 12:13:16, Ivaylo DImitrov wrote: > From: Ivaylo Dimitrov > > Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't > need to be exported. It can also be made way simpler by using sscanf. > > Signed-off-by: Ivaylo Dimitrov Reviewed-by: Pavel Machek -- (engl

[PATCH] vme: Convert VME core to register as a subsystem

Previously, VME bridge support was treated as any other driver (using module_init() macro), but if VME bridge and vme_user (staging) drivers were compiled into the kernel, then vme_user would attempt to register itself before the VME core support had been loaded. This would result in a kernel panic

[PATCH v2] vme_user: Update API to work in mixed environments

This patch updates the vme_master and vme_slave structures to use types with well defined size and to prevent the compiler from inserting padding (between enable and vme_addr for one). The original vme_master and vme_slave structs would be different sizes and have different layouts depending on wh

[PATCH] staging: comedi: ni_at_a2150: fix an always true condition test

As pointed out by the kbuild test robot, and Ian Abbott, the dma >= 0 test is always true because dma is unsigned. This generates a warn message: drivers/staging/comedi/drivers/ni_at_a2150.c:715 a2150_attach() warn: always true condition '(dma >= 0) => (0-u32max >= 0)' Fix the test as suggested

Re: [PATCH v4 4/7] staging: et131x: reduce split lines in nic_return_rfd

On Mon, Dec 09, 2013 at 07:38:27PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 6/7] staging: et131x: remove item that have been done in TODO file

On Mon, Dec 09, 2013 at 07:38:29PM +0800, ZHAO Gang wrote: > Signed-off-by: ZHAO Gang Acked-by: Mark Einon ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 47/48] staging: comedi: pcmmio: tidy up the multi-line comments

Tidy up the multi-line comments are the beginning of the file to follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 142 1 file changed, 71 insertions(+), 71 deletions(-)

[PATCH 28/48] staging: comedi: pcmmio: unwind the digital i/o subdevice init

The board supported by this driver only has one asic that provides the two digital i/o subdevices. The first dio subdevice has 24 channels that support interrupts. The second dio subdevice also has 24 channels but no interrupt support. To make the code clearer and easier to maintain, remove the fo

[PATCH 22/48] staging: comedi: pcmmio: rename 'spinlock' in the private data

This spinlock_t is meant to protect the page registers in the asic. Rename it to make this clear. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH 03/48] staging: comedi: pcmmio: cleanup comedi_lrange tables

Use the BIP_RANGE and UNI_RANGE macros where appropriate instead of the more generic RANGE macro. Rename the range tables so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 25

[PATCH 25/48] staging: comedi: pcmmio: simplify pcmmio_dio_insn_bits()

Currently this function uses the subdevice private data to get the iobase address needed to update the dio output channel state and read the current state of the input channels. This subdevice private data is in the process of being removed. Use the subdevice 'index' to determine the base 'port' n

[PATCH 00/48] staging: comedi: pcmmio: cleanup driver

This driver is actually fairly simple but it's a bit confusing with all the subdevice private data usage. Clean the driver up and remove all the cruft. H Hartley Sweeten (48): staging: comedi: pcmmio: remove unused {lock,unlock}_port() staging: comedi: pcmmio: tidy up switch_page() staging:

[PATCH 23/48] staging: comedi: pcmmio: introduce pcmmio_dio_write()

The paged registers in the asic need to be spinlock protected to ensure that the page is not changed while writing to the registers. Introduce a helper function to make sure the spinlock is used. Use the new helper in pcmmio_reset(). This is one of the places where the spinlock is not used. Sign

[PATCH 19/48] staging: comedi: pcmmio: tidy up init_asics()

Rename this function so it has namespace associated with the driver. The board supported by this driver only has one WinSystems WS16C48 asic on it that handles the digital i/o. Remove the unnecessary for () loop that would reset multiple asics. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc

[PATCH 39/48] staging: comedi: pcmmio: tidy up pcmmio_handle_dio_intr()

Refactor the code to remove some of the indent levels. Remove 'mytrig', the shift and mask end up making it the same as 'triggered' anyway. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 65 +

[PATCH 18/48] staging: comedi: pcmmio: remove 'asic' parameter from switch_page()

The board supported by this driver only has one WinSystems WS16C48 asic on it that handles the digital i/o. Remove the unnecessary 'asic' parameter that is passed to switch_page(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio

[PATCH 45/48] staging: comedi: pcmmio: return '0' after successful attach

The comedi core expects the (*attach) functions to return < 0 to indicate an error or >= 0 for success. Change the return to '0' as that is more typical. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 4 +++- 1 file changed,

[PATCH 26/48] staging: comedi: pcmmio: remove 'iobases' from the subdevice private data

This member of the subdevice private data is not longer used. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drive

[PATCH 24/48] staging: comedi: pcmmio: simplify pcmmio_dio_insn_config()

Currently this function uses the subdevice private data to get the iobase address needed to update the channel configuration. This subdevice private data is in the process of being removed. Use the subdevice 'index' to determine the base 'port' needed to access the correct digital i/o registers. T

[PATCH 27/48] staging: comedi: pcmmio: simplify pcmmio_stop_intr()

This function is only called by the interrupt subdevice so the sanity check of the 'asic' is not necessary. Remove it. The 'nports' is always 3 and the 'firstport' is always 0. Remove the for () loop that clears the registers to disable the interrupts and just use the pcmmio_dio_write() helper to

[PATCH 01/48] staging: comedi: pcmmio: remove unused {lock, unlock}_port()

These functions are #ifdef'ed out and not needed in the driver. Just remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 32 1 file changed, 32 deletions(-) diff --git a/drivers/stag

[PATCH 05/48] staging: comedi: pcmmio: cleanup ai_rinsn()

Rename this function to have namespace associated with the driver. Refactor the function to remove the extra write to the command register between each ADC conversion. We only need to do one dummy conversion in order to flush the serial ADC. After that each command will return the result of the pr

[PATCH 43/48] staging: comedi: pcmmio: remove unused defines

These defines are not longer used in the driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/d

[PATCH 04/48] staging: comedi: pcmmio: use core helpers to munge bipolar ai data

Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers to munge the bipolar analog input data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 22 +- 1 file changed, 9 insertions(+), 13 deleti

[PATCH 02/48] staging: comedi: pcmmio: tidy up switch_page()

All the I/O ports are left unlocked in the driver so the 'pagelock' in the private data is not necessary. The paranoia sanity checks are also unnecessary, Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 12 +-

[PATCH 38/48] staging: comedi: pcmmio: factor the trigger handling out of interrupt_pcmmio()

Factor the code that actually handles the digital input triggers out of the interrupt handler. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 108 +--- 1 file changed, 56 insertions(+), 52 deletio

[PATCH 35/48] staging: comedi: pcmmio: use comedi_legacy_detach() for (*detach)

The (*detach) of this driver just calls comedi_legacy_detach(). Use that directly for the (*detach). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/driv

[PATCH 17/48] staging: comedi: pcmmio: there is only one asic

The board supported by this driver only has one WinSystems WS16C48 asic on it that handles the digital i/o. Remove the 'asics' struct array in the private data and add members for the single 'asic_iobase' and the spinlock used by the asic. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Gre

[PATCH 42/48] staging: comedi: pcmmio: tidy up pcmmio_start_intr()

Refactor the function to remove some indent levels. Use pcmmio_dio_write() to write the polarity and enable paged registers instead of using the for () loop to write each register in the pages. The for () loop actually has a bug. It switches the page to the 'enab' registers for the first port the

[PATCH 20/48] staging: comedi: pcmmio: cleanup the digital i/o register defines

Redefine the registers used to access the digital i/o so that they are based on the dev->iobase of the board instead of the 'asic_iobase' that is stored in the private data. Remove the then unused 'asic_iobase'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- driver

[PATCH 46/48] staging: comedi: pcmmio: update the MODULE_DESCRIPTION

Change the MODULE_DESCRIPTION to something more usefull than the generic "Comedi low-level driver". Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH 34/48] staging: comedi: pcmmio: remove subdevice private data

Only subdevice[2], the dio interrupt subdevice, uses the subdevice private data. Move the members from struct pcmmio_subdev_private to struct pcmmio_private and remove the subdevice private data. This also allows removing the allocation and freeing of devpriv->sprivs. Signed-off-by: H Hartley Swee

[PATCH 06/48] staging: comedi: pcmmio: return error if ai conversion times out

Rename adc_wait_ready() so it has namespace associated with the driver. Fix the function so it returns an errno if the conversion times out. Propogate this errno if it happens. Define the analog input status register to remove the magic numbers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 30/48] staging: comedi: pcmmio: remove 'asic' member from subdevice private data

This member of the subdevice private data is always initialized to '0' by the only subdevice that uses it. Since we only have one asic on the board it's really not needed. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/

[PATCH 48/48] staging: comedi: pcmmio: fix final checkpatch warning

Fis the last checkpatch.pl warning in this driver: WARNING: space prohibited between function name and open parenthesis '(' + comedi_buf_put (s->async, val >> 16)) { Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c |

[PATCH 37/48] staging: comedi: pcmmio: use pcmmio_dio_{read, write}() in interrupt_pcmmio()

Use the helper functions to read/write the PCMMIO_PAGE_INT_ID registers. This allows removing the need to lock/unlock the spinlock 'pagelock' and removes the need for the for () loop that did the read/write of the 3 paged registers. Also, remove the need for the 'got1' local variable by just retur

[PATCH 14/48] staging: comedi: pcmmio: tidy up the ao subdevice init

Add some whitespace to the analog output subdevice init and reorder the init to follow the "norm" in comedi drivers. Remove the init of len_chanlist. This member is only used for subdevices the support async commands. The core will default the value correctly. Signed-off-by: H Hartley Sweeten Cc

[PATCH 40/48] staging: comedi: pcmmio: only hook up async command support if irq is available

Refactor the board attach so that the async commands support is only hooked up if the irq is actually available. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 39 +++-- 1 file changed, 18 inserti

[PATCH 33/48] staging: comedi: pcmmio: remove 'num_asic_chans' from subdevice private data

The 'num_asic_chans' that support interrupts in the interrupt subdevice is always initialized to '24'. Remove this unneeded information from the subdevice private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 14 +++--

[PATCH 10/48] staging: comedi: pcmmio: remove 'iobase' from subdevice private data

The 'iobase' is only used to pass the iobase address of the analog output registers to ao_winsn(). This address is simply dev->iobase + 8. Use that instead and remove the 'iobase' from the subdevice private data. This removes a couple more uses of the ugly 'subpriv' macro. Signed-off-by: H Hartle

[PATCH 13/48] staging: comedi: pcmmio: tidy up ao_rinsn()

Rename this function so it has namespace associated with the driver. Move the 'chan' local variable out of the for () loop. The 'chan' is constant for the comedi_insn and only needs to be fetched once from the insn->chanspec. Also, remove the sanity check of the chan. The comedi core will ensure

[PATCH 44/48] staging: comedi: pcmmio: cleanup the private data

Fix the types of some of the private data members. The 'enabled_mask' and 'stop_count' should be unsigned int values. The 'active' and 'continuous' members are flags, change them to unsigned int bit fields. Remove the 'sprivs' pointer. This should have been removed when the subdevice private data

[PATCH 09/48] staging: comedi: pcmmio: move ai shadow data to device private data

There is only one ai subdevice in this driver so there is no reason to hold the last sample written to each channel in the subdevice private data. Move the data into the device private data, This gets some of the data out of the subdevice private data union and removes some of the uses of the ugly

[PATCH 21/48] staging: comedi: pcmmio: remove 'subpriv' macro

This macro relies on a local variable having a specific name. Remove the macro and add a local variable where used. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmmio.c | 17 ++--- 1 file changed, 14 insertions(+), 3 del

[PATCH 15/48] staging: comedi: pcmmio: tidy up the irq request

The for () loop that does the request_irq() in this driver is a bit of an overkill. The code appears to have been copied from the pcmuio driver which supports boards with 1 or 2 ASIC devices. The board supported by this driver only has 1 ASIC. Simplify the code and store the irq number in the come

[PATCH] staging: comedi: addi_apci_1032: fix subdevice type/flags bug

The SDF_CMD_READ should be one of the s->subdev_flags not part of the s->type. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_1032.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/come

[PATCH 00/31] staging: comedi: tidy up all the comedi_lrange tables

This series cleans up all the comedi_lrange tables to make it easier to spot common code that could be reduced. The series is just to make it easier to review. If needed I can repost this as a single patch. H Hartley Sweeten (31): staging: comedi: pcl812: tidy up comedi_lrange tables staging:

[PATCH 04/31] staging: comedi: pcl818: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl818.c | 104 +++- 1 file changed, 63 insertions(+), 41 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 06/31] staging: comedi: das08: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das08.c | 75 ++ 1 file changed, 39 insertions(+), 36 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 05/31] staging: comedi: adv_pci1710: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 89 +++- 1 file changed, 47 insertions(+), 42 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 15/31] staging: comedi: ni_pcimio: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE and UNI_RANGE macros instead of the more generic RANGE macro to reduce possible typo errors. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcimio.c | 34 +++

[PATCH 11/31] staging: comedi: dt282x: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE and UNI_RANGE macros instead of the more generic RANGE macro to reduce possible typo errors. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt282x.c | 48 ++

[PATCH 03/31] staging: comedi: cb_pcidas64: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 142 +-- 1 file changed, 67 insertions(+), 75 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 19/31] staging: comedi: das16m1: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16m1.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/drivers/

[PATCH 20/31] staging: comedi: fl512: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/fl512.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/comedi/drivers/fl512.c

[PATCH 23/31] staging: comedi: icp_multi: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/icp_multi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/icp_multi.c

[PATCH 17/31] staging: comedi: dmm32at: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm32at.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 14/31] staging: comedi: amplc_pci224: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci224.c | 44 --- 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 13/31] staging: comedi: adl_pci9118: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 42 +++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 07/31] staging: comedi: dt2801: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE and UNI_RANGE macros instead of the more generic RANGE macro to reduce possible typo errors. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2801.c | 72 ++

[PATCH 25/31] staging: comedi: dyna_pci10xx: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dyna_pci10xx.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/dyna_pci10

[PATCH 31/31] staging: comedi: s626: tidy up comedi_lrange table

The comedi_lrange tables are fixed length based on the 'length' value before the array of comedi_krange 'range' values. For aesthetics, remove the trailing comma from last 'range' value. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/s

[PATCH 30/31] staging: comedi: adl_pci9111: tidy up comedi_lrange tables

Tidy up the format of the comedi_lrange table. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c b/drivers/s

[PATCH 16/31] staging: comedi: amplc_pci230: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 28 ++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 26/31] staging: comedi: comedi_test: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_test.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_test.c

[PATCH 10/31] staging: comedi: dt2811: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE and UNI_RANGE macros instead of the more generic RANGE macro to reduce possible typo errors. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2811.c | 48 ++

[PATCH 18/31] staging: comedi: adq12b: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 22/31] staging: comedi: aio_aio12_8: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/aio_aio12_8.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/aio_aio12

[PATCH 27/31] staging: comedi: ni_at_a2150: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE macro instead of the more generic RANGE macro to reduce the potential for typos. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 7 +++ 1 file ch

[PATCH 12/48] staging: comedi: pcmmio: return error if ao conversion times out

Rename wait_dac_ready() so it has namespace associated with the driver. Fix the function so it returns an errno if the conversion times out. Propogate this errno if it happens. Define the analog output status register to remove the magic numbers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott

[PATCH 21/31] staging: comedi: pcl816: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcl8

[PATCH 24/31] staging: comedi: me4000: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drivers/me4000.c b/dr

[PATCH 12/31] staging: comedi: das1800: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Use the BIP_RANGE and UNI_RANGE macros instead of the more generic RANGE macro to reduce possible typo errors. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 49 +

[PATCH 01/31] staging: comedi: pcl812: tidy up comedi_lrange tables

Tidy up the whitespace in the comedi_lrange tables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl812.c | 248 +--- 1 file changed, 132 insertions(+), 116 deletions(-) diff --git a/drivers/staging/comed

  1   2   >