Re: [PATCH 1/9] Staging: bcm: DDRInit: Replaced spaces with tabs.

2013-12-07 Thread Dan Carpenter
This breaks the build... :( regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/9] Staging: bcm: DDRInit: replaced multiple tabs with tab.

2013-12-07 Thread Dan Carpenter
On Fri, Dec 06, 2013 at 11:35:45PM -0500, Gary Rookard wrote: > This is second in a series of patches. This is not useful information. Each patch is it's own thing. If you want to describe the patch series as a whole then send a [patch 0/9] email. regards, dan carpenter > > Signed-off-by: Gar

Re: [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.

2013-12-07 Thread Dan Carpenter
On Fri, Dec 06, 2013 at 11:52:35PM -0500, Gary Rookard wrote: > This is the fifth patch of a series. > > Signed-off-by: Gary Alan Rookard > --- > On branch staging-next > drivers/staging/bcm/DDRInit.c | 270 > +- > 1 file changed, 135 insertions(+), 135 d

Re: [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments.

2013-12-07 Thread Levente Kurusa
Hi, A few comments, see below please. 2013-12-07 05:52, Gary Rookard: This is the fifth patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 270 +- 1 file changed, 135 insertions(+), 135 dele

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-07 Thread Ivajlo Dimitrov
On 06.12.2013 17:10, gre...@linuxfoundation.org wrote: On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote: Hi Greg, On 01.12.2013 19:07, Ivaylo DImitrov wrote: From: Ivaylo Dimitrov Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't need to be exported. It c

[PATCH 11/11] Staging: bcm: DDRInint: tidy up indent issue.

2013-12-07 Thread Gary Rookard
This is the eleventh patch of a series. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c index 96afa15..323570f 100644 --- a/

[PATCH 1/7 v2] staging: et131x: reduce split lines in et131x_config_rx_dma_regs

2013-12-07 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index e3a71d3..f86e713 100644 --- a/drivers/staging/et131x/et131x.c +++ b/d

[PATCH 4/7 v2] staging: et131x: reduce split lines in nic_return_rfd

2013-12-07 Thread ZHAO Gang
Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index f925ce6..5c431c3 100644 --- a/drivers/staging/et131x/et131x.c +++ b/drive

Re: [PATCHv2] iio: mxs-lradc: compute temperature from channel 8 and 9

2013-12-07 Thread Jonathan Cameron
On 12/06/13 19:31, Alexandre Belloni wrote: > The mxs LRADC is able to read an internal die temperature sensor. The > temperature has to be calculated from the value read on channel 8 and channel > 9. > To be able to expose the result to hwmon, implement iio channel 8 as > (channel 9 - channel 8).

[PATCH] Staging: android: fix parantheses coding style issue in alarm-dev.c

2013-12-07 Thread Preetam D'Souza
This patch fixes an unecessary return statement parantheses error found in alarm-dev.c by the checkpatch.pl tool -- alarm-dev.c now has no more errors/warnings! Signed-off-by: Preetam D'Souza --- drivers/staging/android/alarm-dev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [PATCH] Staging: TIDSPBRIDGE: Use vm_iomap_memory for mmap-ing instead of remap_pfn_range

2013-12-07 Thread Steven Luo
This patch causes problems with DSP codecs on OMAP3 devices running Android -- specifically, when the decoder is cleaning up after itself, munmap() of the mapped area fails, leading to a memory leak which eventually crashes the system. As far as I can tell, the code with this patch applied reduces

[PATCH 1/2] staging: et131x: improve code consistency: access struct rx_ring

2013-12-07 Thread ZHAO Gang
Let all the code use a pointer called rx_ring to access struct rx_ring members. Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 48 + 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/s

[PATCH 2/2] staging: et131x: improve code consistency: access struct tx_ring

2013-12-07 Thread ZHAO Gang
Let all the code use a pointer called tx_ring to access struct tx_ring members. Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 190 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/s

Re: [PATCH] Staging: TIDSPBRIDGE: Remove UUID helper

2013-12-07 Thread gre...@linuxfoundation.org
On Sat, Dec 07, 2013 at 10:41:36AM +0200, Ivajlo Dimitrov wrote: > > On 06.12.2013 17:10, gre...@linuxfoundation.org wrote: > > On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote: > >> Hi Greg, > >> > >> On 01.12.2013 19:07, Ivaylo DImitrov wrote: > >>> From: Ivaylo Dimitrov > >>> >