Re: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Stephen Warren
(trimming out the devicetree list and maintainers for this discussion) On 11/26/2013 12:52 PM, Paul Zimmerman wrote: >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Tuesday, November 26, 2013 11:43 AM >> >> On 11/26/2013 12:27 PM, Paul Zimmerman wrote: From: Stephen Warren [ma

[PATCH] drivers: staging: ft1000: ft1000-usb: initialize 'status' with STATUS_SUCCESS in request_code_segment()

2013-11-26 Thread Chen Gang
If "!bool_case", it returns unexpected value instead of STATUS_SUCCESS, so need fix it, the related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_download.o drivers/staging/ft1000/ft1000-usb/ft1000_download.c: In function 'request_code_segment':

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Joe Perches
On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. [] > diff --git a/drivers/staging/media/go7007/go7007-usb.c > b/drivers/staging/media/go7007/go7007-usb.c [] > @@ -1057,7 +1057,7 @@ static in

[PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/stagin

[PATCH] drivers: staging: ft1000: ft1000-usb: ft1000_debug.c: check return value of get_user() in ft1000_ioctl()

2013-11-26 Thread Chen Gang
get_user() may fail and cause 'msgsz' uninitialized, so need give a check. The related warning (with allmodconfig under hexagon): CC [M] drivers/staging/ft1000/ft1000-usb/ft1000_debug.o drivers/staging/ft1000/ft1000-usb/ft1000_debug.c: In function 'ft1000_ioctl': include/uapi/linux/swab.h

Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 11:21 AM, Joe Perches wrote: > On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. > [] >> diff --git a/drivers/staging/media/go7007/go7007-usb.c >> b/drivers/staging/media/go700

[PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/stagin

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Greg KH
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. Related warning (with allmodconfig under > hexagon): > > CC [M] drivers/staging/media/go7007/go7007-usb.o > drivers/staging/medi

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Chen Gang
On 11/27/2013 12:03 PM, Greg KH wrote: > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. Related warning (with allmodconfig under >> hexagon): >> >> CC [M] drivers/staging/media

Re: [PATCH] staging: dwc2: set up all module params

2013-11-26 Thread Gordon Hollingworth
This looks like it is the same problem we saw in the dwc_otg driver with incorrect scheduling of split USB transactions to downstream ports behind single TT hubs (this just makes the problem worse rather than be the cause of anything) In general it should be possible to schedule multiple split tra

[PATCH 0/3] staging: et131x: patches for et131x

2013-11-26 Thread ZHAO Gang
This patch set is based on previous sent v5 of 7 patches for et131x. ZHAO Gang (3): staging: et131x: simplify rx dma code staging: et131x: simplify tx dma code staging: et131x: fix build warning drivers/staging/et131x/et131x.c | 298 +--- 1 file changed,

[PATCH 1/3] staging: et131x: simplify rx dma code

2013-11-26 Thread ZHAO Gang
The original code allocate rx dma memory in several dma_alloc_coherent calls, which causes some problems: 1. since dma_alloc_coherent allocate at least one page memory, it wastes some memory when allocation size is smaller than one page. 2. it causes et131x_rx_dma_memory_free as complex as et131

[PATCH 2/3] staging: et131x: simplify tx dma code

2013-11-26 Thread ZHAO Gang
combine two dma_alloc_coherent to one Signed-off-by: ZHAO Gang --- drivers/staging/et131x/et131x.c | 72 - 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 409949f..45bb

[PATCH 3/3] staging: et131x: fix build warning

2013-11-26 Thread ZHAO Gang
fix make -W1 warning: drivers/staging/et131x//et131x.c: In function ‘et1310_setup_device_for_multicast’: drivers/staging/et131x//et131x.c:1055:6: warning: variable ‘pm_csr’ set but not used [-Wunused-but-set-variable] u32 pm_csr; ^ drivers/staging/et131x//et131x.c: In function ‘et1310_set

<    1   2