On Fri, Nov 22, 2013 at 04:43:44PM -0800, Paul Zimmerman wrote:
> This is a series of cleanups to the DWC2 driver, in response to Dan
> Carpenter's review on 11/15/2013. I believe I have addressed all of
> Dan's suggestions, except for removing the validation checks from
> the dwc2_set_param_* func
On 2013-11-21 19:57, Conrad Gomes wrote:
This series contains various fixes to coding style issues in unioxx5.c
found by checkpatch.pl and due to the usage of pr_err instead of the
preferred dev_err type functions for device drivers.
Conrad Gomes (7):
Staging: comedi: fix line over 80 charact
On 2013-11-22 17:40, H Hartley Sweeten wrote:
Currently the COMEDI_DEBUG option enables the comedi_debug module parameter as
well as a DPRINTK() macro. To actually get debug messages to display the
kernel
still needs to be built with the -DDEBUG flag.
Cleanup all the custom uses of DEBUG in come
I've made the success and error paths clearer and pulled some code in
one indent level.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/dwc2/hcd_queue.c b/drivers/staging/dwc2/hcd_queue.c
index f200f1f6e1c6..ad9136e9d820 100644
--- a/drivers/staging/dwc2/hcd_queue.c
+++ b/drivers/stagi
Combine two conditions and make the success path explicit.
Signed-off-by: Dan Carpenter
---
The code is more complicated than it needs to be because of the debug
code. If we just tested for error and then returned instead of trying
to print a debug message that is the easiest way. Debug code is
Instead of writing code like:
if (dwc2_qh_is_non_per(qh)) {
...
} else {
...
}
return;
write it like:
if (dwc2_qh_is_non_per(qh)) {
...
return;
}
...
Signed-off-by: Dan Carpen
I have reviewed the second half of the driver now.
drivers/staging/dwc2/hcd_ddma.c
616 static void dwc2_fill_host_dma_desc(struct dwc2_hsotg *hsotg,
617 struct dwc2_host_chan *chan,
618 struct dwc2_qtd *qtd, struc
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote:
> go variable is initialised only after the switch case so it cannot be
> dereferenced prior to that happening.
>
> Signed-off-by: Michal Nazarewicz
> ---
> drivers/staging/media/go7007/go7007-usb.c | 8
> 1 file changed
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:18 AM
>
> I have reviewed the second half of the driver now.
>
> drivers/staging/dwc2/hcd_ddma.c
>616 static void dwc2_fill_host_dma_desc(struct dwc2_hsotg *hsotg,
>617
On Fri, Nov 22, 2013 at 10:42:10AM -0700, H Hartley Sweeten wrote:
> This macro is only used to output some function tracing debug messages.
> These messages are just added noise so remove the DEBUG macro as well
> as the noise.
>
> Also, remove pcl816_cmdtest_out() which was only called as part o
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:11 AM
>
> I've made the success and error paths clearer and pulled some code in
> one indent level.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/dwc2/hcd_queue.c
> b/drivers/staging
On Fri, Nov 22, 2013 at 10:42:34AM -0700, H Hartley Sweeten wrote:
> This define is only used to enable a debug message during the board attach.
> The message is just added noise, remove it as well as the DEBUG define.
>
> Signed-off-by: H Hartley Sweeten
> Reviewed-by: Ian Abbott
> ---
> drive
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:14 AM
>
> Combine two conditions and make the success path explicit.
>
> Signed-off-by: Dan Carpenter
> ---
> The code is more complicated than it needs to be because of the debug
> code. If we just test
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:14 AM
>
> Instead of writing code like:
>
> if (dwc2_qh_is_non_per(qh)) {
> ...
> } else {
> ...
> }
> return;
>
> write it like:
>
> if (dwc2_qh
On Fri, Nov 22, 2013 at 10:42:55AM -0700, H Hartley Sweeten wrote:
> This define is not used by the driver. Just remove it.
>
> Signed-off-by: H Hartley Sweeten
> Reviewed-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/fl512.c | 2 --
Wrong subject for driver :(
I'll edit it...
___
On Mon, Nov 25, 2013 at 07:46:57PM +, Paul Zimmerman wrote:
>
> This touches the same function as the patch series "staging: dwc2:
> cleanups for DWC2 driver" that I have already submitted. If you don't
> mind, I will fold this patch into that series when I resubmit it to
> fix some other thin
On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote:
> Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
> DPRINTK macro to output the comedi debugging information.
>
> Remove the debug messages for allocation failures. The failure will
> have already generated a mes
On Monday, November 25, 2013 12:54 PM, Greg KH wrote:
> On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote:
>> Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
>> DPRINTK macro to output the comedi debugging information.
>>
>> Remove the debug messages for allocati
On Mon, Nov 25, 2013 at 08:16:32PM +, Hartley Sweeten wrote:
> On Monday, November 25, 2013 12:54 PM, Greg KH wrote:
> > On Fri, Nov 22, 2013 at 10:47:40AM -0700, H Hartley Sweeten wrote:
> >> Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
> >> DPRINTK macro to output the co
On Fri, Nov 15, 2013 at 11:30:07PM +0100, Laurent Navet wrote:
> if slic_card_locate failed, memmapped_ioaddr is not unmapped.
>
> Signed-off-by: Laurent Navet
> ---
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch causes a build warning to
Remove stale comment after changing dwc2_set_parameters() to void
function
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
index c0b122a..f2708f9 100644
---
My previous patch series "staging: dwc2: cleanups for DWC2 driver" had
a couple of minor problems. This series fixes them up, and also adds a
couple more fixes/cleanups suggested by Dan Carpenter.
Paul Zimmerman (5):
staging: dwc2: remove stale comment after changing function to void
staging:
Fix screwup in checking return value from dwc2_is_controller_alive()
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/hcd_intr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c
index e672e6d..50e6de5 1006
The function dwc2_get_hwparams() was in an awkward place, mixed
in with the dwc2_set_param* functions. Move it down after those
functions.
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/core.c | 124 ++--
1 file changed, 62 insertions(+), 62 deleti
In dwc2_xfercomp_isoc_split_in(), the function has already exited
if len == 0, so no need to test it again
Reported-by: Dan Carpenter
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/hcd_intr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dwc2/hcd_in
The check against MAX_DMA_DESC_SIZE didn't make sense, fix it
Reported-by: Dan Carpenter
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/hcd_ddma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dwc2/hcd_ddma.c b/drivers/staging/dwc2/hcd_ddma.c
in
The first patch cleans sparse warnings and the second one removes
useless code.
Mauro Dreissig (2):
staging: as102: Declare local variables as static
staging: as102: Remove ENTER/LEAVE debugging macros
drivers/staging/media/as102/as102_drv.c| 10 --
drivers/staging/media/as10
Too much noise, also does not cover every possible code paths.
Signed-off-by: Mauro Dreissig
---
drivers/staging/media/as102/as102_drv.c| 10 --
drivers/staging/media/as102/as102_drv.h| 8
drivers/staging/media/as102/as102_fe.c | 26 -
As pointed out by sparse:
drivers/staging/media/as102/as102_fw.c:29:6: warning: symbol 'as102_st_fw1' was
not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:30:6: warning: symbol 'as102_st_fw2' was
not declared. Should it be static?
drivers/staging/media/as102/as102_fw.c:3
On Mon, Nov 25, 2013 at 05:10:52PM -0500, Mauro Dreissig wrote:
> As pointed out by sparse:
>
> drivers/staging/media/as102/as102_fw.c:29:6: warning: symbol 'as102_st_fw1'
> was not declared. Should it be static?
> drivers/staging/media/as102/as102_fw.c:30:6: warning: symbol 'as102_st_fw2'
> was
On Mon, Nov 25, 2013 at 05:10:53PM -0500, Mauro Dreissig wrote:
> Too much noise, also does not cover every possible code paths.
>
> Signed-off-by: Mauro Dreissig
Acked-by: Greg Kroah-Hartman
___
devel mailing list
de...@linuxdriverproject.org
http://
On Mon, Nov 25, 2013 at 05:10:51PM -0500, Mauro Dreissig wrote:
> The first patch cleans sparse warnings and the second one removes
> useless code.
>
> Mauro Dreissig (2):
> staging: as102: Declare local variables as static
> staging: as102: Remove ENTER/LEAVE debugging macros
I've acked thes
The DWC2 USB controller in the BCM2835 (Raspberry Pi) needs some non-
default parameters. Select these based on the compatible value from the
DT node. For all other HW, fall back to the default parameters currently
in use.
The values in params_bcm2835[] were posted to the mailing list by Paul
quit
33 matches
Mail list logo
